)]}'
{"id":"openstack%2Fnova~674876","triplet_id":"openstack%2Fnova~stable%2Fpike~Ie621686053ad774c4ae4f22bb2a455f98900b611","project":"openstack/nova","branch":"stable/pike","topic":"bug/1837877","hashtags":[],"change_id":"Ie621686053ad774c4ae4f22bb2a455f98900b611","subject":"Implement power_off/power_on for the FakeDriver","status":"MERGED","created":"2019-08-06 16:57:19.000000000","updated":"2019-08-08 22:14:43.000000000","submitted":"2019-08-08 22:14:43.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"674876-1565302483671-01c2484d","meta_rev_id":"e8990a9b59726f3b5c4da36449b2c6f6e64a2682","_number":674876,"virtual_id_number":674876,"owner":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"date":"2019-08-06 18:04:32.000000000","_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"value":0,"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"date":"2019-08-06 20:59:59.000000000","_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"date":"2019-08-06 19:32:06.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"date":"2019-08-06 18:08:13.000000000","_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":2,"date":"2019-08-08 22:14:43.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"all":[{"value":0,"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"value":2,"date":"2019-08-08 15:55:01.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"all":[{"value":0,"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"value":1,"date":"2019-08-08 15:55:01.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"value":0,"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-08-06 18:04:32.000000000","updated_by":{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-08-06 19:32:06.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-08-06 20:59:59.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"REVIEWER"},{"updated":"2019-08-08 15:55:01.000000000","updated_by":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"reviewer":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"state":"REVIEWER"},{"updated":"2019-08-08 22:14:43.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"92d51efb1f9fec6b207ad4cdfb9b087d31bf09db","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-08-06 16:57:19.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"7853f6a06ab37e6b5122d0ed49ea84b405d64bb3","author":{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},"date":"2019-08-06 18:04:32.000000000","message":"Patch Set 1:\n\nBuild failed. Comment \u0027powervm: recheck\u0027 to recheck.\n For 3rd party CI contact info: https://wiki.openstack.org/wiki/ThirdPartySystems/IBM_PowerVM_CI\n\n- nova-out-of-tree-pvm http://184.172.12.213/76/674876/1/check/nova-out-of-tree-pvm/4c0ecee : FAILURE in 21m 40s\n- nova-in-tree-pvm http://184.172.12.213/76/674876/1/check/nova-in-tree-pvm/d838d38 : FAILURE in 19m 57s","accounts_in_message":[],"_revision_number":1},{"id":"60171638c90f88da6ba68930835c290abbbda3dc","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-08-06 18:08:13.000000000","message":"Patch Set 1:\n\nThis is needed for the functional test in the change on top of this:\n\nhttps://review.opendev.org/#/c/674877/1/nova/tests/functional/test_server_faults.py@63","accounts_in_message":[],"_revision_number":1},{"id":"4f738605a28d06a507072ad44500ed98d01bb054","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2019-08-06 19:32:06.000000000","message":"Patch Set 1:\n\nBuild succeeded. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm: recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-xenial https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/76/674876/1/check/tempest-dsvm-full-xenial/2ad58e3/ : SUCCESS in 1h 18m 23s\n- tempest-dsvm-full-xenial-py3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/76/674876/1/check/tempest-dsvm-full-xenial-py3/8ef5377/ : FAILURE in 1h 10m 57s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"36071f6e7d186194ffd89dd4b839e1bc81518b06","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2019-08-06 20:59:59.000000000","message":"Patch Set 1:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/674876/1 : FAILURE in 45m 00s","accounts_in_message":[],"_revision_number":1},{"id":"f558b3c732e400b1d55c01d5e1752dfd600edc87","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-06 22:21:53.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://logs.opendev.org/76/674876/1/check/openstack-tox-pep8/23a7f33/ : SUCCESS in 10m 03s\n- openstack-tox-py27 https://logs.opendev.org/76/674876/1/check/openstack-tox-py27/b591734/ : SUCCESS in 14m 39s\n- openstack-tox-py35 https://logs.opendev.org/76/674876/1/check/openstack-tox-py35/f553e09/ : SUCCESS in 14m 18s\n- build-openstack-sphinx-docs https://logs.opendev.org/76/674876/1/check/build-openstack-sphinx-docs/b3d20e4/html/ : SUCCESS in 7m 58s\n- tempest-full https://logs.opendev.org/76/674876/1/check/tempest-full/f03e593/ : SUCCESS in 1h 37m 15s\n- neutron-grenade https://logs.opendev.org/76/674876/1/check/neutron-grenade/84b27c7/ : SUCCESS in 58m 02s\n- ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://logs.opendev.org/76/674876/1/check/ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa/b1f1711/ : SUCCESS in 46m 48s (non-voting)\n- nova-grenade-live-migration https://logs.opendev.org/76/674876/1/check/nova-grenade-live-migration/9d6c274/ : SUCCESS in 58m 19s (non-voting)\n- nova-live-migration https://logs.opendev.org/76/674876/1/check/nova-live-migration/3729ef5/ : SUCCESS in 46m 47s\n- tempest-slow https://logs.opendev.org/76/674876/1/check/tempest-slow/0930879/ : SUCCESS in 1h 57m 54s\n- nova-tox-functional https://logs.opendev.org/76/674876/1/check/nova-tox-functional/8178fd7/ : SUCCESS in 18m 41s\n- nova-tox-functional-py35 https://logs.opendev.org/76/674876/1/check/nova-tox-functional-py35/74f5217/ : SUCCESS in 31m 53s\n- neutron-grenade-multinode https://logs.opendev.org/76/674876/1/check/neutron-grenade-multinode/7644925/ : SUCCESS in 1h 06m 40s\n- devstack-plugin-ceph-tempest https://logs.opendev.org/76/674876/1/check/devstack-plugin-ceph-tempest/d2ccb3e/ : FAILURE in 1h 14m 20s (non-voting)\n- tempest-multinode-full https://logs.opendev.org/76/674876/1/check/tempest-multinode-full/5e4d7f5/ : SUCCESS in 1h 37m 46s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"56b22d6778aa83bd4eb209ed6938093e6c1f6159","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2019-08-08 15:55:01.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nClean backport from original change in queens, LGTM. Proxying Matt\u0027s backport as a stable-core as a +2.","accounts_in_message":[],"_revision_number":1},{"id":"2f65ee0197d10ef26211c2c3a70e91b02d6c31e4","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-08 15:58:47.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"3fa6c1b19cf42f97da35761b89f7ea43e04678de","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-08 22:14:43.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 https://logs.opendev.org/76/674876/1/gate/openstack-tox-pep8/2d69fb4/ : SUCCESS in 13m 49s\n- openstack-tox-py27 https://logs.opendev.org/76/674876/1/gate/openstack-tox-py27/727123c/ : SUCCESS in 17m 17s\n- openstack-tox-py35 https://logs.opendev.org/76/674876/1/gate/openstack-tox-py35/29498f4/ : SUCCESS in 18m 07s\n- build-openstack-sphinx-docs https://logs.opendev.org/76/674876/1/gate/build-openstack-sphinx-docs/94e9c09/html/ : SUCCESS in 11m 14s\n- tempest-full https://logs.opendev.org/76/674876/1/gate/tempest-full/b06bd7c/ : SUCCESS in 1h 47m 15s\n- neutron-grenade https://logs.opendev.org/76/674876/1/gate/neutron-grenade/1844288/ : SUCCESS in 51m 02s\n- nova-live-migration https://logs.opendev.org/76/674876/1/gate/nova-live-migration/b53ee2f/ : SUCCESS in 41m 13s\n- tempest-slow https://logs.opendev.org/76/674876/1/gate/tempest-slow/efa5442/ : SUCCESS in 2h 01m 07s\n- nova-tox-functional https://logs.opendev.org/76/674876/1/gate/nova-tox-functional/0ff3b24/ : SUCCESS in 20m 22s\n- nova-tox-functional-py35 https://logs.opendev.org/76/674876/1/gate/nova-tox-functional-py35/63de3cc/ : SUCCESS in 23m 53s","accounts_in_message":[],"_revision_number":1},{"id":"691a3075387999856f28dec91c9cca2b16ba85f4","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-08 22:14:43.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"4a3eea8c30f5a452bcf82b145c66de3d3416a1cd","revisions":{"4a3eea8c30f5a452bcf82b145c66de3d3416a1cd":{"kind":"REWORK","_number":1,"created":"2019-08-06 16:57:19.000000000","uploader":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"ref":"refs/changes/76/674876/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/76/674876/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/76/674876/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/76/674876/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/76/674876/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/76/674876/1"}}},"commit":{"parents":[{"commit":"fc8cd8f3b346c8f53e2dfc8e3de9fdcaedb0d35d","subject":"Do not dump all instances in the scheduler","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/fc8cd8f3b346c8f53e2dfc8e3de9fdcaedb0d35d"}]}],"author":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2017-10-05 23:19:36.000000000","tz":-240},"committer":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2019-07-26 21:23:16.000000000","tz":-240},"subject":"Implement power_off/power_on for the FakeDriver","message":"Implement power_off/power_on for the FakeDriver\n\nWhen trying to recreate hundreds of instance action\nevents for scale testing with the FakeDriver, a nice\nsimple way to do that is by stopping those instances\nand starting them again.\n\nHowever, since power_off/on aren\u0027t implemented, once\nyou \"stop\" them the sync_instance_power_state periodic\ntask in the compute manager thinks they are still running\non the \"hypervisor\" and will stop them again via the API,\nwhich records yet another instance action and set of\nevents.\n\nThis just toggles the power state bit on the fake instance\nin the FakeDriver to make the periodic task do the right\nthing.\n\nAs a result, we also have more realistic API and\nnotification samples.\n\nChange-Id: Ie621686053ad774c4ae4f22bb2a455f98900b611\n(cherry picked from commit 211e9b1961a14e22b39194fdd90e40738fc27202)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/4a3eea8c30f5a452bcf82b145c66de3d3416a1cd"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/4a3eea8c30f5a452bcf82b145c66de3d3416a1cd"}]},"branch":"refs/heads/stable/pike"}},"requirements":[],"submit_records":[],"submit_requirements":[]}