)]}'
{"id":"openstack%2Fnova~674877","triplet_id":"openstack%2Fnova~stable%2Fpike~I5e0a43ec59341c9ac62f89105ddf82c4a014df81","project":"openstack/nova","branch":"stable/pike","topic":"bug/1837877","hashtags":[],"change_id":"I5e0a43ec59341c9ac62f89105ddf82c4a014df81","subject":"Replace non-nova server fault message","status":"MERGED","created":"2019-08-06 16:57:19.000000000","updated":"2019-08-09 16:42:06.000000000","submitted":"2019-08-09 16:42:05.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"674877-1565368926282-c4f9ddb8","meta_rev_id":"c1064547886b37e2acf1239a81365f8185e69b7e","_number":674877,"virtual_id_number":674877,"owner":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"date":"2019-08-06 17:49:49.000000000","_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"value":0,"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"date":"2019-08-06 21:02:37.000000000","_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"date":"2019-08-06 19:31:23.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":10311,"name":"Joseph Davis","email":"joseph.davis@suse.com","username":"joadavis"},{"value":2,"date":"2019-08-09 16:42:05.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"all":[{"value":0,"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"value":2,"date":"2019-08-09 14:06:57.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":1,"date":"2019-08-06 21:46:15.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":10311,"name":"Joseph Davis","email":"joseph.davis@suse.com","username":"joadavis"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"all":[{"value":0,"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"value":1,"date":"2019-08-09 14:06:57.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":10311,"name":"Joseph Davis","email":"joseph.davis@suse.com","username":"joadavis"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"value":0,"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":10311,"name":"Joseph Davis","email":"joseph.davis@suse.com","username":"joadavis"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":10311,"name":"Joseph Davis","email":"joseph.davis@suse.com","username":"joadavis"},{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-08-06 17:49:49.000000000","updated_by":{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-08-06 19:31:23.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-08-06 21:02:37.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"REVIEWER"},{"updated":"2019-08-06 21:46:15.000000000","updated_by":{"_account_id":10311,"name":"Joseph Davis","email":"joseph.davis@suse.com","username":"joadavis"},"reviewer":{"_account_id":10311,"name":"Joseph Davis","email":"joseph.davis@suse.com","username":"joadavis"},"state":"REVIEWER"},{"updated":"2019-08-09 14:06:57.000000000","updated_by":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"reviewer":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"state":"REVIEWER"},{"updated":"2019-08-09 16:42:05.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"a4ab18d12e99b08fe03a9facf90d00e5859d8de4","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-08-06 16:57:19.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"58c88b11cf479cc07255b54d598450190ecac550","author":{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},"date":"2019-08-06 17:49:49.000000000","message":"Patch Set 1:\n\nBuild failed. Comment \u0027powervm: recheck\u0027 to recheck.\n For 3rd party CI contact info: https://wiki.openstack.org/wiki/ThirdPartySystems/IBM_PowerVM_CI\n\n- nova-out-of-tree-pvm http://184.172.12.213/77/674877/1/check/nova-out-of-tree-pvm/50386f2 : FAILURE in 18m 57s\n- nova-in-tree-pvm http://184.172.12.213/77/674877/1/check/nova-in-tree-pvm/363d59f : FAILURE in 19m 29s","accounts_in_message":[],"_revision_number":1},{"id":"c4d148a7b21d12e86e0e8bd266972e902183cb3c","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2019-08-06 19:31:23.000000000","message":"Patch Set 1:\n\nBuild succeeded. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm: recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-xenial https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/77/674877/1/check/tempest-dsvm-full-xenial/4b5d58e/ : SUCCESS in 1h 13m 33s\n- tempest-dsvm-full-xenial-py3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/77/674877/1/check/tempest-dsvm-full-xenial-py3/9c53b9a/ : FAILURE in 1h 14m 25s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"e9e4589c742347724e14f679716631aa8e13a847","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2019-08-06 21:02:37.000000000","message":"Patch Set 1:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/674877/1 : FAILURE in 45m 55s","accounts_in_message":[],"_revision_number":1},{"id":"7471cc8ba4da41a734e2fd8cb98f3754b40dfd1a","author":{"_account_id":10311,"name":"Joseph Davis","email":"joseph.davis@suse.com","username":"joadavis"},"date":"2019-08-06 21:46:15.000000000","message":"Patch Set 1: Code-Review+1\n\nThis looks great, and I appreciate the tests and explanations in comments.","accounts_in_message":[],"_revision_number":1},{"id":"e25419a20b8ba78d592d474c1af11d4dabf68eda","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-06 22:26:55.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://logs.opendev.org/77/674877/1/check/openstack-tox-pep8/dfe75d6/ : SUCCESS in 10m 16s\n- openstack-tox-py27 https://logs.opendev.org/77/674877/1/check/openstack-tox-py27/fabe996/ : SUCCESS in 12m 57s\n- openstack-tox-py35 https://logs.opendev.org/77/674877/1/check/openstack-tox-py35/18371e3/ : SUCCESS in 19m 32s\n- build-openstack-sphinx-docs https://logs.opendev.org/77/674877/1/check/build-openstack-sphinx-docs/e3e6cb0/html/ : SUCCESS in 8m 08s\n- tempest-full https://logs.opendev.org/77/674877/1/check/tempest-full/f434ba6/ : SUCCESS in 1h 44m 04s\n- neutron-grenade https://logs.opendev.org/77/674877/1/check/neutron-grenade/cc34753/ : SUCCESS in 57m 11s\n- build-openstack-releasenotes https://logs.opendev.org/77/674877/1/check/build-openstack-releasenotes/9d914ed/html/ : SUCCESS in 41m 44s\n- ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://logs.opendev.org/77/674877/1/check/ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa/07ff3ef/ : SUCCESS in 45m 23s (non-voting)\n- nova-grenade-live-migration https://logs.opendev.org/77/674877/1/check/nova-grenade-live-migration/c704eb7/ : SUCCESS in 1h 09m 44s (non-voting)\n- nova-live-migration https://logs.opendev.org/77/674877/1/check/nova-live-migration/f510d3b/ : SUCCESS in 1h 00m 43s\n- tempest-slow https://logs.opendev.org/77/674877/1/check/tempest-slow/f6c84fe/ : SUCCESS in 1h 58m 13s\n- nova-tox-functional https://logs.opendev.org/77/674877/1/check/nova-tox-functional/d386b41/ : SUCCESS in 21m 22s\n- nova-tox-functional-py35 https://logs.opendev.org/77/674877/1/check/nova-tox-functional-py35/01922a8/ : SUCCESS in 22m 14s\n- neutron-grenade-multinode https://logs.opendev.org/77/674877/1/check/neutron-grenade-multinode/4e4c151/ : SUCCESS in 1h 02m 09s\n- devstack-plugin-ceph-tempest https://logs.opendev.org/77/674877/1/check/devstack-plugin-ceph-tempest/babba6b/ : FAILURE in 1h 30m 01s (non-voting)\n- tempest-multinode-full https://logs.opendev.org/77/674877/1/check/tempest-multinode-full/7b0696f/ : SUCCESS in 1h 58m 18s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"8d33d3b3185b87fe57d9c2f56825193116d6a1fe","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2019-08-06 22:32:05.000000000","message":"Patch Set 1: Code-Review+1\n\nClean backport of the queens change, LGTM. Waiting for the master, stein, rocky, and queens changes to merge.","accounts_in_message":[],"_revision_number":1},{"id":"1c3e322ae24f76ec68ffde023295920e671b4605","author":{"_account_id":10311,"name":"Joseph Davis","email":"joseph.davis@suse.com","username":"joadavis"},"date":"2019-08-08 14:23:41.000000000","message":"Patch Set 1:\n\nMaster, stein and rocky have now merged, and it is past the check gates, so we should merge this as well.","accounts_in_message":[],"_revision_number":1},{"id":"b263fd6bc72250d132bc13caa1bc87a75e61aed7","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2019-08-09 14:06:57.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nQueens change has merged, upgrading to +2. Proxying Matt\u0027s backport as stable-core as a +2.","accounts_in_message":[],"_revision_number":1},{"id":"53d20e0017901fb9f46d7fe2db56e6228609207a","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-09 14:07:29.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"e168a38994819bf5858fda1a4097b2a56fa14a2c","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-09 16:42:05.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 https://logs.opendev.org/77/674877/1/gate/openstack-tox-pep8/db7884f/ : SUCCESS in 9m 08s\n- openstack-tox-py27 https://logs.opendev.org/77/674877/1/gate/openstack-tox-py27/68467cc/ : SUCCESS in 14m 02s\n- openstack-tox-py35 https://logs.opendev.org/77/674877/1/gate/openstack-tox-py35/991213d/ : SUCCESS in 15m 36s\n- build-openstack-sphinx-docs https://logs.opendev.org/77/674877/1/gate/build-openstack-sphinx-docs/4e816d3/html/ : SUCCESS in 10m 45s\n- tempest-full https://logs.opendev.org/77/674877/1/gate/tempest-full/39ee17e/ : SUCCESS in 1h 33m 00s\n- neutron-grenade https://logs.opendev.org/77/674877/1/gate/neutron-grenade/6eceb64/ : SUCCESS in 50m 31s\n- build-openstack-releasenotes https://logs.opendev.org/77/674877/1/gate/build-openstack-releasenotes/b31ee45/html/ : SUCCESS in 30m 21s\n- nova-live-migration https://logs.opendev.org/77/674877/1/gate/nova-live-migration/c6f03e2/ : SUCCESS in 52m 38s\n- tempest-slow https://logs.opendev.org/77/674877/1/gate/tempest-slow/6fd7454/ : SUCCESS in 2h 09m 07s\n- nova-tox-functional https://logs.opendev.org/77/674877/1/gate/nova-tox-functional/890a5d6/ : SUCCESS in 21m 47s\n- nova-tox-functional-py35 https://logs.opendev.org/77/674877/1/gate/nova-tox-functional-py35/e2305b7/ : SUCCESS in 20m 46s","accounts_in_message":[],"_revision_number":1},{"id":"ee7ed7527af71772b822aeb116e39473464c35b1","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-09 16:42:06.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"6da28b0aa9b6a0ba67460f88dd2c397605b0679b","revisions":{"6da28b0aa9b6a0ba67460f88dd2c397605b0679b":{"kind":"REWORK","_number":1,"created":"2019-08-06 16:57:19.000000000","uploader":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"ref":"refs/changes/77/674877/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/77/674877/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/77/674877/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/77/674877/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/77/674877/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/77/674877/1"}}},"commit":{"parents":[{"commit":"4a3eea8c30f5a452bcf82b145c66de3d3416a1cd","subject":"Implement power_off/power_on for the FakeDriver","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/4a3eea8c30f5a452bcf82b145c66de3d3416a1cd"}]}],"author":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2019-07-26 14:53:02.000000000","tz":-240},"committer":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2019-08-06 16:07:26.000000000","tz":-240},"subject":"Replace non-nova server fault message","message":"Replace non-nova server fault message\n\nThe server fault \"message\" is always shown in the API\nserver response, regardless of policy or user role.\n\nThe fault \"details\" are only shown to users with the\nadmin role when the fault code is 500.\n\nThe problem with this is for non-nova exceptions, the\nfault message is a string-ified version of the exception\n(see nova.compute.utils.exception_to_dict) which can\ncontain sensitive information which the non-admin owner\nof the server can see.\n\nThis change adds a functional test to recreate the issue\nand a change to exception_to_dict which for the non-nova\ncase changes the fault message by simply storing the\nexception type class name. Admins can still see the fault\ntraceback in the \"details\" key of the fault dict in the\nserver API response. Note that _get_fault_details is\nchanged so that the details also includes the exception\nvalue which is what used to be in the fault message for\nnon-nova exceptions. This is necessary so admins can still\nget the exception message with the traceback details.\n\nNote that nova exceptions with a %(reason)s replacement\nvariable could potentially be leaking sensitive details as\nwell but those would need to be cleaned up on a case-by-case\nbasis since we don\u0027t want to change the behavior of all\nfault messages otherwise users might not see information\nlike NoValidHost when their server goes to ERROR status\nduring scheduling.\n\nSecurityImpact: This change contains a fix for CVE-2019-14433.\n\nChange-Id: I5e0a43ec59341c9ac62f89105ddf82c4a014df81\nCloses-Bug: #1837877\n(cherry picked from commit 298b337a16c0d10916b4431c436d19b3d6f5360e)\n(cherry picked from commit 67651881163b75eb1983eaf753471a91ecec35eb)\n(cherry picked from commit e0b91a5b1e89bd0506dc6da86bc61f1708f0215a)\n(cherry picked from commit 3dcefba60a4f4553888a9dfda9fe3bee094d617a)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/6da28b0aa9b6a0ba67460f88dd2c397605b0679b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/6da28b0aa9b6a0ba67460f88dd2c397605b0679b"}]},"branch":"refs/heads/stable/pike"}},"requirements":[],"submit_records":[],"submit_requirements":[]}