)]}'
{"nova/tests/functional/test_server_faults.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"defa160525451f21b6ff13d84e4ee65ea860ca4f","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        # Start the compute services."},{"line_number":44,"context_line":"        self.start_service(\u0027conductor\u0027)"},{"line_number":45,"context_line":"        enabled_filters \u003d CONF.filter_scheduler.enabled_filters"},{"line_number":46,"context_line":"        # Remove the DiskFilter since we\u0027re using Placement for filtering on"},{"line_number":47,"context_line":"        # DISK_GB."},{"line_number":48,"context_line":"        if \u0027DiskFilter\u0027 in enabled_filters:"},{"line_number":49,"context_line":"            enabled_filters.remove(\u0027DiskFilter\u0027)"},{"line_number":50,"context_line":"            self.flags(enabled_filters\u003denabled_filters,"},{"line_number":51,"context_line":"                       group \u003d \u0027filter_scheduler\u0027)"},{"line_number":52,"context_line":"        self.start_service(\u0027scheduler\u0027)"},{"line_number":53,"context_line":"        self.compute \u003d self.start_service(\u0027compute\u0027)"},{"line_number":54,"context_line":"        api_fixture \u003d self.useFixture(nova_fixtures.OSAPIFixture("}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_18d16030","line":51,"range":{"start_line":46,"start_character":8,"end_line":51,"end_character":50},"updated":"2019-08-09 17:38:45.000000000","message":"I don\u0027t understand why this change is needed (but I can see that it is locally). What is it about the presence of the filter that makes it fail? I would have thought that if placement returned a host with enough DISK_GB, then the DiskFilter would pass that host as well. But it doesn\u0027t.","commit_id":"02ea2c25eddebdc220d66e4a01d8deded7c77a57"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"d5d998fceb887b45979d1eb6406f522dc42bbbd5","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        # Start the compute services."},{"line_number":44,"context_line":"        self.start_service(\u0027conductor\u0027)"},{"line_number":45,"context_line":"        enabled_filters \u003d CONF.filter_scheduler.enabled_filters"},{"line_number":46,"context_line":"        # Remove the DiskFilter since we\u0027re using Placement for filtering on"},{"line_number":47,"context_line":"        # DISK_GB."},{"line_number":48,"context_line":"        if \u0027DiskFilter\u0027 in enabled_filters:"},{"line_number":49,"context_line":"            enabled_filters.remove(\u0027DiskFilter\u0027)"},{"line_number":50,"context_line":"            self.flags(enabled_filters\u003denabled_filters,"},{"line_number":51,"context_line":"                       group \u003d \u0027filter_scheduler\u0027)"},{"line_number":52,"context_line":"        self.start_service(\u0027scheduler\u0027)"},{"line_number":53,"context_line":"        self.compute \u003d self.start_service(\u0027compute\u0027)"},{"line_number":54,"context_line":"        api_fixture \u003d self.useFixture(nova_fixtures.OSAPIFixture("}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_589cb869","line":51,"range":{"start_line":46,"start_character":8,"end_line":51,"end_character":50},"in_reply_to":"7faddb67_18d16030","updated":"2019-08-09 17:50:46.000000000","message":"Looks like the hypervisor reports 0 disk:\n\n2019-08-09 17:28:30,512 DEBUG [nova.scheduler.host_manager] Update host state from compute node: ComputeNode(cpu_allocation_ratio\u003d16.0,cpu_info\u003d\u0027{\"arch\": \"x86_64\", \"model\": \"Nehalem\", \"vendor\": \"Intel\", \"features\": [\"pge\", \"clflush\"], \"topology\": {\"cores\": 1, \"threads\": 1, \"sockets\": 4}}\u0027,created_at\u003d2019-08-09T17:28:27Z,current_workload\u003d0,deleted\u003dFalse,deleted_at\u003dNone,disk_allocation_ratio\u003d1.0,disk_available_least\u003d0,free_disk_gb\u003d1028,free_ram_mb\u003d7680,host\u003d\u0027compute\u0027,host_ip\u003d10.0.2.15,hypervisor_hostname\u003d\u0027fake-mini\u0027,hypervisor_type\u003d\u0027fake\u0027,hypervisor_version\u003d1000,id\u003d1,local_gb\u003d1028,local_gb_used\u003d0,memory_mb\u003d8192,memory_mb_used\u003d512,metrics\u003d\u0027[]\u0027,numa_topology\u003dNone,pci_device_pools\u003dPciDevicePoolList,ram_allocation_ratio\u003d1.5,running_vms\u003d0,service_id\u003dNone,stats\u003d{},supported_hv_specs\u003d[HVSpec],updated_at\u003d2019-08-09T17:28:27Z,uuid\u003d31bda4dc-878f-493a-877a-9f3a61c11d1e,vcpus\u003d1,vcpus_used\u003d0)\n\nand DiskFilter says there\u0027s 0 disk:\n\n2019-08-09 17:28:30,515 DEBUG [nova.scheduler.filters.disk_filter] (compute, fake-mini) ram: 7680MB disk: 0MB io_ops: 0 instances: 0 does not have 20480 MB usable disk, it only has 0.0 MB usable disk.\n\nThis looks like some kind of reporting issue and unrelated to how the DiskFilter works... But if so, how are any other func tests passing if compute has 0 disk all the time? Weird.","commit_id":"02ea2c25eddebdc220d66e4a01d8deded7c77a57"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"26dd9f03b279960f8e5d928e7659f31889e6fbbd","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        # Start the compute services."},{"line_number":44,"context_line":"        self.start_service(\u0027conductor\u0027)"},{"line_number":45,"context_line":"        enabled_filters \u003d CONF.filter_scheduler.enabled_filters"},{"line_number":46,"context_line":"        # Remove the DiskFilter since we\u0027re using Placement for filtering on"},{"line_number":47,"context_line":"        # DISK_GB."},{"line_number":48,"context_line":"        if \u0027DiskFilter\u0027 in enabled_filters:"},{"line_number":49,"context_line":"            enabled_filters.remove(\u0027DiskFilter\u0027)"},{"line_number":50,"context_line":"            self.flags(enabled_filters\u003denabled_filters,"},{"line_number":51,"context_line":"                       group \u003d \u0027filter_scheduler\u0027)"},{"line_number":52,"context_line":"        self.start_service(\u0027scheduler\u0027)"},{"line_number":53,"context_line":"        self.compute \u003d self.start_service(\u0027compute\u0027)"},{"line_number":54,"context_line":"        api_fixture \u003d self.useFixture(nova_fixtures.OSAPIFixture("}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_93da1177","line":51,"range":{"start_line":46,"start_character":8,"end_line":51,"end_character":50},"in_reply_to":"7faddb67_3379dd92","updated":"2019-08-09 18:32:44.000000000","message":"Thanks for the sanity check. In isolation, the code comment and filter removal didn\u0027t make sense to me as to why it would help.","commit_id":"02ea2c25eddebdc220d66e4a01d8deded7c77a57"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0c1acb3175dfd1501f31908dd9552498d4317488","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        # Start the compute services."},{"line_number":44,"context_line":"        self.start_service(\u0027conductor\u0027)"},{"line_number":45,"context_line":"        enabled_filters \u003d CONF.filter_scheduler.enabled_filters"},{"line_number":46,"context_line":"        # Remove the DiskFilter since we\u0027re using Placement for filtering on"},{"line_number":47,"context_line":"        # DISK_GB."},{"line_number":48,"context_line":"        if \u0027DiskFilter\u0027 in enabled_filters:"},{"line_number":49,"context_line":"            enabled_filters.remove(\u0027DiskFilter\u0027)"},{"line_number":50,"context_line":"            self.flags(enabled_filters\u003denabled_filters,"},{"line_number":51,"context_line":"                       group \u003d \u0027filter_scheduler\u0027)"},{"line_number":52,"context_line":"        self.start_service(\u0027scheduler\u0027)"},{"line_number":53,"context_line":"        self.compute \u003d self.start_service(\u0027compute\u0027)"},{"line_number":54,"context_line":"        api_fixture \u003d self.useFixture(nova_fixtures.OSAPIFixture("}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_3379dd92","line":51,"range":{"start_line":46,"start_character":8,"end_line":51,"end_character":50},"in_reply_to":"7faddb67_589cb869","updated":"2019-08-09 18:26:06.000000000","message":"This isn\u0027t new in Ocata functional tests, I copied it from another test. I would have to dig into the failures to come up with a better reason. My guess is maybe some weirdness in how the compute reports available disk or the DiskFilter calculates it compared to how placement gets it. This test is using the SmallFakeDriver which reports 1028 GB of local disk and the allocation ration should be 1.0 so total disk reported to placement should be 1028GB. And the flavor we\u0027re using should be the first one created by the DefaultFlavorsFixture, which requires 1GB of disk:\n\nhttps://github.com/openstack/nova/blob/stable/ocata/nova/tests/fixtures.py#L557\n\nSo yeah, I\u0027d have to re-enable the filter, make things fail and check the logs to see what\u0027s going on. Regardless, like I said, lots of other tests are doing the same thing and if we\u0027re using placement we don\u0027t need the DiskFilter anyway, we were just late to remove the ram/core/disk filters from the default list of enabled filters until Pike (or maybe we did it in pike b/c the ocata scheduler still had compat for computes not yet using placement).","commit_id":"02ea2c25eddebdc220d66e4a01d8deded7c77a57"}]}