)]}'
{"nova/network/nova_ipam_lib.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"b36318f9266e06e28032bfb1a1022eb1a8dca4e4","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            \u0027dns1\u0027: None,"},{"line_number":69,"context_line":"            \u0027dns2\u0027: None}"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        def ips_to_strs(net):"},{"line_number":72,"context_line":"            for key, value in net.items():"},{"line_number":73,"context_line":"                if isinstance(value, netaddr.ip.BaseIP):"},{"line_number":74,"context_line":"                    net[key] \u003d str(value)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F9oTE%3D","line":71,"updated":"2014-02-05 14:46:47.000000000","message":"wonder if this should be moved to a utility function - saw in a different patch that use did a str of an ip address","commit_id":"620b04932eb3cbd4dcdb26859ec4d698129c7cbf"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"cf31e11ee3e0d0433302082b15e9dedffae05766","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            \u0027dns1\u0027: None,"},{"line_number":69,"context_line":"            \u0027dns2\u0027: None}"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        def ips_to_strs(net):"},{"line_number":72,"context_line":"            for key, value in net.items():"},{"line_number":73,"context_line":"                if isinstance(value, netaddr.ip.BaseIP):"},{"line_number":74,"context_line":"                    net[key] \u003d str(value)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUX%2F%2Fxa0%3D","line":71,"in_reply_to":"AAAAUH%2F9oTE%3D","updated":"2014-02-10 21:59:43.000000000","message":"It would certainly be good to find a better way to retrieve the appropriate type from the different network related objects.  But I would expect to see that in it\u0027s own patchset.","commit_id":"620b04932eb3cbd4dcdb26859ec4d698129c7cbf"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"b36318f9266e06e28032bfb1a1022eb1a8dca4e4","unresolved":false,"context_lines":[{"line_number":90,"context_line":"            return []"},{"line_number":91,"context_line":"        fixed_ips \u003d fixed_ip_obj.FixedIPList.get_by_virtual_interface_id("},{"line_number":92,"context_line":"            context, vif_rec.id)"},{"line_number":93,"context_line":"        return [str(fixed_ip.address) for fixed_ip in fixed_ips]"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def get_v6_ips_by_interface(self, context, net_id, vif_id, project_id):"},{"line_number":96,"context_line":"        \"\"\"Returns a list containing a single IPv6 address strings"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F9oTA%3D","line":93,"updated":"2014-02-05 14:46:47.000000000","message":"here is an example where it may be used","commit_id":"620b04932eb3cbd4dcdb26859ec4d698129c7cbf"}],"nova/tests/network/test_ipam_lib.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"b36318f9266e06e28032bfb1a1022eb1a8dca4e4","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"class NeutronNovaIPAMTestCase(test.NoDBTestCase):"},{"line_number":44,"context_line":"    def test_get_v4_ips_by_interface(self):"},{"line_number":45,"context_line":"        fake_ips \u003d [dict(test_fixed_ip.fake_fixed_ip,"},{"line_number":46,"context_line":"                         address\u003d\u0027192.168.1.101\u0027),"},{"line_number":47,"context_line":"                    dict(test_fixed_ip.fake_fixed_ip,"},{"line_number":48,"context_line":"                         address\u003d\u0027192.168.1.102\u0027)]"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F9oS8%3D","line":45,"updated":"2014-02-05 14:46:47.000000000","message":"why not {}","commit_id":"620b04932eb3cbd4dcdb26859ec4d698129c7cbf"}]}
