)]}'
{"nova/db/sqlalchemy/api.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"a59057bf8360b3a78904745122828aa66086fc3d","unresolved":false,"context_lines":[{"line_number":5591,"context_line":"    table_to_rows_archived \u003d {}"},{"line_number":5592,"context_line":"    deleted_instance_uuids \u003d []"},{"line_number":5593,"context_line":"    total_rows_archived \u003d 0"},{"line_number":5594,"context_line":"    engine \u003d get_engine(use_slave\u003dTrue)"},{"line_number":5595,"context_line":"    meta \u003d MetaData(engine)"},{"line_number":5596,"context_line":"    meta.reflect()"},{"line_number":5597,"context_line":"    # Reverse sort the tables so we get the leaf nodes first for processing."},{"line_number":5598,"context_line":"    for table in reversed(meta.sorted_tables):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_abcc2934","line":5595,"range":{"start_line":5594,"start_character":0,"end_line":5595,"end_character":27},"updated":"2019-08-14 22:17:48.000000000","message":"this part of the delta appears unnecessary?","commit_id":"c3a4a7e02c736e6237fdd66ff0af798bff06a1f3"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1ca39ca7a0f8da3677a300bf733d1e9cc3fee690","unresolved":false,"context_lines":[{"line_number":5591,"context_line":"    table_to_rows_archived \u003d {}"},{"line_number":5592,"context_line":"    deleted_instance_uuids \u003d []"},{"line_number":5593,"context_line":"    total_rows_archived \u003d 0"},{"line_number":5594,"context_line":"    engine \u003d get_engine(use_slave\u003dTrue)"},{"line_number":5595,"context_line":"    meta \u003d MetaData(engine)"},{"line_number":5596,"context_line":"    meta.reflect()"},{"line_number":5597,"context_line":"    # Reverse sort the tables so we get the leaf nodes first for processing."},{"line_number":5598,"context_line":"    for table in reversed(meta.sorted_tables):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_becc5b89","line":5595,"range":{"start_line":5594,"start_character":0,"end_line":5595,"end_character":27},"in_reply_to":"7faddb67_9e4abf24","updated":"2019-08-15 16:50:48.000000000","message":"Done","commit_id":"c3a4a7e02c736e6237fdd66ff0af798bff06a1f3"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"3c4fad620493f6ccf6dda7ee39fc6bb4df317596","unresolved":false,"context_lines":[{"line_number":5591,"context_line":"    table_to_rows_archived \u003d {}"},{"line_number":5592,"context_line":"    deleted_instance_uuids \u003d []"},{"line_number":5593,"context_line":"    total_rows_archived \u003d 0"},{"line_number":5594,"context_line":"    engine \u003d get_engine(use_slave\u003dTrue)"},{"line_number":5595,"context_line":"    meta \u003d MetaData(engine)"},{"line_number":5596,"context_line":"    meta.reflect()"},{"line_number":5597,"context_line":"    # Reverse sort the tables so we get the leaf nodes first for processing."},{"line_number":5598,"context_line":"    for table in reversed(meta.sorted_tables):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_cb3ba5e7","line":5595,"range":{"start_line":5594,"start_character":0,"end_line":5595,"end_character":27},"in_reply_to":"7faddb67_abcc2934","updated":"2019-08-20 04:12:39.000000000","message":"+1","commit_id":"c3a4a7e02c736e6237fdd66ff0af798bff06a1f3"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"417d9c056d2ac70b0a51c6b4aa6438b047ad6abf","unresolved":false,"context_lines":[{"line_number":5591,"context_line":"    table_to_rows_archived \u003d {}"},{"line_number":5592,"context_line":"    deleted_instance_uuids \u003d []"},{"line_number":5593,"context_line":"    total_rows_archived \u003d 0"},{"line_number":5594,"context_line":"    engine \u003d get_engine(use_slave\u003dTrue)"},{"line_number":5595,"context_line":"    meta \u003d MetaData(engine)"},{"line_number":5596,"context_line":"    meta.reflect()"},{"line_number":5597,"context_line":"    # Reverse sort the tables so we get the leaf nodes first for processing."},{"line_number":5598,"context_line":"    for table in reversed(meta.sorted_tables):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_9e4abf24","line":5595,"range":{"start_line":5594,"start_character":0,"end_line":5595,"end_character":27},"in_reply_to":"7faddb67_abcc2934","updated":"2019-08-15 16:39:04.000000000","message":"Yeah, I might have meant to pass engine separately originally but realized I can just pass meta and get the engine from that (meta.bind).","commit_id":"c3a4a7e02c736e6237fdd66ff0af798bff06a1f3"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"3c4fad620493f6ccf6dda7ee39fc6bb4df317596","unresolved":false,"context_lines":[{"line_number":5491,"context_line":"        - number of rows archived"},{"line_number":5492,"context_line":"        - list of UUIDs of instances that were archived"},{"line_number":5493,"context_line":"    \"\"\""},{"line_number":5494,"context_line":"    conn \u003d metadata.bind.connect()"},{"line_number":5495,"context_line":"    # NOTE(tdurakov): table metadata should be received"},{"line_number":5496,"context_line":"    # from models, not db tables. Default value specified by SoftDeleteMixin"},{"line_number":5497,"context_line":"    # is known only by models, not DB layer."}],"source_content_type":"text/x-python","patch_set":6,"id":"7faddb67_d9dd7c70","line":5494,"updated":"2019-08-20 04:12:39.000000000","message":"Based on the failing result on the top patch:\n\nhttps://review.opendev.org/672840\n\nthis isn\u0027t sufficient for keeping the cell-targeting for the database access. :(","commit_id":"0703fd03e6562733dd6531c18d65482afe147762"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"d6330a38de1fa054ec401715ac4b4a2391afe491","unresolved":false,"context_lines":[{"line_number":5491,"context_line":"        - number of rows archived"},{"line_number":5492,"context_line":"        - list of UUIDs of instances that were archived"},{"line_number":5493,"context_line":"    \"\"\""},{"line_number":5494,"context_line":"    conn \u003d metadata.bind.connect()"},{"line_number":5495,"context_line":"    # NOTE(tdurakov): table metadata should be received"},{"line_number":5496,"context_line":"    # from models, not db tables. Default value specified by SoftDeleteMixin"},{"line_number":5497,"context_line":"    # is known only by models, not DB layer."}],"source_content_type":"text/x-python","patch_set":6,"id":"7faddb67_2119ea78","line":5494,"in_reply_to":"7faddb67_26e34036","updated":"2019-08-20 15:17:05.000000000","message":"Yes, you are right, I messed something up during the last update. Sorry for the distraction. :(","commit_id":"0703fd03e6562733dd6531c18d65482afe147762"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a618a0638bb9c783e100525a46bb7b354a4b4be7","unresolved":false,"context_lines":[{"line_number":5491,"context_line":"        - number of rows archived"},{"line_number":5492,"context_line":"        - list of UUIDs of instances that were archived"},{"line_number":5493,"context_line":"    \"\"\""},{"line_number":5494,"context_line":"    conn \u003d metadata.bind.connect()"},{"line_number":5495,"context_line":"    # NOTE(tdurakov): table metadata should be received"},{"line_number":5496,"context_line":"    # from models, not db tables. Default value specified by SoftDeleteMixin"},{"line_number":5497,"context_line":"    # is known only by models, not DB layer."}],"source_content_type":"text/x-python","patch_set":6,"id":"7faddb67_26e34036","line":5494,"in_reply_to":"7faddb67_d9dd7c70","updated":"2019-08-20 14:50:53.000000000","message":"Isn\u0027t that because you\u0027re not using the cell-targeted context to get the engine connection?\n\nhttps://review.opendev.org/#/c/507486/67/nova/db/sqlalchemy/api.py@5572","commit_id":"0703fd03e6562733dd6531c18d65482afe147762"}]}