)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e0a258421a61d7cb4cd8fe630d4cc54c3e127ded","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Prevent init_host test to interfere with other tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The test_migrate_disk_and_power_off_crash_finish_revert_migration test"},{"line_number":10,"context_line":"needs to simulate a compute host crash at a certain point. It stop the"},{"line_number":11,"context_line":"exection at a certain point by injecting a sleep then simulating a"},{"line_number":12,"context_line":"compute restart. However the sleep is just 30 seconds which allows the"},{"line_number":13,"context_line":"stopped function to return while other functional tests are running in"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_215e3c76","line":10,"range":{"start_line":10,"start_character":62,"end_line":10,"end_character":66},"updated":"2019-08-13 12:13:32.000000000","message":"stops","commit_id":"4ab1ca163387b33e2ebfc3810265887a50f3d84e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9641cf45cd76e000eca5d97d876f1217e9fe0553","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Prevent init_host test to interfere with other tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The test_migrate_disk_and_power_off_crash_finish_revert_migration test"},{"line_number":10,"context_line":"needs to simulate a compute host crash at a certain point. It stop the"},{"line_number":11,"context_line":"exection at a certain point by injecting a sleep then simulating a"},{"line_number":12,"context_line":"compute restart. However the sleep is just 30 seconds which allows the"},{"line_number":13,"context_line":"stopped function to return while other functional tests are running in"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_2c439315","line":10,"range":{"start_line":10,"start_character":62,"end_line":10,"end_character":66},"in_reply_to":"7faddb67_215e3c76","updated":"2019-08-13 12:40:30.000000000","message":"Done","commit_id":"4ab1ca163387b33e2ebfc3810265887a50f3d84e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e0a258421a61d7cb4cd8fe630d4cc54c3e127ded","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The test_migrate_disk_and_power_off_crash_finish_revert_migration test"},{"line_number":10,"context_line":"needs to simulate a compute host crash at a certain point. It stop the"},{"line_number":11,"context_line":"exection at a certain point by injecting a sleep then simulating a"},{"line_number":12,"context_line":"compute restart. However the sleep is just 30 seconds which allows the"},{"line_number":13,"context_line":"stopped function to return while other functional tests are running in"},{"line_number":14,"context_line":"the same test worker process making those tests fail in a weird way."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_c1540857","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":8},"updated":"2019-08-13 12:13:32.000000000","message":"execution","commit_id":"4ab1ca163387b33e2ebfc3810265887a50f3d84e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9641cf45cd76e000eca5d97d876f1217e9fe0553","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The test_migrate_disk_and_power_off_crash_finish_revert_migration test"},{"line_number":10,"context_line":"needs to simulate a compute host crash at a certain point. It stop the"},{"line_number":11,"context_line":"exection at a certain point by injecting a sleep then simulating a"},{"line_number":12,"context_line":"compute restart. However the sleep is just 30 seconds which allows the"},{"line_number":13,"context_line":"stopped function to return while other functional tests are running in"},{"line_number":14,"context_line":"the same test worker process making those tests fail in a weird way."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_cc499f32","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":8},"in_reply_to":"7faddb67_c1540857","updated":"2019-08-13 12:40:30.000000000","message":"Done","commit_id":"4ab1ca163387b33e2ebfc3810265887a50f3d84e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e0a258421a61d7cb4cd8fe630d4cc54c3e127ded","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"One simple solution is to add a big enough sleep to the test that will"},{"line_number":17,"context_line":"never return before the whole functional test exection. This patch"},{"line_number":18,"context_line":"proposes a millin seconds which is more than 277 hours. Similaraly how"},{"line_number":19,"context_line":"the other test in this test package works. This solution is hackis but"},{"line_number":20,"context_line":"simple. A better solution would be to further enhance the capabilities"},{"line_number":21,"context_line":"of the functional test env supporting nova-compute service crash / kill"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_a1deacd7","line":18,"range":{"start_line":18,"start_character":56,"end_line":18,"end_character":70},"updated":"2019-08-13 12:13:32.000000000","message":"Similar to how","commit_id":"4ab1ca163387b33e2ebfc3810265887a50f3d84e"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"3a0785208a9cf536a38d0b8f51459155610d859a","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"One simple solution is to add a big enough sleep to the test that will"},{"line_number":17,"context_line":"never return before the whole functional test exection. This patch"},{"line_number":18,"context_line":"proposes a millin seconds which is more than 277 hours. Similaraly how"},{"line_number":19,"context_line":"the other test in this test package works. This solution is hackis but"},{"line_number":20,"context_line":"simple. A better solution would be to further enhance the capabilities"},{"line_number":21,"context_line":"of the functional test env supporting nova-compute service crash / kill"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_b6d389d5","line":18,"updated":"2019-08-09 08:14:26.000000000","message":"million","commit_id":"4ab1ca163387b33e2ebfc3810265887a50f3d84e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9641cf45cd76e000eca5d97d876f1217e9fe0553","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"One simple solution is to add a big enough sleep to the test that will"},{"line_number":17,"context_line":"never return before the whole functional test exection. This patch"},{"line_number":18,"context_line":"proposes a millin seconds which is more than 277 hours. Similaraly how"},{"line_number":19,"context_line":"the other test in this test package works. This solution is hackis but"},{"line_number":20,"context_line":"simple. A better solution would be to further enhance the capabilities"},{"line_number":21,"context_line":"of the functional test env supporting nova-compute service crash / kill"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_8c53a7e2","line":18,"range":{"start_line":18,"start_character":56,"end_line":18,"end_character":70},"in_reply_to":"7faddb67_a1deacd7","updated":"2019-08-13 12:40:30.000000000","message":"Done","commit_id":"4ab1ca163387b33e2ebfc3810265887a50f3d84e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9641cf45cd76e000eca5d97d876f1217e9fe0553","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"One simple solution is to add a big enough sleep to the test that will"},{"line_number":17,"context_line":"never return before the whole functional test exection. This patch"},{"line_number":18,"context_line":"proposes a millin seconds which is more than 277 hours. Similaraly how"},{"line_number":19,"context_line":"the other test in this test package works. This solution is hackis but"},{"line_number":20,"context_line":"simple. A better solution would be to further enhance the capabilities"},{"line_number":21,"context_line":"of the functional test env supporting nova-compute service crash / kill"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_ec449b1b","line":18,"in_reply_to":"7faddb67_b6d389d5","updated":"2019-08-13 12:40:30.000000000","message":"Done","commit_id":"4ab1ca163387b33e2ebfc3810265887a50f3d84e"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"3a0785208a9cf536a38d0b8f51459155610d859a","unresolved":false,"context_lines":[{"line_number":16,"context_line":"One simple solution is to add a big enough sleep to the test that will"},{"line_number":17,"context_line":"never return before the whole functional test exection. This patch"},{"line_number":18,"context_line":"proposes a millin seconds which is more than 277 hours. Similaraly how"},{"line_number":19,"context_line":"the other test in this test package works. This solution is hackis but"},{"line_number":20,"context_line":"simple. A better solution would be to further enhance the capabilities"},{"line_number":21,"context_line":"of the functional test env supporting nova-compute service crash / kill"},{"line_number":22,"context_line":"+ restart."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_56d815ef","line":19,"range":{"start_line":19,"start_character":4,"end_line":19,"end_character":14},"updated":"2019-08-09 08:14:26.000000000","message":"I mean this https://review.opendev.org/#/c/675553/1/nova/tests/functional/compute/test_init_host.py@164","commit_id":"4ab1ca163387b33e2ebfc3810265887a50f3d84e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"3024accf939f5aab8299a2e7180fd395e0df02c1","unresolved":false,"context_lines":[{"line_number":16,"context_line":"One simple solution is to add a big enough sleep to the test that will"},{"line_number":17,"context_line":"never return before the whole functional test exection. This patch"},{"line_number":18,"context_line":"proposes a millin seconds which is more than 277 hours. Similaraly how"},{"line_number":19,"context_line":"the other test in this test package works. This solution is hackis but"},{"line_number":20,"context_line":"simple. A better solution would be to further enhance the capabilities"},{"line_number":21,"context_line":"of the functional test env supporting nova-compute service crash / kill"},{"line_number":22,"context_line":"+ restart."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_d53e318a","line":19,"range":{"start_line":19,"start_character":60,"end_line":19,"end_character":66},"updated":"2019-08-09 16:47:53.000000000","message":"hacky","commit_id":"4ab1ca163387b33e2ebfc3810265887a50f3d84e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9641cf45cd76e000eca5d97d876f1217e9fe0553","unresolved":false,"context_lines":[{"line_number":16,"context_line":"One simple solution is to add a big enough sleep to the test that will"},{"line_number":17,"context_line":"never return before the whole functional test exection. This patch"},{"line_number":18,"context_line":"proposes a millin seconds which is more than 277 hours. Similaraly how"},{"line_number":19,"context_line":"the other test in this test package works. This solution is hackis but"},{"line_number":20,"context_line":"simple. A better solution would be to further enhance the capabilities"},{"line_number":21,"context_line":"of the functional test env supporting nova-compute service crash / kill"},{"line_number":22,"context_line":"+ restart."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_ac4ea335","line":19,"range":{"start_line":19,"start_character":60,"end_line":19,"end_character":66},"in_reply_to":"7faddb67_d53e318a","updated":"2019-08-13 12:40:30.000000000","message":"Done","commit_id":"4ab1ca163387b33e2ebfc3810265887a50f3d84e"}],"nova/tests/functional/compute/test_init_host.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e0a258421a61d7cb4cd8fe630d4cc54c3e127ded","unresolved":false,"context_lines":[{"line_number":55,"context_line":"            # fail and set the instance to ERROR status, revert allocations,"},{"line_number":56,"context_line":"            # etc which is not realistic if the service actually crashed while"},{"line_number":57,"context_line":"            # migrate_disk_and_power_off was running."},{"line_number":58,"context_line":"            time.sleep(1000000)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        source_driver \u003d self.computes[source_host].manager.driver"},{"line_number":61,"context_line":"        with mock.patch.object(source_driver, \u0027migrate_disk_and_power_off\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_21ecfc8d","line":58,"updated":"2019-08-13 12:13:32.000000000","message":"Would be good to have a comment here about why this is so large.","commit_id":"4ab1ca163387b33e2ebfc3810265887a50f3d84e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9641cf45cd76e000eca5d97d876f1217e9fe0553","unresolved":false,"context_lines":[{"line_number":55,"context_line":"            # fail and set the instance to ERROR status, revert allocations,"},{"line_number":56,"context_line":"            # etc which is not realistic if the service actually crashed while"},{"line_number":57,"context_line":"            # migrate_disk_and_power_off was running."},{"line_number":58,"context_line":"            time.sleep(1000000)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        source_driver \u003d self.computes[source_host].manager.driver"},{"line_number":61,"context_line":"        with mock.patch.object(source_driver, \u0027migrate_disk_and_power_off\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_6c62ebaf","line":58,"in_reply_to":"7faddb67_21ecfc8d","updated":"2019-08-13 12:40:30.000000000","message":"Done","commit_id":"4ab1ca163387b33e2ebfc3810265887a50f3d84e"}]}