)]}'
{"nova/network/floating_ips.py":[{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"1a5682ce187648a43055cd9888f31b2b25016ef9","unresolved":false,"context_lines":[{"line_number":502,"context_line":"        \"\"\"Returns a floating IP as a dict.\"\"\""},{"line_number":503,"context_line":"        # NOTE(vish): This is no longer used but can\u0027t be removed until"},{"line_number":504,"context_line":"        #             we major version the network_rpcapi."},{"line_number":505,"context_line":"        # NOTE(danms): Not converting to objects since it\u0027s not used"},{"line_number":506,"context_line":"        return dict(self.db.floating_ip_get_by_address(context,"},{"line_number":507,"context_line":"                                                       address).iteritems())"},{"line_number":508,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAUX%2F%2Fe1k%3D","line":505,"updated":"2014-02-12 21:34:20.000000000","message":"This is confusing to me.  According to the comments from vish a number of methods above aren\u0027t used either but they were switched over.  Are the comments from vish wrong, or did you just get some of them anyways?","commit_id":"8e955b81b9b2b604d75e5ffe88c2adcf2d3d310d"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"c3e77837d380965a19874c9853b015e9cb56aa75","unresolved":false,"context_lines":[{"line_number":502,"context_line":"        \"\"\"Returns a floating IP as a dict.\"\"\""},{"line_number":503,"context_line":"        # NOTE(vish): This is no longer used but can\u0027t be removed until"},{"line_number":504,"context_line":"        #             we major version the network_rpcapi."},{"line_number":505,"context_line":"        # NOTE(danms): Not converting to objects since it\u0027s not used"},{"line_number":506,"context_line":"        return dict(self.db.floating_ip_get_by_address(context,"},{"line_number":507,"context_line":"                                                       address).iteritems())"},{"line_number":508,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAUX%2F%2FT7M%3D","line":505,"in_reply_to":"AAAAUX%2F%2Fe1k%3D","updated":"2014-02-14 02:28:52.000000000","message":"Yeah, converting these is basically a no-op, I think.  A number of these methods got moved to be run on the api side instead.\n\nI think we might as well convert them all, but it doesn\u0027t have to be in this patch.  It at least cleans up the grep check of the code looking for db access.  It\u0027s also necessary if we put a hacking check in for importing db directly.","commit_id":"8e955b81b9b2b604d75e5ffe88c2adcf2d3d310d"}],"nova/objects/floating_ip.py":[{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"1a5682ce187648a43055cd9888f31b2b25016ef9","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        if not self._context:"},{"line_number":58,"context_line":"            raise exception.OrphanedObjectError(method\u003d\u0027obj_load_attr\u0027,"},{"line_number":59,"context_line":"                                                objtype\u003dself.obj_name())"},{"line_number":60,"context_line":"        self.fixed_ip \u003d fixed_ip.FixedIP.get_by_id(self._context,"},{"line_number":61,"context_line":"                                                   self.fixed_ip_id,"},{"line_number":62,"context_line":"                                                   expected_attrs\u003d[\u0027network\u0027])"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAUX%2F%2Fezw%3D","line":60,"updated":"2014-02-12 21:34:20.000000000","message":"Shouldn\u0027t this just load the attrname requested and not lookup fixed_ip if some other lazy loadable attr is requested?","commit_id":"8e955b81b9b2b604d75e5ffe88c2adcf2d3d310d"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"c3e77837d380965a19874c9853b015e9cb56aa75","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        if not self._context:"},{"line_number":58,"context_line":"            raise exception.OrphanedObjectError(method\u003d\u0027obj_load_attr\u0027,"},{"line_number":59,"context_line":"                                                objtype\u003dself.obj_name())"},{"line_number":60,"context_line":"        self.fixed_ip \u003d fixed_ip.FixedIP.get_by_id(self._context,"},{"line_number":61,"context_line":"                                                   self.fixed_ip_id,"},{"line_number":62,"context_line":"                                                   expected_attrs\u003d[\u0027network\u0027])"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAUX%2F%2FT5M%3D","line":60,"in_reply_to":"AAAAUX%2F%2Fezw%3D","updated":"2014-02-14 02:28:52.000000000","message":"You are right, indeed.  In this case, fixed_ip is the only possible attribute that could have been requested when it gets to here.  So, it\u0027s technically correct, just a little less future proof than it could be, I guess.","commit_id":"8e955b81b9b2b604d75e5ffe88c2adcf2d3d310d"}]}