)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"adba8ae7ddb3dc3fd09a2b2f829878560308a7ef","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Avoid timeout from service update notification tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Since If32bca070185937ef83f689b7163d965a89ec10a some of the service"},{"line_number":10,"context_line":"update notification tests are slow because setting a compute enabled or"},{"line_number":11,"context_line":"disabled makes an RPC call to the given compute service. These tests"},{"line_number":12,"context_line":"does not have the proper RPC setup so that call times out. Since the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_5026b6bc","line":9,"updated":"2019-08-12 15:42:39.000000000","message":"Yeah good call, I noticed this while debugging bug 1839515.","commit_id":"0718b2fab2de99e52f6072e208a86de51b1d2c0d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"adba8ae7ddb3dc3fd09a2b2f829878560308a7ef","unresolved":false,"context_lines":[{"line_number":11,"context_line":"disabled makes an RPC call to the given compute service. These tests"},{"line_number":12,"context_line":"does not have the proper RPC setup so that call times out. Since the"},{"line_number":13,"context_line":"notification is still generated the test passes. Waiting for this"},{"line_number":14,"context_line":"timeout steals 16 minutes of test execution time unnecessary."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This patch stubs the RPC call as that is not necessary for the"},{"line_number":17,"context_line":"notification testing and therefor speeds up the tests."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_70297287","line":14,"updated":"2019-08-12 15:42:39.000000000","message":"Ouch.","commit_id":"0718b2fab2de99e52f6072e208a86de51b1d2c0d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"83f3e52ec5b386d530cf6298cf5b0b7a8ae34c39","unresolved":false,"context_lines":[{"line_number":11,"context_line":"disabled makes an RPC call to the given compute service. These tests"},{"line_number":12,"context_line":"does not have the proper RPC setup so that call times out. Since the"},{"line_number":13,"context_line":"notification is still generated the test passes. Waiting for this"},{"line_number":14,"context_line":"timeout steals 16 minutes of test execution time unnecessary."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This patch stubs the RPC call as that is not necessary for the"},{"line_number":17,"context_line":"notification testing and therefor speeds up the tests."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_b02e0a8a","line":14,"in_reply_to":"7faddb67_70297287","updated":"2019-08-12 15:43:38.000000000","message":"Confirmed:\n\nhttps://logs.opendev.org/17/675417/2/check/nova-tox-functional/3b9eb82/job-output.txt.gz#_2019-08-09_01_00_11_833546\n\n2019-08-09 01:00:10.330535 | ubuntu-bionic | functional run-test: commands[1] | stestr slowest\n\n2019-08-09 01:00:11.833546 | ubuntu-bionic | nova.tests.functional.notification_sample_tests.test_service.TestServiceUpdateNotificationSampleLatest.test_service_disabled_log_reason  160.273\n2019-08-09 01:00:11.833726 | ubuntu-bionic | nova.tests.functional.notification_sample_tests.test_service.TestServiceUpdateNotificationSampleLatest.test_service_enable               160.259\n2019-08-09 01:00:11.833910 | ubuntu-bionic | nova.tests.functional.notification_sample_tests.test_service.TestServiceUpdateNotificationSampleLatest.test_service_disabled             160.256\n2019-08-09 01:00:11.834074 | ubuntu-bionic | nova.tests.functional.notification_sample_tests.test_service.TestServiceUpdateNotificationSamplev2_52.test_service_disabled_log_reason   160.206\n2019-08-09 01:00:11.834228 | ubuntu-bionic | nova.tests.functional.notification_sample_tests.test_service.TestServiceUpdateNotificationSamplev2_52.test_service_enable                160.203\n2019-08-09 01:00:11.834382 | ubuntu-bionic | nova.tests.functional.notification_sample_tests.test_service.TestServiceUpdateNotificationSamplev2_52.test_service_disabled              160.195","commit_id":"0718b2fab2de99e52f6072e208a86de51b1d2c0d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"adba8ae7ddb3dc3fd09a2b2f829878560308a7ef","unresolved":false,"context_lines":[{"line_number":14,"context_line":"timeout steals 16 minutes of test execution time unnecessary."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This patch stubs the RPC call as that is not necessary for the"},{"line_number":17,"context_line":"notification testing and therefor speeds up the tests."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I0269c4bd3da0e58593811b11985deb237eefe59e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_f00b221f","line":17,"range":{"start_line":17,"start_character":25,"end_line":17,"end_character":33},"updated":"2019-08-12 15:42:39.000000000","message":"therefore","commit_id":"0718b2fab2de99e52f6072e208a86de51b1d2c0d"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"ea79125816c2f6e5282c4961022c7740408999f2","unresolved":false,"context_lines":[{"line_number":14,"context_line":"timeout steals 16 minutes of test execution time unnecessary."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This patch stubs the RPC call as that is not necessary for the"},{"line_number":17,"context_line":"notification testing and therefor speeds up the tests."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I0269c4bd3da0e58593811b11985deb237eefe59e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_5074769c","line":17,"range":{"start_line":17,"start_character":25,"end_line":17,"end_character":33},"in_reply_to":"7faddb67_f00b221f","updated":"2019-08-12 15:51:48.000000000","message":"Done","commit_id":"0718b2fab2de99e52f6072e208a86de51b1d2c0d"}],"nova/tests/functional/notification_sample_tests/test_service.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"adba8ae7ddb3dc3fd09a2b2f829878560308a7ef","unresolved":false,"context_lines":[{"line_number":49,"context_line":"                      test_services.fake_service_get_by_host_binary)"},{"line_number":50,"context_line":"        self.stub_out(\"nova.db.api.service_update\","},{"line_number":51,"context_line":"                      test_services.fake_service_update)"},{"line_number":52,"context_line":"        self.stub_out(\"nova.compute.rpcapi.ComputeAPI.set_host_enabled\","},{"line_number":53,"context_line":"                      lambda *args, **kwargs: None)"},{"line_number":54,"context_line":"        self.useFixture(utils_fixture.TimeFixture(test_services.fake_utcnow()))"},{"line_number":55,"context_line":"        self.useFixture(fixtures.SingleCellSimple())"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_1007de1a","line":52,"updated":"2019-08-12 15:42:39.000000000","message":"Would be good to have a comment here.","commit_id":"0718b2fab2de99e52f6072e208a86de51b1d2c0d"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"ea79125816c2f6e5282c4961022c7740408999f2","unresolved":false,"context_lines":[{"line_number":49,"context_line":"                      test_services.fake_service_get_by_host_binary)"},{"line_number":50,"context_line":"        self.stub_out(\"nova.db.api.service_update\","},{"line_number":51,"context_line":"                      test_services.fake_service_update)"},{"line_number":52,"context_line":"        self.stub_out(\"nova.compute.rpcapi.ComputeAPI.set_host_enabled\","},{"line_number":53,"context_line":"                      lambda *args, **kwargs: None)"},{"line_number":54,"context_line":"        self.useFixture(utils_fixture.TimeFixture(test_services.fake_utcnow()))"},{"line_number":55,"context_line":"        self.useFixture(fixtures.SingleCellSimple())"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_50e79647","line":52,"in_reply_to":"7faddb67_1007de1a","updated":"2019-08-12 15:51:48.000000000","message":"Done","commit_id":"0718b2fab2de99e52f6072e208a86de51b1d2c0d"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"bf2b2a66fbb4c1ce143a077f353d5e772f90c2b4","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        # tests the compute services are faked. So stub out the RPC call to"},{"line_number":55,"context_line":"        # avoid waiting for the RPC timeout. The notifications are generated"},{"line_number":56,"context_line":"        # regardless of the result of the RPC call anyhow."},{"line_number":57,"context_line":"        self.stub_out(\"nova.compute.rpcapi.ComputeAPI.set_host_enabled\","},{"line_number":58,"context_line":"                      lambda *args, **kwargs: None)"},{"line_number":59,"context_line":"        self.useFixture(utils_fixture.TimeFixture(test_services.fake_utcnow()))"},{"line_number":60,"context_line":"        self.useFixture(fixtures.SingleCellSimple())"},{"line_number":61,"context_line":"        self.service_uuid \u003d test_services.fake_service_get_by_host_binary("}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_cbd8b7f1","line":58,"range":{"start_line":57,"start_character":8,"end_line":58,"end_character":51},"updated":"2019-08-12 16:46:31.000000000","message":"Would prefer to spell this:\n\n self.useFixture(fixtures.MockPatch(\n     \"nova.compute.rpcapi.ComputeAPI.set_host_enabled\"))","commit_id":"ce42b6d494f166b42efce660bd3a62aefdb62500"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6753048ca625232e2b8da97ad2f29b42572db810","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        # tests the compute services are faked. So stub out the RPC call to"},{"line_number":55,"context_line":"        # avoid waiting for the RPC timeout. The notifications are generated"},{"line_number":56,"context_line":"        # regardless of the result of the RPC call anyhow."},{"line_number":57,"context_line":"        self.stub_out(\"nova.compute.rpcapi.ComputeAPI.set_host_enabled\","},{"line_number":58,"context_line":"                      lambda *args, **kwargs: None)"},{"line_number":59,"context_line":"        self.useFixture(utils_fixture.TimeFixture(test_services.fake_utcnow()))"},{"line_number":60,"context_line":"        self.useFixture(fixtures.SingleCellSimple())"},{"line_number":61,"context_line":"        self.service_uuid \u003d test_services.fake_service_get_by_host_binary("}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_76d3aa60","line":58,"range":{"start_line":57,"start_character":8,"end_line":58,"end_character":51},"in_reply_to":"7faddb67_cbd8b7f1","updated":"2019-08-12 17:01:05.000000000","message":"It\u0027s the same thing under the covers for stub_out which we use above and extensively in functional tests so I don\u0027t think it\u0027s worth holding this up. Sure lambda\u0027s are kind of gnarly but this doesn\u0027t offend me.","commit_id":"ce42b6d494f166b42efce660bd3a62aefdb62500"}]}