)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"afd4410766a1407cf075c9b0f90a2fa83ad5ed20","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Balazs Gibizer \u003cbalazs.gibizer@est.tech\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-09-02 17:36:50 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Make _rever_allocation nested allocation aware"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As we are introducing migrate / resize revert for servers with nested"},{"line_number":10,"context_line":"allocation (servers with ports having bandwidth resource request) we"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"7faddb67_62e2a403","line":7,"range":{"start_line":7,"start_character":6,"end_line":7,"end_character":11},"updated":"2019-09-03 16:05:00.000000000","message":"revert","commit_id":"9f1b14df84134c97dbfae5b5cd3a5773d94440bb"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"d5a3e623c4b134f164d68cfec442cf3ae8ebe390","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Balazs Gibizer \u003cbalazs.gibizer@est.tech\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-09-02 17:36:50 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Make _rever_allocation nested allocation aware"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As we are introducing migrate / resize revert for servers with nested"},{"line_number":10,"context_line":"allocation (servers with ports having bandwidth resource request) we"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"5faad753_5c76f8da","line":7,"range":{"start_line":7,"start_character":6,"end_line":7,"end_character":11},"in_reply_to":"7faddb67_62e2a403","updated":"2019-09-09 13:05:00.000000000","message":"Done","commit_id":"9f1b14df84134c97dbfae5b5cd3a5773d94440bb"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"6b8a603a0ec914817eece61e4c3f4c22caac9dd5","unresolved":false,"context_lines":[{"line_number":9,"context_line":"As we are introducing migrate / resize revert for servers with nested"},{"line_number":10,"context_line":"allocation (servers with ports having bandwidth resource request) we"},{"line_number":11,"context_line":"need to make the allocation revert process aware of more than one"},{"line_number":12,"context_line":"resouce providers in the original allocation held by the migration."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ie90204f05f57a42f7df05fe40c9c5a7f30cb578e"},{"line_number":15,"context_line":"blueprint: support-move-ops-with-qos-ports"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"5faad753_875de2ea","line":12,"updated":"2019-09-10 09:46:04.000000000","message":"*nods*","commit_id":"6ac965b0fdd61fdb2c3312dff50210f24a88e1f1"}],"nova/compute/manager.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"f4dc0941a547cde15cba71feb37b38c485a49950","unresolved":false,"context_lines":[{"line_number":4370,"context_line":"                      migration.uuid, migration.source_node, instance\u003dinstance)"},{"line_number":4371,"context_line":"            return False"},{"line_number":4372,"context_line":""},{"line_number":4373,"context_line":"        LOG.info(\u0027Swapping old allocation on %(rp_uuids)s held by migration \u0027"},{"line_number":4374,"context_line":"                 \u0027%(mig)s for instance\u0027,"},{"line_number":4375,"context_line":"                 {\u0027rp_uuids\u0027: orig_alloc.keys(), \u0027mig\u0027: migration.uuid},"},{"line_number":4376,"context_line":"                 instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_ccf75fd4","line":4373,"range":{"start_line":4373,"start_character":47,"end_line":4373,"end_character":55},"updated":"2019-08-13 12:42:45.000000000","message":"If we want to keep node here then we could use migration.source_node in the log message.","commit_id":"ec61fe11ea2ac80097a7f00bc7eef28d4e642902"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"afd4410766a1407cf075c9b0f90a2fa83ad5ed20","unresolved":false,"context_lines":[{"line_number":4358,"context_line":"                      migration.uuid, migration.source_node, instance\u003dinstance)"},{"line_number":4359,"context_line":"            return False"},{"line_number":4360,"context_line":""},{"line_number":4361,"context_line":"        if len(orig_alloc) \u003e 1:"},{"line_number":4362,"context_line":"            # NOTE(danms): This may change later if we have other allocations"},{"line_number":4363,"context_line":"            # against other providers that need to be held by the migration"},{"line_number":4364,"context_line":"            # as well. Perhaps something like shared storage resources that"},{"line_number":4365,"context_line":"            # will actually be duplicated during a resize type operation."},{"line_number":4366,"context_line":"            LOG.error(\u0027Migration %(mig)s has allocations against \u0027"},{"line_number":4367,"context_line":"                      \u0027more than one provider %(rps)s. This should not be \u0027"},{"line_number":4368,"context_line":"                      \u0027possible, but reverting it anyway.\u0027,"},{"line_number":4369,"context_line":"                      {\u0027mig\u0027: migration.uuid,"},{"line_number":4370,"context_line":"                       \u0027rps\u0027: \u0027,\u0027.join(orig_alloc.keys())},"},{"line_number":4371,"context_line":"                      instance\u003dinstance)"},{"line_number":4372,"context_line":""},{"line_number":4373,"context_line":"        # We only have a claim against one provider, it is the source node"},{"line_number":4374,"context_line":"        cn_uuid \u003d list(orig_alloc.keys())[0]"}],"source_content_type":"text/x-python","patch_set":10,"id":"7faddb67_22eb4ca4","side":"PARENT","line":4371,"range":{"start_line":4361,"start_character":8,"end_line":4371,"end_character":40},"updated":"2019-09-03 16:05:00.000000000","message":"test_revert_allocation_new_style_unpossible was added with this and is saying this is not possible, but the test doesn\u0027t assert that we log an error for it, nor are we changing how we call move_allocations so it doesn\u0027t fail (the test doesn\u0027t even check how move_allocations is called, just that it is called). Anyway, that test should probably be updated since it\u0027s saying (like this comment) that having more than one allocation on one provider is not possible which this change is asserting can happen now.","commit_id":"9a161a03600feaaa7e1c66dce2fa23ba26e3211d"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"d5a3e623c4b134f164d68cfec442cf3ae8ebe390","unresolved":false,"context_lines":[{"line_number":4358,"context_line":"                      migration.uuid, migration.source_node, instance\u003dinstance)"},{"line_number":4359,"context_line":"            return False"},{"line_number":4360,"context_line":""},{"line_number":4361,"context_line":"        if len(orig_alloc) \u003e 1:"},{"line_number":4362,"context_line":"            # NOTE(danms): This may change later if we have other allocations"},{"line_number":4363,"context_line":"            # against other providers that need to be held by the migration"},{"line_number":4364,"context_line":"            # as well. Perhaps something like shared storage resources that"},{"line_number":4365,"context_line":"            # will actually be duplicated during a resize type operation."},{"line_number":4366,"context_line":"            LOG.error(\u0027Migration %(mig)s has allocations against \u0027"},{"line_number":4367,"context_line":"                      \u0027more than one provider %(rps)s. This should not be \u0027"},{"line_number":4368,"context_line":"                      \u0027possible, but reverting it anyway.\u0027,"},{"line_number":4369,"context_line":"                      {\u0027mig\u0027: migration.uuid,"},{"line_number":4370,"context_line":"                       \u0027rps\u0027: \u0027,\u0027.join(orig_alloc.keys())},"},{"line_number":4371,"context_line":"                      instance\u003dinstance)"},{"line_number":4372,"context_line":""},{"line_number":4373,"context_line":"        # We only have a claim against one provider, it is the source node"},{"line_number":4374,"context_line":"        cn_uuid \u003d list(orig_alloc.keys())[0]"}],"source_content_type":"text/x-python","patch_set":10,"id":"5faad753_dcb748d8","side":"PARENT","line":4371,"range":{"start_line":4361,"start_character":8,"end_line":4371,"end_character":40},"in_reply_to":"7faddb67_22eb4ca4","updated":"2019-09-09 13:05:00.000000000","message":"I think that testing if the allocation is complex or not does not make sense any more as the _revert_allocation code does not care any more. I changed the existing test coverage to reflect the current behavior.","commit_id":"9a161a03600feaaa7e1c66dce2fa23ba26e3211d"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"6b8a603a0ec914817eece61e4c3f4c22caac9dd5","unresolved":false,"context_lines":[{"line_number":4363,"context_line":"                 \u0027%(mig)s for instance\u0027,"},{"line_number":4364,"context_line":"                 {\u0027rp_uuids\u0027: orig_alloc.keys(), \u0027mig\u0027: migration.uuid},"},{"line_number":4365,"context_line":"                 instance\u003dinstance)"},{"line_number":4366,"context_line":"        # FIXME(gibi): This method is flawed in that it assumes every"},{"line_number":4367,"context_line":"        # allocation held by the migration uuid are against the destination"},{"line_number":4368,"context_line":"        # compute RP tree. So it might overwrite allocation against a"},{"line_number":4369,"context_line":"        # shared provider if we had one."}],"source_content_type":"text/x-python","patch_set":16,"id":"5faad753_a7057ec4","line":4366,"range":{"start_line":4366,"start_character":16,"end_line":4366,"end_character":20},"updated":"2019-09-10 09:46:04.000000000","message":"well, that\u0027s still the same problem that was dan told here, but okay.","commit_id":"6ac965b0fdd61fdb2c3312dff50210f24a88e1f1"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"ac421491a073391d783ec89e6cd3ba23aa890d9e","unresolved":false,"context_lines":[{"line_number":4363,"context_line":"                 \u0027%(mig)s for instance\u0027,"},{"line_number":4364,"context_line":"                 {\u0027rp_uuids\u0027: orig_alloc.keys(), \u0027mig\u0027: migration.uuid},"},{"line_number":4365,"context_line":"                 instance\u003dinstance)"},{"line_number":4366,"context_line":"        # FIXME(gibi): This method is flawed in that it assumes every"},{"line_number":4367,"context_line":"        # allocation held by the migration uuid are against the destination"},{"line_number":4368,"context_line":"        # compute RP tree. So it might overwrite allocation against a"},{"line_number":4369,"context_line":"        # shared provider if we had one."}],"source_content_type":"text/x-python","patch_set":16,"id":"5faad753_4c938aa4","line":4366,"range":{"start_line":4366,"start_character":16,"end_line":4366,"end_character":20},"in_reply_to":"5faad753_226adcb2","updated":"2019-09-10 12:48:40.000000000","message":"Well, OK, I understand your point.","commit_id":"6ac965b0fdd61fdb2c3312dff50210f24a88e1f1"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"87a7a8a1197ec88a9d3d3ef1e5841fcdaab98e8f","unresolved":false,"context_lines":[{"line_number":4363,"context_line":"                 \u0027%(mig)s for instance\u0027,"},{"line_number":4364,"context_line":"                 {\u0027rp_uuids\u0027: orig_alloc.keys(), \u0027mig\u0027: migration.uuid},"},{"line_number":4365,"context_line":"                 instance\u003dinstance)"},{"line_number":4366,"context_line":"        # FIXME(gibi): This method is flawed in that it assumes every"},{"line_number":4367,"context_line":"        # allocation held by the migration uuid are against the destination"},{"line_number":4368,"context_line":"        # compute RP tree. So it might overwrite allocation against a"},{"line_number":4369,"context_line":"        # shared provider if we had one."}],"source_content_type":"text/x-python","patch_set":16,"id":"5faad753_226adcb2","line":4366,"range":{"start_line":4366,"start_character":16,"end_line":4366,"end_character":20},"in_reply_to":"5faad753_a7057ec4","updated":"2019-09-10 12:03:04.000000000","message":"It is not the same actually. We went from supporting a single RP in the allocation to support multiple RPs from a single RP tree in the allocation.","commit_id":"6ac965b0fdd61fdb2c3312dff50210f24a88e1f1"}],"nova/tests/unit/compute/test_compute_mgr.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"6b8a603a0ec914817eece61e4c3f4c22caac9dd5","unresolved":false,"context_lines":[{"line_number":7739,"context_line":"        def doit(mock_report, mock_info):"},{"line_number":7740,"context_line":"            a \u003d {"},{"line_number":7741,"context_line":"                uuids.node: {\u0027resources\u0027: {\u0027DISK_GB\u0027: 1}},"},{"line_number":7742,"context_line":"                uuids.child_rp: {\u0027resources\u0027: {\u0027CUSTOM_FOO\u0027: 1}}"},{"line_number":7743,"context_line":"            }"},{"line_number":7744,"context_line":"            mock_report.get_allocations_for_consumer.return_value \u003d a"},{"line_number":7745,"context_line":"            self.migration.uuid \u003d uuids.migration"}],"source_content_type":"text/x-python","patch_set":16,"id":"5faad753_c7319aa4","line":7742,"updated":"2019-09-10 09:46:04.000000000","message":"Cool, this is an allocation for a child RP.","commit_id":"6ac965b0fdd61fdb2c3312dff50210f24a88e1f1"}]}