)]}'
{"id":"openstack%2Fnova~676255","triplet_id":"openstack%2Fnova~stable%2Fstein~Ie19f1be2d60d4d20fac99508d1683ab3f266bfba","project":"openstack/nova","branch":"stable/stein","topic":"bug/1737465","hashtags":[],"change_id":"Ie19f1be2d60d4d20fac99508d1683ab3f266bfba","subject":"Delete unused get_all_host_states method","status":"MERGED","created":"2019-08-13 17:40:27.000000000","updated":"2019-08-29 12:57:08.000000000","submitted":"2019-08-29 12:53:24.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"676255-1567083204431-22bc38ef","meta_rev_id":"c8baa58eb2503d8ddcc91e8a36d2345cbcad6572","_number":676255,"virtual_id_number":676255,"owner":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"date":"2019-08-13 17:41:21.000000000","_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"value":0,"date":"2019-08-13 20:53:01.000000000","_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"date":"2019-08-14 10:06:33.000000000","_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":2,"date":"2019-08-29 12:53:24.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"all":[{"value":0,"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},{"value":2,"date":"2019-08-29 10:17:05.000000000","_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"all":[{"value":0,"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},{"value":1,"date":"2019-08-29 10:17:05.000000000","_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-08-13 17:41:21.000000000","updated_by":{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-08-13 20:53:01.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"REVIEWER"},{"updated":"2019-08-14 10:06:33.000000000","updated_by":{"_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},"reviewer":{"_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-08-29 10:17:05.000000000","updated_by":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"reviewer":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"state":"REVIEWER"},{"updated":"2019-08-29 12:53:24.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"795de1d67ceeb9cacf63458afddc5509458d14f6","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-08-13 17:40:27.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"006e0d7baf39d6ba268f950a804e33f15f10c615","author":{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},"date":"2019-08-13 17:41:21.000000000","message":"Patch Set 1:\n\nTesting failed ubuntu-xenial-s390x. For rechecking only on the ubuntu-xenial-s390x CI, add a review comment with recheck-zkvm. Contact info: zkvm-ci@linux.vnet.ibm.com. For more information, see https://wiki.openstack.org/wiki/ThirdPartySystems/IBM_zKVM_CI\n\n- check-tempest-dsvm-neutron-full-ubuntu-xenial-s390x http://sng01.objectstorage.softlayer.net/v1/AUTH_1940ea10-6e82-4501-b2f9-eb236510e575/ibmzkvmci/production/676255/1/check-tempest-dsvm-neutron-full-ubuntu-xenial-s390x/9878f46 : NOT_REGISTERED","accounts_in_message":[],"_revision_number":1},{"id":"784532a0dd7858f20c1debbe7cea30fdf8b4ab17","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2019-08-13 20:53:01.000000000","message":"Patch Set 1:\n\nBuild succeeded.\n\n- nova http://cloudbase-ci.com/nova/676255/1 : SUCCESS in 2h 09m 15s","accounts_in_message":[],"_revision_number":1},{"id":"b0185255bf19228a5d5300ef22a2fdf44d5b90db","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-13 21:18:09.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/be55f89d1fac4ca890271c9e04e9c5d7 : SUCCESS in 1h 05m 37s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/695ada7c861f410ba1b0ddf12b5a54ea : SUCCESS in 1h 42m 27s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/b43a5feb20d8499a86abc20e80c4199d : SUCCESS in 15m 49s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/d3dabcb0bc6d406eaa395c53d8528833 : SUCCESS in 11m 29s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/ef447c1f13c84e35bd14750a0bea3f91 : SUCCESS in 11m 55s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/8495109c3b8d4d4c8c71e2dd20bf7449 : SUCCESS in 11m 32s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/e96c792fe6434730800b0f3fc6b0f4e5 : SUCCESS in 15m 39s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/d951ddde8c7940e294c07d08eac4b762 : SUCCESS in 14m 47s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/c3f023014149409a8cc63b3bf18c73f2 : SUCCESS in 15m 50s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/3a070a25ee8946b0aafabea691746642 : SUCCESS in 7m 35s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/584295c067d84314bee351e457c96d3d : SUCCESS in 53m 25s (non-voting)\n- devstack-plugin-ceph-tempest https://zuul.opendev.org/t/openstack/build/33c3963097594114bb505644211e633e : SUCCESS in 1h 17m 14s (non-voting)\n- neutron-grenade-multinode https://zuul.opendev.org/t/openstack/build/23f1120c8d384e2099b6def892130d34 : SUCCESS in 1h 08m 02s\n- nova-grenade-live-migration https://zuul.opendev.org/t/openstack/build/c9e9358738d84500a7c06c41d7193129 : SUCCESS in 1h 01m 49s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/2b7037694b904411b34deceef2bac0cd : SUCCESS in 49m 38s\n- nova-next https://zuul.opendev.org/t/openstack/build/31d2eba75fbb41c09b73465cc7f73bba : SUCCESS in 1h 15m 17s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/63eeba40b0334852b7e193518ce31a95 : SUCCESS in 19m 19s\n- nova-tox-functional-py35 https://zuul.opendev.org/t/openstack/build/b6e48141501843acb39f3df201b77b55 : SUCCESS in 20m 04s\n- tempest-multinode-full https://zuul.opendev.org/t/openstack/build/f2d0775db32b42d09d54b65eb103d6aa : SUCCESS in 2h 01m 48s (non-voting)\n- tempest-slow-py3 https://zuul.opendev.org/t/openstack/build/2280bb7860874f2b8b6f3c2878c75c9b : SUCCESS in 2h 26m 04s","accounts_in_message":[],"_revision_number":1},{"id":"4ca684ebd3908e442505d5299f3f9da3cd1b1370","author":{"_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},"date":"2019-08-14 10:06:33.000000000","message":"Patch Set 1:\n\nBuild succeeded.\n\n- Nova-ML2-Sriov http://13.74.249.42/55/676255/1/check-nova/Nova-ML2-Sriov/c1fc1a8 : SUCCESS in 1h 23m 26s (non-voting)\n- Nova-MACVTAP-ML2-Sriov http://13.74.249.42/55/676255/1/check-nova/Nova-MACVTAP-ML2-Sriov/54023bf : SUCCESS in 1h 12m 12s (non-voting)\n\nTo re-run the job post \u0027recheck nova-mlnx\u0027 comment. For more information visit https://wiki.openstack.org/wiki/ThirdPartySystems/Mellanox_CI","accounts_in_message":[],"_revision_number":1},{"id":"fa4afb4cef71f8395cdf126a74865777bd4f819f","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2019-08-29 10:17:05.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nLGTM, trivial cleanup, valid on stable/stein, landed in master and clean. Approving as this is from another Nova stable core.","accounts_in_message":[],"_revision_number":1},{"id":"7d6cf965876708efeb22d96b9a3e146cdb03d2b7","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-29 10:17:47.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"01cdb12eaef61303999f66a3bf8e6d140d3549e4","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-29 12:53:24.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"014d7d43d91be3bee413507ef809d8581d5610a8","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-29 12:53:24.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/6cdb18fe7db5446cac9e8dd532c21669 : SUCCESS in 1h 02m 17s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/d70e604cc6be4c3c9f93e0ac7328600b : SUCCESS in 1h 35m 21s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/6fbdfe696c8f4433b92dbb8f58ff796f : SUCCESS in 12m 56s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/c967e29e57084dbead43d27673de99fb : SUCCESS in 15m 40s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/ffc0887ebcc24c24a4838ccea1b710aa : SUCCESS in 14m 54s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/2b3b35d71b3a46a3a7368daecafdb59c : SUCCESS in 16m 37s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/95b6b765098848eda736dd1ac658455c : SUCCESS in 12m 29s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/2091ca6c1fd14759affc958cef1057fd : SUCCESS in 15m 29s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/14dfee8c29694e6db97c607e2424bfeb : SUCCESS in 8m 22s\n- nova-grenade-live-migration https://zuul.opendev.org/t/openstack/build/53ba2c514ce648679fc897dcb6e823fc : SUCCESS in 1h 08m 44s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/7d1856352d6947419b3db6479bb5e616 : SUCCESS in 47m 31s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/605eca0734914b33bd1dce3a1fe873cc : SUCCESS in 21m 26s\n- nova-tox-functional-py35 https://zuul.opendev.org/t/openstack/build/0fd64916428e4d779f327cc6f5611209 : SUCCESS in 20m 43s\n- nova-next https://zuul.opendev.org/t/openstack/build/844cdc0910d946b185b69c0e22219271 : SUCCESS in 1h 41m 23s\n- tempest-slow-py3 https://zuul.opendev.org/t/openstack/build/8a747c91bc404ecd80ed44d822811943 : SUCCESS in 2h 15m 02s","accounts_in_message":[],"_revision_number":1},{"id":"27c9b3f40451db294a2a8f304802f54bef813a18","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-29 12:57:08.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/4970bd615164421abfb3d74df5d7cefe : SUCCESS in 2m 29s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"77a077573b3fecd6d774bae5d57ff52fd7d977d4","revisions":{"77a077573b3fecd6d774bae5d57ff52fd7d977d4":{"kind":"REWORK","_number":1,"created":"2019-08-13 17:40:27.000000000","uploader":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"ref":"refs/changes/55/676255/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/55/676255/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/55/676255/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/55/676255/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/55/676255/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/55/676255/1"}}},"commit":{"parents":[{"commit":"11fde850e6163b68e006e746406e6c5e6ac980e0","subject":"Don\u0027t generate service UUID for deleted services","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/11fde850e6163b68e006e746406e6c5e6ac980e0"}]}],"author":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2019-06-05 16:31:29.000000000","tz":-240},"committer":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2019-08-13 17:33:14.000000000","tz":-240},"subject":"Delete unused get_all_host_states method","message":"Delete unused get_all_host_states method\n\nThe CachingScheduler was the last thing to use the\nHostManager.get_all_host_states method and the\nCachingScheduler was deleted in Stein [1].\n\nThis removes the unused get_all_host_states method.\nThe majority of the change is in the test code that\nwas using get_all_host_states as an entry point to\ntest the _get_host_states method, so rather than\noutright delete the tests and potentially drop coverage\non _get_host_states, those tests are refactored a bit\nto call _get_host_states directly.\n\n[1] I1832da2190be5ef2b04953938860a56a43e8cddf\n\nChange-Id: Ie19f1be2d60d4d20fac99508d1683ab3f266bfba\n(cherry picked from commit d7ba0d0dba4c9b2c5fa72d55b38d58f6db2ee891)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/77a077573b3fecd6d774bae5d57ff52fd7d977d4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/77a077573b3fecd6d774bae5d57ff52fd7d977d4"}]},"branch":"refs/heads/stable/stein"}},"requirements":[],"submit_records":[],"submit_requirements":[]}