)]}'
{"nova/tests/unit/compute/test_resource_tracker.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"07f48cf9b07607dcdd764fbe516fc853c0fc4b7e","unresolved":false,"context_lines":[{"line_number":1123,"context_line":"            \u0027vcpus\u0027: 4,"},{"line_number":1124,"context_line":"            \u0027running_vms\u0027: 0,"},{"line_number":1125,"context_line":"            \u0027pci_passthrough_devices\u0027: \u0027[]\u0027,"},{"line_number":1126,"context_line":"            \u0027uuid\u0027: uuids.compute_node_uuid"},{"line_number":1127,"context_line":"        }"},{"line_number":1128,"context_line":"        # The expected compute represents the initial values used"},{"line_number":1129,"context_line":"        # when creating a compute node."}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_8af5abcd","line":1126,"updated":"2019-08-14 18:46:09.000000000","message":"Actually since we don\u0027t have Ia69fabce8e7fd7de101e291fe133c6f5f5f7056a we should probably not include uuid in resources and just ignore uuid in obj_equal_prims below.","commit_id":"6cc37953b3b80ccf32f36329c1b787c22beaf53a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"76ea803a22b2fc0631f1877f075b854701fcc4d4","unresolved":false,"context_lines":[{"line_number":1123,"context_line":"            \u0027vcpus\u0027: 4,"},{"line_number":1124,"context_line":"            \u0027running_vms\u0027: 0,"},{"line_number":1125,"context_line":"            \u0027pci_passthrough_devices\u0027: \u0027[]\u0027,"},{"line_number":1126,"context_line":"            \u0027uuid\u0027: uuids.compute_node_uuid"},{"line_number":1127,"context_line":"        }"},{"line_number":1128,"context_line":"        # The expected compute represents the initial values used"},{"line_number":1129,"context_line":"        # when creating a compute node."}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_180dc3e7","line":1126,"in_reply_to":"3fa7e38b_1855c3fa","updated":"2019-10-23 15:55:50.000000000","message":"Actually the diff is pretty minimal so I might as well update this:\n\ndiff --git a/nova/tests/unit/compute/test_resource_tracker.py b/nova/tests/unit/compute/test_resource_tracker.py\nindex bcb15a31bd..f44531590d 100644\n--- a/nova/tests/unit/compute/test_resource_tracker.py\n+++ b/nova/tests/unit/compute/test_resource_tracker.py\n@@ -1122,8 +1122,7 @@ class TestInitComputeNode(BaseTestCase):\n             \u0027current_workload\u0027: 0,\n             \u0027vcpus\u0027: 4,\n             \u0027running_vms\u0027: 0,\n-            \u0027pci_passthrough_devices\u0027: \u0027[]\u0027,\n-            \u0027uuid\u0027: uuids.compute_node_uuid\n+            \u0027pci_passthrough_devices\u0027: \u0027[]\u0027\n         }\n         # The expected compute represents the initial values used\n         # when creating a compute node.\n@@ -1154,7 +1153,7 @@ class TestInitComputeNode(BaseTestCase):\n \n         def fake_copy_resources(_cn, _resources):\n             # We have to set the uuid field on the ComputeNode for logging.\n-            _cn.uuid \u003d _resources[\u0027uuid\u0027]\n+            _cn.uuid \u003d uuids.compute_node_uuid\n             return original_copy_resources(_cn, _resources)\n \n         with test.nested(","commit_id":"6cc37953b3b80ccf32f36329c1b787c22beaf53a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d65f899a9e7553c93f29f5c83efb9672663dd572","unresolved":false,"context_lines":[{"line_number":1123,"context_line":"            \u0027vcpus\u0027: 4,"},{"line_number":1124,"context_line":"            \u0027running_vms\u0027: 0,"},{"line_number":1125,"context_line":"            \u0027pci_passthrough_devices\u0027: \u0027[]\u0027,"},{"line_number":1126,"context_line":"            \u0027uuid\u0027: uuids.compute_node_uuid"},{"line_number":1127,"context_line":"        }"},{"line_number":1128,"context_line":"        # The expected compute represents the initial values used"},{"line_number":1129,"context_line":"        # when creating a compute node."}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_1855c3fa","line":1126,"in_reply_to":"3fa7e38b_7e8b871d","updated":"2019-10-23 15:42:21.000000000","message":"\u003e Did you want to address this still Matt?\n\nDo I *want* to? Not really. Can I? Sure. It doesn\u0027t really make any difference to the runtime code, but I guess there is a slim chance that someone trying to figure out the runtime code workings based on the test could get confused since we don\u0027t have that uuid in resources thing in Queens.","commit_id":"6cc37953b3b80ccf32f36329c1b787c22beaf53a"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"524bee5da4824bf3f4ea411302e4efbebb80123f","unresolved":false,"context_lines":[{"line_number":1123,"context_line":"            \u0027vcpus\u0027: 4,"},{"line_number":1124,"context_line":"            \u0027running_vms\u0027: 0,"},{"line_number":1125,"context_line":"            \u0027pci_passthrough_devices\u0027: \u0027[]\u0027,"},{"line_number":1126,"context_line":"            \u0027uuid\u0027: uuids.compute_node_uuid"},{"line_number":1127,"context_line":"        }"},{"line_number":1128,"context_line":"        # The expected compute represents the initial values used"},{"line_number":1129,"context_line":"        # when creating a compute node."}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_7e8b871d","line":1126,"in_reply_to":"7faddb67_8af5abcd","updated":"2019-10-23 09:59:05.000000000","message":"Did you want to address this still Matt?","commit_id":"6cc37953b3b80ccf32f36329c1b787c22beaf53a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"fba9dca5c7b9d488bfb1dfea175bf3ea0a743ff9","unresolved":false,"context_lines":[{"line_number":1194,"context_line":"        # The first ComputeNode.create fails so rt.compute_nodes should"},{"line_number":1195,"context_line":"        # remain empty."},{"line_number":1196,"context_line":"        resources \u003d copy.deepcopy(_VIRT_DRIVER_AVAIL_RESOURCES)"},{"line_number":1197,"context_line":"        resources[\u0027uuid\u0027] \u003d uuids.cn_uuid  # for the LOG.info message"},{"line_number":1198,"context_line":"        self.assertRaises(test.TestingException,"},{"line_number":1199,"context_line":"                          self.rt._init_compute_node, ctxt, resources)"},{"line_number":1200,"context_line":"        self.assertEqual({}, self.rt.compute_nodes)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_582c9b49","line":1197,"updated":"2019-10-23 15:57:07.000000000","message":"same","commit_id":"6cc37953b3b80ccf32f36329c1b787c22beaf53a"}]}
