)]}'
{"id":"openstack%2Fnova~676289","triplet_id":"openstack%2Fnova~stable%2Fstein~I49460ec3b572ee14b32229e771a5499ff91e8722","project":"openstack/nova","branch":"stable/stein","topic":"bug/1839853","hashtags":[],"change_id":"I49460ec3b572ee14b32229e771a5499ff91e8722","subject":"Fix misuse of nova.objects.base.obj_equal_prims","status":"MERGED","created":"2019-08-13 23:54:27.000000000","updated":"2019-08-14 16:13:49.000000000","submitted":"2019-08-14 16:13:48.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"676289-1565799229112-28760403","meta_rev_id":"e8983aed8082b39c52ee1099c8c9cccb580b28bd","_number":676289,"virtual_id_number":676289,"owner":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"date":"2019-08-14 02:07:24.000000000","_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":2,"date":"2019-08-14 16:13:48.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"all":[{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":2,"date":"2019-08-14 13:17:42.000000000","_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"all":[{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":1,"date":"2019-08-14 13:17:42.000000000","_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-08-14 02:07:24.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"REVIEWER"},{"updated":"2019-08-14 13:17:42.000000000","updated_by":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"reviewer":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"state":"REVIEWER"},{"updated":"2019-08-14 16:13:48.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"ea89cf9432146f4dad8399900f58bdbc84f5d2fb","author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"date":"2019-08-13 23:54:27.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"50a840ccb31283f7c8c9d8bd84d781228928908c","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-14 00:23:11.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/349da7bb1455440680179a9fbc0a318f : SUCCESS in 15m 24s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/d54767aba69b4f13ac47072e4b60378c : SUCCESS in 11m 39s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/e3651488d2f04d28a2f49c37970781cf : SUCCESS in 10m 32s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/8c6e332e57c24f3abe42e3666f4726fd : SUCCESS in 11m 29s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/cc8de6978f084e7299e0d9fbd806edbe : SUCCESS in 11m 59s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/439fda47eb3c433d986720ddb02b3a09 : SUCCESS in 12m 00s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/ff44afac50b24ebfb5d6a382827cb358 : SUCCESS in 11m 30s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/a81830d0fcdb4daa9ae35423a9d03584 : SUCCESS in 5m 52s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/f8338ae5fb944abf97ef63a3462d1838 : SUCCESS in 17m 43s\n- nova-tox-functional-py35 https://zuul.opendev.org/t/openstack/build/f39023300daf4aa796ad32264326a815 : SUCCESS in 18m 47s","accounts_in_message":[],"_revision_number":1},{"id":"8a81267030cf94288bbf12c4833b74b8b9518a41","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2019-08-14 02:07:24.000000000","message":"Patch Set 1:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/676289/1 : FAILURE in 2h 12m 09s","accounts_in_message":[],"_revision_number":1},{"id":"bedbd2b5a7a6270918f3919d9eebb1fcd1cefe68","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-08-14 13:17:42.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nClean backport for a test-only fix, I\u0027m just going to fast approve this.","accounts_in_message":[],"_revision_number":1},{"id":"988f6e3cda83bab7169b9d08966b8cfe7406fb94","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-14 13:18:10.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"cff691eb8ae9461bd43f662b9a910ac0015e8b49","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-14 16:13:48.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/b4f586b8f7724cacbb3782cc33202119 : SUCCESS in 12m 21s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/417a6aeaf9374f9c9010919a4812cd69 : SUCCESS in 11m 31s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/2358459af10f4584b2553aac50960e52 : SUCCESS in 14m 52s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/0b8beb3c67ea46aa84ac999e9705ae0a : SUCCESS in 17m 40s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/12b3dc0721ff41f1b7c648e069d39f77 : SUCCESS in 12m 42s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/6d488517415a4ac4bfed637d6bb2a275 : SUCCESS in 12m 43s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/d9a8ea35ab9045d0b36e307712bdec92 : SUCCESS in 6m 30s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/8b0a3c2488f7480aa01f1d86b848a66b : SUCCESS in 20m 05s\n- nova-tox-functional-py35 https://zuul.opendev.org/t/openstack/build/5946a829a3594da7ab8bbd430d0cb07d : SUCCESS in 24m 13s","accounts_in_message":[],"_revision_number":1},{"id":"5d25cde327bb4fa5528b7e8439720ed03dac6ca5","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-14 16:13:49.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"a8e19afb3d4889412ee6f539bb63865eb8ef5bb5","revisions":{"a8e19afb3d4889412ee6f539bb63865eb8ef5bb5":{"kind":"REWORK","_number":1,"created":"2019-08-13 23:54:27.000000000","uploader":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"ref":"refs/changes/89/676289/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/89/676289/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/89/676289/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/89/676289/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/89/676289/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/89/676289/1"}}},"commit":{"parents":[{"commit":"11fde850e6163b68e006e746406e6c5e6ac980e0","subject":"Don\u0027t generate service UUID for deleted services","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/11fde850e6163b68e006e746406e6c5e6ac980e0"}]}],"author":{"name":"Takashi NATSUME","email":"natsume.takashi@lab.ntt.co.jp","date":"2019-08-13 00:31:32.000000000","tz":540},"committer":{"name":"Takashi NATSUME","email":"natsume.takashi@lab.ntt.co.jp","date":"2019-08-13 23:53:45.000000000","tz":540},"subject":"Fix misuse of nova.objects.base.obj_equal_prims","message":"Fix misuse of nova.objects.base.obj_equal_prims\n\nThe nova.objects.base.obj_equal_prims returns True or False.\nIt does not assert anything.\nSo the return value should be asserted in tests.\n\nAdd assertTrue where the nova.objects.base.obj_equal_prims is called.\n\nChange-Id: I49460ec3b572ee14b32229e771a5499ff91e8722\nCloses-Bug: #1839853\n(cherry picked from commit 5c1d9dcbb29f5a84d56c4e496b3111b4040cad13)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/a8e19afb3d4889412ee6f539bb63865eb8ef5bb5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/a8e19afb3d4889412ee6f539bb63865eb8ef5bb5"}]},"branch":"refs/heads/stable/stein"}},"requirements":[],"submit_records":[],"submit_requirements":[]}