)]}'
{"id":"openstack%2Fnova~676290","triplet_id":"openstack%2Fnova~stable%2Frocky~I49460ec3b572ee14b32229e771a5499ff91e8722","project":"openstack/nova","branch":"stable/rocky","topic":"bug/1839853","hashtags":[],"change_id":"I49460ec3b572ee14b32229e771a5499ff91e8722","subject":"Fix misuse of nova.objects.base.obj_equal_prims","status":"MERGED","created":"2019-08-13 23:57:44.000000000","updated":"2019-08-14 22:37:11.000000000","submitted":"2019-08-14 22:17:29.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"676290-1565821050286-070cffcc","meta_rev_id":"4fcf70c839e3c01d6f9fe869f48c93a93512d934","_number":676290,"virtual_id_number":676290,"owner":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"date":"2019-08-14 22:37:11.000000000","post_submit":true,"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"value":0,"date":"2019-08-14 01:58:14.000000000","_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":2,"date":"2019-08-14 22:17:29.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"all":[{"value":0,"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":2,"date":"2019-08-14 20:58:53.000000000","_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"all":[{"value":0,"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":1,"date":"2019-08-14 20:58:53.000000000","_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-08-14 01:58:14.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"REVIEWER"},{"updated":"2019-08-14 20:58:53.000000000","updated_by":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"reviewer":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"state":"REVIEWER"},{"updated":"2019-08-14 22:17:29.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-08-14 22:37:11.000000000","updated_by":{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"bc0906a3f6bd0db22e310928c6cd9c0fff38ae3e","author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"date":"2019-08-13 23:57:44.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"0132a8b706cf7e9c21648abfe3a8502924b9d897","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-14 00:19:15.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/001a5e9b33ed4767bd836db38ac8638e : SUCCESS in 9m 48s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/bca62ad0fcee4a45a7448b8f48d04c0a : SUCCESS in 14m 56s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/e8dffb25685d4e83a452b5c244df2447 : SUCCESS in 15m 20s\n- build-openstack-sphinx-docs https://zuul.opendev.org/t/openstack/build/f563ac2a2b28488985c889b6b0c378ac : SUCCESS in 7m 55s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/4165d55da8604b10a3604d4b55a86e52 : SUCCESS in 19m 41s\n- nova-tox-functional-py35 https://zuul.opendev.org/t/openstack/build/4b9960f7941546b3bd5d0522b782b71a : SUCCESS in 19m 58s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/c28206e1fa174aaa9a42df07a119e280 : SUCCESS in 13m 41s","accounts_in_message":[],"_revision_number":1},{"id":"b190208cc751216d71b288335b40a636d2db6bb8","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2019-08-14 01:58:14.000000000","message":"Patch Set 1:\n\nBuild succeeded.\n\n- nova http://cloudbase-ci.com/nova/676290/1 : SUCCESS in 1h 59m 44s","accounts_in_message":[],"_revision_number":1},{"id":"806fac6801a6cd7a92598ab0f271c16468a1bdfa","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-08-14 20:58:53.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nClean backport, test-only change, fast approving.","accounts_in_message":[],"_revision_number":1},{"id":"f43444416d651d65982babc091082a72fb8168cf","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-14 21:03:51.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"c7da23ee857807dc6ce238cb27b9f02287587582","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-14 22:17:29.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/04dabb8c860d4fdd894a8c106f264f9d : SUCCESS in 9m 26s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/df22ef45bd58403da2e49a010c300f94 : SUCCESS in 13m 51s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/d4be5c36ddad451fa57c19ee6d481943 : SUCCESS in 13m 01s\n- build-openstack-sphinx-docs https://zuul.opendev.org/t/openstack/build/a4cdcecd2ba8445f9be63773361e6406 : SUCCESS in 7m 39s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/14b3b50812bd4cc29beef37ed657803f : SUCCESS in 16m 03s\n- nova-tox-functional-py35 https://zuul.opendev.org/t/openstack/build/14b670c3ad714f6ba8b46bcc0862de64 : SUCCESS in 17m 31s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/d1348d0fae7e4793a44c0680bd73e1b1 : SUCCESS in 16m 39s","accounts_in_message":[],"_revision_number":1},{"id":"80e8e0e26e5e8315a6e3e77ea7921f201ffa0db5","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-14 22:17:30.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"fb7585e856a619e10d026b659324c4f2c96c85b1","author":{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},"date":"2019-08-14 22:37:11.000000000","message":"Patch Set 1:\n\nBuild failed. Comment \u0027powervm: recheck\u0027 to recheck.\n For 3rd party CI contact info: https://wiki.openstack.org/wiki/ThirdPartySystems/IBM_PowerVM_CI\n\n- nova-out-of-tree-pvm http://184.172.12.213/90/676290/1/check/nova-out-of-tree-pvm/908daca : FAILURE in 22m 07s\n- nova-in-tree-pvm http://184.172.12.213/90/676290/1/check/nova-in-tree-pvm/bf0dcd9 : FAILURE in 26m 52s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"a17bb97b2eb1f8657423f2ecbbfbfb9b1b629ae7","revisions":{"a17bb97b2eb1f8657423f2ecbbfbfb9b1b629ae7":{"kind":"REWORK","_number":1,"created":"2019-08-13 23:57:44.000000000","uploader":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"ref":"refs/changes/90/676290/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/90/676290/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/90/676290/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/90/676290/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/90/676290/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/90/676290/1"}}},"commit":{"parents":[{"commit":"72f9aa720f9137a35d55b9f96e2220d2d0e5588d","subject":"Don\u0027t generate service UUID for deleted services","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/72f9aa720f9137a35d55b9f96e2220d2d0e5588d"}]}],"author":{"name":"Takashi NATSUME","email":"natsume.takashi@lab.ntt.co.jp","date":"2019-08-13 00:31:32.000000000","tz":540},"committer":{"name":"Takashi NATSUME","email":"natsume.takashi@lab.ntt.co.jp","date":"2019-08-13 23:56:45.000000000","tz":540},"subject":"Fix misuse of nova.objects.base.obj_equal_prims","message":"Fix misuse of nova.objects.base.obj_equal_prims\n\nThe nova.objects.base.obj_equal_prims returns True or False.\nIt does not assert anything.\nSo the return value should be asserted in tests.\n\nAdd assertTrue where the nova.objects.base.obj_equal_prims is called.\n\nChange-Id: I49460ec3b572ee14b32229e771a5499ff91e8722\nCloses-Bug: #1839853\n(cherry picked from commit 5c1d9dcbb29f5a84d56c4e496b3111b4040cad13)\n(cherry picked from commit a8e19afb3d4889412ee6f539bb63865eb8ef5bb5)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/a17bb97b2eb1f8657423f2ecbbfbfb9b1b629ae7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/a17bb97b2eb1f8657423f2ecbbfbfb9b1b629ae7"}]},"branch":"refs/heads/stable/rocky"}},"requirements":[],"submit_records":[],"submit_requirements":[]}