)]}'
{"id":"openstack%2Fnova~676291","triplet_id":"openstack%2Fnova~stable%2Fqueens~I49460ec3b572ee14b32229e771a5499ff91e8722","project":"openstack/nova","branch":"stable/queens","topic":"bug/1839853","hashtags":[],"change_id":"I49460ec3b572ee14b32229e771a5499ff91e8722","subject":"Fix misuse of nova.objects.base.obj_equal_prims","status":"MERGED","created":"2019-08-14 00:00:19.000000000","updated":"2019-08-15 16:09:36.000000000","submitted":"2019-08-15 16:09:36.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"676291-1565885376165-5d7c1590","meta_rev_id":"872a8c751d692bbb7b1942a983a1dd863dbda2de","_number":676291,"virtual_id_number":676291,"owner":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"date":"2019-08-14 22:42:05.000000000","_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"value":0,"date":"2019-08-14 00:45:15.000000000","_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":2,"date":"2019-08-15 16:09:35.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"all":[{"value":0,"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":2,"date":"2019-08-15 14:46:37.000000000","_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"all":[{"value":0,"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":1,"date":"2019-08-15 14:46:37.000000000","_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-08-14 00:45:15.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"REVIEWER"},{"updated":"2019-08-14 22:42:05.000000000","updated_by":{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-08-15 14:46:37.000000000","updated_by":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"reviewer":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"state":"REVIEWER"},{"updated":"2019-08-15 16:09:35.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"b329f67cf91d42d602302be945583f873dcf17fa","author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"date":"2019-08-14 00:00:19.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"4fe9dd36d7e12f70f67c593a7820a44a724aea95","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-14 00:25:31.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/0191e79fb3df444cb1afb051f7152391 : SUCCESS in 9m 38s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/bae1267d2fef44bfb7c8162cb21b3787 : SUCCESS in 13m 15s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/1a8e6ff8a0e24476b3c2898848f99c95 : SUCCESS in 12m 24s\n- build-openstack-sphinx-docs https://zuul.opendev.org/t/openstack/build/0963363e9fcd49019a8d7613b794ca2f : SUCCESS in 7m 12s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/9d17762579864cf698f6a9642bca24e9 : SUCCESS in 18m 50s\n- nova-tox-functional-py35 https://zuul.opendev.org/t/openstack/build/ebb8e4ceca4040838de986fe01165a66 : SUCCESS in 20m 46s","accounts_in_message":[],"_revision_number":1},{"id":"12d7e826a65cc0ac37aefbdc12b3dc0bea2e7af8","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2019-08-14 00:45:15.000000000","message":"Patch Set 1:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/676291/1 : FAILURE in 44m 11s","accounts_in_message":[],"_revision_number":1},{"id":"023a66e1deb1bba71787b1c9655a982706c2a295","author":{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},"date":"2019-08-14 22:42:05.000000000","message":"Patch Set 1:\n\nBuild failed. Comment \u0027powervm: recheck\u0027 to recheck.\n For 3rd party CI contact info: https://wiki.openstack.org/wiki/ThirdPartySystems/IBM_PowerVM_CI\n\n- nova-out-of-tree-pvm http://184.172.12.213/91/676291/1/check/nova-out-of-tree-pvm/85153e5 : FAILURE in 20m 58s\n- nova-in-tree-pvm http://184.172.12.213/91/676291/1/check/nova-in-tree-pvm/b9e6172 : FAILURE in 24m 56s","accounts_in_message":[],"_revision_number":1},{"id":"5314cdc41b932bc80df2d848c4318c4c622feae4","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-08-15 14:46:37.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nClean backport, test-only change, fast approving.","accounts_in_message":[],"_revision_number":1},{"id":"b2efa61a73b99f968dfbf58353691578c05f7725","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-15 14:46:59.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"283476827df8cb834458c0e6f3c9d67b46b03fb7","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-15 16:09:35.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/7e75a9afedaf4f2cb8ae7005bebe9d3f : SUCCESS in 9m 04s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/f76eceb5b09e40b790ebd2791b10670b : SUCCESS in 13m 03s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/65e4b4ae0c6e4db8b0a881483a548dd8 : SUCCESS in 15m 55s\n- build-openstack-sphinx-docs https://zuul.opendev.org/t/openstack/build/13264214cf414e4aa2633346114a6463 : SUCCESS in 9m 41s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/8a281ca20ed74b08a51c033af1f2e3b7 : SUCCESS in 24m 25s\n- nova-tox-functional-py35 https://zuul.opendev.org/t/openstack/build/5bc0e9fd39eb4e80854d904b3f9af6d2 : SUCCESS in 19m 05s","accounts_in_message":[],"_revision_number":1},{"id":"12c6bce0634c041a4c88b498a5fe2430cf8dd8c2","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-15 16:09:36.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"151c828b1f498d44342d9265e575e5fdcb0783c1","revisions":{"151c828b1f498d44342d9265e575e5fdcb0783c1":{"kind":"REWORK","_number":1,"created":"2019-08-14 00:00:19.000000000","uploader":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"ref":"refs/changes/91/676291/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/91/676291/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/91/676291/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/91/676291/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/91/676291/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/91/676291/1"}}},"commit":{"parents":[{"commit":"6212da3f57e3405e4a034e35e6cd6f17e555d5f2","subject":"Merge \"libvirt: move checking CONF.my_ip to init_host()\" into stable/queens","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/6212da3f57e3405e4a034e35e6cd6f17e555d5f2"}]}],"author":{"name":"Takashi NATSUME","email":"natsume.takashi@lab.ntt.co.jp","date":"2019-08-13 00:31:32.000000000","tz":540},"committer":{"name":"Takashi NATSUME","email":"natsume.takashi@lab.ntt.co.jp","date":"2019-08-13 23:59:32.000000000","tz":540},"subject":"Fix misuse of nova.objects.base.obj_equal_prims","message":"Fix misuse of nova.objects.base.obj_equal_prims\n\nThe nova.objects.base.obj_equal_prims returns True or False.\nIt does not assert anything.\nSo the return value should be asserted in tests.\n\nAdd assertTrue where the nova.objects.base.obj_equal_prims is called.\n\nChange-Id: I49460ec3b572ee14b32229e771a5499ff91e8722\nCloses-Bug: #1839853\n(cherry picked from commit 5c1d9dcbb29f5a84d56c4e496b3111b4040cad13)\n(cherry picked from commit a8e19afb3d4889412ee6f539bb63865eb8ef5bb5)\n(cherry picked from commit a17bb97b2eb1f8657423f2ecbbfbfb9b1b629ae7)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/151c828b1f498d44342d9265e575e5fdcb0783c1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/151c828b1f498d44342d9265e575e5fdcb0783c1"}]},"branch":"refs/heads/stable/queens"}},"requirements":[],"submit_records":[],"submit_requirements":[]}