)]}'
{"id":"openstack%2Fnova~676292","triplet_id":"openstack%2Fnova~stable%2Fpike~I49460ec3b572ee14b32229e771a5499ff91e8722","project":"openstack/nova","branch":"stable/pike","topic":"bug/1839853","hashtags":[],"change_id":"I49460ec3b572ee14b32229e771a5499ff91e8722","subject":"Fix misuse of nova.objects.base.obj_equal_prims","status":"MERGED","created":"2019-08-14 00:02:09.000000000","updated":"2019-08-15 22:40:30.000000000","submitted":"2019-08-15 22:40:30.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"676292-1565908830010-8c476a95","meta_rev_id":"0010526c4de5229ba981c1d01136cda233bc6bd3","_number":676292,"virtual_id_number":676292,"owner":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"date":"2019-08-14 22:51:49.000000000","_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"value":0,"date":"2019-08-14 01:07:29.000000000","_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":2,"date":"2019-08-15 22:40:29.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"all":[{"value":0,"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":2,"date":"2019-08-15 18:28:42.000000000","_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"all":[{"value":0,"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":1,"date":"2019-08-15 18:28:42.000000000","_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-08-14 01:07:29.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"REVIEWER"},{"updated":"2019-08-14 22:51:49.000000000","updated_by":{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-08-15 18:28:42.000000000","updated_by":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"reviewer":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"state":"REVIEWER"},{"updated":"2019-08-15 22:40:29.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"687f51ed47a64e052873aca46a85b5edd1b2c86c","author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"date":"2019-08-14 00:02:09.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"8942091cafa1dbf6bfb7e973dfe0d8137a4ff222","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-14 00:40:05.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/06980a691b974ab1bc0ff78f60ad7716 : SUCCESS in 12m 42s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/a3ac3161609e4bc7a7712779414a88b3 : SUCCESS in 15m 18s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/6e5b0e50f2554103945a2fb7b8e037f8 : SUCCESS in 15m 12s\n- build-openstack-sphinx-docs https://zuul.opendev.org/t/openstack/build/ec21831e0726491fbf1dde32d6a0a4ce : SUCCESS in 8m 55s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/df1631b2efc54057bd7affcd23db3234 : SUCCESS in 23m 37s\n- nova-tox-functional-py35 https://zuul.opendev.org/t/openstack/build/9b80f49d1554449eb70082297066d0df : SUCCESS in 19m 06s","accounts_in_message":[],"_revision_number":1},{"id":"b86e20705f6938e5ce3ac1cf581fc16e20f2af7d","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2019-08-14 01:07:29.000000000","message":"Patch Set 1:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/676292/1 : FAILURE in 45m 01s","accounts_in_message":[],"_revision_number":1},{"id":"6121b5c693a5b29eb77af915b608e3d299d71961","author":{"_account_id":16128,"name":"IBM PowerVM CI","email":"powervmci@linux.vnet.ibm.com","username":"powervmci","tags":["SERVICE_USER"]},"date":"2019-08-14 22:51:49.000000000","message":"Patch Set 1:\n\nBuild failed. Comment \u0027powervm: recheck\u0027 to recheck.\n For 3rd party CI contact info: https://wiki.openstack.org/wiki/ThirdPartySystems/IBM_PowerVM_CI\n\n- nova-out-of-tree-pvm http://184.172.12.213/92/676292/1/check/nova-out-of-tree-pvm/31673ad : FAILURE in 18m 36s\n- nova-in-tree-pvm http://184.172.12.213/92/676292/1/check/nova-in-tree-pvm/edf12fe : FAILURE in 19m 17s","accounts_in_message":[],"_revision_number":1},{"id":"ea1621aec45e3c4b99999ea34b70aa56064b9597","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-08-15 18:28:42.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nClean backport for a test-only change, fast approving.","accounts_in_message":[],"_revision_number":1},{"id":"5cfe0e12d0d60a8f6f168932459e4ffa1606bbd0","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-15 18:32:20.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"c74d29d9e33ec0a2bbdd86db82d0dfaf2bb44580","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-15 22:40:29.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/90ea27b68fd8415c891ed30460abd527 : SUCCESS in 10m 15s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/e5da925248794819a65f5c1bfe6bb74c : SUCCESS in 14m 49s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/70acf228d6314ff9aae230609e747dbb : SUCCESS in 14m 01s\n- build-openstack-sphinx-docs https://zuul.opendev.org/t/openstack/build/5d986013de994aaa8ca4a81d989d3dab : SUCCESS in 8m 28s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/30a3f0ee8c3e4a8181d13fff353301a2 : SUCCESS in 20m 32s\n- nova-tox-functional-py35 https://zuul.opendev.org/t/openstack/build/7102379390f540ee9f424dcd20d8f984 : SUCCESS in 18m 32s","accounts_in_message":[],"_revision_number":1},{"id":"7612492371a6a772239fb6168ecc299b7523166a","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-15 22:40:30.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"a926d356d08ad4b00c0e810053b20bfd9c46ac41","revisions":{"a926d356d08ad4b00c0e810053b20bfd9c46ac41":{"kind":"REWORK","_number":1,"created":"2019-08-14 00:02:09.000000000","uploader":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"ref":"refs/changes/92/676292/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/92/676292/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/92/676292/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/92/676292/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/92/676292/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/92/676292/1"}}},"commit":{"parents":[{"commit":"6da28b0aa9b6a0ba67460f88dd2c397605b0679b","subject":"Replace non-nova server fault message","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/6da28b0aa9b6a0ba67460f88dd2c397605b0679b"}]}],"author":{"name":"Takashi NATSUME","email":"natsume.takashi@lab.ntt.co.jp","date":"2019-08-13 00:31:32.000000000","tz":540},"committer":{"name":"Takashi NATSUME","email":"natsume.takashi@lab.ntt.co.jp","date":"2019-08-14 00:01:29.000000000","tz":540},"subject":"Fix misuse of nova.objects.base.obj_equal_prims","message":"Fix misuse of nova.objects.base.obj_equal_prims\n\nThe nova.objects.base.obj_equal_prims returns True or False.\nIt does not assert anything.\nSo the return value should be asserted in tests.\n\nAdd assertTrue where the nova.objects.base.obj_equal_prims is called.\n\nChange-Id: I49460ec3b572ee14b32229e771a5499ff91e8722\nCloses-Bug: #1839853\n(cherry picked from commit 5c1d9dcbb29f5a84d56c4e496b3111b4040cad13)\n(cherry picked from commit a8e19afb3d4889412ee6f539bb63865eb8ef5bb5)\n(cherry picked from commit a17bb97b2eb1f8657423f2ecbbfbfb9b1b629ae7)\n(cherry picked from commit 151c828b1f498d44342d9265e575e5fdcb0783c1)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/a926d356d08ad4b00c0e810053b20bfd9c46ac41"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/a926d356d08ad4b00c0e810053b20bfd9c46ac41"}]},"branch":"refs/heads/stable/pike"}},"requirements":[],"submit_records":[],"submit_requirements":[]}