)]}'
{"nova/tests/functional/notification_sample_tests/test_instance.py":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"0829dcbda71edc6fd848e57cf4ef06d665b40592","unresolved":false,"context_lines":[{"line_number":463,"context_line":"        post \u003d {\u0027unshelve\u0027: None}"},{"line_number":464,"context_line":"        self.api.post_server_action(server[\u0027id\u0027], post)"},{"line_number":465,"context_line":"        self._wait_for_state_change(self.api, server, \u0027ACTIVE\u0027)"},{"line_number":466,"context_line":"        self._wait_for_notification(\u0027instance.unshelve.end\u0027)"},{"line_number":467,"context_line":""},{"line_number":468,"context_line":"    def _test_shelve_offload_server(self, server):"},{"line_number":469,"context_line":"        self.flags(shelved_offload_time\u003d-1)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5faad753_61041f4b","line":466,"range":{"start_line":466,"start_character":36,"end_line":466,"end_character":59},"updated":"2019-09-12 06:27:41.000000000","message":"It should be \u0027instance.power_on.end\u0027.\nIf the server status is \u0027SHELVED\u0027, the \u0027start_instance\u0027 method in nova/compute/manager.py is called when unshelving the server [1].\nIn the \u0027start_instance\u0027 method emits \u0027instance.power_on.start\u0027 and \u0027instance.power_on.end\u0027 [2] notifications.\n\n[1] https://github.com/openstack/nova/blob/6e2ec5c5a397b508cddb646e865b6f4d2132f1d6/nova/conductor/manager.py#L649-L652\n[2] https://github.com/openstack/nova/blob/6e2ec5c5a397b508cddb646e865b6f4d2132f1d6/nova/compute/manager.py#L2658-L2660","commit_id":"b778e05f9e869325d0e63219da44a12cd5196577"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"4db5037df31461ce2147441984f3fc2f26169b14","unresolved":false,"context_lines":[{"line_number":463,"context_line":"        post \u003d {\u0027unshelve\u0027: None}"},{"line_number":464,"context_line":"        self.api.post_server_action(server[\u0027id\u0027], post)"},{"line_number":465,"context_line":"        self._wait_for_state_change(self.api, server, \u0027ACTIVE\u0027)"},{"line_number":466,"context_line":"        self._wait_for_notification(\u0027instance.unshelve.end\u0027)"},{"line_number":467,"context_line":""},{"line_number":468,"context_line":"    def _test_shelve_offload_server(self, server):"},{"line_number":469,"context_line":"        self.flags(shelved_offload_time\u003d-1)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_fcb7add7","line":466,"range":{"start_line":466,"start_character":36,"end_line":466,"end_character":59},"in_reply_to":"5faad753_61041f4b","updated":"2019-09-18 08:25:54.000000000","message":"Good point. Thanks Takashi!","commit_id":"b778e05f9e869325d0e63219da44a12cd5196577"}]}