)]}'
{".zuul.yaml":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c4695bb3536c26278209724211f107a94a8aba50","unresolved":false,"context_lines":[{"line_number":354,"context_line":"- project:"},{"line_number":355,"context_line":"    # Please try to keep the list of job names sorted alphabetically."},{"line_number":356,"context_line":"    templates:"},{"line_number":357,"context_line":"      - check-requirements"},{"line_number":358,"context_line":"      #- integrated-gate-compute"},{"line_number":359,"context_line":"      #- openstack-cover-jobs"},{"line_number":360,"context_line":"      #- openstack-lower-constraints-jobs"},{"line_number":361,"context_line":"      #- openstack-python-jobs"},{"line_number":362,"context_line":"      #- openstack-python3-train-jobs"},{"line_number":363,"context_line":"      #- periodic-stable-jobs"},{"line_number":364,"context_line":"      - publish-openstack-docs-pti"},{"line_number":365,"context_line":"      #- release-notes-jobs-python3"},{"line_number":366,"context_line":"    # check:"},{"line_number":367,"context_line":"    #   jobs:"},{"line_number":368,"context_line":"        # # We define our own irrelevant-files so we don\u0027t run the job"},{"line_number":369,"context_line":"        # # on things like nova docs-only changes."},{"line_number":370,"context_line":"        # - ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa:"},{"line_number":371,"context_line":"        #     voting: false"},{"line_number":372,"context_line":"        #     irrelevant-files: *dsvm-irrelevant-files"},{"line_number":373,"context_line":"        # - devstack-plugin-ceph-tempest:"},{"line_number":374,"context_line":"        #     voting: false"},{"line_number":375,"context_line":"        #     irrelevant-files: *dsvm-irrelevant-files"},{"line_number":376,"context_line":"        # - neutron-grenade-multinode:"},{"line_number":377,"context_line":"        #     irrelevant-files: *dsvm-irrelevant-files"},{"line_number":378,"context_line":"        # - neutron-tempest-linuxbridge:"},{"line_number":379,"context_line":"        #     irrelevant-files:"},{"line_number":380,"context_line":"        #       # NOTE(mriedem): This job has its own irrelevant-files section"},{"line_number":381,"context_line":"        #       # so that we only run it on changes to networking and libvirt/vif"},{"line_number":382,"context_line":"        #       # code; we don\u0027t need to run this on all changes, nor do we run"},{"line_number":383,"context_line":"        #       # it in the gate."},{"line_number":384,"context_line":"        #       - ^(?!nova/network/.*)(?!nova/virt/libvirt/vif.py).*$"},{"line_number":385,"context_line":"        # - nova-grenade-live-migration"},{"line_number":386,"context_line":"        # - nova-live-migration"},{"line_number":387,"context_line":"        # - nova-lvm"},{"line_number":388,"context_line":"        # - nova-multi-cell"},{"line_number":389,"context_line":"        # - nova-next"},{"line_number":390,"context_line":"        # - nova-tox-functional"},{"line_number":391,"context_line":"        # - nova-tox-functional-py36"},{"line_number":392,"context_line":"        # - tempest-integrated-compute:"},{"line_number":393,"context_line":"        #     irrelevant-files: *dsvm-irrelevant-files"},{"line_number":394,"context_line":"        # - tempest-slow-py3:"},{"line_number":395,"context_line":"        #     irrelevant-files: *dsvm-irrelevant-files"},{"line_number":396,"context_line":"        # - grenade-py3:"},{"line_number":397,"context_line":"        #     irrelevant-files: *dsvm-irrelevant-files"},{"line_number":398,"context_line":"        # - tempest-ipv6-only:"},{"line_number":399,"context_line":"        #     irrelevant-files: *dsvm-irrelevant-files"},{"line_number":400,"context_line":"    gate:"},{"line_number":401,"context_line":"      jobs:"},{"line_number":402,"context_line":"        - nova-grenade-live-migration"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7faddb67_f881bdfc","line":399,"range":{"start_line":357,"start_character":0,"end_line":399,"end_character":54},"updated":"2019-08-28 14:49:49.000000000","message":"All of this needs to be removed, obviously. I don\u0027t think it was necessary to do in the first place since we\u0027re pretty insistent with out \u0027irrelevant-files\u0027","commit_id":"1a53b0527a47ba0cc763dd5f4cc9b814733c2615"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"8b713030e948740e33d67d0fd45c531b73241bca","unresolved":false,"context_lines":[{"line_number":354,"context_line":"- project:"},{"line_number":355,"context_line":"    # Please try to keep the list of job names sorted alphabetically."},{"line_number":356,"context_line":"    templates:"},{"line_number":357,"context_line":"      - check-requirements"},{"line_number":358,"context_line":"      #- integrated-gate-compute"},{"line_number":359,"context_line":"      #- openstack-cover-jobs"},{"line_number":360,"context_line":"      #- openstack-lower-constraints-jobs"},{"line_number":361,"context_line":"      #- openstack-python-jobs"},{"line_number":362,"context_line":"      #- openstack-python3-train-jobs"},{"line_number":363,"context_line":"      #- periodic-stable-jobs"},{"line_number":364,"context_line":"      - publish-openstack-docs-pti"},{"line_number":365,"context_line":"      #- release-notes-jobs-python3"},{"line_number":366,"context_line":"    # check:"},{"line_number":367,"context_line":"    #   jobs:"},{"line_number":368,"context_line":"        # # We define our own irrelevant-files so we don\u0027t run the job"},{"line_number":369,"context_line":"        # # on things like nova docs-only changes."},{"line_number":370,"context_line":"        # - ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa:"},{"line_number":371,"context_line":"        #     voting: false"},{"line_number":372,"context_line":"        #     irrelevant-files: *dsvm-irrelevant-files"},{"line_number":373,"context_line":"        # - devstack-plugin-ceph-tempest:"},{"line_number":374,"context_line":"        #     voting: false"},{"line_number":375,"context_line":"        #     irrelevant-files: *dsvm-irrelevant-files"},{"line_number":376,"context_line":"        # - neutron-grenade-multinode:"},{"line_number":377,"context_line":"        #     irrelevant-files: *dsvm-irrelevant-files"},{"line_number":378,"context_line":"        # - neutron-tempest-linuxbridge:"},{"line_number":379,"context_line":"        #     irrelevant-files:"},{"line_number":380,"context_line":"        #       # NOTE(mriedem): This job has its own irrelevant-files section"},{"line_number":381,"context_line":"        #       # so that we only run it on changes to networking and libvirt/vif"},{"line_number":382,"context_line":"        #       # code; we don\u0027t need to run this on all changes, nor do we run"},{"line_number":383,"context_line":"        #       # it in the gate."},{"line_number":384,"context_line":"        #       - ^(?!nova/network/.*)(?!nova/virt/libvirt/vif.py).*$"},{"line_number":385,"context_line":"        # - nova-grenade-live-migration"},{"line_number":386,"context_line":"        # - nova-live-migration"},{"line_number":387,"context_line":"        # - nova-lvm"},{"line_number":388,"context_line":"        # - nova-multi-cell"},{"line_number":389,"context_line":"        # - nova-next"},{"line_number":390,"context_line":"        # - nova-tox-functional"},{"line_number":391,"context_line":"        # - nova-tox-functional-py36"},{"line_number":392,"context_line":"        # - tempest-integrated-compute:"},{"line_number":393,"context_line":"        #     irrelevant-files: *dsvm-irrelevant-files"},{"line_number":394,"context_line":"        # - tempest-slow-py3:"},{"line_number":395,"context_line":"        #     irrelevant-files: *dsvm-irrelevant-files"},{"line_number":396,"context_line":"        # - grenade-py3:"},{"line_number":397,"context_line":"        #     irrelevant-files: *dsvm-irrelevant-files"},{"line_number":398,"context_line":"        # - tempest-ipv6-only:"},{"line_number":399,"context_line":"        #     irrelevant-files: *dsvm-irrelevant-files"},{"line_number":400,"context_line":"    gate:"},{"line_number":401,"context_line":"      jobs:"},{"line_number":402,"context_line":"        - nova-grenade-live-migration"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7faddb67_274cb09c","line":399,"range":{"start_line":357,"start_character":0,"end_line":399,"end_character":54},"in_reply_to":"7faddb67_f881bdfc","updated":"2019-09-06 03:16:08.000000000","message":"tox.ini is touched so most jobs will be run. Thus, I commented them out to test PDF build.\n\nWe are almost already so I will revert the change in .zuul.yaml.","commit_id":"1a53b0527a47ba0cc763dd5f4cc9b814733c2615"}],"/COMMIT_MSG":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a0ebaa32fc024e4f1aa96b74585d5f7a5cfffb26","unresolved":false,"context_lines":[{"line_number":11,"context_line":"  deeper levels of nesting."},{"line_number":12,"context_line":"- bindep.txt is borrowed from https://review.opendev.org/#/c/601659/"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"sample-config is temporarily excluded from the hidden toctree"},{"line_number":15,"context_line":"in doc/source/configuration/index.rst and :orphan: is used."},{"line_number":16,"context_line":"If it is included in the hidden toctree, LaTeX fails with"},{"line_number":17,"context_line":"\"TeX capacity exceeded: sorry [main memory size\u003d5000000]\""},{"line_number":18,"context_line":"(with PDF output) .... and if excluded LaTeX fails."},{"line_number":19,"context_line":"The outputs from both cases looks same."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I3aaea1d15a357f550f529beaa84fb1a1a7748358"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7faddb67_19d3493a","line":19,"range":{"start_line":14,"start_character":0,"end_line":19,"end_character":39},"updated":"2019-08-15 17:32:43.000000000","message":"If we don\u0027t have \u0027sample-config\u0027 in the (hidden) toctree, :doc: directive is not converted into a link in the PDF doc.... (while it works for HTML). I have no idea at the moment.","commit_id":"6804e042aaa1f6002486e9fca4250927bb51f802"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"cb3afc74da776eef526175b2a245709723ca1e1f","unresolved":false,"context_lines":[{"line_number":9,"context_line":"- sphinxcontrib-svg2pdfconverter is used to handle SVG properly."},{"line_number":10,"context_line":"- maxlistdepth\u003d10 in latex_elements is needed to handle"},{"line_number":11,"context_line":"  deeper levels of nesting."},{"line_number":12,"context_line":"- bindep.txt is borrowed from https://review.opendev.org/#/c/601659/"},{"line_number":13,"context_line":"- Sample config/policy files are skipped in the PDF document"},{"line_number":14,"context_line":"  as inline sample files cause LaTeX error and direct links"},{"line_number":15,"context_line":"  in PDF doc is discouraged."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"7faddb67_b2ce0459","line":12,"updated":"2019-08-28 10:03:47.000000000","message":"This line is not needed anymore (after digging a bit I noticed that it\u0027s because of https://review.opendev.org/#/c/664555/)","commit_id":"1a53b0527a47ba0cc763dd5f4cc9b814733c2615"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"8b713030e948740e33d67d0fd45c531b73241bca","unresolved":false,"context_lines":[{"line_number":9,"context_line":"- sphinxcontrib-svg2pdfconverter is used to handle SVG properly."},{"line_number":10,"context_line":"- maxlistdepth\u003d10 in latex_elements is needed to handle"},{"line_number":11,"context_line":"  deeper levels of nesting."},{"line_number":12,"context_line":"- bindep.txt is borrowed from https://review.opendev.org/#/c/601659/"},{"line_number":13,"context_line":"- Sample config/policy files are skipped in the PDF document"},{"line_number":14,"context_line":"  as inline sample files cause LaTeX error and direct links"},{"line_number":15,"context_line":"  in PDF doc is discouraged."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"7faddb67_471d2c71","line":12,"in_reply_to":"7faddb67_9870c942","updated":"2019-09-06 03:16:08.000000000","message":"Done","commit_id":"1a53b0527a47ba0cc763dd5f4cc9b814733c2615"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c4695bb3536c26278209724211f107a94a8aba50","unresolved":false,"context_lines":[{"line_number":9,"context_line":"- sphinxcontrib-svg2pdfconverter is used to handle SVG properly."},{"line_number":10,"context_line":"- maxlistdepth\u003d10 in latex_elements is needed to handle"},{"line_number":11,"context_line":"  deeper levels of nesting."},{"line_number":12,"context_line":"- bindep.txt is borrowed from https://review.opendev.org/#/c/601659/"},{"line_number":13,"context_line":"- Sample config/policy files are skipped in the PDF document"},{"line_number":14,"context_line":"  as inline sample files cause LaTeX error and direct links"},{"line_number":15,"context_line":"  in PDF doc is discouraged."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"7faddb67_9870c942","line":12,"in_reply_to":"7faddb67_b2ce0459","updated":"2019-08-28 14:49:49.000000000","message":"+1","commit_id":"1a53b0527a47ba0cc763dd5f4cc9b814733c2615"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c4695bb3536c26278209724211f107a94a8aba50","unresolved":false,"context_lines":[{"line_number":10,"context_line":"- maxlistdepth\u003d10 in latex_elements is needed to handle"},{"line_number":11,"context_line":"  deeper levels of nesting."},{"line_number":12,"context_line":"- bindep.txt is borrowed from https://review.opendev.org/#/c/601659/"},{"line_number":13,"context_line":"- Sample config/policy files are skipped in the PDF document"},{"line_number":14,"context_line":"  as inline sample files cause LaTeX error and direct links"},{"line_number":15,"context_line":"  in PDF doc is discouraged."},{"line_number":16,"context_line":"- create new pdf-docs environment that is used during openstack-tox-docs"},{"line_number":17,"context_line":"  run."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"7faddb67_f8969d3e","line":15,"range":{"start_line":13,"start_character":0,"end_line":15,"end_character":28},"updated":"2019-08-28 14:49:49.000000000","message":"We should file a bug against the Sphinx builder for this.\n\nLater: Ah, there was one [1]. I reopened it. We might want to reference that here.\n\n[1] https://github.com/sphinx-doc/sphinx/issues/3099","commit_id":"1a53b0527a47ba0cc763dd5f4cc9b814733c2615"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c4695bb3536c26278209724211f107a94a8aba50","unresolved":false,"context_lines":[{"line_number":16,"context_line":"- create new pdf-docs environment that is used during openstack-tox-docs"},{"line_number":17,"context_line":"  run."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"sample-config is temporarily excluded from the hidden toctree"},{"line_number":20,"context_line":"in doc/source/configuration/index.rst and :orphan: is used."},{"line_number":21,"context_line":"If it is included in the hidden toctree, LaTeX fails with"},{"line_number":22,"context_line":"\"TeX capacity exceeded: sorry [main memory size\u003d5000000]\""},{"line_number":23,"context_line":"(with PDF output) .... and if excluded LaTeX fails."},{"line_number":24,"context_line":"The outputs from both cases looks same."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Change-Id: I3aaea1d15a357f550f529beaa84fb1a1a7748358"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"7faddb67_e137c44a","line":24,"range":{"start_line":19,"start_character":0,"end_line":24,"end_character":39},"updated":"2019-08-28 14:49:49.000000000","message":"As above, there\u0027s an open bug for this","commit_id":"1a53b0527a47ba0cc763dd5f4cc9b814733c2615"}],"doc/source/conf.py":[{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"8d3a40586a96dde22fa21bd3b595cd066fe629dd","unresolved":false,"context_lines":[{"line_number":124,"context_line":"# (source start file, target name, title, author, documentclass"},{"line_number":125,"context_line":"# [howto/manual])."},{"line_number":126,"context_line":"latex_documents \u003d ["},{"line_number":127,"context_line":"    (\u0027index\u0027, \u0027Nova.tex\u0027, u\u0027Nova Documentation\u0027,"},{"line_number":128,"context_line":"     u\u0027OpenStack Foundation\u0027, \u0027manual\u0027),"},{"line_number":129,"context_line":"]"},{"line_number":130,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_b1a07b44","line":127,"updated":"2019-08-24 10:31:27.000000000","message":"this needs lowercasing to Nova.tex","commit_id":"9a392f85a3d4b171ce703bb561ab1c3a6c3ba3d8"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"9939a880da5771e53fba8b14506d84f394e39dcf","unresolved":false,"context_lines":[{"line_number":129,"context_line":"]"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"# Allow deeper levels of nesting for \\begin...\\end stanzas"},{"line_number":132,"context_line":"latex_elements \u003d {\u0027maxlistdepth\u0027: 10}"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"# -- Options for openstackdocstheme -------------------------------------------"},{"line_number":135,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5faad753_c3cd1b5e","line":132,"updated":"2019-09-09 19:28:52.000000000","message":"if you override latex_elements, don\u0027t you lose the default settings set by openstackdocstheme?","commit_id":"16b9486bf7e91bfd5dc48297cee9f54b49156c93"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"93a0b1212f3254739f4bc345b302d050b17c5433","unresolved":false,"context_lines":[{"line_number":129,"context_line":"]"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"# Allow deeper levels of nesting for \\begin...\\end stanzas"},{"line_number":132,"context_line":"latex_elements \u003d {\u0027maxlistdepth\u0027: 10}"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"# -- Options for openstackdocstheme -------------------------------------------"},{"line_number":135,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5faad753_a1280e86","line":132,"in_reply_to":"5faad753_5346d47e","updated":"2019-09-10 07:50:01.000000000","message":"I don\u0027t have a suggestion, sadly. I have the same problem (which I reported on the etherpad about PDF building issues) and I\u0027m looking for a solution which does not remove the defaults.","commit_id":"16b9486bf7e91bfd5dc48297cee9f54b49156c93"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"ddba90ee15fa9316fe1613ecf6a840586d520dbb","unresolved":false,"context_lines":[{"line_number":129,"context_line":"]"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"# Allow deeper levels of nesting for \\begin...\\end stanzas"},{"line_number":132,"context_line":"latex_elements \u003d {\u0027maxlistdepth\u0027: 10}"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"# -- Options for openstackdocstheme -------------------------------------------"},{"line_number":135,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5faad753_69d3c239","line":132,"in_reply_to":"5faad753_6ebc28dc","updated":"2019-09-11 06:42:57.000000000","message":"Interesting discovery. About this patch: the (not yet) defined fix for the.openstackdocstheme bug may require a change here (but hopefully not)","commit_id":"16b9486bf7e91bfd5dc48297cee9f54b49156c93"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9751d0b6973bd0e734bae4c1ac2d61c31bd21b21","unresolved":false,"context_lines":[{"line_number":129,"context_line":"]"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"# Allow deeper levels of nesting for \\begin...\\end stanzas"},{"line_number":132,"context_line":"latex_elements \u003d {\u0027maxlistdepth\u0027: 10}"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"# -- Options for openstackdocstheme -------------------------------------------"},{"line_number":135,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5faad753_6ebc28dc","line":132,"in_reply_to":"5faad753_9cbc59dd","updated":"2019-09-11 05:18:38.000000000","message":"From my investigation, it looks like a bug of openstackdocstheme. latex_elements from openstackdocstheme is not used even when latex_elements is not configured in doc/source/conf.py. For more detail, see https://bugs.launchpad.net/openstack-doc-tools/+bug/1843527\n\nFrom POV of this nova patch, defining latex_elements here loses nothing.","commit_id":"16b9486bf7e91bfd5dc48297cee9f54b49156c93"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"aedb964ca9cd0507c73070b9c71959d0d52fbcc0","unresolved":false,"context_lines":[{"line_number":129,"context_line":"]"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"# Allow deeper levels of nesting for \\begin...\\end stanzas"},{"line_number":132,"context_line":"latex_elements \u003d {\u0027maxlistdepth\u0027: 10}"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"# -- Options for openstackdocstheme -------------------------------------------"},{"line_number":135,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5faad753_9cbc59dd","line":132,"in_reply_to":"5faad753_a1280e86","updated":"2019-09-10 09:01:47.000000000","message":"Thanks for the information. I haven\u0027t noticed that in the etherpad.\nPerhaps we need to check the order of processing config options in doc/source/conf.py and sphinx extensions. Let\u0027s explore it as the common problem.","commit_id":"16b9486bf7e91bfd5dc48297cee9f54b49156c93"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"791b1f85348da1e5f85a6d28a2266a0fb4d901f8","unresolved":false,"context_lines":[{"line_number":129,"context_line":"]"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"# Allow deeper levels of nesting for \\begin...\\end stanzas"},{"line_number":132,"context_line":"latex_elements \u003d {\u0027maxlistdepth\u0027: 10}"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"# -- Options for openstackdocstheme -------------------------------------------"},{"line_number":135,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5faad753_5346d47e","line":132,"in_reply_to":"5faad753_c3cd1b5e","updated":"2019-09-10 06:43:42.000000000","message":"what is your suggestion then?","commit_id":"16b9486bf7e91bfd5dc48297cee9f54b49156c93"}],"tox.ini":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c4695bb3536c26278209724211f107a94a8aba50","unresolved":false,"context_lines":[{"line_number":182,"context_line":"description \u003d"},{"line_number":183,"context_line":"  Build PDF documentation."},{"line_number":184,"context_line":"envdir \u003d {toxworkdir}/docs"},{"line_number":185,"context_line":"deps \u003d -r{toxinidir}/doc/requirements.txt"},{"line_number":186,"context_line":"commands \u003d"},{"line_number":187,"context_line":"  rm -rf doc/build/pdf"},{"line_number":188,"context_line":"  sphinx-build -W -b latex doc/source doc/build/pdf"}],"source_content_type":"text/x-properties","patch_set":6,"id":"7faddb67_f8253d5d","line":185,"range":{"start_line":185,"start_character":7,"end_line":185,"end_character":41},"updated":"2019-08-28 14:49:49.000000000","message":"{[testenv:docs]deps}","commit_id":"1a53b0527a47ba0cc763dd5f4cc9b814733c2615"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"8b713030e948740e33d67d0fd45c531b73241bca","unresolved":false,"context_lines":[{"line_number":182,"context_line":"description \u003d"},{"line_number":183,"context_line":"  Build PDF documentation."},{"line_number":184,"context_line":"envdir \u003d {toxworkdir}/docs"},{"line_number":185,"context_line":"deps \u003d -r{toxinidir}/doc/requirements.txt"},{"line_number":186,"context_line":"commands \u003d"},{"line_number":187,"context_line":"  rm -rf doc/build/pdf"},{"line_number":188,"context_line":"  sphinx-build -W -b latex doc/source doc/build/pdf"}],"source_content_type":"text/x-properties","patch_set":6,"id":"7faddb67_c7fefc36","line":185,"range":{"start_line":185,"start_character":7,"end_line":185,"end_character":41},"in_reply_to":"7faddb67_f8253d5d","updated":"2019-09-06 03:16:08.000000000","message":"Done","commit_id":"1a53b0527a47ba0cc763dd5f4cc9b814733c2615"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c4695bb3536c26278209724211f107a94a8aba50","unresolved":false,"context_lines":[{"line_number":184,"context_line":"envdir \u003d {toxworkdir}/docs"},{"line_number":185,"context_line":"deps \u003d -r{toxinidir}/doc/requirements.txt"},{"line_number":186,"context_line":"commands \u003d"},{"line_number":187,"context_line":"  rm -rf doc/build/pdf"},{"line_number":188,"context_line":"  sphinx-build -W -b latex doc/source doc/build/pdf"},{"line_number":189,"context_line":"  make -C doc/build/pdf"},{"line_number":190,"context_line":""}],"source_content_type":"text/x-properties","patch_set":6,"id":"7faddb67_38baf5e0","line":187,"updated":"2019-08-28 14:49:49.000000000","message":"I was going to suggest adding \u0027doc/build/doctrees\u0027 to this, but I note we don\u0027t actually set this specifically. /me wonders if we should be either (a) sharing it and not removing it above or (b) stop setting it above (seeing as we\u0027re already modifying that target)","commit_id":"1a53b0527a47ba0cc763dd5f4cc9b814733c2615"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"8b713030e948740e33d67d0fd45c531b73241bca","unresolved":false,"context_lines":[{"line_number":184,"context_line":"envdir \u003d {toxworkdir}/docs"},{"line_number":185,"context_line":"deps \u003d -r{toxinidir}/doc/requirements.txt"},{"line_number":186,"context_line":"commands \u003d"},{"line_number":187,"context_line":"  rm -rf doc/build/pdf"},{"line_number":188,"context_line":"  sphinx-build -W -b latex doc/source doc/build/pdf"},{"line_number":189,"context_line":"  make -C doc/build/pdf"},{"line_number":190,"context_line":""}],"source_content_type":"text/x-properties","patch_set":6,"id":"7faddb67_e768d8f4","line":187,"in_reply_to":"7faddb67_38baf5e0","updated":"2019-09-06 03:16:08.000000000","message":"In my understanding, the reason we specify -d option for HTML build is because we publish all contents under doc/build/html and avoid publishing doctree data.\n\nIn case of PDF build, we publish only the main PDF file, so -d option is unnecessary.\n\nThought?","commit_id":"1a53b0527a47ba0cc763dd5f4cc9b814733c2615"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"df9d36eae241e99a7705bdf7e4d6e6bdaee7bff5","unresolved":false,"context_lines":[{"line_number":184,"context_line":"envdir \u003d {toxworkdir}/docs"},{"line_number":185,"context_line":"deps \u003d -r{toxinidir}/doc/requirements.txt"},{"line_number":186,"context_line":"commands \u003d"},{"line_number":187,"context_line":"  rm -rf doc/build/pdf"},{"line_number":188,"context_line":"  sphinx-build -W -b latex doc/source doc/build/pdf"},{"line_number":189,"context_line":"  make -C doc/build/pdf"},{"line_number":190,"context_line":""}],"source_content_type":"text/x-properties","patch_set":6,"id":"5faad753_94aa3217","line":187,"in_reply_to":"7faddb67_e768d8f4","updated":"2019-09-06 04:37:19.000000000","message":"I agree with you - -d is unneeded since we only copy the single PDF file.","commit_id":"1a53b0527a47ba0cc763dd5f4cc9b814733c2615"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c4695bb3536c26278209724211f107a94a8aba50","unresolved":false,"context_lines":[{"line_number":186,"context_line":"commands \u003d"},{"line_number":187,"context_line":"  rm -rf doc/build/pdf"},{"line_number":188,"context_line":"  sphinx-build -W -b latex doc/source doc/build/pdf"},{"line_number":189,"context_line":"  make -C doc/build/pdf"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"[testenv:api-guide]"},{"line_number":192,"context_line":"description \u003d"}],"source_content_type":"text/x-properties","patch_set":6,"id":"7faddb67_f8b3fd08","line":189,"range":{"start_line":189,"start_character":2,"end_line":189,"end_character":6},"updated":"2019-08-28 14:49:49.000000000","message":"This needs to be whitelisted, right?","commit_id":"1a53b0527a47ba0cc763dd5f4cc9b814733c2615"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"8b713030e948740e33d67d0fd45c531b73241bca","unresolved":false,"context_lines":[{"line_number":186,"context_line":"commands \u003d"},{"line_number":187,"context_line":"  rm -rf doc/build/pdf"},{"line_number":188,"context_line":"  sphinx-build -W -b latex doc/source doc/build/pdf"},{"line_number":189,"context_line":"  make -C doc/build/pdf"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"[testenv:api-guide]"},{"line_number":192,"context_line":"description \u003d"}],"source_content_type":"text/x-properties","patch_set":6,"id":"7faddb67_4798cc19","line":189,"range":{"start_line":189,"start_character":2,"end_line":189,"end_character":6},"in_reply_to":"7faddb67_f8b3fd08","updated":"2019-09-06 03:16:08.000000000","message":"It looks like that nova tox.ini uses global whitelist_externals, so I added \"make\" around L.17.","commit_id":"1a53b0527a47ba0cc763dd5f4cc9b814733c2615"}]}