)]}'
{"id":"openstack%2Fnova~677329","triplet_id":"openstack%2Fnova~stable%2Fstein~I4b606fce473d064b9bb00213696c075cea020aaf","project":"openstack/nova","branch":"stable/stein","topic":"bug/1840200","hashtags":[],"change_id":"I4b606fce473d064b9bb00213696c075cea020aaf","subject":"Fix \u0027has_calls\u0027 method calls in unit tests","status":"MERGED","created":"2019-08-20 02:23:04.000000000","updated":"2019-09-17 22:47:27.000000000","submitted":"2019-09-17 22:45:11.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"677329-1568760311308-da1e170b","meta_rev_id":"e9da6bf3a07aa94e8b912031712daed594f204cd","_number":677329,"virtual_id_number":677329,"owner":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"date":"2019-08-20 04:34:16.000000000","_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":2,"date":"2019-09-17 22:45:10.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"all":[{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":2,"date":"2019-08-29 10:42:32.000000000","_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":2,"date":"2019-09-17 15:45:58.000000000","_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"all":[{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":1,"date":"2019-09-17 15:45:58.000000000","_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-08-20 04:34:16.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"REVIEWER"},{"updated":"2019-08-29 10:42:32.000000000","updated_by":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"reviewer":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"state":"REVIEWER"},{"updated":"2019-09-17 15:45:58.000000000","updated_by":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"reviewer":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"state":"REVIEWER"},{"updated":"2019-09-17 22:45:10.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"48a89a870e1cf6cca03dd124edacf6d4d257c2c1","author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"date":"2019-08-20 02:23:04.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d83f873986d122b687fe0ca8657ac827914bea67","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-20 02:59:04.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/0e90f527fa344c16960a27748fb7c9ee : SUCCESS in 17m 50s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/01fab68e6d084228ba6715653200c694 : SUCCESS in 21m 01s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/05d027a833784ffb9609bb7ada335aa4 : SUCCESS in 14m 01s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/80c3e0718f2c469c84113208656c7f00 : SUCCESS in 19m 30s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/9abe1d1c1e394e958aba8c840b563f93 : SUCCESS in 15m 28s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/2b6a1197b0d2433e93f3286cd7eadbe6 : SUCCESS in 21m 49s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/4c524dbeda3743fa9e438ae08488b17c : SUCCESS in 18m 33s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/54450230d1154222b1f5e5f0479fd9c8 : SUCCESS in 9m 51s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/f21164d2a6004110b963946d4a91e89b : SUCCESS in 28m 04s\n- nova-tox-functional-py35 https://zuul.opendev.org/t/openstack/build/6361097bbb4a4afa8226e2cab16f1d0e : SUCCESS in 20m 01s","accounts_in_message":[],"_revision_number":1},{"id":"fce2e0e6a121d811a4cb041f238af16c5f41523a","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2019-08-20 04:34:16.000000000","message":"Patch Set 1:\n\nBuild succeeded.\n\n- nova http://cloudbase-ci.com/nova/677329/1 : SUCCESS in 2h 10m 17s","accounts_in_message":[],"_revision_number":1},{"id":"5cc358d0b60e944d5069593bf63fb86a57bb1f98","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2019-08-29 10:42:32.000000000","message":"Patch Set 1: Code-Review+2\n\nLGTM","accounts_in_message":[],"_revision_number":1},{"id":"0ce67ed8139e0bca944c8d65eb5fc381b239204a","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-09-17 15:45:58.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nLooks like a clean backport so OK.","accounts_in_message":[],"_revision_number":1},{"id":"67468e7fc5596c619726ae61648d2199cd1897ca","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-17 15:46:33.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"b5ffca2a365cd6e3ff97a40d19d875df3ef36cd8","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-17 22:45:10.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/3858b92dee6140e28ef5ded8f3d73104 : SUCCESS in 14m 22s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/352ad1e1548847e5bfb93975480c94fd : SUCCESS in 10m 54s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/3e1b4ddf0ef24d9bb3142ffcfd37d95a : SUCCESS in 13m 15s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/9b1827591c38406f9c47605954cc9dcb : SUCCESS in 12m 33s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/3a882d78d69f48e7b3e88120dcf1858a : SUCCESS in 24m 41s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/7a834e4fb8d347ffbd1e5affbe244840 : SUCCESS in 23m 40s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/45721aeac0f349be9584e71e81ba6f88 : SUCCESS in 8m 37s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/88f23dce918845808a3ce68cf4ffce95 : SUCCESS in 27m 01s\n- nova-tox-functional-py35 https://zuul.opendev.org/t/openstack/build/73533dee8f8d45178eeda857991d6bf9 : SUCCESS in 26m 42s","accounts_in_message":[],"_revision_number":1},{"id":"189a4f5c4219a59ec86234b071873af0285a14e8","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-17 22:45:11.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"4487507761034598379c51dacf303ea805486173","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-17 22:47:27.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/d7aa4dda342f41288e3c36c7c4c9911e : SUCCESS in 1m 10s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"fa59033c40745febc26399e668ceb9911f8ec45d","revisions":{"fa59033c40745febc26399e668ceb9911f8ec45d":{"kind":"REWORK","_number":1,"created":"2019-08-20 02:23:04.000000000","uploader":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"ref":"refs/changes/29/677329/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/29/677329/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/29/677329/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/29/677329/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/29/677329/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/29/677329/1"}}},"commit":{"parents":[{"commit":"a8e19afb3d4889412ee6f539bb63865eb8ef5bb5","subject":"Fix misuse of nova.objects.base.obj_equal_prims","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/a8e19afb3d4889412ee6f539bb63865eb8ef5bb5"}]}],"author":{"name":"Takashi NATSUME","email":"natsume.takashi@lab.ntt.co.jp","date":"2019-08-15 01:00:38.000000000","tz":540},"committer":{"name":"Takashi NATSUME","email":"natsume.takashi@lab.ntt.co.jp","date":"2019-08-20 02:16:37.000000000","tz":540},"subject":"Fix \u0027has_calls\u0027 method calls in unit tests","message":"Fix \u0027has_calls\u0027 method calls in unit tests\n\nThe \u0027has_calls\u0027 method does not exist in assertion methods of mock.\nReplace the \u0027has_calls\u0027 method with an \u0027assert_has_calls\u0027 method or\nan \u0027assert_called_once_with\u0027 method.\nAdd an \u0027assertEqual\u0027 check before an \u0027assert_has_calls\u0027 method.\n\nChange-Id: I4b606fce473d064b9bb00213696c075cea020aaf\nCloses-Bug: #1840200\n(cherry picked from commit ad482e53fbb956288e73692f6bff5f74d862fe5d)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/fa59033c40745febc26399e668ceb9911f8ec45d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/fa59033c40745febc26399e668ceb9911f8ec45d"}]},"branch":"refs/heads/stable/stein"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
