)]}'
{"id":"openstack%2Fnova~677330","triplet_id":"openstack%2Fnova~stable%2Frocky~I4b606fce473d064b9bb00213696c075cea020aaf","project":"openstack/nova","branch":"stable/rocky","topic":"bug/1840200","hashtags":[],"change_id":"I4b606fce473d064b9bb00213696c075cea020aaf","subject":"Fix \u0027has_calls\u0027 method calls in unit tests","status":"MERGED","created":"2019-08-20 02:38:39.000000000","updated":"2019-09-27 17:48:37.000000000","submitted":"2019-09-27 17:48:37.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"677330-1569606517015-e03b07bf","meta_rev_id":"38a7b3c889b5a10c4ecaa3eb1966dc69d2121fb0","_number":677330,"virtual_id_number":677330,"owner":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"date":"2019-08-20 04:57:01.000000000","_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2019-09-27 17:48:36.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"all":[{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":2,"date":"2019-09-17 18:45:25.000000000","_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":2,"date":"2019-09-27 13:59:56.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"all":[{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":1,"date":"2019-09-27 13:59:56.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-08-20 04:57:01.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"REVIEWER"},{"updated":"2019-09-17 18:45:25.000000000","updated_by":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"reviewer":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"state":"REVIEWER"},{"updated":"2019-09-27 13:59:56.000000000","updated_by":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"reviewer":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"state":"REVIEWER"},{"updated":"2019-09-27 17:48:36.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"4ddc6e46336801d5d386e49d3379101df3366613","author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"date":"2019-08-20 02:38:39.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e5ea9c5368eb5af6d39344f28f5295e1a863766a","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-20 03:01:07.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/b1f2714e896041db9ea3a1258f999de6 : SUCCESS in 9m 19s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/bda35ec9a3a943e98f2283daea455a1d : FAILURE in 14m 56s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/667666162056488ba4449a54ea04073a : FAILURE in 12m 38s\n- build-openstack-sphinx-docs https://zuul.opendev.org/t/openstack/build/5e4a7a37cd7748ee92ef3c83a741d99d : SUCCESS in 7m 50s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/bcffda738ab94601be0169bc36cd0685 : SUCCESS in 16m 44s\n- nova-tox-functional-py35 https://zuul.opendev.org/t/openstack/build/d7cef9064f5c4b9285c2df0a154fed65 : SUCCESS in 21m 09s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/9752ef5d6e5449f686b8b524205b4954 : FAILURE in 12m 28s","accounts_in_message":[],"_revision_number":1},{"id":"25450de09682e1f400d67c91b7a968ad21a57872","author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"date":"2019-08-20 03:02:24.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"9281e3570474a50c26a6c0e4061c92fefa820e78","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-20 03:28:53.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/488081db8eca452f86161cf45a1492e2 : SUCCESS in 11m 26s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/6fe180515a1941f893b7bb4337271bd6 : SUCCESS in 13m 34s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/c90f289211334db49f57b3f0ec900460 : SUCCESS in 16m 06s\n- build-openstack-sphinx-docs https://zuul.opendev.org/t/openstack/build/96ad16636ba443b39c952e2a0e7e7b8a : SUCCESS in 8m 56s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/8839599f1db64f3ba9a5873296078bd6 : SUCCESS in 18m 13s\n- nova-tox-functional-py35 https://zuul.opendev.org/t/openstack/build/3434e7fbe50b472b9950e8af7ba2bd94 : SUCCESS in 19m 11s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/f6ef2d3d519a4fd59e310b264bd6dff7 : SUCCESS in 13m 07s","accounts_in_message":[],"_revision_number":2},{"id":"3b090517c976d251dc291eafc67c2395d9036275","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2019-08-20 04:57:01.000000000","message":"Patch Set 2:\n\nBuild succeeded.\n\n- nova http://cloudbase-ci.com/nova/677330/2 : SUCCESS in 1h 53m 54s","accounts_in_message":[],"_revision_number":2},{"id":"aae03501394b63ca967fa07a925cc058a9bbd4a3","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-09-17 18:45:25.000000000","message":"Patch Set 2: Code-Review+2\n\nLooks OK to me.","accounts_in_message":[],"_revision_number":2},{"id":"16419624be57d767a0bca2c62e070e822800a9ed","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2019-09-27 13:59:56.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"30ea8ed6d5377dfb5f08b4c440d263ca6ed9954a","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-27 14:00:49.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"33e43f84848665268284b8397a9a83fbefa87b41","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-27 17:48:36.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/e735be7904a84a5c86828278320ac4a4 : SUCCESS in 10m 39s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/4def112aec1f42f4a120a9d39cfe3b82 : SUCCESS in 11m 49s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/c02b9294abf240a1aa1dffe845dd971b : SUCCESS in 12m 52s\n- build-openstack-sphinx-docs https://zuul.opendev.org/t/openstack/build/9b92c3c54b99418784cdf06323a74ade : SUCCESS in 10m 33s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/becc42b186754ae687eb600222314066 : SUCCESS in 18m 19s\n- nova-tox-functional-py35 https://zuul.opendev.org/t/openstack/build/45a6e33e0452426ab677440df50bcea8 : SUCCESS in 15m 18s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/1db45b68f0a24a4191a15c0cd816c17a : SUCCESS in 15m 02s","accounts_in_message":[],"_revision_number":2},{"id":"94631c3b456c6c0ae3cc9aeafb0a883ce7b48d47","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-27 17:48:37.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"8e7e54f60b0374d6439a4cedc098c5a3c97b79d9","revisions":{"2b2c690ee5ba0af0bdd646822e4da2ce23fa67c2":{"kind":"REWORK","_number":1,"created":"2019-08-20 02:38:39.000000000","uploader":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"ref":"refs/changes/30/677330/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/30/677330/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/30/677330/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/30/677330/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/30/677330/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/30/677330/1"}}},"commit":{"parents":[{"commit":"e4218abdc2f520fa0caad9887c0c67c6f04f26ba","subject":"Merge \"Add \u0027path\u0027 query parameter to console access url\" into stable/rocky","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/e4218abdc2f520fa0caad9887c0c67c6f04f26ba"}]}],"author":{"name":"Takashi NATSUME","email":"natsume.takashi@lab.ntt.co.jp","date":"2019-08-15 01:00:38.000000000","tz":540},"committer":{"name":"Takashi NATSUME","email":"natsume.takashi@lab.ntt.co.jp","date":"2019-08-20 02:36:45.000000000","tz":540},"subject":"Fix \u0027has_calls\u0027 method calls in unit tests","message":"Fix \u0027has_calls\u0027 method calls in unit tests\n\nThe \u0027has_calls\u0027 method does not exist in assertion methods of mock.\nReplace the \u0027has_calls\u0027 method with an \u0027assert_has_calls\u0027 method or\nan \u0027assert_called_once_with\u0027 method.\nAdd an \u0027assertEqual\u0027 check before an \u0027assert_has_calls\u0027 method.\n\nConflicts:\n    nova/tests/unit/compute/test_compute_mgr.py\n\nNOTE(takashin): The conflict is due to not having the following change\nin stable/rocky.\n\n    Ic062446e5c620c89aec3065b34bcdc6bf5966275\n\nChange-Id: I4b606fce473d064b9bb00213696c075cea020aaf\nCloses-Bug: #1840200\n(cherry picked from commit ad482e53fbb956288e73692f6bff5f74d862fe5d)\n(cherry picked from commit fa59033c40745febc26399e668ceb9911f8ec45d)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/2b2c690ee5ba0af0bdd646822e4da2ce23fa67c2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/2b2c690ee5ba0af0bdd646822e4da2ce23fa67c2"}]},"branch":"refs/heads/stable/rocky"},"8e7e54f60b0374d6439a4cedc098c5a3c97b79d9":{"kind":"REWORK","_number":2,"created":"2019-08-20 03:02:24.000000000","uploader":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"ref":"refs/changes/30/677330/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/30/677330/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/30/677330/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/30/677330/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/30/677330/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/30/677330/2"}}},"commit":{"parents":[{"commit":"e4218abdc2f520fa0caad9887c0c67c6f04f26ba","subject":"Merge \"Add \u0027path\u0027 query parameter to console access url\" into stable/rocky","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/e4218abdc2f520fa0caad9887c0c67c6f04f26ba"}]}],"author":{"name":"Takashi NATSUME","email":"natsume.takashi@lab.ntt.co.jp","date":"2019-08-15 01:00:38.000000000","tz":540},"committer":{"name":"Takashi NATSUME","email":"natsume.takashi@lab.ntt.co.jp","date":"2019-08-20 03:00:52.000000000","tz":540},"subject":"Fix \u0027has_calls\u0027 method calls in unit tests","message":"Fix \u0027has_calls\u0027 method calls in unit tests\n\nThe \u0027has_calls\u0027 method does not exist in assertion methods of mock.\nReplace the \u0027has_calls\u0027 method with an \u0027assert_has_calls\u0027 method or\nan \u0027assert_called_once_with\u0027 method.\nAdd an \u0027assertEqual\u0027 check before an \u0027assert_has_calls\u0027 method.\n\nConflicts:\n    nova/tests/unit/compute/test_compute_mgr.py\n\nNOTE(takashin): The conflict is due to not having the following change\nin stable/rocky.\n\n    Ic062446e5c620c89aec3065b34bcdc6bf5966275\n\nChange-Id: I4b606fce473d064b9bb00213696c075cea020aaf\nCloses-Bug: #1840200\n(cherry picked from commit ad482e53fbb956288e73692f6bff5f74d862fe5d)\n(cherry picked from commit fa59033c40745febc26399e668ceb9911f8ec45d)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/8e7e54f60b0374d6439a4cedc098c5a3c97b79d9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/8e7e54f60b0374d6439a4cedc098c5a3c97b79d9"}]},"branch":"refs/heads/stable/rocky"}},"requirements":[],"submit_records":[],"submit_requirements":[]}