)]}'
{"id":"openstack%2Fnova~677378","triplet_id":"openstack%2Fnova~stable%2Fqueens~I4b606fce473d064b9bb00213696c075cea020aaf","project":"openstack/nova","branch":"stable/queens","topic":"bug/1840200","hashtags":[],"change_id":"I4b606fce473d064b9bb00213696c075cea020aaf","subject":"Fix \u0027has_calls\u0027 method calls in unit tests","status":"MERGED","created":"2019-08-20 03:41:04.000000000","updated":"2019-10-17 10:33:30.000000000","submitted":"2019-10-17 10:33:30.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"677378-1571308410047-14372de2","meta_rev_id":"0ba9211135d5ed5154cafaee523f9d7af8a016b0","_number":677378,"virtual_id_number":677378,"owner":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"date":"2019-08-20 04:25:02.000000000","_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2019-10-17 10:33:29.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"recommended":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"all":[{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":1,"date":"2019-10-01 11:35:30.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":2,"date":"2019-10-14 18:08:53.000000000","_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2019-10-17 09:33:19.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"all":[{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-10-17 09:33:19.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-08-20 04:25:02.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"REVIEWER"},{"updated":"2019-10-01 11:35:30.000000000","updated_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"reviewer":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"state":"REVIEWER"},{"updated":"2019-10-14 18:08:53.000000000","updated_by":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"reviewer":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"state":"REVIEWER"},{"updated":"2019-10-17 09:33:19.000000000","updated_by":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"reviewer":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"state":"REVIEWER"},{"updated":"2019-10-17 10:33:29.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"8c73445daaa14b8c6a146da7099d8fc59b981237","author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"date":"2019-08-20 03:41:04.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"0da2908604581a926edf255061d927606adcb6b8","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-20 04:17:18.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/c55bfa98798c4659a5f3b5cad9edf816 : SUCCESS in 19m 05s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/2a159c5cb23c4b2ead7c92e5fb623dda : SUCCESS in 24m 01s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/4546f2fe821b4264808a727ce96dee27 : SUCCESS in 23m 01s\n- build-openstack-sphinx-docs https://zuul.opendev.org/t/openstack/build/c585738d2d0b4615a9addf922fa121db : SUCCESS in 7m 38s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/aadb9d686663485a85902338a50bd2f5 : SUCCESS in 30m 41s\n- nova-tox-functional-py35 https://zuul.opendev.org/t/openstack/build/0e4aabb24c344c43a5d8e84464a3cd59 : SUCCESS in 29m 23s","accounts_in_message":[],"_revision_number":1},{"id":"b2f851c72be38a6d2d569f476ce1c83ffa2146f5","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2019-08-20 04:25:02.000000000","message":"Patch Set 1:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/677378/1 : FAILURE in 43m 13s","accounts_in_message":[],"_revision_number":1},{"id":"ee0a9e894792128ea38d469d285549f77be1ea15","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2019-10-01 11:35:30.000000000","message":"Patch Set 1: Code-Review+1\n\nThe backport looks good, conflict is mentioned. Already merged in in Rocky. LGTM.","accounts_in_message":[],"_revision_number":1},{"id":"517ee5caf264792c7a4ad2b85aeabba7408619d9","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-10-14 18:08:53.000000000","message":"Patch Set 1: Code-Review+2\n\nLooks good to me, the conflict is noted.","accounts_in_message":[],"_revision_number":1},{"id":"c086f759c85b9187460eec2f5c61dd7afcd39e3f","author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"date":"2019-10-17 09:33:19.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nEverything is gently noted, LGTM.","accounts_in_message":[],"_revision_number":1},{"id":"385eaa4ab1f9d83bd2d8f5814aab0e2dbac55e02","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-17 09:33:40.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"f338cb7c3eea2be1d1dc6bbe0a23ea1eac843c69","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-17 10:33:29.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/75b91358ef404f1a965f478d834cb792 : SUCCESS in 9m 54s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/28f6f3749b5c443d85a3a3c25a54f100 : SUCCESS in 14m 25s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/1a01dad0a7c24f469179cda1cde333e8 : SUCCESS in 14m 27s\n- build-openstack-sphinx-docs https://zuul.opendev.org/t/openstack/build/080155d44f5742f2b2592d373aaa5f2d : SUCCESS in 8m 07s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/035a325656d6422985afbb52f0d63da6 : SUCCESS in 19m 08s\n- nova-tox-functional-py35 https://zuul.opendev.org/t/openstack/build/f392eff26b2449949a634b00e4f9e2f4 : SUCCESS in 25m 23s","accounts_in_message":[],"_revision_number":1},{"id":"68c8777396b4dcc70bb52dd02709536d47685a56","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-17 10:33:30.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"eca5608fe35728b12fc4d817f4a7e0a783219047","revisions":{"eca5608fe35728b12fc4d817f4a7e0a783219047":{"kind":"REWORK","_number":1,"created":"2019-08-20 03:41:04.000000000","uploader":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"ref":"refs/changes/78/677378/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/78/677378/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/78/677378/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/78/677378/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/78/677378/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/78/677378/1"}}},"commit":{"parents":[{"commit":"151c828b1f498d44342d9265e575e5fdcb0783c1","subject":"Fix misuse of nova.objects.base.obj_equal_prims","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/151c828b1f498d44342d9265e575e5fdcb0783c1"}]}],"author":{"name":"Takashi NATSUME","email":"natsume.takashi@lab.ntt.co.jp","date":"2019-08-15 01:00:38.000000000","tz":540},"committer":{"name":"Takashi NATSUME","email":"natsume.takashi@lab.ntt.co.jp","date":"2019-08-20 03:38:25.000000000","tz":540},"subject":"Fix \u0027has_calls\u0027 method calls in unit tests","message":"Fix \u0027has_calls\u0027 method calls in unit tests\n\nThe \u0027has_calls\u0027 method does not exist in assertion methods of mock.\nReplace the \u0027has_calls\u0027 method with an \u0027assert_has_calls\u0027 method or\nan \u0027assert_called_once_with\u0027 method.\nAdd an \u0027assertEqual\u0027 check before an \u0027assert_has_calls\u0027 method.\n\nConflicts:\n    nova/tests/unit/virt/ironic/test_driver.py\n\nNOTE(takashin): The conflict is due to not having the following change\nin stable/queens.\n\n    I87f085589bb663c519650f307f25d087c88bbdb1\n\nChange-Id: I4b606fce473d064b9bb00213696c075cea020aaf\nCloses-Bug: #1840200\n(cherry picked from commit ad482e53fbb956288e73692f6bff5f74d862fe5d)\n(cherry picked from commit fa59033c40745febc26399e668ceb9911f8ec45d)\n(cherry picked from commit 8e7e54f60b0374d6439a4cedc098c5a3c97b79d9)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/eca5608fe35728b12fc4d817f4a7e0a783219047"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/eca5608fe35728b12fc4d817f4a7e0a783219047"}]},"branch":"refs/heads/stable/queens"}},"requirements":[],"submit_records":[],"submit_requirements":[]}