)]}'
{"id":"openstack%2Fnova~677388","triplet_id":"openstack%2Fnova~stable%2Fstein~I54dff4d5ed513690d0fae65de47a1a9c23aebbd4","project":"openstack/nova","branch":"stable/stein","topic":"bug/1840601","hashtags":[],"change_id":"I54dff4d5ed513690d0fae65de47a1a9c23aebbd4","subject":"Fix wrong assertions in unit tests","status":"MERGED","created":"2019-08-20 04:55:47.000000000","updated":"2019-09-18 10:03:24.000000000","submitted":"2019-09-18 09:59:53.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"677388-1568800793883-fa3c3f25","meta_rev_id":"9c8b15068ac7af6a1504d407d52275df37e00309","_number":677388,"virtual_id_number":677388,"owner":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":2,"date":"2019-09-18 09:59:52.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"date":"2019-09-18 00:30:52.000000000","_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"date":"2019-09-17 23:51:51.000000000","_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"date":"2019-09-18 04:42:52.000000000","_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2019-09-17 15:47:04.000000000","_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},{"value":2,"date":"2019-08-29 10:38:27.000000000","_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-09-17 15:47:04.000000000","_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},{"value":0,"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"value":0,"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-08-29 10:38:27.000000000","updated_by":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"reviewer":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"state":"REVIEWER"},{"updated":"2019-09-17 15:47:04.000000000","updated_by":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"reviewer":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"state":"REVIEWER"},{"updated":"2019-09-18 00:30:52.000000000","updated_by":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"reviewer":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"state":"REVIEWER"},{"updated":"2019-09-18 04:42:52.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"REVIEWER"},{"updated":"2019-09-18 09:59:52.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"365cbeeaa7a0fb8ac8e3fcc3be7ed5dd999b483b","author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"date":"2019-08-20 04:55:47.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f9745c9bbf8efb3dfb8c2bdaaafb13c1c7df3b08","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-20 05:23:17.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/e8591ba5b0d040f483adb34ba95edd41 : SUCCESS in 20m 57s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/21b3fb717baa41e4916beb72281d8077 : SUCCESS in 13m 02s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/2cad2fd1d8b34a9c9cb8deb13e1031d5 : SUCCESS in 10m 11s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/962e931cc69d40cf87d68a37b434a0b4 : SUCCESS in 14m 14s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/a572b58151c14ffbb81b224195c97f5b : SUCCESS in 13m 20s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/559c5311b3c34d698fa7d556bf262768 : SUCCESS in 15m 46s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/3c1599ecc945440e85e69d4a0f3373c1 : SUCCESS in 10m 49s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/2859ac52178c4b189f03924bbad4ae1e : SUCCESS in 7m 02s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/7172a1cabf8b4105b45221d81fdf7800 : SUCCESS in 18m 29s\n- nova-tox-functional-py35 https://zuul.opendev.org/t/openstack/build/e98ace2389dd44359413185f8da8944b : SUCCESS in 22m 31s","accounts_in_message":[],"_revision_number":1},{"id":"d20511f89ae7e7b2f9984e70566d7953e6388c86","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2019-08-20 07:01:19.000000000","message":"Patch Set 1:\n\nBuild succeeded.\n\n- nova http://cloudbase-ci.com/nova/677388/1 : SUCCESS in 2h 04m 48s","accounts_in_message":[],"_revision_number":1},{"id":"687984feb7aeddad2d81b881c3a18dc696d42b90","author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"date":"2019-08-29 10:38:27.000000000","message":"Patch Set 1: Code-Review+2\n\nLGTM, I\u0027d typically wait for a need to backport test-only changes like this but I can see you have several lined up and already backported to other branches. In the long run this might actually ease future backports from master so I\u0027m +2 for now.","accounts_in_message":[],"_revision_number":1},{"id":"ac8db9f2119f4170c18d41586f29c649efaba126","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-09-17 15:47:04.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nOK - same thoughts as Lee. This seems fine since it\u0027s a clean backport.","accounts_in_message":[],"_revision_number":1},{"id":"27294a47d4036939af96db7845d3db778ce4b6e1","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-17 15:47:34.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"0b8759fe8e29eff85d5434a6cdb6d236827c498d","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-17 22:45:17.000000000","message":"Patch Set 1: Verified-2\n\nBuild failed (gate pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/beb8a099596741de911c407487beebe6 : SUCCESS in 13m 09s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/061fd37a4b41481c92e41f9e0464a3bb : SUCCESS in 10m 06s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/5411bf309e9a48558e5bbaa7e9d6d5f1 : SUCCESS in 13m 38s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/d9ce092c05794f8c9bdee64514e82c0e : SUCCESS in 13m 59s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/4ac49c68ceaa4abf91f261155f36699a : SUCCESS in 16m 01s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/0184e23e144f452f91360c099964d430 : SUCCESS in 13m 49s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/1f7a549f59cb43b58af3be7b88582eef : SUCCESS in 7m 57s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/84fa331dc5c44f9dbf83211a86817a73 : SUCCESS in 33m 55s\n- nova-tox-functional-py35 https://zuul.opendev.org/t/openstack/build/474287333c8d452aa473ce4c353f0632 : FAILURE in 33m 41s","accounts_in_message":[],"_revision_number":1},{"id":"d17b58e6ec20bee94ad883a867ac4c3dd46dd04e","author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"date":"2019-09-17 23:51:51.000000000","message":"Patch Set 1:\n\nrecheck subunit parser","accounts_in_message":[],"_revision_number":1},{"id":"34e0c4795806b18958ad4352478b9992951d34cd","author":{"_account_id":29963,"name":"Intel_Zuul","display_name":"Intel Corporation CI","email":"intel-openstack-ci@intel.com","username":"Intel_Zuul"},"date":"2019-09-18 00:30:52.000000000","message":"Patch Set 1:\n\nBuild failed.\n\n- pmem-tempest-plugin-filtered http://52.27.155.124/88/677388/1/check/pmem-tempest-plugin-filtered/85e76f6/ : FAILURE in 28m 52s","accounts_in_message":[],"_revision_number":1},{"id":"3089726db37d4b7a0bee14eb1b4c1efe0a5cb4b9","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-18 03:15:07.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/ba1e83e8fef94c69a944cb721a3e6e7c : SUCCESS in 15m 07s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/af68000125b54c4a9cce8798edc69805 : SUCCESS in 13m 34s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/8eadcbb22cc442dd95fa386647601ff9 : SUCCESS in 10m 18s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/3802ddee43af44398ce3cc71cd45363c : SUCCESS in 13m 01s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/8c817059550a40b8b05828cb53a0a1b1 : SUCCESS in 15m 29s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/0b36f3a44d9d45308c5432c1f136f604 : SUCCESS in 10m 14s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/c3959ba09eff4df6a4cba8958dae3772 : SUCCESS in 12m 16s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/cd073bba9b834d33a6078622268c1aac : SUCCESS in 7m 41s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/38d3146f17c5408aab209bdcda3d00f7 : SUCCESS in 19m 31s\n- nova-tox-functional-py35 https://zuul.opendev.org/t/openstack/build/2a564b65834f414ab77859324a45fe69 : SUCCESS in 20m 53s","accounts_in_message":[],"_revision_number":1},{"id":"7865e6155aa880005fb10d12534fd45c880efa36","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-18 03:15:54.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"8a74cbdd696b33bb9fad8dd7c7a94105e44d0a8c","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2019-09-18 04:42:52.000000000","message":"Patch Set 1:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/677388/1 : FAILURE in 2h 28m 13s","accounts_in_message":[],"_revision_number":1},{"id":"7accc3902800b64571b66cbdfdb91f4403a6ea79","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-18 09:59:52.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/e467d1315c7c4690aa4da2e6052f264c : SUCCESS in 11m 51s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/f9a0d6a29cbe41c3a5d280c7f5177dc5 : SUCCESS in 9m 07s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/2161c52808fc4b7b8ff06e3bbb6a1373 : SUCCESS in 13m 57s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/d65f93405402476291c55ceb1c96f0af : SUCCESS in 13m 58s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/018f4ee7246c405dbdc68ea93c78159a : SUCCESS in 12m 33s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/46758ec42fd045448b73ab4fb2e0d535 : SUCCESS in 11m 33s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/319212924efb409a81c924c5344355c4 : SUCCESS in 7m 23s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/f3cde0ed10464457b845646e923914e4 : SUCCESS in 20m 27s\n- nova-tox-functional-py35 https://zuul.opendev.org/t/openstack/build/b0f95d175521490fad8d31d413ae820d : SUCCESS in 22m 29s","accounts_in_message":[],"_revision_number":1},{"id":"da548a77b2cd71ef25a26258a0452550704ecdd4","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-18 09:59:53.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"fd590716c26c80ce2e0d5a8f21c89022a940f293","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-18 10:03:24.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/bc5049ef8e054173a5ed96c9dbc85d3f : SUCCESS in 56s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"88b2206f2d2a306280004c5e66c7911bb7b77f58","revisions":{"88b2206f2d2a306280004c5e66c7911bb7b77f58":{"kind":"REWORK","_number":1,"created":"2019-08-20 04:55:47.000000000","uploader":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"ref":"refs/changes/88/677388/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/88/677388/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/88/677388/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/88/677388/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/88/677388/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/88/677388/1"}}},"commit":{"parents":[{"commit":"a8e19afb3d4889412ee6f539bb63865eb8ef5bb5","subject":"Fix misuse of nova.objects.base.obj_equal_prims","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/a8e19afb3d4889412ee6f539bb63865eb8ef5bb5"}]}],"author":{"name":"Takashi NATSUME","email":"natsume.takashi@lab.ntt.co.jp","date":"2019-08-19 01:13:56.000000000","tz":540},"committer":{"name":"Takashi NATSUME","email":"natsume.takashi@lab.ntt.co.jp","date":"2019-08-20 04:53:33.000000000","tz":540},"subject":"Fix wrong assertions in unit tests","message":"Fix wrong assertions in unit tests\n\nChange-Id: I54dff4d5ed513690d0fae65de47a1a9c23aebbd4\nCloses-Bug: #1840601\n(cherry picked from commit 8ea5e373381fc4152d2914742ef42a75acbbcc53)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/88b2206f2d2a306280004c5e66c7911bb7b77f58"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/88b2206f2d2a306280004c5e66c7911bb7b77f58"}]},"branch":"refs/heads/stable/stein"}},"requirements":[],"submit_records":[],"submit_requirements":[]}