)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d3e2b4a2102d2c9b11b87dc77a6e85a4671ebe7b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove zVM requirement from the top level requirements."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Requirements for just one hypervisor driver should not appear in"},{"line_number":10,"context_line":"requirements.txt. This has been a long standing policy. Otherwise"},{"line_number":11,"context_line":"we\u0027re forcing deployers to install a dependancy that the vast"},{"line_number":12,"context_line":"majority of them will never use. Instead, dynamically load the"},{"line_number":13,"context_line":"depedancy at run time."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7faddb67_b429628a","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":55},"updated":"2019-08-22 21:02:28.000000000","message":"If so then we should have the same rules for hyperv, powervm and xenapi.","commit_id":"91442b94bff50fc0fa1d4b21518c2a49f6d6ca98"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"a761800adc28ed9f0b873bffd8c0093dbec57287","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove zVM requirement from the top level requirements."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Requirements for just one hypervisor driver should not appear in"},{"line_number":10,"context_line":"requirements.txt. This has been a long standing policy. Otherwise"},{"line_number":11,"context_line":"we\u0027re forcing deployers to install a dependancy that the vast"},{"line_number":12,"context_line":"majority of them will never use. Instead, dynamically load the"},{"line_number":13,"context_line":"depedancy at run time."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7faddb67_543d8e8c","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":55},"in_reply_to":"7faddb67_b429628a","updated":"2019-08-22 21:17:04.000000000","message":"Yah, but they can be fixed in separate patches.\n\nWhich I think is a good idea so we can break their CIs one at a time.","commit_id":"91442b94bff50fc0fa1d4b21518c2a49f6d6ca98"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1f296c8fa285ca6764fe99d52cd00c95d9c7b44a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9dc519cb_14c91e96","updated":"2024-01-26 15:12:40.000000000","message":"It seems this was covered by https://review.opendev.org/c/openstack/nova/+/822749 which also covers the other virt drivers.","commit_id":"91442b94bff50fc0fa1d4b21518c2a49f6d6ca98"}],"nova/virt/zvm/utils.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"7b22ddd13eb605a908299dd0c03bc7ebe2f28d15","unresolved":false,"context_lines":[{"line_number":45,"context_line":"                        \"but ca_file is configured to %(ca_file)s\","},{"line_number":46,"context_line":"                        {\u0027url\u0027: zcc_url, \u0027ca_file\u0027: ca_file})"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        # Import zvmconnector dynamically so it is not a dependancy for"},{"line_number":49,"context_line":"        # all nova users."},{"line_number":50,"context_line":"        connector \u003d importutils.import_module(\u0027zvmconnector\u0027).connector"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_61e80db3","line":48,"range":{"start_line":48,"start_character":57,"end_line":48,"end_character":67},"updated":"2019-08-22 18:16:48.000000000","message":"dependency","commit_id":"97e3f767621f1607abea80fb6b8dadf80a0fc17a"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"7b22ddd13eb605a908299dd0c03bc7ebe2f28d15","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        # Import zvmconnector dynamically so it is not a dependancy for"},{"line_number":49,"context_line":"        # all nova users."},{"line_number":50,"context_line":"        connector \u003d importutils.import_module(\u0027zvmconnector\u0027).connector"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        if _ssl_enabled and ca_file:"},{"line_number":53,"context_line":"            self._conn \u003d connector.ZVMConnector(_url.hostname, _url.port,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_21ca1546","line":50,"range":{"start_line":50,"start_character":8,"end_line":50,"end_character":71},"updated":"2019-08-22 18:16:48.000000000","message":"I don\u0027t think this is different from just\n\n from zvmconnector import connector\n\nis it?","commit_id":"97e3f767621f1607abea80fb6b8dadf80a0fc17a"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"62b0ccdb9cd790e3f0fc52e6b4106dfbcbeb1aec","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        # Import zvmconnector dynamically so it is not a dependancy for"},{"line_number":49,"context_line":"        # all nova users."},{"line_number":50,"context_line":"        connector \u003d importutils.import_module(\u0027zvmconnector\u0027).connector"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        if _ssl_enabled and ca_file:"},{"line_number":53,"context_line":"            self._conn \u003d connector.ZVMConnector(_url.hostname, _url.port,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_72b8dde7","line":50,"range":{"start_line":50,"start_character":8,"end_line":50,"end_character":71},"in_reply_to":"7faddb67_21ca1546","updated":"2019-08-22 20:34:08.000000000","message":"It isn\u0027t. This is just how the other drivers do this, for reasons I no longer remember.","commit_id":"97e3f767621f1607abea80fb6b8dadf80a0fc17a"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"a761800adc28ed9f0b873bffd8c0093dbec57287","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"import os"},{"line_number":16,"context_line":"from oslo_log import log as logging"},{"line_number":17,"context_line":"from oslo_utils import importutils"},{"line_number":18,"context_line":"import six"},{"line_number":19,"context_line":"import six.moves.urllib.parse as urlparse"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_943306c5","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":34},"updated":"2019-08-22 21:17:04.000000000","message":"no longer used","commit_id":"91442b94bff50fc0fa1d4b21518c2a49f6d6ca98"}],"requirements.txt":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d3e2b4a2102d2c9b11b87dc77a6e85a4671ebe7b","unresolved":false,"context_lines":[{"line_number":58,"context_line":"os-resource-classes\u003e\u003d0.1.0 # Apache-2.0"},{"line_number":59,"context_line":"os-traits\u003e\u003d0.16.0 # Apache-2.0"},{"line_number":60,"context_line":"os-vif\u003e\u003d1.14.0 # Apache-2.0"},{"line_number":61,"context_line":"os-win\u003e\u003d3.0.0 # Apache-2.0"},{"line_number":62,"context_line":"castellan\u003e\u003d0.16.0 # Apache-2.0"},{"line_number":63,"context_line":"microversion-parse\u003e\u003d0.2.1 # Apache-2.0"},{"line_number":64,"context_line":"os-xenapi\u003e\u003d0.3.3 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":2,"id":"7faddb67_b4008202","line":61,"updated":"2019-08-22 21:02:28.000000000","message":"hyperv only","commit_id":"91442b94bff50fc0fa1d4b21518c2a49f6d6ca98"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d3e2b4a2102d2c9b11b87dc77a6e85a4671ebe7b","unresolved":false,"context_lines":[{"line_number":61,"context_line":"os-win\u003e\u003d3.0.0 # Apache-2.0"},{"line_number":62,"context_line":"castellan\u003e\u003d0.16.0 # Apache-2.0"},{"line_number":63,"context_line":"microversion-parse\u003e\u003d0.2.1 # Apache-2.0"},{"line_number":64,"context_line":"os-xenapi\u003e\u003d0.3.3 # Apache-2.0"},{"line_number":65,"context_line":"tooz\u003e\u003d1.58.0 # Apache-2.0"},{"line_number":66,"context_line":"cursive\u003e\u003d0.2.1 # Apache-2.0"},{"line_number":67,"context_line":"pypowervm\u003e\u003d1.1.15 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":2,"id":"7faddb67_54058e0f","line":64,"updated":"2019-08-22 21:02:28.000000000","message":"oh hi xenapi","commit_id":"91442b94bff50fc0fa1d4b21518c2a49f6d6ca98"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d3e2b4a2102d2c9b11b87dc77a6e85a4671ebe7b","unresolved":false,"context_lines":[{"line_number":64,"context_line":"os-xenapi\u003e\u003d0.3.3 # Apache-2.0"},{"line_number":65,"context_line":"tooz\u003e\u003d1.58.0 # Apache-2.0"},{"line_number":66,"context_line":"cursive\u003e\u003d0.2.1 # Apache-2.0"},{"line_number":67,"context_line":"pypowervm\u003e\u003d1.1.15 # Apache-2.0"},{"line_number":68,"context_line":"retrying\u003e\u003d1.3.3,!\u003d1.3.0 # Apache-2.0"},{"line_number":69,"context_line":"os-service-types\u003e\u003d1.7.0 # Apache-2.0"},{"line_number":70,"context_line":"taskflow\u003e\u003d2.16.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":2,"id":"7faddb67_140f1630","line":67,"updated":"2019-08-22 21:02:28.000000000","message":"powervm here","commit_id":"91442b94bff50fc0fa1d4b21518c2a49f6d6ca98"}]}