)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"13ef55e8b1c35c6a3d1346139f0dccb0b313328f","unresolved":false,"context_lines":[{"line_number":876,"context_line":""},{"line_number":877,"context_line":"    def _reset_live_migration(self, context, instance):"},{"line_number":878,"context_line":"        migration \u003d None"},{"line_number":879,"context_line":"        try:"},{"line_number":880,"context_line":"            migration \u003d objects.Migration.get_by_instance_and_status("},{"line_number":881,"context_line":"                                      context, instance.uuid, \u0027running\u0027)"},{"line_number":882,"context_line":"            if migration:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_24a4bca2","line":879,"updated":"2019-11-20 15:26:47.000000000","message":"nit: I\u0027d have preferred to have two distinct exception checks with specific exception types.","commit_id":"ebcf6e4ce576285949c5a202f2d7d21dc03156ef"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"13ef55e8b1c35c6a3d1346139f0dccb0b313328f","unresolved":false,"context_lines":[{"line_number":880,"context_line":"            migration \u003d objects.Migration.get_by_instance_and_status("},{"line_number":881,"context_line":"                                      context, instance.uuid, \u0027running\u0027)"},{"line_number":882,"context_line":"            if migration:"},{"line_number":883,"context_line":"                self.live_migration_abort(context, instance, migration.id)"},{"line_number":884,"context_line":"        except Exception:"},{"line_number":885,"context_line":"            LOG.exception(\u0027Failed to abort live-migration\u0027,"},{"line_number":886,"context_line":"                          instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_246fdc60","line":883,"updated":"2019-11-20 15:26:47.000000000","message":"NOTE(for me) : we can do this because we\u0027re on the target node.","commit_id":"ebcf6e4ce576285949c5a202f2d7d21dc03156ef"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"13ef55e8b1c35c6a3d1346139f0dccb0b313328f","unresolved":false,"context_lines":[{"line_number":881,"context_line":"                                      context, instance.uuid, \u0027running\u0027)"},{"line_number":882,"context_line":"            if migration:"},{"line_number":883,"context_line":"                self.live_migration_abort(context, instance, migration.id)"},{"line_number":884,"context_line":"        except Exception:"},{"line_number":885,"context_line":"            LOG.exception(\u0027Failed to abort live-migration\u0027,"},{"line_number":886,"context_line":"                          instance\u003dinstance)"},{"line_number":887,"context_line":"        finally:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_c4db681e","line":884,"range":{"start_line":884,"start_character":15,"end_line":884,"end_character":24},"updated":"2019-11-20 15:26:47.000000000","message":"I don\u0027t really like to swallow any kind of exception here (in general) but I think it\u0027s harmless.\n\nFoolish I am if not.","commit_id":"ebcf6e4ce576285949c5a202f2d7d21dc03156ef"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"13ef55e8b1c35c6a3d1346139f0dccb0b313328f","unresolved":false,"context_lines":[{"line_number":884,"context_line":"        except Exception:"},{"line_number":885,"context_line":"            LOG.exception(\u0027Failed to abort live-migration\u0027,"},{"line_number":886,"context_line":"                          instance\u003dinstance)"},{"line_number":887,"context_line":"        finally:"},{"line_number":888,"context_line":"            if migration:"},{"line_number":889,"context_line":"                self._set_migration_status(migration, \u0027error\u0027)"},{"line_number":890,"context_line":"            LOG.info(\u0027Instance found in migrating state during \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_84e1f0d1","line":887,"updated":"2019-11-20 15:26:47.000000000","message":"you\u0027d not have needed the finally clause if you were catching the right exceptions... Even with this, since you swallow any exception in the catch-all, unless LOG.exception raises an exception itself, what\u0027s below this line will be called anyway.","commit_id":"ebcf6e4ce576285949c5a202f2d7d21dc03156ef"}]}