)]}'
{"nova/api/openstack/compute/plugins/v3/servers.py":[{"author":{"_account_id":8412,"name":"Mike Durnosvistov","email":"glacierr.dev@gmail.com","username":"mdurnosvistov"},"change_message_id":"66b9fb9009bbe266d24629418b7c3bcc72c2c9ca","unresolved":false,"context_lines":[{"line_number":796,"context_line":"        \"\"\""},{"line_number":797,"context_line":"        if create_kwargs.get(\u0027block_device_mapping\u0027):"},{"line_number":798,"context_line":"            return \u0027\u0027"},{"line_number":799,"context_line":"        else:"},{"line_number":800,"context_line":"            image_href \u003d server_dict.get(\u0027image_ref\u0027)"},{"line_number":801,"context_line":"            return self._image_uuid_from_href(unicode(image_href))"},{"line_number":802,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"baada198_0810174e","line":799,"range":{"start_line":799,"start_character":8,"end_line":799,"end_character":13},"updated":"2014-08-08 08:34:52.000000000","message":"This condition not needed","commit_id":"906661cfd789652b41d17164d5d47dabc6709a3c"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"5e2b2875a7b3507eda8c4d7bdfc943c504bb45f3","unresolved":false,"context_lines":[{"line_number":796,"context_line":"        \"\"\""},{"line_number":797,"context_line":"        if create_kwargs.get(\u0027block_device_mapping\u0027):"},{"line_number":798,"context_line":"            return \u0027\u0027"},{"line_number":799,"context_line":"        else:"},{"line_number":800,"context_line":"            image_href \u003d server_dict.get(\u0027image_ref\u0027)"},{"line_number":801,"context_line":"            return self._image_uuid_from_href(unicode(image_href))"},{"line_number":802,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"baada198_59d1d1f6","line":799,"in_reply_to":"baada198_0810174e","updated":"2014-08-11 00:33:44.000000000","message":"Nice catch, will fix it.","commit_id":"906661cfd789652b41d17164d5d47dabc6709a3c"}],"nova/api/openstack/compute/schemas/v3/servers.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"fc1c2228bbb4d7833868c36ad1d3e804a7d23110","unresolved":false,"context_lines":[{"line_number":34,"context_line":"                    \u0027items\u0027: {"},{"line_number":35,"context_line":"                        \u0027type\u0027: \u0027object\u0027,"},{"line_number":36,"context_line":"                        \u0027properties\u0027: {"},{"line_number":37,"context_line":"                            \u0027fixed_ip\u0027: {\u0027type\u0027: \u0027string\u0027, \u0027format\u0027: \u0027ipv4\u0027},"},{"line_number":38,"context_line":"                            \u0027port\u0027: {\u0027type\u0027: \u0027string\u0027, \u0027format\u0027: \u0027uuid\u0027},"},{"line_number":39,"context_line":"                            \u0027uuid\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":40,"context_line":"                        },"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAWn%2F%2F%2BuI%3D","line":37,"updated":"2014-04-08 05:34:18.000000000","message":"here should allow ipv6 also now because of the following changed code:\n\nnova/api/openstack/compute/plugins/v3/servers.py\n 378                 if address is not None and not utils.is_valid_ip_address(\n 379                         address):\n 380                     msg \u003d _(\"Invalid fixed IP address (%s)\") % address\n 381                     raise exc.HTTPBadRequest(explanation\u003dmsg)","commit_id":"5ca371fa279365d2f256a498163ee370d41212c8"},{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"b7c024c3273e81f9baafd5c4189a31133e32d660","unresolved":false,"context_lines":[{"line_number":31,"context_line":"                    \u0027items\u0027: {"},{"line_number":32,"context_line":"                        \u0027type\u0027: \u0027object\u0027,"},{"line_number":33,"context_line":"                        \u0027properties\u0027: {"},{"line_number":34,"context_line":"                            \u0027fixed_ip\u0027: {"},{"line_number":35,"context_line":"                                \u0027type\u0027: \u0027string\u0027,"},{"line_number":36,"context_line":"                                \u0027oneOf\u0027: ["},{"line_number":37,"context_line":"                                    {\u0027format\u0027: \u0027ipv4\u0027},"}],"source_content_type":"text/x-python","patch_set":16,"id":"fa98f980_6f311ba2","line":34,"updated":"2014-09-01 04:42:13.000000000","message":"Its oke for fixed_ip to be None isn\u0027t it?","commit_id":"c06d8ca95be81ad4b327081418b4fa7b499a5159"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"1885e27050a490dcf8fec24147ea374cec99049e","unresolved":false,"context_lines":[{"line_number":31,"context_line":"                    \u0027items\u0027: {"},{"line_number":32,"context_line":"                        \u0027type\u0027: \u0027object\u0027,"},{"line_number":33,"context_line":"                        \u0027properties\u0027: {"},{"line_number":34,"context_line":"                            \u0027fixed_ip\u0027: {"},{"line_number":35,"context_line":"                                \u0027type\u0027: \u0027string\u0027,"},{"line_number":36,"context_line":"                                \u0027oneOf\u0027: ["},{"line_number":37,"context_line":"                                    {\u0027format\u0027: \u0027ipv4\u0027},"}],"source_content_type":"text/x-python","patch_set":16,"id":"fa98f980_ea1416f7","line":34,"in_reply_to":"fa98f980_6f311ba2","updated":"2014-09-01 07:27:35.000000000","message":"Nice catch, _get_requested_networks() expects None also for fixed_ip on current code. So I will add it on the next patch.","commit_id":"c06d8ca95be81ad4b327081418b4fa7b499a5159"},{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"b7c024c3273e81f9baafd5c4189a31133e32d660","unresolved":false,"context_lines":[{"line_number":38,"context_line":"                                    {\u0027format\u0027: \u0027ipv6\u0027}"},{"line_number":39,"context_line":"                                ]"},{"line_number":40,"context_line":"                            },"},{"line_number":41,"context_line":"                            \u0027port\u0027: {\u0027type\u0027: \u0027string\u0027, \u0027format\u0027: \u0027uuid\u0027},"},{"line_number":42,"context_line":"                            \u0027uuid\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":43,"context_line":"                        },"},{"line_number":44,"context_line":"                        \u0027additionalProperties\u0027: False,"}],"source_content_type":"text/x-python","patch_set":16,"id":"fa98f980_8f263f67","line":41,"updated":"2014-09-01 04:42:13.000000000","message":"Its ok for port to be None isn\u0027t it?","commit_id":"c06d8ca95be81ad4b327081418b4fa7b499a5159"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"1885e27050a490dcf8fec24147ea374cec99049e","unresolved":false,"context_lines":[{"line_number":38,"context_line":"                                    {\u0027format\u0027: \u0027ipv6\u0027}"},{"line_number":39,"context_line":"                                ]"},{"line_number":40,"context_line":"                            },"},{"line_number":41,"context_line":"                            \u0027port\u0027: {\u0027type\u0027: \u0027string\u0027, \u0027format\u0027: \u0027uuid\u0027},"},{"line_number":42,"context_line":"                            \u0027uuid\u0027: {\u0027type\u0027: \u0027string\u0027},"},{"line_number":43,"context_line":"                        },"},{"line_number":44,"context_line":"                        \u0027additionalProperties\u0027: False,"}],"source_content_type":"text/x-python","patch_set":16,"id":"fa98f980_cadd9244","line":41,"in_reply_to":"fa98f980_8f263f67","updated":"2014-09-01 07:27:35.000000000","message":"Thanks, will update here also.","commit_id":"c06d8ca95be81ad4b327081418b4fa7b499a5159"}]}