)]}'
{"nova/tests/api/openstack/compute/plugins/v3/test_availability_zone.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"d7eede854d943be59ca66d8413399144bc2107d0","unresolved":false,"context_lines":[{"line_number":464,"context_line":"                                         \u0027report_count\u0027: 0})"},{"line_number":465,"context_line":"        agg \u003d db.aggregate_create(admin_context,"},{"line_number":466,"context_line":"                        {\u0027name\u0027: \u0027agg1\u0027},"},{"line_number":467,"context_line":"                        {\u0027os-availability-zone:availability_zone\u0027: \u0027nova\u0027})"},{"line_number":468,"context_line":"        db.aggregate_host_add(admin_context, agg[\u0027id\u0027], \u0027host1_zones\u0027)"},{"line_number":469,"context_line":"        res \u003d self.controller.create(req, body).obj"},{"line_number":470,"context_line":"        server \u003d res[\u0027server\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2B9IA%3D","line":467,"updated":"2014-01-20 12:58:46.000000000","message":"This change seems unnecessary because \u0027os-availability-zone:\u0027 is removed at server_create() of AvailabilityZone.","commit_id":"a986a661202534c4fadd63e087afe44cf71346d3"},{"author":{"_account_id":6348,"name":"xu-haiwei","email":"hai-xu@xr.jp.nec.com","username":"xu-haiwei"},"change_message_id":"1f906c14b7f3f61ad370f45f602980c37eabd045","unresolved":false,"context_lines":[{"line_number":464,"context_line":"                                         \u0027report_count\u0027: 0})"},{"line_number":465,"context_line":"        agg \u003d db.aggregate_create(admin_context,"},{"line_number":466,"context_line":"                        {\u0027name\u0027: \u0027agg1\u0027},"},{"line_number":467,"context_line":"                        {\u0027os-availability-zone:availability_zone\u0027: \u0027nova\u0027})"},{"line_number":468,"context_line":"        db.aggregate_host_add(admin_context, agg[\u0027id\u0027], \u0027host1_zones\u0027)"},{"line_number":469,"context_line":"        res \u003d self.controller.create(req, body).obj"},{"line_number":470,"context_line":"        server \u003d res[\u0027server\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2B4J4%3D","line":467,"in_reply_to":"AAAAUH%2F%2B9IA%3D","updated":"2014-01-21 06:37:55.000000000","message":"You are right, it should not be changed here. Thank you.","commit_id":"a986a661202534c4fadd63e087afe44cf71346d3"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"e5ee3ea9f66ff1f5d90e665f55f1f2297798c217","unresolved":false,"context_lines":[{"line_number":449,"context_line":"                    \u0027hello\u0027: \u0027world\u0027,"},{"line_number":450,"context_line":"                    \u0027open\u0027: \u0027stack\u0027,"},{"line_number":451,"context_line":"                },"},{"line_number":452,"context_line":"                \u0027os-availability-zone:availability_zone\u0027: \"nova\","},{"line_number":453,"context_line":"            },"},{"line_number":454,"context_line":"        }"},{"line_number":455,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2B4JE%3D","line":452,"updated":"2014-01-21 06:46:20.000000000","message":"Only change this isn\u0027t enough. this testcase isn\u0027t valid. Before fix this, the test still can pass. Maybe we shouldn\u0027t use default availability_zone \u0027nova\u0027. And we should assert the value is what we passed in at line 436","commit_id":"e16e176922065c1cb8b8fd0f95b02526d8f54a47"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"370cc9e64b68fa48d68f06acb0411dc87f0b2269","unresolved":false,"context_lines":[{"line_number":449,"context_line":"                    \u0027hello\u0027: \u0027world\u0027,"},{"line_number":450,"context_line":"                    \u0027open\u0027: \u0027stack\u0027,"},{"line_number":451,"context_line":"                },"},{"line_number":452,"context_line":"                \u0027os-availability-zone:availability_zone\u0027: \"nova\","},{"line_number":453,"context_line":"            },"},{"line_number":454,"context_line":"        }"},{"line_number":455,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2By2k%3D","line":452,"in_reply_to":"AAAAUH%2F%2B4EU%3D","updated":"2014-01-22 03:09:48.000000000","message":"I think this test isn\u0027t just test the input. But remove my point first. If other people think ok, then I\u0027m ok","commit_id":"e16e176922065c1cb8b8fd0f95b02526d8f54a47"},{"author":{"_account_id":6348,"name":"xu-haiwei","email":"hai-xu@xr.jp.nec.com","username":"xu-haiwei"},"change_message_id":"2bb11d91e48b5a43c956f2ec4cd04f5fae1324dc","unresolved":false,"context_lines":[{"line_number":449,"context_line":"                    \u0027hello\u0027: \u0027world\u0027,"},{"line_number":450,"context_line":"                    \u0027open\u0027: \u0027stack\u0027,"},{"line_number":451,"context_line":"                },"},{"line_number":452,"context_line":"                \u0027os-availability-zone:availability_zone\u0027: \"nova\","},{"line_number":453,"context_line":"            },"},{"line_number":454,"context_line":"        }"},{"line_number":455,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2B4EU%3D","line":452,"in_reply_to":"AAAAUH%2F%2B4JE%3D","updated":"2014-01-21 07:15:50.000000000","message":"Thank you Alex.\n\nThe original testcase can pass because the element in the body isn\u0027t checked. After all the validation framework patches are merged,\nthe original testcase won\u0027t be passed any more. So I think this change is meaningful. \n\nSecondly, if we use other availability_zone instead of nova, the 400 exception will be raised, because it can\u0027t be found in the DB. And I\u0027m afraid that situation is not this testcase mean to test.","commit_id":"e16e176922065c1cb8b8fd0f95b02526d8f54a47"},{"author":{"_account_id":6348,"name":"xu-haiwei","email":"hai-xu@xr.jp.nec.com","username":"xu-haiwei"},"change_message_id":"ebf25f02f39181c91e7c4690cfea7df5369725ee","unresolved":false,"context_lines":[{"line_number":449,"context_line":"                    \u0027hello\u0027: \u0027world\u0027,"},{"line_number":450,"context_line":"                    \u0027open\u0027: \u0027stack\u0027,"},{"line_number":451,"context_line":"                },"},{"line_number":452,"context_line":"                \u0027os-availability-zone:availability_zone\u0027: \"nova\","},{"line_number":453,"context_line":"            },"},{"line_number":454,"context_line":"        }"},{"line_number":455,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2BG5Q%3D","line":452,"in_reply_to":"AAAAUH%2F%2BHD0%3D","updated":"2014-01-30 02:44:33.000000000","message":"@Ken\u0027ichi Ohmichi\n\nThank you. \n@Alex Xu\n\nYour advice is supported by Ken\u0027ichi Ohmichi.\n\nI will modify it.","commit_id":"e16e176922065c1cb8b8fd0f95b02526d8f54a47"},{"author":{"_account_id":6348,"name":"xu-haiwei","email":"hai-xu@xr.jp.nec.com","username":"xu-haiwei"},"change_message_id":"b85fa1fbdc617f8d8ee818d051b73e65c1c364e7","unresolved":false,"context_lines":[{"line_number":449,"context_line":"                    \u0027hello\u0027: \u0027world\u0027,"},{"line_number":450,"context_line":"                    \u0027open\u0027: \u0027stack\u0027,"},{"line_number":451,"context_line":"                },"},{"line_number":452,"context_line":"                \u0027os-availability-zone:availability_zone\u0027: \"nova\","},{"line_number":453,"context_line":"            },"},{"line_number":454,"context_line":"        }"},{"line_number":455,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2BysM%3D","line":452,"in_reply_to":"AAAAUH%2F%2By2k%3D","updated":"2014-01-22 04:15:35.000000000","message":"Thank you Alex, let\u0027s see what other reviewers say.","commit_id":"e16e176922065c1cb8b8fd0f95b02526d8f54a47"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"2cb5740f69a183c99678f109f79ab59bae434f1d","unresolved":false,"context_lines":[{"line_number":449,"context_line":"                    \u0027hello\u0027: \u0027world\u0027,"},{"line_number":450,"context_line":"                    \u0027open\u0027: \u0027stack\u0027,"},{"line_number":451,"context_line":"                },"},{"line_number":452,"context_line":"                \u0027os-availability-zone:availability_zone\u0027: \"nova\","},{"line_number":453,"context_line":"            },"},{"line_number":454,"context_line":"        }"},{"line_number":455,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2BHD0%3D","line":452,"in_reply_to":"AAAAUH%2F%2BysM%3D","updated":"2014-01-30 02:07:55.000000000","message":"I think it is OK to keep \u0027nova\u0027 as a value, but the following code is necessary at line436 because of detecting this bug.\n\n self.assertEqual(\u0027nova\u0027, kwargs[\u0027availability_zone\u0027])","commit_id":"e16e176922065c1cb8b8fd0f95b02526d8f54a47"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"7707d6af9cdaffb83d0df7b5248686f3e933f3b6","unresolved":false,"context_lines":[{"line_number":450,"context_line":"                    \u0027hello\u0027: \u0027world\u0027,"},{"line_number":451,"context_line":"                    \u0027open\u0027: \u0027stack\u0027,"},{"line_number":452,"context_line":"                },"},{"line_number":453,"context_line":"                \u0027os-availability-zone:availability_zone\u0027: \"nova\","},{"line_number":454,"context_line":"            },"},{"line_number":455,"context_line":"        }"},{"line_number":456,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F%2FV9E%3D","line":453,"updated":"2014-03-18 14:03:30.000000000","message":"Can you use \u0027availability_zone.ATTRIBUTE_NAME\u0027 instead? we will be sure of the key.","commit_id":"bdc1045e462b2658d37b4d415f8231a9b377a8fc"},{"author":{"_account_id":6348,"name":"xu-haiwei","email":"hai-xu@xr.jp.nec.com","username":"xu-haiwei"},"change_message_id":"d8a4382587730a6ce2026dd8374a4e0e195e947f","unresolved":false,"context_lines":[{"line_number":450,"context_line":"                    \u0027hello\u0027: \u0027world\u0027,"},{"line_number":451,"context_line":"                    \u0027open\u0027: \u0027stack\u0027,"},{"line_number":452,"context_line":"                },"},{"line_number":453,"context_line":"                \u0027os-availability-zone:availability_zone\u0027: \"nova\","},{"line_number":454,"context_line":"            },"},{"line_number":455,"context_line":"        }"},{"line_number":456,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F%2Bq68%3D","line":453,"in_reply_to":"AAAAWH%2F%2FV9E%3D","updated":"2014-03-25 06:34:39.000000000","message":"Done.","commit_id":"bdc1045e462b2658d37b4d415f8231a9b377a8fc"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"ddad164fb7f07938430d013844aab3f559e5efb4","unresolved":false,"context_lines":[{"line_number":450,"context_line":"                    \u0027hello\u0027: \u0027world\u0027,"},{"line_number":451,"context_line":"                    \u0027open\u0027: \u0027stack\u0027,"},{"line_number":452,"context_line":"                },"},{"line_number":453,"context_line":"                \u0027os-availability-zone:availability_zone\u0027: \"nova\","},{"line_number":454,"context_line":"            },"},{"line_number":455,"context_line":"        }"},{"line_number":456,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F%2BrdU%3D","line":453,"in_reply_to":"AAAAWH%2F%2FV9E%3D","updated":"2014-03-25 05:00:04.000000000","message":"sahid\u0027s comment seems reasonable.","commit_id":"bdc1045e462b2658d37b4d415f8231a9b377a8fc"}]}