)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"6cee9f5af9982e267c7a78bf37e0ff2fd52a6645","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     LuyaoZhong \u003cluyao.zhong@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-08-28 05:44:48 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Retrive the allocations early"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Moves the allocation retrieving early, it will be passed to"},{"line_number":10,"context_line":"instance_claim/rebuild_claim/resize_claim in ResourceTracker,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7faddb67_08d23cd2","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":7},"updated":"2019-08-28 23:11:02.000000000","message":"Retrieve","commit_id":"6be47a79b80b38038604675a491000675b4621c0"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"7c354036b9964f9299d8b29594ba8586825e62d4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     LuyaoZhong \u003cluyao.zhong@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-08-30 10:48:44 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Retrive the allocations early"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Moves the allocation retrieving early, it will be passed to"},{"line_number":10,"context_line":"instance_claim/rebuild_claim/resize_claim in ResourceTracker,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"7faddb67_64b3b84f","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":7},"updated":"2019-08-30 15:26:49.000000000","message":"Retrieve","commit_id":"d32588136047d83bf8d1cbe764b06ba8de49caba"}],"nova/compute/manager.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"83b3c158102a298c553410a51214de71a2c8e4f2","unresolved":false,"context_lines":[{"line_number":2213,"context_line":"                context, instance, request_group_resource_providers_mapping)"},{"line_number":2214,"context_line":""},{"line_number":2215,"context_line":"        try:"},{"line_number":2216,"context_line":"            allocs \u003d ("},{"line_number":2217,"context_line":"                self.reportclient.get_allocations_for_consumer(context,"},{"line_number":2218,"context_line":"                                                               instance.uuid))"},{"line_number":2219,"context_line":"        except Exception:"},{"line_number":2220,"context_line":"            LOG.exception(\u0027Failure retrieving placement allocations\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"7faddb67_a213bc64","line":2217,"range":{"start_line":2216,"start_character":21,"end_line":2217,"end_character":16},"updated":"2019-09-03 16:22:50.000000000","message":"nit: shouldn\u0027t be necessary\n\nLater: I see this was copy-pasted from below. nvm","commit_id":"1187e037f353f575f3d9f15d15686265b5ec7374"},{"author":{"_account_id":23598,"name":"Zhong Luyao","email":"luyao.zhong@intel.com","username":"ZhongLuyao"},"change_message_id":"a45f3715f40bd758530c1c73f16f8f38a0b7df2e","unresolved":false,"context_lines":[{"line_number":2213,"context_line":"                context, instance, request_group_resource_providers_mapping)"},{"line_number":2214,"context_line":""},{"line_number":2215,"context_line":"        try:"},{"line_number":2216,"context_line":"            allocs \u003d ("},{"line_number":2217,"context_line":"                self.reportclient.get_allocations_for_consumer(context,"},{"line_number":2218,"context_line":"                                                               instance.uuid))"},{"line_number":2219,"context_line":"        except Exception:"},{"line_number":2220,"context_line":"            LOG.exception(\u0027Failure retrieving placement allocations\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"5faad753_250dea36","line":2217,"range":{"start_line":2216,"start_character":21,"end_line":2217,"end_character":16},"in_reply_to":"7faddb67_a213bc64","updated":"2019-09-11 10:32:01.000000000","message":"Done","commit_id":"1187e037f353f575f3d9f15d15686265b5ec7374"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"83b3c158102a298c553410a51214de71a2c8e4f2","unresolved":false,"context_lines":[{"line_number":2212,"context_line":"            self._update_pci_request_spec_with_allocated_interface_name("},{"line_number":2213,"context_line":"                context, instance, request_group_resource_providers_mapping)"},{"line_number":2214,"context_line":""},{"line_number":2215,"context_line":"        try:"},{"line_number":2216,"context_line":"            allocs \u003d ("},{"line_number":2217,"context_line":"                self.reportclient.get_allocations_for_consumer(context,"},{"line_number":2218,"context_line":"                                                               instance.uuid))"},{"line_number":2219,"context_line":"        except Exception:"},{"line_number":2220,"context_line":"            LOG.exception(\u0027Failure retrieving placement allocations\u0027,"},{"line_number":2221,"context_line":"                          instance\u003dinstance)"},{"line_number":2222,"context_line":"            msg \u003d _(\u0027Failure retrieving placement allocations\u0027)"},{"line_number":2223,"context_line":"            raise exception.BuildAbortException(instance_uuid\u003dinstance.uuid,"},{"line_number":2224,"context_line":"                                                reason\u003dmsg)"},{"line_number":2225,"context_line":""},{"line_number":2226,"context_line":"        try:"},{"line_number":2227,"context_line":"            scheduler_hints \u003d self._get_scheduler_hints(filter_properties,"}],"source_content_type":"text/x-python","patch_set":11,"id":"7faddb67_3d6851b8","line":2224,"range":{"start_line":2215,"start_character":0,"end_line":2224,"end_character":59},"updated":"2019-09-03 16:22:50.000000000","message":"Reading the docstring for this, it seems this is a legacy method that we should be trying to avoid using in favour of \u0027get_allocs_for_consumer\u0027. What\u0027s more, it doesn\u0027t look like \u0027get_allocations_for_consumer\u0027 can raise an exception since we\u0027re catching the only two obvious things I can see this raising. So, we should either (a) replace this with a call to \u0027get_allocs_for_consumer\u0027 and handle the specific exceptions it can raise, or (b) remove the exception handling code.","commit_id":"1187e037f353f575f3d9f15d15686265b5ec7374"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"205f5358ee58677918befe771b43b9dda3e43972","unresolved":false,"context_lines":[{"line_number":2212,"context_line":"            self._update_pci_request_spec_with_allocated_interface_name("},{"line_number":2213,"context_line":"                context, instance, request_group_resource_providers_mapping)"},{"line_number":2214,"context_line":""},{"line_number":2215,"context_line":"        try:"},{"line_number":2216,"context_line":"            allocs \u003d ("},{"line_number":2217,"context_line":"                self.reportclient.get_allocations_for_consumer(context,"},{"line_number":2218,"context_line":"                                                               instance.uuid))"},{"line_number":2219,"context_line":"        except Exception:"},{"line_number":2220,"context_line":"            LOG.exception(\u0027Failure retrieving placement allocations\u0027,"},{"line_number":2221,"context_line":"                          instance\u003dinstance)"},{"line_number":2222,"context_line":"            msg \u003d _(\u0027Failure retrieving placement allocations\u0027)"},{"line_number":2223,"context_line":"            raise exception.BuildAbortException(instance_uuid\u003dinstance.uuid,"},{"line_number":2224,"context_line":"                                                reason\u003dmsg)"},{"line_number":2225,"context_line":""},{"line_number":2226,"context_line":"        try:"},{"line_number":2227,"context_line":"            scheduler_hints \u003d self._get_scheduler_hints(filter_properties,"}],"source_content_type":"text/x-python","patch_set":11,"id":"5faad753_9a73dd4d","line":2224,"range":{"start_line":2215,"start_character":0,"end_line":2224,"end_character":59},"in_reply_to":"5faad753_371be481","updated":"2019-09-11 09:38:16.000000000","message":"If there was an existing test, leave it in (adjusting if necessary for the new position of the code). But I wouldn\u0027t think there\u0027s a need to add any new UT.\n\nBTW, since you\u0027re in the area, you could add a TODO to remove the try/except and cut over to get_allocs_for_consumer.","commit_id":"1187e037f353f575f3d9f15d15686265b5ec7374"},{"author":{"_account_id":23598,"name":"Zhong Luyao","email":"luyao.zhong@intel.com","username":"ZhongLuyao"},"change_message_id":"d6f6fa29d90671fddf73bf4b847522e2f6e479b3","unresolved":false,"context_lines":[{"line_number":2212,"context_line":"            self._update_pci_request_spec_with_allocated_interface_name("},{"line_number":2213,"context_line":"                context, instance, request_group_resource_providers_mapping)"},{"line_number":2214,"context_line":""},{"line_number":2215,"context_line":"        try:"},{"line_number":2216,"context_line":"            allocs \u003d ("},{"line_number":2217,"context_line":"                self.reportclient.get_allocations_for_consumer(context,"},{"line_number":2218,"context_line":"                                                               instance.uuid))"},{"line_number":2219,"context_line":"        except Exception:"},{"line_number":2220,"context_line":"            LOG.exception(\u0027Failure retrieving placement allocations\u0027,"},{"line_number":2221,"context_line":"                          instance\u003dinstance)"},{"line_number":2222,"context_line":"            msg \u003d _(\u0027Failure retrieving placement allocations\u0027)"},{"line_number":2223,"context_line":"            raise exception.BuildAbortException(instance_uuid\u003dinstance.uuid,"},{"line_number":2224,"context_line":"                                                reason\u003dmsg)"},{"line_number":2225,"context_line":""},{"line_number":2226,"context_line":"        try:"},{"line_number":2227,"context_line":"            scheduler_hints \u003d self._get_scheduler_hints(filter_properties,"}],"source_content_type":"text/x-python","patch_set":11,"id":"5faad753_371be481","line":2224,"range":{"start_line":2215,"start_character":0,"end_line":2224,"end_character":59},"in_reply_to":"5faad753_7f5bbc86","updated":"2019-09-11 09:13:56.000000000","message":"Okay, do you need a unittest for this?","commit_id":"1187e037f353f575f3d9f15d15686265b5ec7374"},{"author":{"_account_id":23598,"name":"Zhong Luyao","email":"luyao.zhong@intel.com","username":"ZhongLuyao"},"change_message_id":"a45f3715f40bd758530c1c73f16f8f38a0b7df2e","unresolved":false,"context_lines":[{"line_number":2212,"context_line":"            self._update_pci_request_spec_with_allocated_interface_name("},{"line_number":2213,"context_line":"                context, instance, request_group_resource_providers_mapping)"},{"line_number":2214,"context_line":""},{"line_number":2215,"context_line":"        try:"},{"line_number":2216,"context_line":"            allocs \u003d ("},{"line_number":2217,"context_line":"                self.reportclient.get_allocations_for_consumer(context,"},{"line_number":2218,"context_line":"                                                               instance.uuid))"},{"line_number":2219,"context_line":"        except Exception:"},{"line_number":2220,"context_line":"            LOG.exception(\u0027Failure retrieving placement allocations\u0027,"},{"line_number":2221,"context_line":"                          instance\u003dinstance)"},{"line_number":2222,"context_line":"            msg \u003d _(\u0027Failure retrieving placement allocations\u0027)"},{"line_number":2223,"context_line":"            raise exception.BuildAbortException(instance_uuid\u003dinstance.uuid,"},{"line_number":2224,"context_line":"                                                reason\u003dmsg)"},{"line_number":2225,"context_line":""},{"line_number":2226,"context_line":"        try:"},{"line_number":2227,"context_line":"            scheduler_hints \u003d self._get_scheduler_hints(filter_properties,"}],"source_content_type":"text/x-python","patch_set":11,"id":"5faad753_6503e20e","line":2224,"range":{"start_line":2215,"start_character":0,"end_line":2224,"end_character":59},"in_reply_to":"5faad753_9a73dd4d","updated":"2019-09-11 10:32:01.000000000","message":"Done","commit_id":"1187e037f353f575f3d9f15d15686265b5ec7374"},{"author":{"_account_id":23598,"name":"Zhong Luyao","email":"luyao.zhong@intel.com","username":"ZhongLuyao"},"change_message_id":"5604de8d6d2d3eddf9a4e78dea0a17161768ac5d","unresolved":false,"context_lines":[{"line_number":2212,"context_line":"            self._update_pci_request_spec_with_allocated_interface_name("},{"line_number":2213,"context_line":"                context, instance, request_group_resource_providers_mapping)"},{"line_number":2214,"context_line":""},{"line_number":2215,"context_line":"        try:"},{"line_number":2216,"context_line":"            allocs \u003d ("},{"line_number":2217,"context_line":"                self.reportclient.get_allocations_for_consumer(context,"},{"line_number":2218,"context_line":"                                                               instance.uuid))"},{"line_number":2219,"context_line":"        except Exception:"},{"line_number":2220,"context_line":"            LOG.exception(\u0027Failure retrieving placement allocations\u0027,"},{"line_number":2221,"context_line":"                          instance\u003dinstance)"},{"line_number":2222,"context_line":"            msg \u003d _(\u0027Failure retrieving placement allocations\u0027)"},{"line_number":2223,"context_line":"            raise exception.BuildAbortException(instance_uuid\u003dinstance.uuid,"},{"line_number":2224,"context_line":"                                                reason\u003dmsg)"},{"line_number":2225,"context_line":""},{"line_number":2226,"context_line":"        try:"},{"line_number":2227,"context_line":"            scheduler_hints \u003d self._get_scheduler_hints(filter_properties,"}],"source_content_type":"text/x-python","patch_set":11,"id":"7faddb67_e7e218d4","line":2224,"range":{"start_line":2215,"start_character":0,"end_line":2224,"end_character":59},"in_reply_to":"7faddb67_3d6851b8","updated":"2019-09-04 12:51:59.000000000","message":"I choose (b). :)","commit_id":"1187e037f353f575f3d9f15d15686265b5ec7374"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"4687863a5ab5003ba108c17bb65ff734a89354a0","unresolved":false,"context_lines":[{"line_number":2212,"context_line":"            self._update_pci_request_spec_with_allocated_interface_name("},{"line_number":2213,"context_line":"                context, instance, request_group_resource_providers_mapping)"},{"line_number":2214,"context_line":""},{"line_number":2215,"context_line":"        try:"},{"line_number":2216,"context_line":"            allocs \u003d ("},{"line_number":2217,"context_line":"                self.reportclient.get_allocations_for_consumer(context,"},{"line_number":2218,"context_line":"                                                               instance.uuid))"},{"line_number":2219,"context_line":"        except Exception:"},{"line_number":2220,"context_line":"            LOG.exception(\u0027Failure retrieving placement allocations\u0027,"},{"line_number":2221,"context_line":"                          instance\u003dinstance)"},{"line_number":2222,"context_line":"            msg \u003d _(\u0027Failure retrieving placement allocations\u0027)"},{"line_number":2223,"context_line":"            raise exception.BuildAbortException(instance_uuid\u003dinstance.uuid,"},{"line_number":2224,"context_line":"                                                reason\u003dmsg)"},{"line_number":2225,"context_line":""},{"line_number":2226,"context_line":"        try:"},{"line_number":2227,"context_line":"            scheduler_hints \u003d self._get_scheduler_hints(filter_properties,"}],"source_content_type":"text/x-python","patch_set":11,"id":"5faad753_7f5bbc86","line":2224,"range":{"start_line":2215,"start_character":0,"end_line":2224,"end_character":59},"in_reply_to":"7faddb67_e7e218d4","updated":"2019-09-06 22:45:18.000000000","message":"It would have been best to leave this as it was for now, since we\u0027re explicitly just moving code. The cutover to get_allocs_for_consumer and any exception handling changes should have been done later/separately.","commit_id":"1187e037f353f575f3d9f15d15686265b5ec7374"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"83b3c158102a298c553410a51214de71a2c8e4f2","unresolved":false,"context_lines":[{"line_number":4415,"context_line":"        instance.save()"},{"line_number":4416,"context_line":""},{"line_number":4417,"context_line":"        limits \u003d filter_properties.get(\u0027limits\u0027, {})"},{"line_number":4418,"context_line":"        allocs \u003d ("},{"line_number":4419,"context_line":"            self.reportclient.get_allocations_for_consumer(context,"},{"line_number":4420,"context_line":"                                                           instance.uuid))"},{"line_number":4421,"context_line":"        with self.rt.resize_claim(context, instance, instance_type, node,"},{"line_number":4422,"context_line":"                                  migration, allocs, image_meta\u003dimage,"},{"line_number":4423,"context_line":"                                  limits\u003dlimits) as claim:"}],"source_content_type":"text/x-python","patch_set":11,"id":"7faddb67_1d5b1522","line":4420,"range":{"start_line":4418,"start_character":0,"end_line":4420,"end_character":74},"updated":"2019-09-03 16:22:50.000000000","message":"Yeah, we\u0027re not handling any exceptions here, nor should we need to","commit_id":"1187e037f353f575f3d9f15d15686265b5ec7374"},{"author":{"_account_id":23598,"name":"Zhong Luyao","email":"luyao.zhong@intel.com","username":"ZhongLuyao"},"change_message_id":"5604de8d6d2d3eddf9a4e78dea0a17161768ac5d","unresolved":false,"context_lines":[{"line_number":4415,"context_line":"        instance.save()"},{"line_number":4416,"context_line":""},{"line_number":4417,"context_line":"        limits \u003d filter_properties.get(\u0027limits\u0027, {})"},{"line_number":4418,"context_line":"        allocs \u003d ("},{"line_number":4419,"context_line":"            self.reportclient.get_allocations_for_consumer(context,"},{"line_number":4420,"context_line":"                                                           instance.uuid))"},{"line_number":4421,"context_line":"        with self.rt.resize_claim(context, instance, instance_type, node,"},{"line_number":4422,"context_line":"                                  migration, allocs, image_meta\u003dimage,"},{"line_number":4423,"context_line":"                                  limits\u003dlimits) as claim:"}],"source_content_type":"text/x-python","patch_set":11,"id":"7faddb67_876d6430","line":4420,"range":{"start_line":4418,"start_character":0,"end_line":4420,"end_character":74},"in_reply_to":"7faddb67_1d5b1522","updated":"2019-09-04 12:51:59.000000000","message":"Done","commit_id":"1187e037f353f575f3d9f15d15686265b5ec7374"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"83b3c158102a298c553410a51214de71a2c8e4f2","unresolved":false,"context_lines":[{"line_number":5414,"context_line":""},{"line_number":5415,"context_line":"        limits \u003d filter_properties.get(\u0027limits\u0027, {})"},{"line_number":5416,"context_line":""},{"line_number":5417,"context_line":"        allocations \u003d self.reportclient.get_allocations_for_consumer("},{"line_number":5418,"context_line":"            context, instance.uuid)"},{"line_number":5419,"context_line":""},{"line_number":5420,"context_line":"        shelved_image_ref \u003d instance.image_ref"},{"line_number":5421,"context_line":"        if image:"}],"source_content_type":"text/x-python","patch_set":11,"id":"7faddb67_dd9eddb6","line":5418,"range":{"start_line":5417,"start_character":0,"end_line":5418,"end_character":35},"updated":"2019-09-03 16:22:50.000000000","message":"Or here, fwiw","commit_id":"1187e037f353f575f3d9f15d15686265b5ec7374"},{"author":{"_account_id":23598,"name":"Zhong Luyao","email":"luyao.zhong@intel.com","username":"ZhongLuyao"},"change_message_id":"5604de8d6d2d3eddf9a4e78dea0a17161768ac5d","unresolved":false,"context_lines":[{"line_number":5414,"context_line":""},{"line_number":5415,"context_line":"        limits \u003d filter_properties.get(\u0027limits\u0027, {})"},{"line_number":5416,"context_line":""},{"line_number":5417,"context_line":"        allocations \u003d self.reportclient.get_allocations_for_consumer("},{"line_number":5418,"context_line":"            context, instance.uuid)"},{"line_number":5419,"context_line":""},{"line_number":5420,"context_line":"        shelved_image_ref \u003d instance.image_ref"},{"line_number":5421,"context_line":"        if image:"}],"source_content_type":"text/x-python","patch_set":11,"id":"7faddb67_2762703f","line":5418,"range":{"start_line":5417,"start_character":0,"end_line":5418,"end_character":35},"in_reply_to":"7faddb67_dd9eddb6","updated":"2019-09-04 12:51:59.000000000","message":"Done","commit_id":"1187e037f353f575f3d9f15d15686265b5ec7374"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"da4d8d27b53d92ff7f875f275c4f069af6cf17d0","unresolved":false,"context_lines":[{"line_number":2212,"context_line":"            self._update_pci_request_spec_with_allocated_interface_name("},{"line_number":2213,"context_line":"                context, instance, request_group_resource_providers_mapping)"},{"line_number":2214,"context_line":""},{"line_number":2215,"context_line":"        allocs \u003d self.reportclient.get_allocations_for_consumer("},{"line_number":2216,"context_line":"                context, instance.uuid)"},{"line_number":2217,"context_line":""},{"line_number":2218,"context_line":"        try:"},{"line_number":2219,"context_line":"            scheduler_hints \u003d self._get_scheduler_hints(filter_properties,"}],"source_content_type":"text/x-python","patch_set":15,"id":"7faddb67_cc94ca38","line":2216,"range":{"start_line":2215,"start_character":8,"end_line":2216,"end_character":39},"updated":"2019-09-05 05:00:42.000000000","message":"emm...I think we should check if allocs is None or empty, then we should stop the spawn new instance. I see your take care of that case https://review.opendev.org/#/c/678452/17/nova/compute/resource_tracker.py@397, but still don\u0027t think it make sense to continue the process.","commit_id":"4f00627183d9cce47f704fd4cec42398585a72ab"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"86e03c0d7a4d0ddd18acb2e7b7eefcd719130402","unresolved":false,"context_lines":[{"line_number":2212,"context_line":"            self._update_pci_request_spec_with_allocated_interface_name("},{"line_number":2213,"context_line":"                context, instance, request_group_resource_providers_mapping)"},{"line_number":2214,"context_line":""},{"line_number":2215,"context_line":"        allocs \u003d self.reportclient.get_allocations_for_consumer("},{"line_number":2216,"context_line":"                context, instance.uuid)"},{"line_number":2217,"context_line":""},{"line_number":2218,"context_line":"        try:"},{"line_number":2219,"context_line":"            scheduler_hints \u003d self._get_scheduler_hints(filter_properties,"}],"source_content_type":"text/x-python","patch_set":15,"id":"5faad753_3666d8ef","line":2216,"range":{"start_line":2215,"start_character":8,"end_line":2216,"end_character":39},"in_reply_to":"5faad753_53828751","updated":"2019-09-06 14:29:44.000000000","message":"yea, I think i see now. We still can boot instance without allocation due to compat the old cached scheduler. Since we have no cached scheduler now, but that cleanup should be a separate patch. No allocation means no pmem and gpu allocation, that make sense also.","commit_id":"4f00627183d9cce47f704fd4cec42398585a72ab"},{"author":{"_account_id":23598,"name":"Zhong Luyao","email":"luyao.zhong@intel.com","username":"ZhongLuyao"},"change_message_id":"c9c255a824ec543c293f6f993f1413e64f1df39f","unresolved":false,"context_lines":[{"line_number":2212,"context_line":"            self._update_pci_request_spec_with_allocated_interface_name("},{"line_number":2213,"context_line":"                context, instance, request_group_resource_providers_mapping)"},{"line_number":2214,"context_line":""},{"line_number":2215,"context_line":"        allocs \u003d self.reportclient.get_allocations_for_consumer("},{"line_number":2216,"context_line":"                context, instance.uuid)"},{"line_number":2217,"context_line":""},{"line_number":2218,"context_line":"        try:"},{"line_number":2219,"context_line":"            scheduler_hints \u003d self._get_scheduler_hints(filter_properties,"}],"source_content_type":"text/x-python","patch_set":15,"id":"5faad753_53828751","line":2216,"range":{"start_line":2215,"start_character":8,"end_line":2216,"end_character":39},"in_reply_to":"5faad753_5812a4b3","updated":"2019-09-06 13:38:39.000000000","message":"I even found some functional tests to assert no allocations, \nhttps://github.com/openstack/nova/blob/master/nova/tests/functional/test_nova_manage.py#L462\nso if it is not a problem when allocs is empty?","commit_id":"4f00627183d9cce47f704fd4cec42398585a72ab"},{"author":{"_account_id":23598,"name":"Zhong Luyao","email":"luyao.zhong@intel.com","username":"ZhongLuyao"},"change_message_id":"d5b630fb01a967e7058a422d14e879ad9df13073","unresolved":false,"context_lines":[{"line_number":2212,"context_line":"            self._update_pci_request_spec_with_allocated_interface_name("},{"line_number":2213,"context_line":"                context, instance, request_group_resource_providers_mapping)"},{"line_number":2214,"context_line":""},{"line_number":2215,"context_line":"        allocs \u003d self.reportclient.get_allocations_for_consumer("},{"line_number":2216,"context_line":"                context, instance.uuid)"},{"line_number":2217,"context_line":""},{"line_number":2218,"context_line":"        try:"},{"line_number":2219,"context_line":"            scheduler_hints \u003d self._get_scheduler_hints(filter_properties,"}],"source_content_type":"text/x-python","patch_set":15,"id":"5faad753_5812a4b3","line":2216,"range":{"start_line":2215,"start_character":8,"end_line":2216,"end_character":39},"in_reply_to":"7faddb67_45d0a8f7","updated":"2019-09-06 13:12:56.000000000","message":"It will break too many unittests and functional tests if we check whether it is empty and raise an exception, I\u0027m thinking....If there is some way to address these fail tests.","commit_id":"4f00627183d9cce47f704fd4cec42398585a72ab"},{"author":{"_account_id":23598,"name":"Zhong Luyao","email":"luyao.zhong@intel.com","username":"ZhongLuyao"},"change_message_id":"bc17150e2153776110b8356cd0579c5ea163fb69","unresolved":false,"context_lines":[{"line_number":2212,"context_line":"            self._update_pci_request_spec_with_allocated_interface_name("},{"line_number":2213,"context_line":"                context, instance, request_group_resource_providers_mapping)"},{"line_number":2214,"context_line":""},{"line_number":2215,"context_line":"        allocs \u003d self.reportclient.get_allocations_for_consumer("},{"line_number":2216,"context_line":"                context, instance.uuid)"},{"line_number":2217,"context_line":""},{"line_number":2218,"context_line":"        try:"},{"line_number":2219,"context_line":"            scheduler_hints \u003d self._get_scheduler_hints(filter_properties,"}],"source_content_type":"text/x-python","patch_set":15,"id":"7faddb67_45d0a8f7","line":2216,"range":{"start_line":2215,"start_character":8,"end_line":2216,"end_character":39},"in_reply_to":"7faddb67_cc94ca38","updated":"2019-09-05 11:19:55.000000000","message":"see @5407, we do nothing to handle the empty allocs.\nBut agree with that it doesn\u0027t make sense to continue.\nFor instance build, we can raise BuildAbortException, what about others?","commit_id":"4f00627183d9cce47f704fd4cec42398585a72ab"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"da4d8d27b53d92ff7f875f275c4f069af6cf17d0","unresolved":false,"context_lines":[{"line_number":3144,"context_line":"        with self._error_out_instance_on_exception(context, instance):"},{"line_number":3145,"context_line":"            try:"},{"line_number":3146,"context_line":"                allocs \u003d self.reportclient.get_allocations_for_consumer("},{"line_number":3147,"context_line":"                        context, instance.uuid)"},{"line_number":3148,"context_line":"                claim_ctxt \u003d rebuild_claim("},{"line_number":3149,"context_line":"                    context, instance, scheduled_node, allocs,"},{"line_number":3150,"context_line":"                    limits\u003dlimits, image_meta\u003dimage_meta,"}],"source_content_type":"text/x-python","patch_set":15,"id":"7faddb67_8ca25299","line":3147,"updated":"2019-09-05 05:00:42.000000000","message":"ditto","commit_id":"4f00627183d9cce47f704fd4cec42398585a72ab"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"da4d8d27b53d92ff7f875f275c4f069af6cf17d0","unresolved":false,"context_lines":[{"line_number":4407,"context_line":""},{"line_number":4408,"context_line":"        limits \u003d filter_properties.get(\u0027limits\u0027, {})"},{"line_number":4409,"context_line":"        allocs \u003d self.reportclient.get_allocations_for_consumer("},{"line_number":4410,"context_line":"            context, instance.uuid)"},{"line_number":4411,"context_line":"        with self.rt.resize_claim(context, instance, instance_type, node,"},{"line_number":4412,"context_line":"                                  migration, allocs, image_meta\u003dimage,"},{"line_number":4413,"context_line":"                                  limits\u003dlimits) as claim:"}],"source_content_type":"text/x-python","patch_set":15,"id":"7faddb67_ac9dce57","line":4410,"updated":"2019-09-05 05:00:42.000000000","message":"ditto","commit_id":"4f00627183d9cce47f704fd4cec42398585a72ab"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5602a8b50a26a93dd149448cc13f8a3531f237db","unresolved":false,"context_lines":[{"line_number":3143,"context_line":""},{"line_number":3144,"context_line":"        with self._error_out_instance_on_exception(context, instance):"},{"line_number":3145,"context_line":"            try:"},{"line_number":3146,"context_line":"                allocs \u003d self.reportclient.get_allocations_for_consumer("},{"line_number":3147,"context_line":"                        context, instance.uuid)"},{"line_number":3148,"context_line":"                claim_ctxt \u003d rebuild_claim("},{"line_number":3149,"context_line":"                    context, instance, scheduled_node, allocs,"},{"line_number":3150,"context_line":"                    limits\u003dlimits, image_meta\u003dimage_meta,"}],"source_content_type":"text/x-python","patch_set":20,"id":"5faad753_60d687c6","line":3147,"range":{"start_line":3146,"start_character":0,"end_line":3147,"end_character":47},"updated":"2019-09-10 14:35:57.000000000","message":"This should really be done outside of the try, since we\u0027re not trying to catch anything from this, right?","commit_id":"c56c8042a812e26ef5e7741f7e1358c3b89d9ae6"},{"author":{"_account_id":23598,"name":"Zhong Luyao","email":"luyao.zhong@intel.com","username":"ZhongLuyao"},"change_message_id":"dfd66ad2a0d0b803e475ee32d2a578e0e6607cd3","unresolved":false,"context_lines":[{"line_number":3143,"context_line":""},{"line_number":3144,"context_line":"        with self._error_out_instance_on_exception(context, instance):"},{"line_number":3145,"context_line":"            try:"},{"line_number":3146,"context_line":"                allocs \u003d self.reportclient.get_allocations_for_consumer("},{"line_number":3147,"context_line":"                        context, instance.uuid)"},{"line_number":3148,"context_line":"                claim_ctxt \u003d rebuild_claim("},{"line_number":3149,"context_line":"                    context, instance, scheduled_node, allocs,"},{"line_number":3150,"context_line":"                    limits\u003dlimits, image_meta\u003dimage_meta,"}],"source_content_type":"text/x-python","patch_set":20,"id":"5faad753_54e1becf","line":3147,"range":{"start_line":3146,"start_character":0,"end_line":3147,"end_character":47},"in_reply_to":"5faad753_314d349a","updated":"2019-09-11 08:33:23.000000000","message":"Oh, I forgot this.","commit_id":"c56c8042a812e26ef5e7741f7e1358c3b89d9ae6"},{"author":{"_account_id":23598,"name":"Zhong Luyao","email":"luyao.zhong@intel.com","username":"ZhongLuyao"},"change_message_id":"d6f6fa29d90671fddf73bf4b847522e2f6e479b3","unresolved":false,"context_lines":[{"line_number":3143,"context_line":""},{"line_number":3144,"context_line":"        with self._error_out_instance_on_exception(context, instance):"},{"line_number":3145,"context_line":"            try:"},{"line_number":3146,"context_line":"                allocs \u003d self.reportclient.get_allocations_for_consumer("},{"line_number":3147,"context_line":"                        context, instance.uuid)"},{"line_number":3148,"context_line":"                claim_ctxt \u003d rebuild_claim("},{"line_number":3149,"context_line":"                    context, instance, scheduled_node, allocs,"},{"line_number":3150,"context_line":"                    limits\u003dlimits, image_meta\u003dimage_meta,"}],"source_content_type":"text/x-python","patch_set":20,"id":"5faad753_5766a053","line":3147,"range":{"start_line":3146,"start_character":0,"end_line":3147,"end_character":47},"in_reply_to":"5faad753_54e1becf","updated":"2019-09-11 09:13:56.000000000","message":"Done","commit_id":"c56c8042a812e26ef5e7741f7e1358c3b89d9ae6"},{"author":{"_account_id":23598,"name":"Zhong Luyao","email":"luyao.zhong@intel.com","username":"ZhongLuyao"},"change_message_id":"9af447de8bde1c958549f273fd532bfd2835848c","unresolved":false,"context_lines":[{"line_number":3143,"context_line":""},{"line_number":3144,"context_line":"        with self._error_out_instance_on_exception(context, instance):"},{"line_number":3145,"context_line":"            try:"},{"line_number":3146,"context_line":"                allocs \u003d self.reportclient.get_allocations_for_consumer("},{"line_number":3147,"context_line":"                        context, instance.uuid)"},{"line_number":3148,"context_line":"                claim_ctxt \u003d rebuild_claim("},{"line_number":3149,"context_line":"                    context, instance, scheduled_node, allocs,"},{"line_number":3150,"context_line":"                    limits\u003dlimits, image_meta\u003dimage_meta,"}],"source_content_type":"text/x-python","patch_set":20,"id":"5faad753_314d349a","line":3147,"range":{"start_line":3146,"start_character":0,"end_line":3147,"end_character":47},"in_reply_to":"5faad753_60d687c6","updated":"2019-09-11 08:13:23.000000000","message":"Done","commit_id":"c56c8042a812e26ef5e7741f7e1358c3b89d9ae6"}],"nova/compute/resource_tracker.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"6cee9f5af9982e267c7a78bf37e0ff2fd52a6645","unresolved":false,"context_lines":[{"line_number":151,"context_line":"        self.ram_allocation_ratio \u003d CONF.ram_allocation_ratio"},{"line_number":152,"context_line":"        self.cpu_allocation_ratio \u003d CONF.cpu_allocation_ratio"},{"line_number":153,"context_line":"        self.disk_allocation_ratio \u003d CONF.disk_allocation_ratio"},{"line_number":154,"context_line":"        self.prov_tree \u003d None"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    @utils.synchronized(COMPUTE_RESOURCE_SEMAPHORE)"},{"line_number":157,"context_line":"    def instance_claim(self, context, instance, nodename, allocations,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7faddb67_28613812","line":154,"range":{"start_line":154,"start_character":8,"end_line":154,"end_character":29},"updated":"2019-08-28 23:11:02.000000000","message":"I don\u0027t see where this is used. Did it bleed in from another patch in the series?","commit_id":"6be47a79b80b38038604675a491000675b4621c0"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"3414d4937f5515cb99401e0556d18a2d7014609d","unresolved":false,"context_lines":[{"line_number":151,"context_line":"        self.ram_allocation_ratio \u003d CONF.ram_allocation_ratio"},{"line_number":152,"context_line":"        self.cpu_allocation_ratio \u003d CONF.cpu_allocation_ratio"},{"line_number":153,"context_line":"        self.disk_allocation_ratio \u003d CONF.disk_allocation_ratio"},{"line_number":154,"context_line":"        self.prov_tree \u003d None"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    @utils.synchronized(COMPUTE_RESOURCE_SEMAPHORE)"},{"line_number":157,"context_line":"    def instance_claim(self, context, instance, nodename, allocations,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7faddb67_36dd0bdd","line":154,"range":{"start_line":154,"start_character":8,"end_line":154,"end_character":29},"in_reply_to":"7faddb67_28613812","updated":"2019-08-29 17:36:37.000000000","message":"please hit this if you respin, but it\u0027s not worth blocking on","commit_id":"6be47a79b80b38038604675a491000675b4621c0"},{"author":{"_account_id":23598,"name":"Zhong Luyao","email":"luyao.zhong@intel.com","username":"ZhongLuyao"},"change_message_id":"ad19ef26cdad9092c6d85bceca797432189c96e2","unresolved":false,"context_lines":[{"line_number":151,"context_line":"        self.ram_allocation_ratio \u003d CONF.ram_allocation_ratio"},{"line_number":152,"context_line":"        self.cpu_allocation_ratio \u003d CONF.cpu_allocation_ratio"},{"line_number":153,"context_line":"        self.disk_allocation_ratio \u003d CONF.disk_allocation_ratio"},{"line_number":154,"context_line":"        self.prov_tree \u003d None"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    @utils.synchronized(COMPUTE_RESOURCE_SEMAPHORE)"},{"line_number":157,"context_line":"    def instance_claim(self, context, instance, nodename, allocations,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7faddb67_40fd4fb0","line":154,"range":{"start_line":154,"start_character":8,"end_line":154,"end_character":29},"in_reply_to":"7faddb67_36dd0bdd","updated":"2019-08-30 09:27:00.000000000","message":"Done","commit_id":"6be47a79b80b38038604675a491000675b4621c0"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5602a8b50a26a93dd149448cc13f8a3531f237db","unresolved":false,"context_lines":[{"line_number":264,"context_line":"        and CPUs"},{"line_number":265,"context_line":"        :param migration: A migration object if one was already created"},{"line_number":266,"context_line":"                          elsewhere for this operation (otherwise None)"},{"line_number":267,"context_line":"        :parma allocations: the placement allocation records."},{"line_number":268,"context_line":"        :returns: A Claim ticket representing the reserved resources.  This"},{"line_number":269,"context_line":"        should be turned into finalize  a resource claim or free"},{"line_number":270,"context_line":"        resources after the compute operation is finished."}],"source_content_type":"text/x-python","patch_set":20,"id":"5faad753_00feb336","line":267,"range":{"start_line":267,"start_character":0,"end_line":267,"end_character":61},"updated":"2019-09-10 14:35:57.000000000","message":"nit: the order of these is off, but it was wrong beforehand too. Would be a good follow up","commit_id":"c56c8042a812e26ef5e7741f7e1358c3b89d9ae6"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9fae7af997604235c3d2c076b555c3db2f6b2462","unresolved":false,"context_lines":[{"line_number":264,"context_line":"        and CPUs"},{"line_number":265,"context_line":"        :param migration: A migration object if one was already created"},{"line_number":266,"context_line":"                          elsewhere for this operation (otherwise None)"},{"line_number":267,"context_line":"        :parma allocations: the placement allocation records."},{"line_number":268,"context_line":"        :returns: A Claim ticket representing the reserved resources.  This"},{"line_number":269,"context_line":"        should be turned into finalize  a resource claim or free"},{"line_number":270,"context_line":"        resources after the compute operation is finished."}],"source_content_type":"text/x-python","patch_set":23,"id":"5faad753_8417f7ed","line":267,"range":{"start_line":267,"start_character":9,"end_line":267,"end_character":14},"updated":"2019-09-11 16:27:19.000000000","message":"param","commit_id":"2bb91df071e0f0826563a315a9fc035277d6b3c4"},{"author":{"_account_id":23598,"name":"Zhong Luyao","email":"luyao.zhong@intel.com","username":"ZhongLuyao"},"change_message_id":"8cd263c0a5e56f626b462e9dd6ae530fa6aee797","unresolved":false,"context_lines":[{"line_number":264,"context_line":"        and CPUs"},{"line_number":265,"context_line":"        :param migration: A migration object if one was already created"},{"line_number":266,"context_line":"                          elsewhere for this operation (otherwise None)"},{"line_number":267,"context_line":"        :parma allocations: the placement allocation records."},{"line_number":268,"context_line":"        :returns: A Claim ticket representing the reserved resources.  This"},{"line_number":269,"context_line":"        should be turned into finalize  a resource claim or free"},{"line_number":270,"context_line":"        resources after the compute operation is finished."}],"source_content_type":"text/x-python","patch_set":23,"id":"5faad753_4249eecd","line":267,"range":{"start_line":267,"start_character":9,"end_line":267,"end_character":14},"in_reply_to":"5faad753_8417f7ed","updated":"2019-09-11 18:55:18.000000000","message":"Done","commit_id":"2bb91df071e0f0826563a315a9fc035277d6b3c4"},{"author":{"_account_id":23598,"name":"Zhong Luyao","email":"luyao.zhong@intel.com","username":"ZhongLuyao"},"change_message_id":"f17108e0c043a7403eca4d2654813f906f886da8","unresolved":false,"context_lines":[{"line_number":246,"context_line":"                                limits\u003dlimits)"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"    @utils.synchronized(COMPUTE_RESOURCE_SEMAPHORE)"},{"line_number":249,"context_line":"    def live_migration_claim(self, context, instance, nodename, migration,"},{"line_number":250,"context_line":"                             limits):"},{"line_number":251,"context_line":"        \"\"\"Builds a MoveClaim for a live migration."},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"        :param context: The request context."}],"source_content_type":"text/x-python","patch_set":26,"id":"5faad753_bc255ead","line":250,"range":{"start_line":249,"start_character":3,"end_line":250,"end_character":37},"updated":"2019-09-12 06:37:50.000000000","message":"will pass allocations to this also after the live migration change is done.","commit_id":"d5a124b24d78aef9d04719b471edc185615a5349"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"ad5346c468a5f6ba111d39903e378e90425e5cf3","unresolved":false,"context_lines":[{"line_number":262,"context_line":"        # Flavor and image cannot change during a live migration."},{"line_number":263,"context_line":"        instance_type \u003d instance.flavor"},{"line_number":264,"context_line":"        image_meta \u003d instance.image_meta"},{"line_number":265,"context_line":"        # TODO(Luyao) will pass allocations to live_migration_claim after the"},{"line_number":266,"context_line":"        # live migration change is done, now just set it None to _move_claim"},{"line_number":267,"context_line":"        return self._move_claim(context, instance, instance_type, nodename,"},{"line_number":268,"context_line":"                                migration, None, move_type\u003d\u0027live-migration\u0027,"},{"line_number":269,"context_line":"                                image_meta\u003dimage_meta, limits\u003dlimits)"}],"source_content_type":"text/x-python","patch_set":28,"id":"5faad753_d596ecf0","line":266,"range":{"start_line":265,"start_character":8,"end_line":266,"end_character":76},"updated":"2019-09-12 10:23:08.000000000","message":"ack","commit_id":"66f2e0b4f6827d5385b963ee3cc21fba9231bfff"}],"nova/tests/unit/compute/test_compute_mgr.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"83b3c158102a298c553410a51214de71a2c8e4f2","unresolved":false,"context_lines":[{"line_number":6004,"context_line":"                set_error\u003dTrue, cleanup_volumes\u003dTrue,"},{"line_number":6005,"context_line":"                nil_out_host_and_node\u003dTrue)"},{"line_number":6006,"context_line":""},{"line_number":6007,"context_line":"    def test_build_and_run_instance_aborts_on_failed_allocations_get("},{"line_number":6008,"context_line":"            self):"},{"line_number":6009,"context_line":"        self.mock_get_allocs.side_effect \u003d exception.NotFound()"},{"line_number":6010,"context_line":""},{"line_number":6011,"context_line":"        self.assertRaises(exception.BuildAbortException,"},{"line_number":6012,"context_line":"            self.compute._build_and_run_instance,"},{"line_number":6013,"context_line":"                    self.context, self.instance, self.image,"},{"line_number":6014,"context_line":"                    self.injected_files, self.admin_pass,"},{"line_number":6015,"context_line":"                    self.requested_networks, self.security_groups,"},{"line_number":6016,"context_line":"                    self.block_device_mapping, self.node,"},{"line_number":6017,"context_line":"                    self.limits, self.filter_properties)"},{"line_number":6018,"context_line":""},{"line_number":6019,"context_line":"    @mock.patch.object(manager.ComputeManager, \u0027_do_build_and_run_instance\u0027)"},{"line_number":6020,"context_line":"    @mock.patch(\u0027nova.compute.stats.Stats.build_failed\u0027)"}],"source_content_type":"text/x-python","patch_set":11,"id":"7faddb67_7d78097d","line":6017,"range":{"start_line":6007,"start_character":0,"end_line":6017,"end_character":56},"updated":"2019-09-03 16:22:50.000000000","message":"As noted in the file this is testing, I don\u0027t know if this is a viable exception to raise so I think this test can/should be dropped","commit_id":"1187e037f353f575f3d9f15d15686265b5ec7374"},{"author":{"_account_id":23598,"name":"Zhong Luyao","email":"luyao.zhong@intel.com","username":"ZhongLuyao"},"change_message_id":"5604de8d6d2d3eddf9a4e78dea0a17161768ac5d","unresolved":false,"context_lines":[{"line_number":6004,"context_line":"                set_error\u003dTrue, cleanup_volumes\u003dTrue,"},{"line_number":6005,"context_line":"                nil_out_host_and_node\u003dTrue)"},{"line_number":6006,"context_line":""},{"line_number":6007,"context_line":"    def test_build_and_run_instance_aborts_on_failed_allocations_get("},{"line_number":6008,"context_line":"            self):"},{"line_number":6009,"context_line":"        self.mock_get_allocs.side_effect \u003d exception.NotFound()"},{"line_number":6010,"context_line":""},{"line_number":6011,"context_line":"        self.assertRaises(exception.BuildAbortException,"},{"line_number":6012,"context_line":"            self.compute._build_and_run_instance,"},{"line_number":6013,"context_line":"                    self.context, self.instance, self.image,"},{"line_number":6014,"context_line":"                    self.injected_files, self.admin_pass,"},{"line_number":6015,"context_line":"                    self.requested_networks, self.security_groups,"},{"line_number":6016,"context_line":"                    self.block_device_mapping, self.node,"},{"line_number":6017,"context_line":"                    self.limits, self.filter_properties)"},{"line_number":6018,"context_line":""},{"line_number":6019,"context_line":"    @mock.patch.object(manager.ComputeManager, \u0027_do_build_and_run_instance\u0027)"},{"line_number":6020,"context_line":"    @mock.patch(\u0027nova.compute.stats.Stats.build_failed\u0027)"}],"source_content_type":"text/x-python","patch_set":11,"id":"7faddb67_67a70852","line":6017,"range":{"start_line":6007,"start_character":0,"end_line":6017,"end_character":56},"in_reply_to":"7faddb67_7d78097d","updated":"2019-09-04 12:51:59.000000000","message":"Done","commit_id":"1187e037f353f575f3d9f15d15686265b5ec7374"}],"nova/tests/unit/compute/test_resource_tracker.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5602a8b50a26a93dd149448cc13f8a3531f237db","unresolved":false,"context_lines":[{"line_number":474,"context_line":"                   reserved_host_memory_mb\u003d0,"},{"line_number":475,"context_line":"                   reserved_host_cpus\u003d0)"},{"line_number":476,"context_line":"        self.allocations \u003d {"},{"line_number":477,"context_line":"            _COMPUTE_NODE_FIXTURES[0].uuid: {"},{"line_number":478,"context_line":"                \"generation\": 0,"},{"line_number":479,"context_line":"                \"resources\": {"},{"line_number":480,"context_line":"                    \"VCPU\": 1,"}],"source_content_type":"text/x-python","patch_set":20,"id":"5faad753_60ad2730","line":477,"range":{"start_line":477,"start_character":12,"end_line":477,"end_character":34},"updated":"2019-09-10 14:35:57.000000000","message":"A comment about why you\u0027re using this specific UUI would be helpful","commit_id":"c56c8042a812e26ef5e7741f7e1358c3b89d9ae6"},{"author":{"_account_id":23598,"name":"Zhong Luyao","email":"luyao.zhong@intel.com","username":"ZhongLuyao"},"change_message_id":"9af447de8bde1c958549f273fd532bfd2835848c","unresolved":false,"context_lines":[{"line_number":474,"context_line":"                   reserved_host_memory_mb\u003d0,"},{"line_number":475,"context_line":"                   reserved_host_cpus\u003d0)"},{"line_number":476,"context_line":"        self.allocations \u003d {"},{"line_number":477,"context_line":"            _COMPUTE_NODE_FIXTURES[0].uuid: {"},{"line_number":478,"context_line":"                \"generation\": 0,"},{"line_number":479,"context_line":"                \"resources\": {"},{"line_number":480,"context_line":"                    \"VCPU\": 1,"}],"source_content_type":"text/x-python","patch_set":20,"id":"5faad753_912ae88d","line":477,"range":{"start_line":477,"start_character":12,"end_line":477,"end_character":34},"in_reply_to":"5faad753_60ad2730","updated":"2019-09-11 08:13:23.000000000","message":"Actually no special reason.","commit_id":"c56c8042a812e26ef5e7741f7e1358c3b89d9ae6"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b346e111df157644176c57e35846ca35a722345f","unresolved":false,"context_lines":[{"line_number":474,"context_line":"                   reserved_host_memory_mb\u003d0,"},{"line_number":475,"context_line":"                   reserved_host_cpus\u003d0)"},{"line_number":476,"context_line":"        self.allocations \u003d {"},{"line_number":477,"context_line":"            _COMPUTE_NODE_FIXTURES[0].uuid: {"},{"line_number":478,"context_line":"                \"generation\": 0,"},{"line_number":479,"context_line":"                \"resources\": {"},{"line_number":480,"context_line":"                    \"VCPU\": 1,"}],"source_content_type":"text/x-python","patch_set":20,"id":"5faad753_64e9b618","line":477,"range":{"start_line":477,"start_character":12,"end_line":477,"end_character":34},"in_reply_to":"5faad753_60ad2730","updated":"2019-09-10 16:44:32.000000000","message":"UUID","commit_id":"c56c8042a812e26ef5e7741f7e1358c3b89d9ae6"}]}