)]}'
{".zuul.yaml":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8632851619a43f5a4b06b7cbbfcb69af3e916b07","unresolved":false,"context_lines":[{"line_number":265,"context_line":"      - openstack/oslo.versionedobjects"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"- job:"},{"line_number":268,"context_line":"    name: nova-grenade-live-migration"},{"line_number":269,"context_line":"    parent: nova-dsvm-multinode-base"},{"line_number":270,"context_line":"    description: |"},{"line_number":271,"context_line":"      Multi-node grenade job which runs nova/tests/live_migration/hooks tests."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7faddb67_9c744f38","side":"PARENT","line":268,"updated":"2019-08-27 15:43:21.000000000","message":"Just a note to myself that no other projects are using this job in their .zuul.yaml:\n\nhttp://codesearch.openstack.org/?q\u003dnova-grenade-live-migration\u0026i\u003dnope\u0026files\u003d\u0026repos\u003d","commit_id":"912a46c9d4d3a8cc63724adff70acf8a4fc34d9b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c4337e2dacc9ab15b1928a112a018a9c4cca5379","unresolved":false,"context_lines":[{"line_number":269,"context_line":"    parent: nova-dsvm-multinode-base"},{"line_number":270,"context_line":"    description: |"},{"line_number":271,"context_line":"      Multi-node grenade job which runs nova/tests/live_migration/hooks tests."},{"line_number":272,"context_line":"      In other words, this tests live and cold migration  and resize with"},{"line_number":273,"context_line":"      mixed-version compute services which is important for things like"},{"line_number":274,"context_line":"      rolling upgrade support."},{"line_number":275,"context_line":"      The former name for this job was \"nova-grenade-live-migration\"."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7faddb67_9c6a0f7f","line":272,"range":{"start_line":272,"start_character":56,"end_line":272,"end_character":58},"updated":"2019-08-27 15:38:25.000000000","message":"one too many spaces","commit_id":"4c532fb3b793057bf4a371523c02514be9af3a6e"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"a8b92491ca301ded6f1aa23d2882fb1311041854","unresolved":false,"context_lines":[{"line_number":269,"context_line":"    parent: nova-dsvm-multinode-base"},{"line_number":270,"context_line":"    description: |"},{"line_number":271,"context_line":"      Multi-node grenade job which runs nova/tests/live_migration/hooks tests."},{"line_number":272,"context_line":"      In other words, this tests live and cold migration  and resize with"},{"line_number":273,"context_line":"      mixed-version compute services which is important for things like"},{"line_number":274,"context_line":"      rolling upgrade support."},{"line_number":275,"context_line":"      The former name for this job was \"nova-grenade-live-migration\"."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7faddb67_86aff829","line":272,"range":{"start_line":272,"start_character":56,"end_line":272,"end_character":58},"in_reply_to":"7faddb67_9c6a0f7f","updated":"2019-08-29 09:24:19.000000000","message":"Done","commit_id":"4c532fb3b793057bf4a371523c02514be9af3a6e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c4337e2dacc9ab15b1928a112a018a9c4cca5379","unresolved":false,"context_lines":[{"line_number":272,"context_line":"      In other words, this tests live and cold migration  and resize with"},{"line_number":273,"context_line":"      mixed-version compute services which is important for things like"},{"line_number":274,"context_line":"      rolling upgrade support."},{"line_number":275,"context_line":"      The former name for this job was \"nova-grenade-live-migration\"."},{"line_number":276,"context_line":"    run: playbooks/legacy/nova-grenade-live-migration/run.yaml"},{"line_number":277,"context_line":"    post-run: playbooks/legacy/nova-grenade-live-migration/post.yaml"},{"line_number":278,"context_line":"    required-projects:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7faddb67_bc658bb1","line":275,"range":{"start_line":275,"start_character":17,"end_line":275,"end_character":21},"updated":"2019-08-27 15:38:25.000000000","message":"names - and then let\u0027s list both","commit_id":"4c532fb3b793057bf4a371523c02514be9af3a6e"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"a8b92491ca301ded6f1aa23d2882fb1311041854","unresolved":false,"context_lines":[{"line_number":272,"context_line":"      In other words, this tests live and cold migration  and resize with"},{"line_number":273,"context_line":"      mixed-version compute services which is important for things like"},{"line_number":274,"context_line":"      rolling upgrade support."},{"line_number":275,"context_line":"      The former name for this job was \"nova-grenade-live-migration\"."},{"line_number":276,"context_line":"    run: playbooks/legacy/nova-grenade-live-migration/run.yaml"},{"line_number":277,"context_line":"    post-run: playbooks/legacy/nova-grenade-live-migration/post.yaml"},{"line_number":278,"context_line":"    required-projects:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7faddb67_a6aa3417","line":275,"range":{"start_line":275,"start_character":17,"end_line":275,"end_character":21},"in_reply_to":"7faddb67_bc658bb1","updated":"2019-08-29 09:24:19.000000000","message":"Done","commit_id":"4c532fb3b793057bf4a371523c02514be9af3a6e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"de271de7ef087c2f726e3a74f1c4bc163bbe2ada","unresolved":false,"context_lines":[{"line_number":251,"context_line":"    parent: nova-dsvm-multinode-base"},{"line_number":252,"context_line":"    description: |"},{"line_number":253,"context_line":"      Multi-node grenade job which runs nova/tests/live_migration/hooks tests."},{"line_number":254,"context_line":"      In other words, this tests live and cold migration and resize with"},{"line_number":255,"context_line":"      mixed-version compute services which is important for things like"},{"line_number":256,"context_line":"      rolling upgrade support."},{"line_number":257,"context_line":"      The former names for this job were \"nova-grenade-live-migration\" and"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7faddb67_31d3d503","line":254,"range":{"start_line":254,"start_character":38,"end_line":254,"end_character":67},"updated":"2019-08-29 18:23:32.000000000","message":"This isn\u0027t true yet, right? That comes with https://review.opendev.org/#/c/679210/.","commit_id":"6ebfd032c860920f272915362e30cbd231a581a4"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2a3782382e8927f1712ec80318888d47bc490c52","unresolved":false,"context_lines":[{"line_number":251,"context_line":"    parent: nova-dsvm-multinode-base"},{"line_number":252,"context_line":"    description: |"},{"line_number":253,"context_line":"      Multi-node grenade job which runs nova/tests/live_migration/hooks tests."},{"line_number":254,"context_line":"      In other words, this tests live and cold migration and resize with"},{"line_number":255,"context_line":"      mixed-version compute services which is important for things like"},{"line_number":256,"context_line":"      rolling upgrade support."},{"line_number":257,"context_line":"      The former names for this job were \"nova-grenade-live-migration\" and"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7faddb67_d15fe172","line":254,"range":{"start_line":254,"start_character":38,"end_line":254,"end_character":67},"in_reply_to":"7faddb67_31d3d503","updated":"2019-08-29 18:38:36.000000000","message":"Done","commit_id":"6ebfd032c860920f272915362e30cbd231a581a4"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3434bd84a6b6a8047e19a05213f7836b0e38c883","unresolved":false,"context_lines":[{"line_number":255,"context_line":"      services which is important for things like rolling upgrade support."},{"line_number":256,"context_line":"      The former names for this job were \"nova-grenade-live-migration\" and"},{"line_number":257,"context_line":"      \"legacy-grenade-dsvm-neutron-multinode-live-migration\"."},{"line_number":258,"context_line":"    run: playbooks/legacy/nova-grenade-live-migration/run.yaml"},{"line_number":259,"context_line":"    post-run: playbooks/legacy/nova-grenade-live-migration/post.yaml"},{"line_number":260,"context_line":"    required-projects:"},{"line_number":261,"context_line":"      - openstack/grenade"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7faddb67_8c1f0e5a","line":258,"range":{"start_line":258,"start_character":26,"end_line":258,"end_character":53},"updated":"2019-08-29 18:49:28.000000000","message":"We should also rename this path.","commit_id":"1cd16bd2fa28335db2adb34355f3d117bc39d87c"}],"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c4337e2dacc9ab15b1928a112a018a9c4cca5379","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Balazs Gibizer \u003cbalazs.gibizer@est.tech\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-08-27 15:37:45 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add resize tests to nova-grenade job"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"To cover resize and migrate RPC changes in nova with grenade this patch"},{"line_number":10,"context_line":"renames the nova-grenade-live-migration job to nova-grenade-multinode"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_dc47271e","line":7,"range":{"start_line":7,"start_character":20,"end_line":7,"end_character":32},"updated":"2019-08-27 15:38:25.000000000","message":"nova-grenade-multinode\n\nThe commit message title doesn\u0027t really convey the rename of the job - maybe split that into a separate change before this one that adds the resize test to the job in case we need to revert the latter for some reason?","commit_id":"4c532fb3b793057bf4a371523c02514be9af3a6e"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"a8b92491ca301ded6f1aa23d2882fb1311041854","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Balazs Gibizer \u003cbalazs.gibizer@est.tech\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-08-27 15:37:45 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add resize tests to nova-grenade job"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"To cover resize and migrate RPC changes in nova with grenade this patch"},{"line_number":10,"context_line":"renames the nova-grenade-live-migration job to nova-grenade-multinode"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_69708f41","line":7,"range":{"start_line":7,"start_character":20,"end_line":7,"end_character":32},"in_reply_to":"7faddb67_dc47271e","updated":"2019-08-29 09:24:19.000000000","message":"Done","commit_id":"4c532fb3b793057bf4a371523c02514be9af3a6e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c4337e2dacc9ab15b1928a112a018a9c4cca5379","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"To cover resize and migrate RPC changes in nova with grenade this patch"},{"line_number":10,"context_line":"renames the nova-grenade-live-migration job to nova-grenade-multinode"},{"line_number":11,"context_line":"and adds runs the resize tempest tests as part of the job."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Changes in [1] could potentially break a mixed-compute-version"},{"line_number":14,"context_line":"environment as we don\u0027t have grenade coverage."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_fc42230d","line":11,"range":{"start_line":11,"start_character":4,"end_line":11,"end_character":8},"updated":"2019-08-27 15:38:25.000000000","message":"nix","commit_id":"4c532fb3b793057bf4a371523c02514be9af3a6e"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"a8b92491ca301ded6f1aa23d2882fb1311041854","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"To cover resize and migrate RPC changes in nova with grenade this patch"},{"line_number":10,"context_line":"renames the nova-grenade-live-migration job to nova-grenade-multinode"},{"line_number":11,"context_line":"and adds runs the resize tempest tests as part of the job."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Changes in [1] could potentially break a mixed-compute-version"},{"line_number":14,"context_line":"environment as we don\u0027t have grenade coverage."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_29905742","line":11,"range":{"start_line":11,"start_character":4,"end_line":11,"end_character":8},"in_reply_to":"7faddb67_fc42230d","updated":"2019-08-29 09:24:19.000000000","message":"Done","commit_id":"4c532fb3b793057bf4a371523c02514be9af3a6e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"de271de7ef087c2f726e3a74f1c4bc163bbe2ada","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Rename the nova-grenade-live-migration job to nova-grenade-multinode"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This job tests more that just live migration and we are planning to"},{"line_number":10,"context_line":"add even more multinode tests to it. So this patch renames the job to"},{"line_number":11,"context_line":"better reflect what the job covers."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7faddb67_d18cc12f","line":9,"range":{"start_line":9,"start_character":20,"end_line":9,"end_character":24},"updated":"2019-08-29 18:23:32.000000000","message":"than\n\nAlso, I don\u0027t think this job tests more than live migration right? It\u0027s the nova-live-migration job that runs the test_evacuate.sh script.\n\nThis change https://review.opendev.org/#/c/604400/ would make the grenade job run evacuate tests also, but I\u0027ve stalled out on that for now.","commit_id":"6ebfd032c860920f272915362e30cbd231a581a4"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2a3782382e8927f1712ec80318888d47bc490c52","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Rename the nova-grenade-live-migration job to nova-grenade-multinode"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This job tests more that just live migration and we are planning to"},{"line_number":10,"context_line":"add even more multinode tests to it. So this patch renames the job to"},{"line_number":11,"context_line":"better reflect what the job covers."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7faddb67_f1621d3d","line":9,"range":{"start_line":9,"start_character":20,"end_line":9,"end_character":24},"in_reply_to":"7faddb67_d18cc12f","updated":"2019-08-29 18:38:36.000000000","message":"Done","commit_id":"6ebfd032c860920f272915362e30cbd231a581a4"}],"nova/tests/live_migration/hooks/run_tests.sh":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c4337e2dacc9ab15b1928a112a018a9c4cca5379","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"echo \u00275. test cold migration and resize\u0027"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"run_tempest \"cold migration and resize test\" \"test_resize_server\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"7faddb67_7cbcf3da","line":65,"updated":"2019-08-27 15:38:25.000000000","message":"Will this actually test cold migration or just resize?\n\nA couple other things here:\n\n1. This script runs some tests with a default devstack configuration which is local disk and lvm volumes and does block migration, then re-configures the environment for ceph and tests using shared storage, but you\u0027ve only hit the latter. So if we want to test the former for cold migration and resize as well, you need to run this earlier before we re-configure for ceph.\n\n2. This script is also used by the nova-live-migration job, so simply adding this here but leaving the nova-live-migration job with that name when it runs more than live migration (actually that job already runs more than live migration, it also runs evacuate testing [1]), is a bit confusing. So for now, I think we should somehow make this conditional to only run for the grenade job until/unless we rename the nova-live-migration job to nova-multinode later. I think you can do that by inspecting if there is a grenade environment variable defined, like GRENADE_PHASE [2].\n\n[1] https://github.com/openstack/nova/blob/912a46c9d4d3a8cc63724adff70acf8a4fc34d9b/playbooks/legacy/nova-live-migration/run.yaml#L52\n[2] https://ac13160b9f6505cb4f48-58ad23e4ce64c146e6acb1a522568306.ssl.cf1.rackcdn.com/663851/42/check/nova-grenade-live-migration/ef84274/logs/old/local_conf.txt.gz","commit_id":"4c532fb3b793057bf4a371523c02514be9af3a6e"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"a8b92491ca301ded6f1aa23d2882fb1311041854","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"echo \u00275. test cold migration and resize\u0027"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"run_tempest \"cold migration and resize test\" \"test_resize_server\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"7faddb67_e9ab1f85","line":65,"in_reply_to":"7faddb67_7cbcf3da","updated":"2019-08-29 09:24:19.000000000","message":"* split this commit into two so this change is now in [1]\n\n* added cold migrate to the regexp now\n\n1) moved the test run earlier in the script\n2) added a conditional as you suggested.\n\n\n[1] https://review.opendev.org/#/c/679210/","commit_id":"4c532fb3b793057bf4a371523c02514be9af3a6e"}]}