)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"8fa28b0cf6f71d56ace886b89079f5df55c01aea","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sahid Orentino Ferdjaoui \u003csahid.ferdjaoui@cloudwatt.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-01-20 19:49:18 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"libvirt, finsih_migration could be faster"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"finish_migration is called with a parameter resize_instance"},{"line_number":10,"context_line":"it should be used to know if it is necessary to resize of not"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAUH%2F%2B3ec%3D","line":7,"updated":"2014-01-21 09:40:49.000000000","message":"This is a totally meaningless subject line. Please describe what the change is doing eg\n\n  \"Skip resizing disks when finishing migration unless explicitly requested\"","commit_id":"947c4f491ec48cfe3e311ba91195c9fc141c793c"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"58135c75b9d8e4fb29cedd83734a27269a4e1535","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sahid Orentino Ferdjaoui \u003csahid.ferdjaoui@cloudwatt.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-01-20 19:49:18 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"libvirt, finsih_migration could be faster"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"finish_migration is called with a parameter resize_instance"},{"line_number":10,"context_line":"it should be used to know if it is necessary to resize of not"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAUH%2F%2B3bs%3D","line":7,"in_reply_to":"AAAAUH%2F%2B3ec%3D","updated":"2014-01-21 09:45:52.000000000","message":"Sure Daniel, Actually i\u0027m working on. This is a \"draft\" I wanted to get advices from the community to know if my assumption was good. I will add tests and refactor the code.","commit_id":"947c4f491ec48cfe3e311ba91195c9fc141c793c"}],"nova/tests/virt/libvirt/test_libvirt.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"b66666aba734856e1f2af1941591ad60fb4e4525","unresolved":false,"context_lines":[{"line_number":8209,"context_line":"        inst \u003d {\u0027root_gb\u0027: 10, \u0027ephemeral_gb\u0027: 20, \u0027swap_gb\u0027: 30}"},{"line_number":8210,"context_line":""},{"line_number":8211,"context_line":"        info \u003d {\u0027path\u0027: \u0027/path/disk\u0027}"},{"line_number":8212,"context_line":"        self.assertEqual("},{"line_number":8213,"context_line":"            self.libvirtconnection._disk_size_from_instance(inst, info),"},{"line_number":8214,"context_line":"            10 * units.Gi)"},{"line_number":8215,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAWn%2F%2F7I0%3D","line":8212,"updated":"2014-04-08 13:25:22.000000000","message":"if you need to make a change then please have the expected value first","commit_id":"9cecdeb85a5ea852ebda85060d75e169d7a7536c"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"7096fae9e2368a9d773986e3640dab35ae47894b","unresolved":false,"context_lines":[{"line_number":8209,"context_line":"        inst \u003d {\u0027root_gb\u0027: 10, \u0027ephemeral_gb\u0027: 20, \u0027swap_gb\u0027: 30}"},{"line_number":8210,"context_line":""},{"line_number":8211,"context_line":"        info \u003d {\u0027path\u0027: \u0027/path/disk\u0027}"},{"line_number":8212,"context_line":"        self.assertEqual("},{"line_number":8213,"context_line":"            self.libvirtconnection._disk_size_from_instance(inst, info),"},{"line_number":8214,"context_line":"            10 * units.Gi)"},{"line_number":8215,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAWn%2F%2F5Yc%3D","line":8212,"in_reply_to":"AAAAWn%2F%2F7I0%3D","updated":"2014-04-08 16:51:06.000000000","message":"I didn\u0027t not pay attention of this rule. I\u0027m waiting until tomorrow to get new commenys and I will upload a new patchset to address your comments.","commit_id":"9cecdeb85a5ea852ebda85060d75e169d7a7536c"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"b66666aba734856e1f2af1941591ad60fb4e4525","unresolved":false,"context_lines":[{"line_number":8215,"context_line":""},{"line_number":8216,"context_line":"        info \u003d {\u0027path\u0027: \u0027/path/disk.local\u0027}"},{"line_number":8217,"context_line":"        self.assertEqual("},{"line_number":8218,"context_line":"            self.libvirtconnection._disk_size_from_instance(inst, info),"},{"line_number":8219,"context_line":"            20 * units.Gi)"},{"line_number":8220,"context_line":""},{"line_number":8221,"context_line":"        info \u003d {\u0027path\u0027: \u0027/path/disk.swap\u0027}"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAWn%2F%2F7Is%3D","line":8218,"updated":"2014-04-08 13:25:22.000000000","message":"ditto","commit_id":"9cecdeb85a5ea852ebda85060d75e169d7a7536c"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"b66666aba734856e1f2af1941591ad60fb4e4525","unresolved":false,"context_lines":[{"line_number":8220,"context_line":""},{"line_number":8221,"context_line":"        info \u003d {\u0027path\u0027: \u0027/path/disk.swap\u0027}"},{"line_number":8222,"context_line":"        self.assertEqual("},{"line_number":8223,"context_line":"            self.libvirtconnection._disk_size_from_instance(inst, info), 0)"},{"line_number":8224,"context_line":""},{"line_number":8225,"context_line":"    def _test_finish_migration(self, power_on):"},{"line_number":8226,"context_line":"        \"\"\"Test for nova.virt.libvirt.libvirt_driver.LivirtConnection"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAWn%2F%2F7Ic%3D","line":8223,"updated":"2014-04-08 13:25:22.000000000","message":"ditto","commit_id":"9cecdeb85a5ea852ebda85060d75e169d7a7536c"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"b714b01d07fca0c4ae1f4943db8f4841ac7e2b9f","unresolved":false,"context_lines":[{"line_number":4705,"context_line":"                         block_device_info\u003dNone, power_on\u003dTrue):"},{"line_number":4706,"context_line":"        LOG.debug(_(\"Starting finish_migration\"), instance\u003dinstance)"},{"line_number":4707,"context_line":""},{"line_number":4708,"context_line":"        if resize_instance:"},{"line_number":4709,"context_line":"            # resize disks. only \"disk\" and \"disk.local\" are necessary."},{"line_number":4710,"context_line":"            disk_info \u003d jsonutils.loads(disk_info)"},{"line_number":4711,"context_line":"            for info in disk_info:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2B6u8%3D","line":4708,"updated":"2014-01-20 19:04:14.000000000","message":"To avoid getting really deep nesting, I think everything under this if should be broken out into a helper function.","commit_id":"947c4f491ec48cfe3e311ba91195c9fc141c793c"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"3dd051d82ac794dda09312e2b421aa592e3b161c","unresolved":false,"context_lines":[{"line_number":4705,"context_line":"                         block_device_info\u003dNone, power_on\u003dTrue):"},{"line_number":4706,"context_line":"        LOG.debug(_(\"Starting finish_migration\"), instance\u003dinstance)"},{"line_number":4707,"context_line":""},{"line_number":4708,"context_line":"        if resize_instance:"},{"line_number":4709,"context_line":"            # resize disks. only \"disk\" and \"disk.local\" are necessary."},{"line_number":4710,"context_line":"            disk_info \u003d jsonutils.loads(disk_info)"},{"line_number":4711,"context_line":"            for info in disk_info:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2B6ug%3D","line":4708,"in_reply_to":"AAAAUH%2F%2B6u8%3D","updated":"2014-01-20 19:06:03.000000000","message":"Sure, it could be really better...","commit_id":"947c4f491ec48cfe3e311ba91195c9fc141c793c"},{"author":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"change_message_id":"64a45a9f445cadf49e0dfa2a0c2f6cce2f987ef2","unresolved":false,"context_lines":[{"line_number":4708,"context_line":"            size \u003d instance[\u0027ephemeral_gb\u0027]"},{"line_number":4709,"context_line":"        else:"},{"line_number":4710,"context_line":"            size \u003d 0"},{"line_number":4711,"context_line":"        return (size * unit.Gi)"},{"line_number":4712,"context_line":""},{"line_number":4713,"context_line":"    def _resize_instance(self, instance, disk_info):"},{"line_number":4714,"context_line":"        # resize disks. only \"disk\" and \"disk.local\" are necessary."}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2BxIw%3D","line":4711,"updated":"2014-01-22 10:44:40.000000000","message":"brackets are redundant","commit_id":"3bfa23a2e53919758a2b83249a8ced6a403fde79"},{"author":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"change_message_id":"16d4c9dc2106448a12ff3a29e34917e590ceb4b3","unresolved":false,"context_lines":[{"line_number":4708,"context_line":"            size \u003d instance[\u0027ephemeral_gb\u0027]"},{"line_number":4709,"context_line":"        else:"},{"line_number":4710,"context_line":"            size \u003d 0"},{"line_number":4711,"context_line":"        return (size * unit.Gi)"},{"line_number":4712,"context_line":""},{"line_number":4713,"context_line":"    def _resize_instance(self, instance, disk_info):"},{"line_number":4714,"context_line":"        # resize disks. only \"disk\" and \"disk.local\" are necessary."}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2Bpqo%3D","line":4711,"in_reply_to":"AAAAUH%2F%2BxFA%3D","updated":"2014-01-23 14:52:47.000000000","message":"only if you need to respin for other reasons","commit_id":"3bfa23a2e53919758a2b83249a8ced6a403fde79"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"c1a8e5692e0eb0149c5dd3c8c37f8663e30d3de2","unresolved":false,"context_lines":[{"line_number":4708,"context_line":"            size \u003d instance[\u0027ephemeral_gb\u0027]"},{"line_number":4709,"context_line":"        else:"},{"line_number":4710,"context_line":"            size \u003d 0"},{"line_number":4711,"context_line":"        return (size * unit.Gi)"},{"line_number":4712,"context_line":""},{"line_number":4713,"context_line":"    def _resize_instance(self, instance, disk_info):"},{"line_number":4714,"context_line":"        # resize disks. only \"disk\" and \"disk.local\" are necessary."}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2BxFA%3D","line":4711,"in_reply_to":"AAAAUH%2F%2BxIw%3D","updated":"2014-01-22 10:54:10.000000000","message":"Thanks to take time for this review draidbrady, Do you want I publish a new patchset without brackets?","commit_id":"3bfa23a2e53919758a2b83249a8ced6a403fde79"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"25fcc4565824e03b6ab6d22334441662a3dac091","unresolved":false,"context_lines":[{"line_number":4760,"context_line":"            size \u003d instance[\u0027ephemeral_gb\u0027]"},{"line_number":4761,"context_line":"        else:"},{"line_number":4762,"context_line":"            size \u003d 0"},{"line_number":4763,"context_line":"        return (size * units.Gi)"},{"line_number":4764,"context_line":""},{"line_number":4765,"context_line":"    def _resize_instance(self, instance, disk_info):"},{"line_number":4766,"context_line":"        # resize disks. only \"disk\" and \"disk.local\" are necessary."}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F9hZ8%3D","line":4763,"updated":"2014-02-06 10:38:46.000000000","message":"brackets are redundant","commit_id":"af3d0344f8a480f8ed30f904b88301225c3ddc6e"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"655aba49043f831267782b2b91043e57806b0e4b","unresolved":false,"context_lines":[{"line_number":4760,"context_line":"            size \u003d instance[\u0027ephemeral_gb\u0027]"},{"line_number":4761,"context_line":"        else:"},{"line_number":4762,"context_line":"            size \u003d 0"},{"line_number":4763,"context_line":"        return (size * units.Gi)"},{"line_number":4764,"context_line":""},{"line_number":4765,"context_line":"    def _resize_instance(self, instance, disk_info):"},{"line_number":4766,"context_line":"        # resize disks. only \"disk\" and \"disk.local\" are necessary."}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F9hSY%3D","line":4763,"in_reply_to":"AAAAUH%2F9hZ8%3D","updated":"2014-02-06 10:46:51.000000000","message":"@p-draigbrady\t told me about it. Ok i\u0027m going to remove it","commit_id":"af3d0344f8a480f8ed30f904b88301225c3ddc6e"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"25fcc4565824e03b6ab6d22334441662a3dac091","unresolved":false,"context_lines":[{"line_number":4799,"context_line":""},{"line_number":4800,"context_line":"        if resize_instance:"},{"line_number":4801,"context_line":"            self._resize_instance("},{"line_number":4802,"context_line":"                instance, jsonutils.loads(disk_info))"},{"line_number":4803,"context_line":""},{"line_number":4804,"context_line":"        disk_info \u003d blockinfo.get_disk_info(CONF.libvirt.virt_type,"},{"line_number":4805,"context_line":"                                            instance,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F9hZU%3D","line":4802,"updated":"2014-02-06 10:38:46.000000000","message":"I think this can be merged to one line","commit_id":"af3d0344f8a480f8ed30f904b88301225c3ddc6e"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"655aba49043f831267782b2b91043e57806b0e4b","unresolved":false,"context_lines":[{"line_number":4799,"context_line":""},{"line_number":4800,"context_line":"        if resize_instance:"},{"line_number":4801,"context_line":"            self._resize_instance("},{"line_number":4802,"context_line":"                instance, jsonutils.loads(disk_info))"},{"line_number":4803,"context_line":""},{"line_number":4804,"context_line":"        disk_info \u003d blockinfo.get_disk_info(CONF.libvirt.virt_type,"},{"line_number":4805,"context_line":"                                            instance,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F9hSQ%3D","line":4802,"in_reply_to":"AAAAUH%2F9hZU%3D","updated":"2014-02-06 10:46:51.000000000","message":"I guess too.","commit_id":"af3d0344f8a480f8ed30f904b88301225c3ddc6e"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"0dbff5699a8a2149deb85f09c5448b0c87e7711e","unresolved":false,"context_lines":[{"line_number":4790,"context_line":"                path_qcow \u003d info[\u0027path\u0027] + \u0027_qcow\u0027"},{"line_number":4791,"context_line":"                utils.execute(\u0027qemu-img\u0027, \u0027convert\u0027, \u0027-f\u0027, \u0027raw\u0027,"},{"line_number":4792,"context_line":"                              \u0027-O\u0027, \u0027qcow2\u0027, info[\u0027path\u0027], path_qcow)"},{"line_number":4793,"context_line":"                utils.execute(\u0027mv\u0027, path_qcow, info[\u0027path\u0027])"},{"line_number":4794,"context_line":""},{"line_number":4795,"context_line":"    def finish_migration(self, context, migration, instance, disk_info,"},{"line_number":4796,"context_line":"                         network_info, image_meta, resize_instance,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F9Wxw%3D","line":4793,"updated":"2014-02-07 14:09:58.000000000","message":"will above code logic (if fmt \u003d\u003d \u0027raw\u0027 and CONF.use_cow_images:)\nbe affected if \u0027resize_instance\u0027 is False? \n\noriginally, it will be executed whenever resize_instance is True or False, but after your change, it will be executed only when it\u0027s True","commit_id":"02bffc4bc440194571ae51bd62bc17cf5acea524"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"8d00a084f70721701075e11451faa5cfe5203815","unresolved":false,"context_lines":[{"line_number":4790,"context_line":"                path_qcow \u003d info[\u0027path\u0027] + \u0027_qcow\u0027"},{"line_number":4791,"context_line":"                utils.execute(\u0027qemu-img\u0027, \u0027convert\u0027, \u0027-f\u0027, \u0027raw\u0027,"},{"line_number":4792,"context_line":"                              \u0027-O\u0027, \u0027qcow2\u0027, info[\u0027path\u0027], path_qcow)"},{"line_number":4793,"context_line":"                utils.execute(\u0027mv\u0027, path_qcow, info[\u0027path\u0027])"},{"line_number":4794,"context_line":""},{"line_number":4795,"context_line":"    def finish_migration(self, context, migration, instance, disk_info,"},{"line_number":4796,"context_line":"                         network_info, image_meta, resize_instance,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F9WYI%3D","line":4793,"in_reply_to":"AAAAUH%2F9Wxw%3D","updated":"2014-02-07 15:09:46.000000000","message":"You are completely right jichenjc, ...I don\u0027t know if we have to update the disk type during the migration, if we don\u0027t have to update the disk size. \n\nWe need some other comments to know what we have to do.\n@p-draigbrady perhaps you can help us?","commit_id":"02bffc4bc440194571ae51bd62bc17cf5acea524"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"fd48d32c79baaa75e72ada9848598827e8eebeaf","unresolved":false,"context_lines":[{"line_number":4821,"context_line":"            fname \u003d os.path.basename(info[\u0027path\u0027])"},{"line_number":4822,"context_line":"            # resize disks. only \"disk\" and \"disk.local\" are necessary."},{"line_number":4823,"context_line":"            if resize_instance and fname in (\u0027disk\u0027, \u0027disk.local\u0027):"},{"line_number":4824,"context_line":"                self._resize_disk_instance(instance, info)"},{"line_number":4825,"context_line":"            if CONF.use_cow_images and info[\u0027type\u0027] \u003d\u003d \u0027raw\u0027:"},{"line_number":4826,"context_line":"                self._convert_disk_instance(instance, info)"},{"line_number":4827,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAUX%2F%2BuGs%3D","line":4824,"updated":"2014-02-19 15:43:01.000000000","message":"Previously the resizing of disks was done unconditionally. Now you\u0027re only doing it for certain disk names.\n\nI think it would be nice if this patch was split into 2 parts. First a patch which does the refactoring of \u0027finish_migration\u0027 into separate methods but with *no* functional change. Second a patch which does any functional change that might be required.","commit_id":"a92588014e8832efb9dc373d21b2e0506cf9826c"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"bba4a45f9fa90b491d3951be703e6e779f271c57","unresolved":false,"context_lines":[{"line_number":4821,"context_line":"            fname \u003d os.path.basename(info[\u0027path\u0027])"},{"line_number":4822,"context_line":"            # resize disks. only \"disk\" and \"disk.local\" are necessary."},{"line_number":4823,"context_line":"            if resize_instance and fname in (\u0027disk\u0027, \u0027disk.local\u0027):"},{"line_number":4824,"context_line":"                self._resize_disk_instance(instance, info)"},{"line_number":4825,"context_line":"            if CONF.use_cow_images and info[\u0027type\u0027] \u003d\u003d \u0027raw\u0027:"},{"line_number":4826,"context_line":"                self._convert_disk_instance(instance, info)"},{"line_number":4827,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAUX%2F%2BtKU%3D","line":4824,"in_reply_to":"AAAAUX%2F%2BuGs%3D","updated":"2014-02-19 17:18:43.000000000","message":"indeed, this imply a lot of change and it could be better to do it in two patchsets.","commit_id":"a92588014e8832efb9dc373d21b2e0506cf9826c"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"cd904d0a71da82ea1177eeba2d77542af6a5079e","unresolved":false,"context_lines":[{"line_number":4852,"context_line":""},{"line_number":4853,"context_line":"        Returns the disk size by using the disk name to determine whether it"},{"line_number":4854,"context_line":"        is a root or an ephemeral disk, then by checking properties of the"},{"line_number":4855,"context_line":"        instance returns the size converted to megabytes."},{"line_number":4856,"context_line":""},{"line_number":4857,"context_line":"        Returns 0 if the disk name not match (disk, disk.local)."},{"line_number":4858,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAVn%2F%2FE%2Fg%3D","line":4855,"updated":"2014-03-10 05:24:32.000000000","message":"I think it\u0027s gigabytes, right?","commit_id":"48c65afc79957999c7f5c60b214be40ff006025c"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"5a48b28499ad42109c8129e5d8813774348f8881","unresolved":false,"context_lines":[{"line_number":4852,"context_line":""},{"line_number":4853,"context_line":"        Returns the disk size by using the disk name to determine whether it"},{"line_number":4854,"context_line":"        is a root or an ephemeral disk, then by checking properties of the"},{"line_number":4855,"context_line":"        instance returns the size converted to megabytes."},{"line_number":4856,"context_line":""},{"line_number":4857,"context_line":"        Returns 0 if the disk name not match (disk, disk.local)."},{"line_number":4858,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAVn%2F%2FDM0%3D","line":4855,"in_reply_to":"AAAAVn%2F%2FE%2Fg%3D","updated":"2014-03-10 12:22:26.000000000","message":"Actually it\u0027s in bytes ;)","commit_id":"48c65afc79957999c7f5c60b214be40ff006025c"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"610cae44a35289d58b58d1b8f47c190b1e3267f0","unresolved":false,"context_lines":[{"line_number":4873,"context_line":"        # resize disks. only \"disk\" and \"disk.local\" are necessary."},{"line_number":4874,"context_line":"        disk_info \u003d jsonutils.loads(disk_info)"},{"line_number":4875,"context_line":"        for info in disk_info:"},{"line_number":4876,"context_line":"            size \u003d self._disk_size_from_instance(instance, info)"},{"line_number":4877,"context_line":""},{"line_number":4878,"context_line":"            # If we have a non partitioned image that we can extend"},{"line_number":4879,"context_line":"            # then ensure we\u0027re in \u0027raw\u0027 format so we can extend file system."}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAWH%2F%2FW2Y%3D","line":4876,"updated":"2014-03-18 12:06:59.000000000","message":"Another option could be:\nLibvirtDriver._disk_size_from_instance(instance, info)\nBut I guess that this is 6 of one and half a dozen of the other","commit_id":"b7c4e68da6c417875f612877ddc36efd15564c3a"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"db62dba5f389c5a0e339d72251ccd440d98a24ec","unresolved":false,"context_lines":[{"line_number":4873,"context_line":"        # resize disks. only \"disk\" and \"disk.local\" are necessary."},{"line_number":4874,"context_line":"        disk_info \u003d jsonutils.loads(disk_info)"},{"line_number":4875,"context_line":"        for info in disk_info:"},{"line_number":4876,"context_line":"            size \u003d self._disk_size_from_instance(instance, info)"},{"line_number":4877,"context_line":""},{"line_number":4878,"context_line":"            # If we have a non partitioned image that we can extend"},{"line_number":4879,"context_line":"            # then ensure we\u0027re in \u0027raw\u0027 format so we can extend file system."}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAWH%2F%2FWZ0%3D","line":4876,"in_reply_to":"AAAAWH%2F%2FW2Y%3D","updated":"2014-03-18 13:05:08.000000000","message":"Actually because it is a private method I have used self._disk_size...\nThis comes from a previously comment of Daniel about using self instead of LibvirtDriver.","commit_id":"b7c4e68da6c417875f612877ddc36efd15564c3a"}]}