)]}'
{"gate/live_migration/hooks/run_tests.sh":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1e33953bf51aeb8c03174154aae4cecc506107b3","unresolved":false,"context_lines":[{"line_number":43,"context_line":"#run_tempest  \"NFS shared storage test\" \"live_migration\""},{"line_number":44,"context_line":"#nfs_teardown"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"if [ -n \"$GRENADE_PHASE\" ]; then"},{"line_number":47,"context_line":"    echo \u00273. test cold migration and resize\u0027"},{"line_number":48,"context_line":"    run_tempest \"cold migration and resize test\" \"test_resize_server|test_cold_migration|test_revert_cold_migration\""},{"line_number":49,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":2,"id":"7faddb67_31dd15dd","line":46,"updated":"2019-08-29 18:42:14.000000000","message":"Would be good to have a comment about why this is conditional.","commit_id":"6d05234419e20ec7bb7b12530ed5fbc21718b532"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1e33953bf51aeb8c03174154aae4cecc506107b3","unresolved":false,"context_lines":[{"line_number":46,"context_line":"if [ -n \"$GRENADE_PHASE\" ]; then"},{"line_number":47,"context_line":"    echo \u00273. test cold migration and resize\u0027"},{"line_number":48,"context_line":"    run_tempest \"cold migration and resize test\" \"test_resize_server|test_cold_migration|test_revert_cold_migration\""},{"line_number":49,"context_line":"fi"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"echo \u00274. test with Ceph for root + ephemeral disks\u0027"},{"line_number":52,"context_line":"# Discover and set variables for the OS version so the devstack-plugin-ceph"}],"source_content_type":"text/x-sh","patch_set":2,"id":"7faddb67_31a4354b","line":49,"updated":"2019-08-29 18:42:14.000000000","message":"nit: echo an else here that we skip 3. for the live migration job","commit_id":"6d05234419e20ec7bb7b12530ed5fbc21718b532"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"b12ed6ceb94845de015de84121f09bfc0cd11a82","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"# The nova-grenade-multinode job also runs resize and cold migration tests"},{"line_number":47,"context_line":"# so we check for a grenade-only variable."},{"line_number":48,"context_line":"if [[ -n \"$GRENADE_PHASE\" ]]; then"},{"line_number":49,"context_line":"    echo \u00273. test cold migration and resize\u0027"},{"line_number":50,"context_line":"    run_tempest \"cold migration and resize test\" \"test_resize_server|test_cold_migration|test_revert_cold_migration\""},{"line_number":51,"context_line":"else"}],"source_content_type":"text/x-sh","patch_set":4,"id":"7faddb67_bd99d01e","line":48,"updated":"2019-08-30 09:01:00.000000000","message":"It seems this conditional does not work as intended\nhttps://zuul.opendev.org/t/openstack/build/45e67c66107340c19cbdad96ceeff830/log/job-output.txt#6493","commit_id":"4c50b684b9aa5bad58e43fd96b70e851d2e76799"}]}