)]}'
{"id":"openstack%2Fnova~679274","triplet_id":"openstack%2Fnova~stable%2Fqueens~I6b33fcbc4d616dcc9b126ed744846acf2b56c5af","project":"openstack/nova","branch":"stable/queens","topic":"bug/1751923","hashtags":[],"change_id":"I6b33fcbc4d616dcc9b126ed744846acf2b56c5af","subject":"Force refresh instance info_cache during heal","status":"ABANDONED","created":"2019-08-29 14:37:02.000000000","updated":"2022-11-11 18:24:48.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"8912e13108ecfc17afa9af9732027448500a7541","_number":679274,"virtual_id_number":679274,"owner":{"_account_id":6737,"name":"Edward Hope-Morley","email":"edward.hope-morley@canonical.com","username":"hopem"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"date":"2019-08-31 16:07:53.000000000","_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"date":"2019-08-29 20:05:36.000000000","_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"date":"2019-08-29 16:47:29.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":-1,"date":"2019-08-29 20:41:23.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"rejected":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"all":[{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":-1,"date":"2019-08-30 13:33:31.000000000","_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-08-29 16:47:29.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-08-29 20:05:36.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"REVIEWER"},{"updated":"2019-08-29 20:41:23.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-08-30 13:33:31.000000000","updated_by":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"reviewer":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"state":"REVIEWER"},{"updated":"2019-08-31 16:07:53.000000000","updated_by":{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"ef9eeaf09dd4b05a557fc770f24dca8899ae5df6","author":{"_account_id":6737,"name":"Edward Hope-Morley","email":"edward.hope-morley@canonical.com","username":"hopem"},"date":"2019-08-29 14:37:02.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"87152d76be51a65ee58a254fce391bef88c40769","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2019-08-29 16:47:29.000000000","message":"Patch Set 1:\n\nBuild failed. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm: recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-xenial https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/74/679274/1/check/tempest-dsvm-full-xenial/9e1d8c9/ : FAILURE in 1h 33m 56s\n- tempest-dsvm-full-xenial-py3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/74/679274/1/check/tempest-dsvm-full-xenial-py3/e95cd78/ : FAILURE in 1h 46m 20s (non-voting)\n- grenade-dsvm-xenial https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/74/679274/1/check/grenade-dsvm-xenial/56ede89/ : SUCCESS in 1h 26m 26s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"8179ca71a4eaf491633f518738952fcac3c391eb","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2019-08-29 20:05:36.000000000","message":"Patch Set 1:\n\nFor rechecking only on the Cloudbase Nova Hyper-V CI, add a review comment with run-Cloudbase Nova Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/679274/1 : FAILURE in 1h 17m 50s","accounts_in_message":[],"_revision_number":1},{"id":"9d6fba7e93de762f2d8ab88c86b4a86daa208800","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-29 20:41:23.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/0676956b700b4134808e3693fdf4ad77 : SUCCESS in 15m 04s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/be810dccf94244f59d7f33f14fc8f917 : SUCCESS in 15m 01s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/8d3452c85e954f56a50693faef991631 : SUCCESS in 16m 23s\n- build-openstack-sphinx-docs https://zuul.opendev.org/t/openstack/build/48c8718347614741b49dc52bca368a97 : SUCCESS in 11m 12s\n- tempest-full https://zuul.opendev.org/t/openstack/build/7918732a3c984ed0927e59084bffb703 : FAILURE in 1h 22m 09s\n- neutron-grenade https://zuul.opendev.org/t/openstack/build/ab2d24b7c0de40d3865f6f333b531fa8 : SUCCESS in 1h 05m 25s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/cae16b6cfff04179aa9e218523281aa9 : FAILURE in 1h 09m 49s\n- ironic-tempest-dsvm-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/d2c65256ebf143eca4c69e8454250b24 : SUCCESS in 56m 05s (non-voting)\n- nova-cells-v1 https://zuul.opendev.org/t/openstack/build/9c726bfaa56647409f254e38a13068a6 : SUCCESS in 47m 39s\n- nova-grenade-live-migration https://zuul.opendev.org/t/openstack/build/81aacccb6cce4a35a86990082d21c640 : SUCCESS in 1h 05m 49s (non-voting)\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/d52eed0adaa44af1a6dce853f931885e : SUCCESS in 52m 26s\n- nova-multiattach https://zuul.opendev.org/t/openstack/build/39241bc865cf43ae8c73a699a4476f41 : FAILURE in 1h 03m 01s\n- nova-next https://zuul.opendev.org/t/openstack/build/3d20553535404323a486fb6c9838438d : FAILURE in 1h 14m 44s\n- tempest-slow https://zuul.opendev.org/t/openstack/build/a22830d611ba441c99f66a6e02732f45 : SUCCESS in 2h 04m 07s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/a6e9557a185a409caf3eea8e1e35b583 : SUCCESS in 22m 02s\n- nova-tox-functional-py35 https://zuul.opendev.org/t/openstack/build/c689933a204340a692b81fb80452c529 : SUCCESS in 20m 08s\n- neutron-grenade-multinode https://zuul.opendev.org/t/openstack/build/3793725a2d794aca8d856a098edf69af : SUCCESS in 1h 04m 02s\n- devstack-plugin-ceph-tempest https://zuul.opendev.org/t/openstack/build/2b88b464ad114c818c08427fa8e3a1bb : FAILURE in 1h 11m 27s (non-voting)\n- neutron-tempest-linuxbridge https://zuul.opendev.org/t/openstack/build/6f7beaf1841f4358a7c03f6a64c4c409 : FAILURE in 1h 13m 10s\n- tempest-multinode-full https://zuul.opendev.org/t/openstack/build/5ce2b8ab86974f3b99422955222bc17a : FAILURE in 1h 35m 23s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"05d735da55e808014f13df14e2bc118d5a8eb64d","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-08-30 13:33:31.000000000","message":"Patch Set 1: Workflow-1\n\nFor the same reasons in https://review.opendev.org/#/c/679271/.","accounts_in_message":[],"_revision_number":1},{"id":"af120b9d67a53a87c7a3264dfead6186472bbf02","author":{"_account_id":14595,"name":"z Systems KVM","email":"zkvm-ci@linux.vnet.ibm.com","username":"ibm-zkvm-ci","tags":["SERVICE_USER"]},"date":"2019-08-31 16:07:53.000000000","message":"Patch Set 1:\n\nTesting failed ubuntu-xenial-s390x. For rechecking only on the ubuntu-xenial-s390x CI, add a review comment with recheck-zkvm. Contact info: zkvm-ci@linux.vnet.ibm.com. For more information, see https://wiki.openstack.org/wiki/ThirdPartySystems/IBM_zKVM_CI\n\n- check-tempest-dsvm-neutron-full-ubuntu-xenial-s390x http://sng01.objectstorage.softlayer.net/v1/AUTH_1940ea10-6e82-4501-b2f9-eb236510e575/ibmzkvmci/production/679274/1/check-tempest-dsvm-neutron-full-ubuntu-xenial-s390x/806f3eb : FAILURE in 1h 47m 59s","accounts_in_message":[],"_revision_number":1},{"id":"8912e13108ecfc17afa9af9732027448500a7541","tag":"autogenerated:gerrit:abandon","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2022-11-11 18:24:48.000000000","message":"Abandoned\n\nThis branch transitioned to End of Life for this project, open patches needs to be closed to be able to delete the branch.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"56d90ee3e6e93b5361c38959761c0f29ffe35924","revisions":{"56d90ee3e6e93b5361c38959761c0f29ffe35924":{"kind":"REWORK","_number":1,"created":"2019-08-29 14:37:02.000000000","uploader":{"_account_id":6737,"name":"Edward Hope-Morley","email":"edward.hope-morley@canonical.com","username":"hopem"},"ref":"refs/changes/74/679274/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/74/679274/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/74/679274/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/74/679274/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/74/679274/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/74/679274/1"}}},"commit":{"parents":[{"commit":"fab410ceeca43e79b1ea138805e118ed6bbe10d9","subject":"Remove experimental job on openSUSE 42.3","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/fab410ceeca43e79b1ea138805e118ed6bbe10d9"}]}],"author":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2018-08-14 09:57:53.000000000","tz":480},"committer":{"name":"Edward Hope-Morley","email":"edward.hope-morley@canonical.com","date":"2019-08-29 14:35:49.000000000","tz":60},"subject":"Force refresh instance info_cache during heal","message":"Force refresh instance info_cache during heal\n\nIf the instance info_cache is corrupted somehow, like during\na host reboot and the ports aren\u0027t wired up properly or\na mistaken policy change in neutron results in nova resetting\nthe info_cache to an empty list, the _heal_instance_info_cache\nis meant to fix it (once the current state of the ports for\nthe instance in neutron is corrected). However, the task is\ncurrently only refreshing the cache *based* on the current contents\nof the cache, which defeats the purpose of neutron being the source\nof truth for the ports attached to the instance.\n\nThis change makes the _heal_instance_info_cache periodic task\npass a \"force_refresh\" kwarg, which defaults to False for backward\ncompatibility with other methods that refresh the cache after\noperations like attach/detach interface, and if True will make\nnova get the current state of the ports for the instance from neutron\nand fully rebuild the info_cache.\n\nTo not lose port order in info_cache this change takes original order\nfrom nova historical data that are stored as VirtualInterfaceList\nobjects. For ports that are not registered as VirtualInterfaces\nobjects it will add them at the end of port_order list. Due to this\nfor instances older than Newton another patch was introduced to fill\nmissing VirtualInterface objects in the DB [1].\n\nLong-term we should be able to refactor some of the older refresh\ncode which leverages the cache to instead use the refresh_vif_id\nkwarg so that we do targeted cache updates when we do things like\nattach and detach ports, but that\u0027s a change for another day.\n\n[1] https://review.openstack.org/#/c/614167\n\nAlso contains partial cherry-pick of commit 4c93003 - which deletes\nsupport for the deprectated virtual-interfaces api call that is\ndeprecated in queens - and removes unit test removed as part of that\ncommit which conflicts with this patch.\n\nCo-Authored-By: Maciej Jozefczyk \u003cmaciej.jozefczyk@corp.ovh.com\u003e\nCloses-Bug: #1751923\n(cherry picked from commit ba44c155ce1dcefede9741722a0525820d6da2b8)\n(cherry picked from commit ca5867d5644fdf1c74cc786ee71876ceb8c419bd)\n\nChange-Id: I6b33fcbc4d616dcc9b126ed744846acf2b56c5af\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/56d90ee3e6e93b5361c38959761c0f29ffe35924"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/56d90ee3e6e93b5361c38959761c0f29ffe35924"}]},"branch":"refs/heads/stable/queens"}},"requirements":[],"submit_records":[],"submit_requirements":[]}