)]}'
{"nova/conductor/tasks/migrate.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"35ab2018597dd0f22cbca73ee0190ccdb9fd4296","unresolved":false,"context_lines":[{"line_number":292,"context_line":"        # available resources."},{"line_number":293,"context_line":"        elevated \u003d self.context.elevated()"},{"line_number":294,"context_line":"        host_available \u003d False"},{"line_number":295,"context_line":"        selection \u003d None"},{"line_number":296,"context_line":"        while self.host_list and not host_available:"},{"line_number":297,"context_line":"            selection \u003d self.host_list.pop(0)"},{"line_number":298,"context_line":"            if selection.allocation_request:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_91c6149c","line":295,"updated":"2019-09-03 13:51:40.000000000","message":"This is probably not necessary.","commit_id":"134e12acff785aacf60fb4d19b5589a58e89f6c7"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"0a28c7a79a6eb8e0bce6ab8bfbae57ae64f1d02a","unresolved":false,"context_lines":[{"line_number":292,"context_line":"        # available resources."},{"line_number":293,"context_line":"        elevated \u003d self.context.elevated()"},{"line_number":294,"context_line":"        host_available \u003d False"},{"line_number":295,"context_line":"        selection \u003d None"},{"line_number":296,"context_line":"        while self.host_list and not host_available:"},{"line_number":297,"context_line":"            selection \u003d self.host_list.pop(0)"},{"line_number":298,"context_line":"            if selection.allocation_request:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_e8cbc446","line":295,"in_reply_to":"7faddb67_5c3af333","updated":"2019-09-04 13:16:48.000000000","message":"Can be a follow-up","commit_id":"134e12acff785aacf60fb4d19b5589a58e89f6c7"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"95dbe3dad0bb5d316cbfd8a2e15e395aa1ec82f7","unresolved":false,"context_lines":[{"line_number":292,"context_line":"        # available resources."},{"line_number":293,"context_line":"        elevated \u003d self.context.elevated()"},{"line_number":294,"context_line":"        host_available \u003d False"},{"line_number":295,"context_line":"        selection \u003d None"},{"line_number":296,"context_line":"        while self.host_list and not host_available:"},{"line_number":297,"context_line":"            selection \u003d self.host_list.pop(0)"},{"line_number":298,"context_line":"            if selection.allocation_request:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_5c3af333","line":295,"in_reply_to":"7faddb67_91c6149c","updated":"2019-09-03 14:54:52.000000000","message":"Yeah, I see now. Semantically selection is not accessed if host_available is False. And host_available can only be True if we entered the core of the while loop at least once, and therefore selection is also defined.\n\nMy IDE tricked me.","commit_id":"134e12acff785aacf60fb4d19b5589a58e89f6c7"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e3df955643804d7f8a7261f61d4a2db6399f6080","unresolved":false,"context_lines":[{"line_number":292,"context_line":"        # available resources."},{"line_number":293,"context_line":"        elevated \u003d self.context.elevated()"},{"line_number":294,"context_line":"        host_available \u003d False"},{"line_number":295,"context_line":"        selection \u003d None"},{"line_number":296,"context_line":"        while self.host_list and not host_available:"},{"line_number":297,"context_line":"            selection \u003d self.host_list.pop(0)"},{"line_number":298,"context_line":"            if selection.allocation_request:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_3b060888","line":295,"in_reply_to":"7faddb67_e8cbc446","updated":"2019-09-04 13:50:39.000000000","message":"I don\u0027t think it\u0027s necessary to follow up on this, I was just pointing it out.","commit_id":"134e12acff785aacf60fb4d19b5589a58e89f6c7"}]}