)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"ee4d80c62f1aa78fcbc6d6528a5df73aa39d624e","unresolved":false,"context_lines":[{"line_number":13,"context_line":"On VMware driver, setting disk_io_limits when attach disk,"},{"line_number":14,"context_line":"so add force detach/attach disk when resize. Specifically,"},{"line_number":15,"context_line":"the original _resize_disk() didn\u0027t anything if flavor.root_gb"},{"line_number":16,"context_line":"has not changed. But in this patch, the function does"},{"line_number":17,"context_line":"detach_disk_from_vm() and attach_disk_to_vm() in the case."},{"line_number":18,"context_line":"This change sets disk_io_limits in any case."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I98f00257c38d95423bc926f3aa6a7b39dc84012e"},{"line_number":21,"context_line":"Closes-bug: #1841514"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5faad753_ac97b190","line":18,"range":{"start_line":16,"start_character":17,"end_line":18,"end_character":44},"updated":"2019-09-09 17:22:55.000000000","message":"This is because we need to apply the change of disk_io_limits to the virtual machine anytime.","commit_id":"7413860961e456966d064985cc1d1c08386cf3b3"},{"author":{"_account_id":13570,"name":"Akira KAMIO","email":"kamioakira2.0@gmail.com","username":"kamio"},"change_message_id":"66c316227f72871366f525745ea47c28cf0d1910","unresolved":false,"context_lines":[{"line_number":13,"context_line":"On VMware driver, setting disk_io_limits when attach disk,"},{"line_number":14,"context_line":"so add force detach/attach disk when resize. Specifically,"},{"line_number":15,"context_line":"the original _resize_disk() didn\u0027t anything if flavor.root_gb"},{"line_number":16,"context_line":"has not changed. But in this patch, the function does"},{"line_number":17,"context_line":"detach_disk_from_vm() and attach_disk_to_vm() in the case."},{"line_number":18,"context_line":"This change sets disk_io_limits in any case."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I98f00257c38d95423bc926f3aa6a7b39dc84012e"},{"line_number":21,"context_line":"Closes-bug: #1841514"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5faad753_ed291d9b","line":18,"range":{"start_line":16,"start_character":17,"end_line":18,"end_character":44},"in_reply_to":"5faad753_ac97b190","updated":"2019-09-10 04:10:50.000000000","message":"I fixed the commit message as pointed out.","commit_id":"7413860961e456966d064985cc1d1c08386cf3b3"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"236e4c85276e9c6bf21a86cf23f85949c2291f28","unresolved":false,"context_lines":[{"line_number":10,"context_line":"target flavor. But using VMware driver, disk_io_limits does not"},{"line_number":11,"context_line":"changed."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"On VMware driver, setting disk_io_limits when attach disk,"},{"line_number":14,"context_line":"so add force detach/attach disk when resize. Specifically,"},{"line_number":15,"context_line":"the original _resize_disk() didn\u0027t anything if flavor.root_gb"},{"line_number":16,"context_line":"has not changed. This is because we need to apply the change of"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5faad753_3b02cf0c","line":13,"updated":"2019-09-12 11:43:34.000000000","message":"I think you mean \"fails when disk is attached\"? Is that right or do you mean something else?","commit_id":"18de962e8a87787ae0e1d9d84b0d05d24cd27caf"},{"author":{"_account_id":13570,"name":"Akira KAMIO","email":"kamioakira2.0@gmail.com","username":"kamio"},"change_message_id":"c6ab34157118d41488f78364d90bc516cdf5d9dc","unresolved":false,"context_lines":[{"line_number":10,"context_line":"target flavor. But using VMware driver, disk_io_limits does not"},{"line_number":11,"context_line":"changed."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"On VMware driver, setting disk_io_limits when attach disk,"},{"line_number":14,"context_line":"so add force detach/attach disk when resize. Specifically,"},{"line_number":15,"context_line":"the original _resize_disk() didn\u0027t anything if flavor.root_gb"},{"line_number":16,"context_line":"has not changed. This is because we need to apply the change of"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3fa7e38b_94cca289","line":13,"in_reply_to":"5faad753_3b02cf0c","updated":"2019-10-15 01:53:59.000000000","message":"That\u0027s not what I mean.\n\nDisk attaching is not problem.\nThe problem is not setting disk_io_limits when VM resize.","commit_id":"18de962e8a87787ae0e1d9d84b0d05d24cd27caf"}],"nova/virt/vmwareapi/vmops.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"34ba1634728b30aff9db95175b1109e989418418","unresolved":false,"context_lines":[{"line_number":1393,"context_line":"                              original_disk)"},{"line_number":1394,"context_line":"            ds_util.disk_move(self._session, dc_info.ref, resized_disk,"},{"line_number":1395,"context_line":"                              vmdk.path)"},{"line_number":1396,"context_line":"        else:"},{"line_number":1397,"context_line":"            self._volumeops.detach_disk_from_vm(vm_ref, instance, vmdk.device)"},{"line_number":1398,"context_line":""},{"line_number":1399,"context_line":"        self._volumeops.attach_disk_to_vm("},{"line_number":1400,"context_line":"            vm_ref, instance, vmdk.adapter_type, vmdk.disk_type, vmdk.path,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5faad753_02d032f7","line":1397,"range":{"start_line":1396,"start_character":0,"end_line":1397,"end_character":78},"updated":"2019-09-06 18:23:55.000000000","message":"What is this change?\nThe original _resize_disk() didn\u0027t anything if the condition of line 1376 is false.\nBut in this patch, the function does detach_disk_from_vm() and attach_disk_to_vm() in the case.\nI cannot follow the purpose according to the commit message and the corresponding issue.","commit_id":"06680eae057581a732bf6984040230c4cc5f7eef"},{"author":{"_account_id":13570,"name":"Akira KAMIO","email":"kamioakira2.0@gmail.com","username":"kamio"},"change_message_id":"0e00190e9a52f381f497a54d2fe1e48c4fe0b9cf","unresolved":false,"context_lines":[{"line_number":1393,"context_line":"                              original_disk)"},{"line_number":1394,"context_line":"            ds_util.disk_move(self._session, dc_info.ref, resized_disk,"},{"line_number":1395,"context_line":"                              vmdk.path)"},{"line_number":1396,"context_line":"        else:"},{"line_number":1397,"context_line":"            self._volumeops.detach_disk_from_vm(vm_ref, instance, vmdk.device)"},{"line_number":1398,"context_line":""},{"line_number":1399,"context_line":"        self._volumeops.attach_disk_to_vm("},{"line_number":1400,"context_line":"            vm_ref, instance, vmdk.adapter_type, vmdk.disk_type, vmdk.path,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5faad753_4812b65a","line":1397,"range":{"start_line":1396,"start_character":0,"end_line":1397,"end_character":78},"in_reply_to":"5faad753_02d032f7","updated":"2019-09-09 06:47:42.000000000","message":"I changed the commit message in more detail.","commit_id":"06680eae057581a732bf6984040230c4cc5f7eef"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"34ba1634728b30aff9db95175b1109e989418418","unresolved":false,"context_lines":[{"line_number":1513,"context_line":"            ds_util.disk_delete(self._session, dc_info.ref, vmdk.path)"},{"line_number":1514,"context_line":"            ds_util.disk_move(self._session, dc_info.ref,"},{"line_number":1515,"context_line":"                              str(original_disk), vmdk.path)"},{"line_number":1516,"context_line":"            self._volumeops.attach_disk_to_vm("},{"line_number":1517,"context_line":"                vm_ref, instance, vmdk.adapter_type, vmdk.disk_type, vmdk.path,"},{"line_number":1518,"context_line":"                disk_io_limits\u003dextra_specs.disk_io_limits)"},{"line_number":1519,"context_line":"        else:"},{"line_number":1520,"context_line":"            self._volumeops.detach_disk_from_vm(vm_ref, instance,"},{"line_number":1521,"context_line":"                                                vmdk.device)"},{"line_number":1522,"context_line":"            self._volumeops.attach_disk_to_vm("},{"line_number":1523,"context_line":"                vm_ref, instance, vmdk.adapter_type, vmdk.disk_type, vmdk.path,"},{"line_number":1524,"context_line":"                disk_io_limits\u003dextra_specs.disk_io_limits)"},{"line_number":1525,"context_line":"        # Reconfigure ephemerals"},{"line_number":1526,"context_line":"        self._remove_ephemerals_and_swap(vm_ref)"},{"line_number":1527,"context_line":"        self._resize_create_ephemerals_and_swap(vm_ref, instance,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5faad753_02f9127f","line":1524,"range":{"start_line":1516,"start_character":0,"end_line":1524,"end_character":58},"updated":"2019-09-06 18:23:55.000000000","message":"This code can be\n\n else:\n     self._volumeops.detach_disk_from_vm(vm_ref, instance,\n                                         vmdk.device)\n self._volumeops.attach_disk_to_vm(\n        vm_ref, instance, vmdk.adapter_type, vmdk.disk_type, vmdk.path,\n        disk_io_limits\u003dextra_specs.disk_io_limits)\n\nlike the above changed code.","commit_id":"06680eae057581a732bf6984040230c4cc5f7eef"},{"author":{"_account_id":13570,"name":"Akira KAMIO","email":"kamioakira2.0@gmail.com","username":"kamio"},"change_message_id":"0e00190e9a52f381f497a54d2fe1e48c4fe0b9cf","unresolved":false,"context_lines":[{"line_number":1513,"context_line":"            ds_util.disk_delete(self._session, dc_info.ref, vmdk.path)"},{"line_number":1514,"context_line":"            ds_util.disk_move(self._session, dc_info.ref,"},{"line_number":1515,"context_line":"                              str(original_disk), vmdk.path)"},{"line_number":1516,"context_line":"            self._volumeops.attach_disk_to_vm("},{"line_number":1517,"context_line":"                vm_ref, instance, vmdk.adapter_type, vmdk.disk_type, vmdk.path,"},{"line_number":1518,"context_line":"                disk_io_limits\u003dextra_specs.disk_io_limits)"},{"line_number":1519,"context_line":"        else:"},{"line_number":1520,"context_line":"            self._volumeops.detach_disk_from_vm(vm_ref, instance,"},{"line_number":1521,"context_line":"                                                vmdk.device)"},{"line_number":1522,"context_line":"            self._volumeops.attach_disk_to_vm("},{"line_number":1523,"context_line":"                vm_ref, instance, vmdk.adapter_type, vmdk.disk_type, vmdk.path,"},{"line_number":1524,"context_line":"                disk_io_limits\u003dextra_specs.disk_io_limits)"},{"line_number":1525,"context_line":"        # Reconfigure ephemerals"},{"line_number":1526,"context_line":"        self._remove_ephemerals_and_swap(vm_ref)"},{"line_number":1527,"context_line":"        self._resize_create_ephemerals_and_swap(vm_ref, instance,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5faad753_a826cab6","line":1524,"range":{"start_line":1516,"start_character":0,"end_line":1524,"end_character":58},"in_reply_to":"5faad753_02f9127f","updated":"2019-09-09 06:47:42.000000000","message":"I changed the code as pointed out.","commit_id":"06680eae057581a732bf6984040230c4cc5f7eef"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"236e4c85276e9c6bf21a86cf23f85949c2291f28","unresolved":false,"context_lines":[{"line_number":1394,"context_line":"            ds_util.disk_move(self._session, dc_info.ref, resized_disk,"},{"line_number":1395,"context_line":"                              vmdk.path)"},{"line_number":1396,"context_line":"        else:"},{"line_number":1397,"context_line":"            self._volumeops.detach_disk_from_vm(vm_ref, instance, vmdk.device)"},{"line_number":1398,"context_line":""},{"line_number":1399,"context_line":"        self._volumeops.attach_disk_to_vm("},{"line_number":1400,"context_line":"            vm_ref, instance, vmdk.adapter_type, vmdk.disk_type, vmdk.path,"}],"source_content_type":"text/x-python","patch_set":4,"id":"5faad753_5e145944","line":1397,"updated":"2019-09-12 11:43:34.000000000","message":"This will not be called if flavor.root_gb is bigger _and_  someone wants to change disk_io_limits.\n\nWhat happens in that case?","commit_id":"18de962e8a87787ae0e1d9d84b0d05d24cd27caf"},{"author":{"_account_id":13570,"name":"Akira KAMIO","email":"kamioakira2.0@gmail.com","username":"kamio"},"change_message_id":"c6ab34157118d41488f78364d90bc516cdf5d9dc","unresolved":false,"context_lines":[{"line_number":1394,"context_line":"            ds_util.disk_move(self._session, dc_info.ref, resized_disk,"},{"line_number":1395,"context_line":"                              vmdk.path)"},{"line_number":1396,"context_line":"        else:"},{"line_number":1397,"context_line":"            self._volumeops.detach_disk_from_vm(vm_ref, instance, vmdk.device)"},{"line_number":1398,"context_line":""},{"line_number":1399,"context_line":"        self._volumeops.attach_disk_to_vm("},{"line_number":1400,"context_line":"            vm_ref, instance, vmdk.adapter_type, vmdk.disk_type, vmdk.path,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_34aa8e70","line":1397,"in_reply_to":"5faad753_5e145944","updated":"2019-10-15 01:53:59.000000000","message":"If flavor.root_gb is bigger, do the original logic.\nSo, do the original logic, if flavor.root_gb is bigger _and_  someone wants to change disk_io_limits.\n\n\nIn the original codes, do nothing if someone wants to change disk_io_limits.\nSo in this case disk_io_limits is not changed.","commit_id":"18de962e8a87787ae0e1d9d84b0d05d24cd27caf"}]}