)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ca8376c4263ea8bc4ce1c5769c0d7f58195e97d9","unresolved":false,"context_lines":[{"line_number":7,"context_line":"migrate: Add bw min service level check of source compute"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"During cold migrate the RequestSpec goes from the dest compute to the"},{"line_number":10,"context_line":"source compute and then back to the dest. The previous patch added"},{"line_number":11,"context_line":"service level check for the dest compute. However the source compute also"},{"line_number":12,"context_line":"needs to be new enough so the RequestSpec is passed through it."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7faddb67_0c6df42d","line":10,"range":{"start_line":10,"start_character":46,"end_line":10,"end_character":60},"updated":"2019-09-05 16:51:04.000000000","message":"I really dislike it when people do this in commit messages because while I get it in a gerrit review series context, it won\u0027t make sense later when looking at git history. So please add a footnote or something like you did below.","commit_id":"d50b8ca99de3798364efbd49dbdce05cf0cc724d"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"b13733cf5f84b1b09640b7e5ee9dacc069c11ada","unresolved":false,"context_lines":[{"line_number":7,"context_line":"migrate: Add bw min service level check of source compute"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"During cold migrate the RequestSpec goes from the dest compute to the"},{"line_number":10,"context_line":"source compute and then back to the dest. The previous patch added"},{"line_number":11,"context_line":"service level check for the dest compute. However the source compute also"},{"line_number":12,"context_line":"needs to be new enough so the RequestSpec is passed through it."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5faad753_98033c0e","line":10,"range":{"start_line":10,"start_character":46,"end_line":10,"end_character":60},"in_reply_to":"7faddb67_0c6df42d","updated":"2019-09-06 15:13:17.000000000","message":"Point taken. Done.","commit_id":"d50b8ca99de3798364efbd49dbdce05cf0cc724d"}],"nova/api/openstack/compute/migrate_server.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ca8376c4263ea8bc4ce1c5769c0d7f58195e97d9","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"MIN_COMPUTE_BANDWIDTH \u003d 39"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"class MigrateServerController(wsgi.Controller):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_5f55d0c0","line":35,"range":{"start_line":35,"start_character":12,"end_line":35,"end_character":21},"updated":"2019-09-05 16:51:04.000000000","message":"nit: maybe call this MIN_COMPUTE_MOVE_BANDWIDTH?","commit_id":"d50b8ca99de3798364efbd49dbdce05cf0cc724d"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"b13733cf5f84b1b09640b7e5ee9dacc069c11ada","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"MIN_COMPUTE_BANDWIDTH \u003d 39"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"class MigrateServerController(wsgi.Controller):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5faad753_78fe8006","line":35,"range":{"start_line":35,"start_character":12,"end_line":35,"end_character":21},"in_reply_to":"7faddb67_5f55d0c0","updated":"2019-09-06 15:13:17.000000000","message":"Done","commit_id":"d50b8ca99de3798364efbd49dbdce05cf0cc724d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ca8376c4263ea8bc4ce1c5769c0d7f58195e97d9","unresolved":false,"context_lines":[{"line_number":69,"context_line":"                        \"bandwidth policy, is not supported with this \""},{"line_number":70,"context_line":"                        \"microversion\")"},{"line_number":71,"context_line":"                raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":72,"context_line":"            else:"},{"line_number":73,"context_line":"                source_service \u003d objects.Service.get_by_host_and_binary("},{"line_number":74,"context_line":"                    context, instance.host, \u0027nova-compute\u0027)"},{"line_number":75,"context_line":"                if source_service.version \u003c MIN_COMPUTE_BANDWIDTH:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_1f73d881","line":72,"range":{"start_line":72,"start_character":12,"end_line":72,"end_character":17},"updated":"2019-09-05 16:51:04.000000000","message":"you can drop this else","commit_id":"d50b8ca99de3798364efbd49dbdce05cf0cc724d"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"b13733cf5f84b1b09640b7e5ee9dacc069c11ada","unresolved":false,"context_lines":[{"line_number":69,"context_line":"                        \"bandwidth policy, is not supported with this \""},{"line_number":70,"context_line":"                        \"microversion\")"},{"line_number":71,"context_line":"                raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":72,"context_line":"            else:"},{"line_number":73,"context_line":"                source_service \u003d objects.Service.get_by_host_and_binary("},{"line_number":74,"context_line":"                    context, instance.host, \u0027nova-compute\u0027)"},{"line_number":75,"context_line":"                if source_service.version \u003c MIN_COMPUTE_BANDWIDTH:"}],"source_content_type":"text/x-python","patch_set":3,"id":"5faad753_1d85fead","line":72,"range":{"start_line":72,"start_character":12,"end_line":72,"end_character":17},"in_reply_to":"7faddb67_1f73d881","updated":"2019-09-06 15:13:17.000000000","message":"Done","commit_id":"d50b8ca99de3798364efbd49dbdce05cf0cc724d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ca8376c4263ea8bc4ce1c5769c0d7f58195e97d9","unresolved":false,"context_lines":[{"line_number":70,"context_line":"                        \"microversion\")"},{"line_number":71,"context_line":"                raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":72,"context_line":"            else:"},{"line_number":73,"context_line":"                source_service \u003d objects.Service.get_by_host_and_binary("},{"line_number":74,"context_line":"                    context, instance.host, \u0027nova-compute\u0027)"},{"line_number":75,"context_line":"                if source_service.version \u003c MIN_COMPUTE_BANDWIDTH:"},{"line_number":76,"context_line":"                    msg \u003d _(\"The migrate action on a server with ports having \""}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_ff635ca9","line":73,"updated":"2019-09-05 16:51:04.000000000","message":"Add a TODO to remove this after Train.","commit_id":"d50b8ca99de3798364efbd49dbdce05cf0cc724d"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"b13733cf5f84b1b09640b7e5ee9dacc069c11ada","unresolved":false,"context_lines":[{"line_number":70,"context_line":"                        \"microversion\")"},{"line_number":71,"context_line":"                raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":72,"context_line":"            else:"},{"line_number":73,"context_line":"                source_service \u003d objects.Service.get_by_host_and_binary("},{"line_number":74,"context_line":"                    context, instance.host, \u0027nova-compute\u0027)"},{"line_number":75,"context_line":"                if source_service.version \u003c MIN_COMPUTE_BANDWIDTH:"},{"line_number":76,"context_line":"                    msg \u003d _(\"The migrate action on a server with ports having \""}],"source_content_type":"text/x-python","patch_set":3,"id":"5faad753_1d73bee9","line":73,"in_reply_to":"7faddb67_ff635ca9","updated":"2019-09-06 15:13:17.000000000","message":"Done","commit_id":"d50b8ca99de3798364efbd49dbdce05cf0cc724d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ca8376c4263ea8bc4ce1c5769c0d7f58195e97d9","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                            \"resource requests, like a port with a QoS \""},{"line_number":78,"context_line":"                            \"minimum bandwidth policy, is not yet supported \""},{"line_number":79,"context_line":"                            \"on the source compute\")"},{"line_number":80,"context_line":"                    raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        try:"},{"line_number":83,"context_line":"            self.compute_api.resize(req.environ[\u0027nova.context\u0027], instance,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_7f0d2ce5","line":80,"range":{"start_line":80,"start_character":30,"end_line":80,"end_character":44},"updated":"2019-09-05 16:51:04.000000000","message":"This should likely be a 409 really since the user can retry once the source compute is upgraded. Similar to how VolumeTypeSupportNotYetAvailable works.","commit_id":"d50b8ca99de3798364efbd49dbdce05cf0cc724d"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"b13733cf5f84b1b09640b7e5ee9dacc069c11ada","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                            \"resource requests, like a port with a QoS \""},{"line_number":78,"context_line":"                            \"minimum bandwidth policy, is not yet supported \""},{"line_number":79,"context_line":"                            \"on the source compute\")"},{"line_number":80,"context_line":"                    raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        try:"},{"line_number":83,"context_line":"            self.compute_api.resize(req.environ[\u0027nova.context\u0027], instance,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5faad753_9d67ae26","line":80,"range":{"start_line":80,"start_character":30,"end_line":80,"end_character":44},"in_reply_to":"7faddb67_7f0d2ce5","updated":"2019-09-06 15:13:17.000000000","message":"Done","commit_id":"d50b8ca99de3798364efbd49dbdce05cf0cc724d"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"a3ed1cb0a30c46e302e0fa5f0563ecf37303cd56","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"MIN_COMPUTE_MOVE_BANDWIDTH \u003d 39"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"class MigrateServerController(wsgi.Controller):"}],"source_content_type":"text/x-python","patch_set":4,"id":"5faad753_46c37eee","line":35,"updated":"2019-09-09 16:29:58.000000000","message":"Ack looks the right version","commit_id":"a061b0ea2e7f13a71dcc0f088c9dae3b11ba7059"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"a3ed1cb0a30c46e302e0fa5f0563ecf37303cd56","unresolved":false,"context_lines":[{"line_number":79,"context_line":"                        \"resource requests, like a port with a QoS \""},{"line_number":80,"context_line":"                        \"minimum bandwidth policy, is not yet supported \""},{"line_number":81,"context_line":"                        \"on the source compute\")"},{"line_number":82,"context_line":"                raise exc.HTTPConflict(explanation\u003dmsg)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        try:"},{"line_number":85,"context_line":"            self.compute_api.resize(req.environ[\u0027nova.context\u0027], instance,"}],"source_content_type":"text/x-python","patch_set":4,"id":"5faad753_e66cea09","line":82,"updated":"2019-09-09 16:29:58.000000000","message":"It\u0027s okay to provide an exception here (it\u0027s not a backwards compability issue) since the behaviour is still okay.","commit_id":"a061b0ea2e7f13a71dcc0f088c9dae3b11ba7059"}]}