)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"fbd7acf6e6161996f18b5884f23b2895daa2cd7c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"resize: Add bw min service level check of source compute"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"During resize the RequestSpec goes from the dest compute to the"},{"line_number":10,"context_line":"source compute and then back to the dest. The previous patch added"},{"line_number":11,"context_line":"service level check for the dest compute. However the source compute also"},{"line_number":12,"context_line":"needs to be new enough so the RequestSpec is passed through it."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7faddb67_bf30849f","line":10,"range":{"start_line":10,"start_character":46,"end_line":10,"end_character":60},"updated":"2019-09-05 16:52:14.000000000","message":"same comment as in https://review.opendev.org/#/c/680395/3","commit_id":"373148030c624675beb9ab1b3a1f9ec67e9a1087"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"9d881b351bd01e9e1c376dea6ed62fa0c13684f4","unresolved":false,"context_lines":[{"line_number":7,"context_line":"resize: Add bw min service level check of source compute"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"During resize the RequestSpec goes from the dest compute to the"},{"line_number":10,"context_line":"source compute and then back to the dest. The previous patch added"},{"line_number":11,"context_line":"service level check for the dest compute. However the source compute also"},{"line_number":12,"context_line":"needs to be new enough so the RequestSpec is passed through it."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5faad753_7883e057","line":10,"range":{"start_line":10,"start_character":46,"end_line":10,"end_character":60},"in_reply_to":"7faddb67_bf30849f","updated":"2019-09-06 15:13:22.000000000","message":"Done","commit_id":"373148030c624675beb9ab1b3a1f9ec67e9a1087"}],"nova/api/openstack/compute/servers.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"fbd7acf6e6161996f18b5884f23b2895daa2cd7c","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    exception.RealtimeMaskNotFoundOrInvalid,"},{"line_number":86,"context_line":")"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"MIN_COMPUTE_BANDWIDTH \u003d 39"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"class ServersController(wsgi.Controller):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_3f1c9411","line":88,"updated":"2019-09-05 16:52:14.000000000","message":"MIN_COMPUTE_MOVE_BANDWIDTH?","commit_id":"373148030c624675beb9ab1b3a1f9ec67e9a1087"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"9d881b351bd01e9e1c376dea6ed62fa0c13684f4","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    exception.RealtimeMaskNotFoundOrInvalid,"},{"line_number":86,"context_line":")"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"MIN_COMPUTE_BANDWIDTH \u003d 39"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"class ServersController(wsgi.Controller):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5faad753_18abccd6","line":88,"in_reply_to":"7faddb67_3f1c9411","updated":"2019-09-06 15:13:22.000000000","message":"Done","commit_id":"373148030c624675beb9ab1b3a1f9ec67e9a1087"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"fbd7acf6e6161996f18b5884f23b2895daa2cd7c","unresolved":false,"context_lines":[{"line_number":950,"context_line":"                        \"bandwidth policy, is not supported with this \""},{"line_number":951,"context_line":"                        \"microversion\")"},{"line_number":952,"context_line":"                raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":953,"context_line":"            else:"},{"line_number":954,"context_line":"                source_service \u003d objects.Service.get_by_host_and_binary("},{"line_number":955,"context_line":"                    context, instance.host, \u0027nova-compute\u0027)"},{"line_number":956,"context_line":"                if source_service.version \u003c MIN_COMPUTE_BANDWIDTH:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_df16a0f2","line":953,"range":{"start_line":953,"start_character":12,"end_line":953,"end_character":17},"updated":"2019-09-05 16:52:14.000000000","message":"drop the else","commit_id":"373148030c624675beb9ab1b3a1f9ec67e9a1087"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"9d881b351bd01e9e1c376dea6ed62fa0c13684f4","unresolved":false,"context_lines":[{"line_number":950,"context_line":"                        \"bandwidth policy, is not supported with this \""},{"line_number":951,"context_line":"                        \"microversion\")"},{"line_number":952,"context_line":"                raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":953,"context_line":"            else:"},{"line_number":954,"context_line":"                source_service \u003d objects.Service.get_by_host_and_binary("},{"line_number":955,"context_line":"                    context, instance.host, \u0027nova-compute\u0027)"},{"line_number":956,"context_line":"                if source_service.version \u003c MIN_COMPUTE_BANDWIDTH:"}],"source_content_type":"text/x-python","patch_set":3,"id":"5faad753_b8b7183b","line":953,"range":{"start_line":953,"start_character":12,"end_line":953,"end_character":17},"in_reply_to":"7faddb67_df16a0f2","updated":"2019-09-06 15:13:22.000000000","message":"Done","commit_id":"373148030c624675beb9ab1b3a1f9ec67e9a1087"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"fbd7acf6e6161996f18b5884f23b2895daa2cd7c","unresolved":false,"context_lines":[{"line_number":958,"context_line":"                            \"resource requests, like a port with a QoS \""},{"line_number":959,"context_line":"                            \"minimum bandwidth policy, is not yet supported \""},{"line_number":960,"context_line":"                            \"on the source compute\")"},{"line_number":961,"context_line":"                    raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":962,"context_line":""},{"line_number":963,"context_line":"        try:"},{"line_number":964,"context_line":"            self.compute_api.resize(context, instance, flavor_id, **kwargs)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_9fd26833","line":961,"range":{"start_line":961,"start_character":30,"end_line":961,"end_character":44},"updated":"2019-09-05 16:52:14.000000000","message":"same as https://review.opendev.org/#/c/680395/3 - this should probably be a 409 since it\u0027s a temporary condition.","commit_id":"373148030c624675beb9ab1b3a1f9ec67e9a1087"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"9d881b351bd01e9e1c376dea6ed62fa0c13684f4","unresolved":false,"context_lines":[{"line_number":958,"context_line":"                            \"resource requests, like a port with a QoS \""},{"line_number":959,"context_line":"                            \"minimum bandwidth policy, is not yet supported \""},{"line_number":960,"context_line":"                            \"on the source compute\")"},{"line_number":961,"context_line":"                    raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":962,"context_line":""},{"line_number":963,"context_line":"        try:"},{"line_number":964,"context_line":"            self.compute_api.resize(context, instance, flavor_id, **kwargs)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5faad753_d8b45438","line":961,"range":{"start_line":961,"start_character":30,"end_line":961,"end_character":44},"in_reply_to":"7faddb67_9fd26833","updated":"2019-09-06 15:13:22.000000000","message":"Done","commit_id":"373148030c624675beb9ab1b3a1f9ec67e9a1087"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"06596ebc8e92b1502e20e4f3634517a5b0f56973","unresolved":false,"context_lines":[{"line_number":942,"context_line":"        # We could potentially move this check to conductor and avoid the"},{"line_number":943,"context_line":"        # extra API call to neutron when we support move operations with ports"},{"line_number":944,"context_line":"        # having resource requests."},{"line_number":945,"context_line":"        if common.instance_has_port_with_resource_request("},{"line_number":946,"context_line":"                context, instance_id, self.network_api):"},{"line_number":947,"context_line":"            if not common.supports_port_resource_request_during_move(req):"},{"line_number":948,"context_line":"                msg \u003d _(\"The resize action on a server with ports having \""},{"line_number":949,"context_line":"                        \"resource requests, like a port with a QoS minimum \""},{"line_number":950,"context_line":"                        \"bandwidth policy, is not supported with this \""},{"line_number":951,"context_line":"                        \"microversion\")"},{"line_number":952,"context_line":"                raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":953,"context_line":""},{"line_number":954,"context_line":"            # TODO(gibi): Remove when nova only supports compute newer than"},{"line_number":955,"context_line":"            # Train"}],"source_content_type":"text/x-python","patch_set":4,"id":"5faad753_62afa694","line":952,"range":{"start_line":945,"start_character":8,"end_line":952,"end_character":57},"updated":"2019-09-06 18:13:18.000000000","message":"I guess this goes away later in the series but I was just musing about how it\u0027d be nice if we had moved these resource request specific validation checks into a private method and then it\u0027d be easier to just drop that code altogether later and it\u0027s off to the side from the main method, but it\u0027s not a big deal.","commit_id":"d19b8badbcf2431f752322ccebb22133a3518737"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"28a6b53e65ba8a51fe45b93b6f742680d630b58e","unresolved":false,"context_lines":[{"line_number":942,"context_line":"        # We could potentially move this check to conductor and avoid the"},{"line_number":943,"context_line":"        # extra API call to neutron when we support move operations with ports"},{"line_number":944,"context_line":"        # having resource requests."},{"line_number":945,"context_line":"        if common.instance_has_port_with_resource_request("},{"line_number":946,"context_line":"                context, instance_id, self.network_api):"},{"line_number":947,"context_line":"            if not common.supports_port_resource_request_during_move(req):"},{"line_number":948,"context_line":"                msg \u003d _(\"The resize action on a server with ports having \""},{"line_number":949,"context_line":"                        \"resource requests, like a port with a QoS minimum \""},{"line_number":950,"context_line":"                        \"bandwidth policy, is not supported with this \""},{"line_number":951,"context_line":"                        \"microversion\")"},{"line_number":952,"context_line":"                raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":953,"context_line":""},{"line_number":954,"context_line":"            # TODO(gibi): Remove when nova only supports compute newer than"},{"line_number":955,"context_line":"            # Train"}],"source_content_type":"text/x-python","patch_set":4,"id":"5faad753_ab301209","line":952,"range":{"start_line":945,"start_character":8,"end_line":952,"end_character":57},"in_reply_to":"5faad753_62afa694","updated":"2019-09-08 17:27:02.000000000","message":"The first condition instance_has_port_with_resource_request remains until the compute service version check is needed. But yes the supports_port_resource_request_during_move() condition is removed in https://review.opendev.org/#/c/679019/8/nova/api/openstack/compute/servers.py","commit_id":"d19b8badbcf2431f752322ccebb22133a3518737"}]}