)]}'
{"nova/virt/ironic/driver.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4c23f2fdc18f9b0ec1fc9572e1a7e313977be907","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"_NODE_FIELDS \u003d (\u0027uuid\u0027, \u0027power_state\u0027, \u0027target_power_state\u0027, \u0027provision_state\u0027,"},{"line_number":84,"context_line":"                \u0027target_provision_state\u0027, \u0027last_error\u0027, \u0027maintenance\u0027,"},{"line_number":85,"context_line":"                \u0027properties\u0027, \u0027instance_uuid\u0027, \u0027traits\u0027, \u0027resource_class\u0027)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"# Console state checking interval in seconds"},{"line_number":88,"context_line":"_CONSOLE_STATE_CHECKING_INTERVAL \u003d 1"}],"source_content_type":"text/x-python","patch_set":2,"id":"5faad753_96c6ac16","line":85,"range":{"start_line":85,"start_character":31,"end_line":85,"end_character":44},"updated":"2019-09-06 14:59:46.000000000","message":"And this shouldn\u0027t be instance_id? These are fields on the node resource in the API or in the SDK? Because the SDK uses instance_id right? Nevermind, this is the correct one I guess and it was the others that were wrong. It\u0027s definitely confusing.","commit_id":"19f01023c23b793388d693b7272cac799b5b6ff8"},{"author":{"_account_id":29745,"name":"Dustin Cowles","email":"cowlesd@gmail.com","username":"dustinc","status":"inactive"},"change_message_id":"bad80ce57bfdf106183e688bc41fd6f3c09db625","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"_NODE_FIELDS \u003d (\u0027uuid\u0027, \u0027power_state\u0027, \u0027target_power_state\u0027, \u0027provision_state\u0027,"},{"line_number":84,"context_line":"                \u0027target_provision_state\u0027, \u0027last_error\u0027, \u0027maintenance\u0027,"},{"line_number":85,"context_line":"                \u0027properties\u0027, \u0027instance_uuid\u0027, \u0027traits\u0027, \u0027resource_class\u0027)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"# Console state checking interval in seconds"},{"line_number":88,"context_line":"_CONSOLE_STATE_CHECKING_INTERVAL \u003d 1"}],"source_content_type":"text/x-python","patch_set":2,"id":"5faad753_a83b3d9a","line":85,"range":{"start_line":85,"start_character":31,"end_line":85,"end_character":44},"in_reply_to":"5faad753_7671b0e0","updated":"2019-09-06 20:05:32.000000000","message":"I plan to clean up this entire series quite a bit, this included, in U. The SDK patch Dimitry made to map the fields will be a huge help.","commit_id":"19f01023c23b793388d693b7272cac799b5b6ff8"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"f6a792dc0696a68b08a715ffcbe0d05013a22b32","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"_NODE_FIELDS \u003d (\u0027uuid\u0027, \u0027power_state\u0027, \u0027target_power_state\u0027, \u0027provision_state\u0027,"},{"line_number":84,"context_line":"                \u0027target_provision_state\u0027, \u0027last_error\u0027, \u0027maintenance\u0027,"},{"line_number":85,"context_line":"                \u0027properties\u0027, \u0027instance_uuid\u0027, \u0027traits\u0027, \u0027resource_class\u0027)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"# Console state checking interval in seconds"},{"line_number":88,"context_line":"_CONSOLE_STATE_CHECKING_INTERVAL \u003d 1"}],"source_content_type":"text/x-python","patch_set":2,"id":"5faad753_7671b0e0","line":85,"range":{"start_line":85,"start_character":31,"end_line":85,"end_character":44},"in_reply_to":"5faad753_96c6ac16","updated":"2019-09-06 15:05:51.000000000","message":"Let\u0027s keep it like this for now. A fix for openstacksdk to understand instance_id has just been posted.","commit_id":"19f01023c23b793388d693b7272cac799b5b6ff8"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4c23f2fdc18f9b0ec1fc9572e1a7e313977be907","unresolved":false,"context_lines":[{"line_number":689,"context_line":""},{"line_number":690,"context_line":"        \"\"\""},{"line_number":691,"context_line":"        # NOTE(dustinc): The SDK returns an object with instance_id,"},{"line_number":692,"context_line":"        #  but the Ironic API expects instance_uuid in query."},{"line_number":693,"context_line":"        context \u003d nova_context.get_admin_context()"},{"line_number":694,"context_line":"        return [objects.Instance.get_by_uuid(context, i.instance_id).name"},{"line_number":695,"context_line":"                for i in self._get_node_list(return_generator\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5faad753_d67504fc","line":692,"updated":"2019-09-06 14:59:46.000000000","message":"yup: https://docs.openstack.org/api-ref/baremetal/?expanded\u003dlist-nodes-detail#id4","commit_id":"19f01023c23b793388d693b7272cac799b5b6ff8"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"24a6016d26db282df46923424b97b69b1edde8b3","unresolved":false,"context_lines":[{"line_number":689,"context_line":""},{"line_number":690,"context_line":"        \"\"\""},{"line_number":691,"context_line":"        # NOTE(dustinc): The SDK returns an object with instance_id,"},{"line_number":692,"context_line":"        #  but the Ironic API expects instance_uuid in query."},{"line_number":693,"context_line":"        context \u003d nova_context.get_admin_context()"},{"line_number":694,"context_line":"        return [objects.Instance.get_by_uuid(context, i.instance_id).name"},{"line_number":695,"context_line":"                for i in self._get_node_list(return_generator\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_909a2ac3","line":692,"in_reply_to":"5faad753_d67504fc","updated":"2019-09-17 14:33:16.000000000","message":"We can unwind this once we can pick up an SDK release with https://review.opendev.org/#/c/680649/","commit_id":"19f01023c23b793388d693b7272cac799b5b6ff8"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4c23f2fdc18f9b0ec1fc9572e1a7e313977be907","unresolved":false,"context_lines":[{"line_number":801,"context_line":"        if partition_key is not None:"},{"line_number":802,"context_line":"            try:"},{"line_number":803,"context_line":"                self._can_send_version(min_version\u003d\u00271.46\u0027)"},{"line_number":804,"context_line":"                nodes \u003d _get_node_list(conductor_group\u003dpartition_key)"},{"line_number":805,"context_line":"                LOG.debug(\u0027Limiting manageable ironic nodes to conductor \u0027"},{"line_number":806,"context_line":"                          \u0027group %s\u0027, partition_key)"},{"line_number":807,"context_line":"            except exception.IronicAPIVersionNotAvailable:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5faad753_f6728011","line":804,"range":{"start_line":804,"start_character":39,"end_line":804,"end_character":54},"updated":"2019-09-06 14:59:46.000000000","message":"and this is ok https://docs.openstack.org/api-ref/baremetal/?expanded\u003dlist-nodes-detail#id4","commit_id":"19f01023c23b793388d693b7272cac799b5b6ff8"}]}