)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6fde43c3e2b30c89af34984ef9f632efb9551471","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Nova raise exceptions when extending volume fails"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"nova catches exceptions and should raise them instead of return"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I24359de100fc7b9695e8bdb1076886fc35da4d6e"},{"line_number":12,"context_line":"Related-Bug: #1843008"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5faad753_78e8c015","line":9,"updated":"2019-09-06 12:53:33.000000000","message":"This should explain why nova should raise - presumably to record a failure for the instance action event so the user can see that the operation failed from the instance actions API.","commit_id":"cd543ef9f153b3732cd91586d4c56012562a3c95"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ab493e8b6451ef05aecec94f9099451e0a9a897c","unresolved":false,"context_lines":[{"line_number":9,"context_line":"nova catches exceptions and should raise them instead of return"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I24359de100fc7b9695e8bdb1076886fc35da4d6e"},{"line_number":12,"context_line":"Related-Bug: #1843008"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5faad753_98649cbb","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":7},"updated":"2019-09-06 12:54:08.000000000","message":"This should be Closes-Bug","commit_id":"cd543ef9f153b3732cd91586d4c56012562a3c95"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"5d756eaa7df1f43b12c3a94a41a9d7e2486a5630","unresolved":false,"context_lines":[{"line_number":9,"context_line":"When extending volume failed in nova with exception of"},{"line_number":10,"context_line":"volume not found or connection_info is None, nova will"},{"line_number":11,"context_line":"not raise exception, in that case, nova API will"},{"line_number":12,"context_line":"not detect the failure , this patch fixes it."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I24359de100fc7b9695e8bdb1076886fc35da4d6e"},{"line_number":15,"context_line":"Closes-Bug: #1843008"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3fa7e38b_61be8a66","line":12,"range":{"start_line":12,"start_character":22,"end_line":12,"end_character":23},"updated":"2019-09-20 09:40:56.000000000","message":"nit: space","commit_id":"a1ad65239383bcadd3ffabbe67a51caa583a1d4f"},{"author":{"_account_id":29451,"name":"hulina","email":"hulina@cmss.chinamobile.com","username":"hulina"},"change_message_id":"0e25efbb0801dfeaa1bf23b3ddc2e8431215dcbc","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When extending volume failed in nova with exception of"},{"line_number":10,"context_line":"volume not found or connection_info is None, nova will"},{"line_number":11,"context_line":"not raise exception, in that case, nova API will"},{"line_number":12,"context_line":"not detect the failure, this patch fixes it."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I24359de100fc7b9695e8bdb1076886fc35da4d6e"},{"line_number":15,"context_line":"Closes-Bug: #1843008"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ff570b3c_db3852d4","line":12,"range":{"start_line":11,"start_character":34,"end_line":12,"end_character":44},"updated":"2020-06-03 01:32:33.000000000","message":"sorry, my description here is not accurate, which leads to misunderstanding. I mean, when we execute nova instance-aciton-list , it will not return ERROR","commit_id":"8c0116320cc01e82aa4d9ebba71e067408eb4f6d"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"9abac5e270ea1002031391179194df191db5f523","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"c66cd45f_59ee14d4","updated":"2025-08-11 04:35:08.000000000","message":"Hi Stephen, We are planning to use this change as part of our NFS extend feature. I will own co-author this patch and address any pending review comments. please complete this review.","commit_id":"c9f36071b00ceb0698b1c2959bc14844e2cd999c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"97d9bc270927bdb9fa9cd2124f2340ef3a79487f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"fa8dc9d1_4faacbf3","updated":"2025-08-11 10:20:49.000000000","message":"i mentioned this on irc but to move this forward we need 2 things\n\nfirst i would like to see a functional regression test added for #1843008\nas a sepreate intall patch showing that the instance action event does not go to error.\n\nsecond this patch shoudl update that test showing it does to go to error and we need a release note to explain what to an operator/admin what has been fixed and why they shoudl care. i.e. the commit message tell deveolper what and why but the release not should be writing with the openstack admin/operatior in mind and explain the imporment in terms they woudl care about.","commit_id":"c9f36071b00ceb0698b1c2959bc14844e2cd999c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"7196abbd03a1efb6c83477a16d300a802988e16f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"98af5e05_9aa5d521","updated":"2025-08-11 10:10:02.000000000","message":"support for extendign nfs volumes is a feature not a bug\nhttps://review.opendev.org/q/topic:%22bp/extend-volume-completion-action%22\n\nso at most we cna mark it as error.\n\nwe sould not offically supprot extendign nfs voluem until the fature is actully completed","commit_id":"c9f36071b00ceb0698b1c2959bc14844e2cd999c"}],"nova/compute/manager.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6fde43c3e2b30c89af34984ef9f632efb9551471","unresolved":false,"context_lines":[{"line_number":8657,"context_line":"            bdm \u003d objects.BlockDeviceMapping.get_by_volume_and_instance("},{"line_number":8658,"context_line":"                   context, extended_volume_id, instance.uuid)"},{"line_number":8659,"context_line":"        except exception.NotFound:"},{"line_number":8660,"context_line":"            LOG.warning(\u0027Extend volume failed, \u0027"},{"line_number":8661,"context_line":"                        \u0027volume %(vol)s is not attached to instance.\u0027,"},{"line_number":8662,"context_line":"                        {\u0027vol\u0027: extended_volume_id},"},{"line_number":8663,"context_line":"                        instance\u003dinstance)"},{"line_number":8664,"context_line":"            raise"},{"line_number":8665,"context_line":""},{"line_number":8666,"context_line":"        LOG.info(\u0027Cinder extended volume %(vol)s; \u0027"},{"line_number":8667,"context_line":"                 \u0027extending it to detect new size\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5faad753_58d06451","line":8664,"range":{"start_line":8660,"start_character":12,"end_line":8664,"end_character":17},"updated":"2019-09-06 12:53:33.000000000","message":"Rather than raise explicitly, use:\n\nwith excutils.save_and_reraise_exception():\n    LOG.warning(\u0027Extend volume failed, \u0027\n                ...)\n\nThat will mean we retain the current traceback and don\u0027t switch greenthreads while logging.","commit_id":"cd543ef9f153b3732cd91586d4c56012562a3c95"},{"author":{"_account_id":29451,"name":"hulina","email":"hulina@cmss.chinamobile.com","username":"hulina"},"change_message_id":"a4358a6e4ce7974111b10d3d706cc15dc8787fa6","unresolved":false,"context_lines":[{"line_number":8657,"context_line":"            bdm \u003d objects.BlockDeviceMapping.get_by_volume_and_instance("},{"line_number":8658,"context_line":"                   context, extended_volume_id, instance.uuid)"},{"line_number":8659,"context_line":"        except exception.NotFound:"},{"line_number":8660,"context_line":"            LOG.warning(\u0027Extend volume failed, \u0027"},{"line_number":8661,"context_line":"                        \u0027volume %(vol)s is not attached to instance.\u0027,"},{"line_number":8662,"context_line":"                        {\u0027vol\u0027: extended_volume_id},"},{"line_number":8663,"context_line":"                        instance\u003dinstance)"},{"line_number":8664,"context_line":"            raise"},{"line_number":8665,"context_line":""},{"line_number":8666,"context_line":"        LOG.info(\u0027Cinder extended volume %(vol)s; \u0027"},{"line_number":8667,"context_line":"                 \u0027extending it to detect new size\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5faad753_9d8d2033","line":8664,"range":{"start_line":8660,"start_character":12,"end_line":8664,"end_character":17},"in_reply_to":"5faad753_58d06451","updated":"2019-09-11 01:30:26.000000000","message":"Thank you, I will modify the patch according to your comments.","commit_id":"cd543ef9f153b3732cd91586d4c56012562a3c95"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6fde43c3e2b30c89af34984ef9f632efb9551471","unresolved":false,"context_lines":[{"line_number":8674,"context_line":"                        \u0027attached volume %(vol)s has no connection_info\u0027,"},{"line_number":8675,"context_line":"                        {\u0027vol\u0027: extended_volume_id},"},{"line_number":8676,"context_line":"                        instance\u003dinstance)"},{"line_number":8677,"context_line":"            raise"},{"line_number":8678,"context_line":""},{"line_number":8679,"context_line":"        connection_info \u003d jsonutils.loads(bdm.connection_info)"},{"line_number":8680,"context_line":"        bdm.volume_size \u003d volume[\u0027size\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"5faad753_f8c4b094","line":8677,"updated":"2019-09-06 12:53:33.000000000","message":"same here","commit_id":"cd543ef9f153b3732cd91586d4c56012562a3c95"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6fde43c3e2b30c89af34984ef9f632efb9551471","unresolved":false,"context_lines":[{"line_number":8692,"context_line":"                        \u0027volume_id\u003d%(volume_id)s, reason: %(msg)s\u0027,"},{"line_number":8693,"context_line":"                        {\u0027volume_id\u0027: extended_volume_id, \u0027msg\u0027: ex},"},{"line_number":8694,"context_line":"                        instance\u003dinstance)"},{"line_number":8695,"context_line":"            raise"},{"line_number":8696,"context_line":""},{"line_number":8697,"context_line":"    @staticmethod"},{"line_number":8698,"context_line":"    def _is_state_valid_for_power_update_event(instance, target_power_state):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5faad753_783680b7","line":8695,"updated":"2019-09-06 12:53:33.000000000","message":"Should probably use save_and_reraise_exception here as well.","commit_id":"cd543ef9f153b3732cd91586d4c56012562a3c95"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"6c3248f286b50e73860334b06e08a57b0b2e6264","unresolved":false,"context_lines":[{"line_number":8670,"context_line":"        volume \u003d self.volume_api.get(context, bdm.volume_id)"},{"line_number":8671,"context_line":""},{"line_number":8672,"context_line":"        try:"},{"line_number":8673,"context_line":"           if bdm.connection_info:"},{"line_number":8674,"context_line":"              connection_info \u003d jsonutils.loads(bdm.connection_info)"},{"line_number":8675,"context_line":"        except exception.NotFound:"},{"line_number":8676,"context_line":"            with excutils.save_and_reraise_exception():"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_0737a6e5","line":8673,"updated":"2019-09-20 10:10:54.000000000","message":"Your pepe8 test failed also because of this, here indentation is wrong. The indentation should be a multiple of 4.","commit_id":"a1ad65239383bcadd3ffabbe67a51caa583a1d4f"},{"author":{"_account_id":29451,"name":"hulina","email":"hulina@cmss.chinamobile.com","username":"hulina"},"change_message_id":"73706a29d7d1aa7eadd7f89187fe3a4715985e9f","unresolved":false,"context_lines":[{"line_number":8670,"context_line":"        volume \u003d self.volume_api.get(context, bdm.volume_id)"},{"line_number":8671,"context_line":""},{"line_number":8672,"context_line":"        try:"},{"line_number":8673,"context_line":"           if bdm.connection_info:"},{"line_number":8674,"context_line":"              connection_info \u003d jsonutils.loads(bdm.connection_info)"},{"line_number":8675,"context_line":"        except exception.NotFound:"},{"line_number":8676,"context_line":"            with excutils.save_and_reraise_exception():"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_7c9a926e","line":8673,"in_reply_to":"3fa7e38b_0737a6e5","updated":"2019-09-23 03:31:09.000000000","message":"yes, i\u0027ll fix it","commit_id":"a1ad65239383bcadd3ffabbe67a51caa583a1d4f"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"5d756eaa7df1f43b12c3a94a41a9d7e2486a5630","unresolved":false,"context_lines":[{"line_number":8669,"context_line":"                 instance\u003dinstance)"},{"line_number":8670,"context_line":"        volume \u003d self.volume_api.get(context, bdm.volume_id)"},{"line_number":8671,"context_line":""},{"line_number":8672,"context_line":"        try:"},{"line_number":8673,"context_line":"           if bdm.connection_info:"},{"line_number":8674,"context_line":"              connection_info \u003d jsonutils.loads(bdm.connection_info)"},{"line_number":8675,"context_line":"        except exception.NotFound:"},{"line_number":8676,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":8677,"context_line":"                LOG.warning(\u0027Extend volume failed, \u0027"},{"line_number":8678,"context_line":"                            \u0027attached volume %(vol)s has no connection_info\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_843154a5","line":8675,"range":{"start_line":8672,"start_character":0,"end_line":8675,"end_character":34},"updated":"2019-09-20 09:40:56.000000000","message":"Do we need this try..except?\n\nmaybe we only do like this.\n        ...\n        if bdm.connection_info is None:\n            with excutils.save_and_reraise_exception():\n                LOG.warning(...","commit_id":"a1ad65239383bcadd3ffabbe67a51caa583a1d4f"},{"author":{"_account_id":29451,"name":"hulina","email":"hulina@cmss.chinamobile.com","username":"hulina"},"change_message_id":"5912abf04f5ff90b0932f8bcd1b8502daea0fbe5","unresolved":false,"context_lines":[{"line_number":8669,"context_line":"                 instance\u003dinstance)"},{"line_number":8670,"context_line":"        volume \u003d self.volume_api.get(context, bdm.volume_id)"},{"line_number":8671,"context_line":""},{"line_number":8672,"context_line":"        try:"},{"line_number":8673,"context_line":"           if bdm.connection_info:"},{"line_number":8674,"context_line":"              connection_info \u003d jsonutils.loads(bdm.connection_info)"},{"line_number":8675,"context_line":"        except exception.NotFound:"},{"line_number":8676,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":8677,"context_line":"                LOG.warning(\u0027Extend volume failed, \u0027"},{"line_number":8678,"context_line":"                            \u0027attached volume %(vol)s has no connection_info\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_fcae8296","line":8675,"range":{"start_line":8672,"start_character":0,"end_line":8675,"end_character":34},"in_reply_to":"3fa7e38b_843154a5","updated":"2019-09-23 03:29:38.000000000","message":"I used like this:\n      ...\n        if bdm.connection_info is None:\n            with excutils.save_and_reraise_exception():\n                LOG.warning(...\nnova report an error that There is no (currently) captured exception to force the reraising of.\nmaybe we must capture exception firstly, then we save the exception state, run handler code, and then re-raise the original exception. If another exception occurs, the saved exception is logged and the new exception is re-raised, is it?","commit_id":"a1ad65239383bcadd3ffabbe67a51caa583a1d4f"},{"author":{"_account_id":29451,"name":"hulina","email":"hulina@cmss.chinamobile.com","username":"hulina"},"change_message_id":"2c85a0743d53ff712c4bc7e22428327b53796601","unresolved":false,"context_lines":[{"line_number":8669,"context_line":"                 instance\u003dinstance)"},{"line_number":8670,"context_line":"        volume \u003d self.volume_api.get(context, bdm.volume_id)"},{"line_number":8671,"context_line":""},{"line_number":8672,"context_line":"        try:"},{"line_number":8673,"context_line":"           if bdm.connection_info:"},{"line_number":8674,"context_line":"              connection_info \u003d jsonutils.loads(bdm.connection_info)"},{"line_number":8675,"context_line":"        except exception.NotFound:"},{"line_number":8676,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":8677,"context_line":"                LOG.warning(\u0027Extend volume failed, \u0027"},{"line_number":8678,"context_line":"                            \u0027attached volume %(vol)s has no connection_info\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_0468041f","line":8675,"range":{"start_line":8672,"start_character":0,"end_line":8675,"end_character":34},"in_reply_to":"3fa7e38b_843154a5","updated":"2019-09-20 09:54:34.000000000","message":"Sorry, i am not very familiar with the use of save_and_reraise_exception, mistaken for having to work with try except","commit_id":"a1ad65239383bcadd3ffabbe67a51caa583a1d4f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"82c58edacacfc449f515277f5df3659ed9ca0b58","unresolved":false,"context_lines":[{"line_number":8670,"context_line":"        volume \u003d self.volume_api.get(context, bdm.volume_id)"},{"line_number":8671,"context_line":""},{"line_number":8672,"context_line":"        try:"},{"line_number":8673,"context_line":"            if bdm.connection_info:"},{"line_number":8674,"context_line":"                connection_info \u003d jsonutils.loads(bdm.connection_info)"},{"line_number":8675,"context_line":"        except exception.NotFound:"},{"line_number":8676,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":8677,"context_line":"                LOG.warning(\u0027Extend volume failed, \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"bf51134e_661a1e17","line":8674,"range":{"start_line":8673,"start_character":0,"end_line":8674,"end_character":70},"updated":"2020-06-26 17:26:22.000000000","message":"This isn\u0027t the same. Previously, the check would fail if \u0027connection_info\u0027 was None. Now it will only fail if it\u0027s but is invalid JSON. It sounds like we want two checks here","commit_id":"c9f36071b00ceb0698b1c2959bc14844e2cd999c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"82c58edacacfc449f515277f5df3659ed9ca0b58","unresolved":false,"context_lines":[{"line_number":8672,"context_line":"        try:"},{"line_number":8673,"context_line":"            if bdm.connection_info:"},{"line_number":8674,"context_line":"                connection_info \u003d jsonutils.loads(bdm.connection_info)"},{"line_number":8675,"context_line":"        except exception.NotFound:"},{"line_number":8676,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":8677,"context_line":"                LOG.warning(\u0027Extend volume failed, \u0027"},{"line_number":8678,"context_line":"                            \u0027attached volume %(vol)s has no connection_info\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"bf51134e_46155ae4","line":8675,"range":{"start_line":8675,"start_character":15,"end_line":8675,"end_character":34},"updated":"2020-06-26 17:26:22.000000000","message":"What\u0027s raising this?","commit_id":"c9f36071b00ceb0698b1c2959bc14844e2cd999c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"82c58edacacfc449f515277f5df3659ed9ca0b58","unresolved":false,"context_lines":[{"line_number":8673,"context_line":"            if bdm.connection_info:"},{"line_number":8674,"context_line":"                connection_info \u003d jsonutils.loads(bdm.connection_info)"},{"line_number":8675,"context_line":"        except exception.NotFound:"},{"line_number":8676,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":8677,"context_line":"                LOG.warning(\u0027Extend volume failed, \u0027"},{"line_number":8678,"context_line":"                            \u0027attached volume %(vol)s has no connection_info\u0027,"},{"line_number":8679,"context_line":"                            {\u0027vol\u0027: extended_volume_id},"}],"source_content_type":"text/x-python","patch_set":6,"id":"bf51134e_e60d8ee8","line":8676,"range":{"start_line":8676,"start_character":12,"end_line":8676,"end_character":55},"updated":"2020-06-26 17:26:22.000000000","message":"Do we need this? Could we do\n\n  LOG.warning(...)\n  raise\n\nlike below?","commit_id":"c9f36071b00ceb0698b1c2959bc14844e2cd999c"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"82c58edacacfc449f515277f5df3659ed9ca0b58","unresolved":false,"context_lines":[{"line_number":8695,"context_line":"                LOG.warning(\u0027Extend volume failed, \u0027"},{"line_number":8696,"context_line":"                            \u0027volume_id\u003d%(volume_id)s, reason: %(msg)s\u0027,"},{"line_number":8697,"context_line":"                            {\u0027volume_id\u0027: extended_volume_id, \u0027msg\u0027: ex},"},{"line_number":8698,"context_line":"                            instance\u003dinstance)"},{"line_number":8699,"context_line":""},{"line_number":8700,"context_line":"    @staticmethod"},{"line_number":8701,"context_line":"    def _is_state_valid_for_power_update_event(instance, target_power_state):"}],"source_content_type":"text/x-python","patch_set":6,"id":"bf51134e_26fb06c1","line":8698,"updated":"2020-06-26 17:26:22.000000000","message":"Is this change necessary? It\u0027s the same thing unless \u0027LOG.warning\u0027 raises an exception, no?","commit_id":"c9f36071b00ceb0698b1c2959bc14844e2cd999c"}],"nova/tests/unit/compute/test_compute_mgr.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"4bd928c74e742762abbe7b4a2e87c3becb239ef9","unresolved":false,"context_lines":[{"line_number":3210,"context_line":""},{"line_number":3211,"context_line":"    def test_extend_volume_connection_is_None(self):"},{"line_number":3212,"context_line":"        \"\"\"Tests the case where driver.extend_volume tries to extend"},{"line_number":3213,"context_line":"        a volume, which bdm.connextion_info is None."},{"line_number":3214,"context_line":"        \"\"\""},{"line_number":3215,"context_line":"        inst_obj \u003d objects.Instance(id\u003d3, uuid\u003duuids.instance)"},{"line_number":3216,"context_line":"        bdm \u003d objects.BlockDeviceMapping("}],"source_content_type":"text/x-python","patch_set":4,"id":"1f493fa4_1172054a","line":3213,"range":{"start_line":3213,"start_character":28,"end_line":3213,"end_character":43},"updated":"2020-05-07 09:50:05.000000000","message":"connection_info","commit_id":"8c0116320cc01e82aa4d9ebba71e067408eb4f6d"},{"author":{"_account_id":29451,"name":"hulina","email":"hulina@cmss.chinamobile.com","username":"hulina"},"change_message_id":"9b37c18038afd4a90375217098dfac994dc6cd81","unresolved":false,"context_lines":[{"line_number":3210,"context_line":""},{"line_number":3211,"context_line":"    def test_extend_volume_connection_is_None(self):"},{"line_number":3212,"context_line":"        \"\"\"Tests the case where driver.extend_volume tries to extend"},{"line_number":3213,"context_line":"        a volume, which bdm.connextion_info is None."},{"line_number":3214,"context_line":"        \"\"\""},{"line_number":3215,"context_line":"        inst_obj \u003d objects.Instance(id\u003d3, uuid\u003duuids.instance)"},{"line_number":3216,"context_line":"        bdm \u003d objects.BlockDeviceMapping("}],"source_content_type":"text/x-python","patch_set":4,"id":"ff570b3c_bbef5e1b","line":3213,"range":{"start_line":3213,"start_character":28,"end_line":3213,"end_character":43},"in_reply_to":"1f493fa4_1172054a","updated":"2020-06-03 01:41:37.000000000","message":"yes,i\u0027ll fix it","commit_id":"8c0116320cc01e82aa4d9ebba71e067408eb4f6d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"82c58edacacfc449f515277f5df3659ed9ca0b58","unresolved":false,"context_lines":[{"line_number":3210,"context_line":""},{"line_number":3211,"context_line":"    def test_extend_volume_connection_is_None(self):"},{"line_number":3212,"context_line":"        \"\"\"Tests the case where driver.extend_volume tries to extend"},{"line_number":3213,"context_line":"        a volume, which bdm.connection_info is None."},{"line_number":3214,"context_line":"        \"\"\""},{"line_number":3215,"context_line":"        inst_obj \u003d objects.Instance(id\u003d3, uuid\u003duuids.instance)"},{"line_number":3216,"context_line":"        bdm \u003d objects.BlockDeviceMapping("}],"source_content_type":"text/x-python","patch_set":6,"id":"bf51134e_c6de8a3c","line":3213,"range":{"start_line":3213,"start_character":18,"end_line":3213,"end_character":52},"updated":"2020-06-26 17:26:22.000000000","message":"this is not what you\u0027re testing. You\u0027re testing that the BDM lookup (\u0027get_by_volume_and_instance\u0027) fails","commit_id":"c9f36071b00ceb0698b1c2959bc14844e2cd999c"}]}