)]}'
{"api-ref/source/os-volume-attachments.inc":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"697166d3dd44149b6fb882ce03e83b1c347fb766","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"**Example List volume attachments for an instance: JSON response**"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":".. literalinclude:: ../../doc/api_samples/os-volumes/v2.79/list-volume-attachments-resp.json"},{"line_number":47,"context_line":"   :language: javascript"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"**Example List tagged volume attachments for an instance (v2.70): JSON response**"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"5faad753_12fdd139","line":46,"updated":"2019-09-09 04:47:21.000000000","message":"According to the commants in https://review.opendev.org/#/c/673133/15/api-ref/source/os-volume-attachments.inc, a v2.1 example and a v2.79 example should be shown here.\nSo replace the v2.70 example with v2.79 example.","commit_id":"af63dd931cd1a38ff031293dbbda3d16dad0f6bc"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"2da92319b950e15200731063b5f94c8395da71ea","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"**Example List volume attachments for an instance: JSON response**"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":".. literalinclude:: ../../doc/api_samples/os-volumes/v2.79/list-volume-attachments-resp.json"},{"line_number":47,"context_line":"   :language: javascript"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"**Example List tagged volume attachments for an instance (v2.70): JSON response**"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"5faad753_75f50fcb","line":46,"in_reply_to":"5faad753_12fdd139","updated":"2019-09-09 05:44:43.000000000","message":"Done","commit_id":"af63dd931cd1a38ff031293dbbda3d16dad0f6bc"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"697166d3dd44149b6fb882ce03e83b1c347fb766","unresolved":false,"context_lines":[{"line_number":159,"context_line":""},{"line_number":160,"context_line":"**Example Show a detail of a volume attachment: JSON response**"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":".. literalinclude:: ../../doc/api_samples/os-volumes/v2.79/volume-attachment-detail-resp.json"},{"line_number":163,"context_line":"   :language: javascript"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"**Example Show a detail of a tagged volume attachment (v2.70): JSON response**"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"5faad753_32fa4d42","line":162,"updated":"2019-09-09 04:47:21.000000000","message":"ditto","commit_id":"af63dd931cd1a38ff031293dbbda3d16dad0f6bc"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"2da92319b950e15200731063b5f94c8395da71ea","unresolved":false,"context_lines":[{"line_number":159,"context_line":""},{"line_number":160,"context_line":"**Example Show a detail of a volume attachment: JSON response**"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":".. literalinclude:: ../../doc/api_samples/os-volumes/v2.79/volume-attachment-detail-resp.json"},{"line_number":163,"context_line":"   :language: javascript"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"**Example Show a detail of a tagged volume attachment (v2.70): JSON response**"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"5faad753_15029bb5","line":162,"in_reply_to":"5faad753_32fa4d42","updated":"2019-09-09 05:44:43.000000000","message":"Done","commit_id":"af63dd931cd1a38ff031293dbbda3d16dad0f6bc"}],"nova/api/openstack/compute/rest_api_version_history.rst":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"d1c03b984803c2b811e1d3e806581a0649131e34","unresolved":false,"context_lines":[{"line_number":1019,"context_line":"field in the request body when attaching a volume to a server, to support"},{"line_number":1020,"context_line":"configuring whether to delete the data volume when the server is destroyed."},{"line_number":1021,"context_line":"Also, ``delete_on_termination`` is added to the GET responses when showing"},{"line_number":1022,"context_line":"attached volumes, and the ``delete_on_termination`` field will be contained"},{"line_number":1023,"context_line":"in POST API response body."},{"line_number":1024,"context_line":""},{"line_number":1025,"context_line":"The affected APIs are as follows:"}],"source_content_type":"text/x-rst","patch_set":4,"id":"5faad753_842b9280","line":1022,"range":{"start_line":1022,"start_character":58,"end_line":1022,"end_character":65},"updated":"2019-09-10 16:42:20.000000000","message":"s/will be/is/","commit_id":"1c810dd08da23dba3de73f31e40ffbd5efcef2d4"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"79bb2725679667ffb5febf2e37cf79281b7ed0cf","unresolved":false,"context_lines":[{"line_number":1019,"context_line":"field in the request body when attaching a volume to a server, to support"},{"line_number":1020,"context_line":"configuring whether to delete the data volume when the server is destroyed."},{"line_number":1021,"context_line":"Also, ``delete_on_termination`` is added to the GET responses when showing"},{"line_number":1022,"context_line":"attached volumes, and the ``delete_on_termination`` field will be contained"},{"line_number":1023,"context_line":"in POST API response body."},{"line_number":1024,"context_line":""},{"line_number":1025,"context_line":"The affected APIs are as follows:"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3fa7e38b_fdd43249","line":1022,"range":{"start_line":1022,"start_character":58,"end_line":1022,"end_character":65},"in_reply_to":"5faad753_842b9280","updated":"2019-10-09 07:20:33.000000000","message":"Done","commit_id":"1c810dd08da23dba3de73f31e40ffbd5efcef2d4"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"d1c03b984803c2b811e1d3e806581a0649131e34","unresolved":false,"context_lines":[{"line_number":1020,"context_line":"configuring whether to delete the data volume when the server is destroyed."},{"line_number":1021,"context_line":"Also, ``delete_on_termination`` is added to the GET responses when showing"},{"line_number":1022,"context_line":"attached volumes, and the ``delete_on_termination`` field will be contained"},{"line_number":1023,"context_line":"in POST API response body."},{"line_number":1024,"context_line":""},{"line_number":1025,"context_line":"The affected APIs are as follows:"},{"line_number":1026,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"5faad753_040ec231","line":1023,"range":{"start_line":1023,"start_character":25,"end_line":1023,"end_character":26},"updated":"2019-09-10 16:42:20.000000000","message":"when attaching a volume.","commit_id":"1c810dd08da23dba3de73f31e40ffbd5efcef2d4"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"79bb2725679667ffb5febf2e37cf79281b7ed0cf","unresolved":false,"context_lines":[{"line_number":1020,"context_line":"configuring whether to delete the data volume when the server is destroyed."},{"line_number":1021,"context_line":"Also, ``delete_on_termination`` is added to the GET responses when showing"},{"line_number":1022,"context_line":"attached volumes, and the ``delete_on_termination`` field will be contained"},{"line_number":1023,"context_line":"in POST API response body."},{"line_number":1024,"context_line":""},{"line_number":1025,"context_line":"The affected APIs are as follows:"},{"line_number":1026,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"3fa7e38b_9dcbbea3","line":1023,"range":{"start_line":1023,"start_character":25,"end_line":1023,"end_character":26},"in_reply_to":"5faad753_040ec231","updated":"2019-10-09 07:20:33.000000000","message":"Done","commit_id":"1c810dd08da23dba3de73f31e40ffbd5efcef2d4"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"3723952b7597debbca32a29cc340a32152d89ad4","unresolved":false,"context_lines":[{"line_number":1048,"context_line":"configuring whether to delete the data volume when the server is destroyed."},{"line_number":1049,"context_line":"Also, ``delete_on_termination`` is added to the GET responses when showing"},{"line_number":1050,"context_line":"attached volumes, and the ``delete_on_termination`` field is contained"},{"line_number":1051,"context_line":"in POST API response body when attaching a volume."},{"line_number":1052,"context_line":""},{"line_number":1053,"context_line":"The affected APIs are as follows:"},{"line_number":1054,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"3fa7e38b_4f4ab35a","line":1051,"range":{"start_line":1051,"start_character":0,"end_line":1051,"end_character":2},"updated":"2020-02-19 19:11:57.000000000","message":"in the","commit_id":"9ae8d2cd932da66dc42fb2f6e37b65e329cbdc34"}],"nova/tests/unit/api/openstack/compute/test_volumes.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"eb6f9b0e64972c5385627afa8de1805e3207f3d5","unresolved":false,"context_lines":[{"line_number":1111,"context_line":"        req.method \u003d \u0027GET\u0027"},{"line_number":1112,"context_line":"        result \u003d self.attachments.show(req, FAKE_UUID, FAKE_UUID_A)"},{"line_number":1113,"context_line":""},{"line_number":1114,"context_line":"        # Delete the delete_on_termination from the init expected_show"},{"line_number":1115,"context_line":"        del self.expected_show[\u0027volumeAttachment\u0027][\u0027delete_on_termination\u0027]"},{"line_number":1116,"context_line":"        self.assertEqual(self.expected_show, result)"},{"line_number":1117,"context_line":""},{"line_number":1118,"context_line":""},{"line_number":1119,"context_line":"class SwapVolumeMultiattachTestCase(test.NoDBTestCase):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5faad753_261c4b69","line":1116,"range":{"start_line":1114,"start_character":0,"end_line":1116,"end_character":52},"updated":"2019-09-09 09:16:45.000000000","message":"you can just check \u0027delete_on_termination\u0027 exist or not\n\n        self.assertNotIn(\u0027delete_on_termination\u0027, result[\u0027volumeAttachment\u0027])","commit_id":"5966197ad926f7ec8b7697d71957db4791a18664"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"a1ca4a154d57650ec38f51f2d8e664aad901611f","unresolved":false,"context_lines":[{"line_number":1111,"context_line":"        req.method \u003d \u0027GET\u0027"},{"line_number":1112,"context_line":"        result \u003d self.attachments.show(req, FAKE_UUID, FAKE_UUID_A)"},{"line_number":1113,"context_line":""},{"line_number":1114,"context_line":"        # Delete the delete_on_termination from the init expected_show"},{"line_number":1115,"context_line":"        del self.expected_show[\u0027volumeAttachment\u0027][\u0027delete_on_termination\u0027]"},{"line_number":1116,"context_line":"        self.assertEqual(self.expected_show, result)"},{"line_number":1117,"context_line":""},{"line_number":1118,"context_line":""},{"line_number":1119,"context_line":"class SwapVolumeMultiattachTestCase(test.NoDBTestCase):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5faad753_c61217b2","line":1116,"range":{"start_line":1114,"start_character":0,"end_line":1116,"end_character":52},"in_reply_to":"5faad753_261c4b69","updated":"2019-09-09 11:06:20.000000000","message":"Done","commit_id":"5966197ad926f7ec8b7697d71957db4791a18664"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"eb6f9b0e64972c5385627afa8de1805e3207f3d5","unresolved":false,"context_lines":[{"line_number":1114,"context_line":"        # Delete the delete_on_termination from the init expected_show"},{"line_number":1115,"context_line":"        del self.expected_show[\u0027volumeAttachment\u0027][\u0027delete_on_termination\u0027]"},{"line_number":1116,"context_line":"        self.assertEqual(self.expected_show, result)"},{"line_number":1117,"context_line":""},{"line_number":1118,"context_line":""},{"line_number":1119,"context_line":"class SwapVolumeMultiattachTestCase(test.NoDBTestCase):"},{"line_number":1120,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5faad753_a656fb05","line":1117,"range":{"start_line":1117,"start_character":0,"end_line":1117,"end_character":0},"updated":"2019-09-09 09:16:45.000000000","message":"also add test for index.\n\ndef test_list_pre_v279(self):\n        \"\"\"Before microversion 2.79, list of a volume attachment\n        does not contain the \u0027delete_on_termination\u0027 field in the response\n        body.\n        \"\"\"\n        req \u003d self._get_req(body\u003d{}, microversion\u003d\u00272.78\u0027)\n        req.method \u003d \u0027GET\u0027\n        result \u003d self.attachments.index(req, FAKE_UUID_A)\n\n        self.assertNotIn(\u0027delete_on_termination\u0027, result[\u0027volumeAttachment\u0027])","commit_id":"5966197ad926f7ec8b7697d71957db4791a18664"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"a1ca4a154d57650ec38f51f2d8e664aad901611f","unresolved":false,"context_lines":[{"line_number":1114,"context_line":"        # Delete the delete_on_termination from the init expected_show"},{"line_number":1115,"context_line":"        del self.expected_show[\u0027volumeAttachment\u0027][\u0027delete_on_termination\u0027]"},{"line_number":1116,"context_line":"        self.assertEqual(self.expected_show, result)"},{"line_number":1117,"context_line":""},{"line_number":1118,"context_line":""},{"line_number":1119,"context_line":"class SwapVolumeMultiattachTestCase(test.NoDBTestCase):"},{"line_number":1120,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5faad753_6627a314","line":1117,"range":{"start_line":1117,"start_character":0,"end_line":1117,"end_character":0},"in_reply_to":"5faad753_a656fb05","updated":"2019-09-09 11:06:20.000000000","message":"Done","commit_id":"5966197ad926f7ec8b7697d71957db4791a18664"}],"releasenotes/notes/bp-support-delete-on-termination-in-server-attach-volume-5d08b4e97fdd24f9.yaml":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"d1c03b984803c2b811e1d3e806581a0649131e34","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    field in the request body when attaching a volume to a server, to support"},{"line_number":6,"context_line":"    configuring whether to delete the data volume when the server is destroyed."},{"line_number":7,"context_line":"    Also, ``delete_on_termination`` is added to the GET responses when showing"},{"line_number":8,"context_line":"    attached volumes, and the ``delete_on_termination`` field will be contained"},{"line_number":9,"context_line":"    in POST API response body."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"    The affected APIs are as follows:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5faad753_e10d983e","line":8,"range":{"start_line":8,"start_character":62,"end_line":8,"end_character":69},"updated":"2019-09-10 16:42:20.000000000","message":"s/will be/is/","commit_id":"1c810dd08da23dba3de73f31e40ffbd5efcef2d4"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"79bb2725679667ffb5febf2e37cf79281b7ed0cf","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    field in the request body when attaching a volume to a server, to support"},{"line_number":6,"context_line":"    configuring whether to delete the data volume when the server is destroyed."},{"line_number":7,"context_line":"    Also, ``delete_on_termination`` is added to the GET responses when showing"},{"line_number":8,"context_line":"    attached volumes, and the ``delete_on_termination`` field will be contained"},{"line_number":9,"context_line":"    in POST API response body."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"    The affected APIs are as follows:"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_9d409e09","line":8,"range":{"start_line":8,"start_character":62,"end_line":8,"end_character":69},"in_reply_to":"5faad753_e10d983e","updated":"2019-10-09 07:20:33.000000000","message":"Done","commit_id":"1c810dd08da23dba3de73f31e40ffbd5efcef2d4"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"d1c03b984803c2b811e1d3e806581a0649131e34","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    configuring whether to delete the data volume when the server is destroyed."},{"line_number":7,"context_line":"    Also, ``delete_on_termination`` is added to the GET responses when showing"},{"line_number":8,"context_line":"    attached volumes, and the ``delete_on_termination`` field will be contained"},{"line_number":9,"context_line":"    in POST API response body."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"    The affected APIs are as follows:"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5faad753_e4128658","line":9,"range":{"start_line":9,"start_character":29,"end_line":9,"end_character":30},"updated":"2019-09-10 16:42:20.000000000","message":"when attaching a volume.","commit_id":"1c810dd08da23dba3de73f31e40ffbd5efcef2d4"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"79bb2725679667ffb5febf2e37cf79281b7ed0cf","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    configuring whether to delete the data volume when the server is destroyed."},{"line_number":7,"context_line":"    Also, ``delete_on_termination`` is added to the GET responses when showing"},{"line_number":8,"context_line":"    attached volumes, and the ``delete_on_termination`` field will be contained"},{"line_number":9,"context_line":"    in POST API response body."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"    The affected APIs are as follows:"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_bd431a13","line":9,"range":{"start_line":9,"start_character":29,"end_line":9,"end_character":30},"in_reply_to":"5faad753_e4128658","updated":"2019-10-09 07:20:33.000000000","message":"Done","commit_id":"1c810dd08da23dba3de73f31e40ffbd5efcef2d4"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"3723952b7597debbca32a29cc340a32152d89ad4","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    configuring whether to delete the data volume when the server is destroyed."},{"line_number":7,"context_line":"    Also, ``delete_on_termination`` is added to the GET responses when showing"},{"line_number":8,"context_line":"    attached volumes, and the ``delete_on_termination`` field is contained"},{"line_number":9,"context_line":"    in POST API response body when attaching a volume."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"    The affected APIs are as follows:"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3fa7e38b_ef4eff6b","line":9,"range":{"start_line":9,"start_character":4,"end_line":9,"end_character":6},"updated":"2020-02-19 19:11:57.000000000","message":"in the","commit_id":"9ae8d2cd932da66dc42fb2f6e37b65e329cbdc34"}]}