)]}'
{"doc/api_samples/os-volumes/list-volume-attachments-resp.json":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"98583331d4039737c93fd9ff57daa16213363f5f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"volumeAttachments\": ["},{"line_number":3,"context_line":"        {"},{"line_number":4,"context_line":"            \"device\": \"/dev/sdb\","},{"line_number":5,"context_line":"            \"id\": \"a07f71dc-8151-4e7d-a0cc-cd24a3f11113\","},{"line_number":6,"context_line":"            \"serverId\": \"fd5bb1c4-de31-4071-8472-9410bc9155ec\","},{"line_number":7,"context_line":"            \"volumeId\": \"a07f71dc-8151-4e7d-a0cc-cd24a3f11113\""},{"line_number":8,"context_line":"        }"},{"line_number":9,"context_line":"    ]"},{"line_number":10,"context_line":"}"}],"source_content_type":"application/json","patch_set":3,"id":"5faad753_f1e79ce3","line":8,"range":{"start_line":3,"start_character":0,"end_line":8,"end_character":9},"updated":"2019-09-11 07:56:24.000000000","message":"IMO, the example of the response body of the \u0027list\u0027 API had better have multiple volume attachment items in the API reference.\n\nhttps://2dfe92361451b97fe3b2-ea1b996598061886e0c0a8d1c7e56346.ssl.cf2.rackcdn.com/680834/3/check/build-openstack-api-ref/d16499b/docs/?expanded\u003dlist-volume-attachments-for-an-instance-detail#list-volume-attachments-for-an-instance","commit_id":"df28420760c606285da704b82ffdd1dd5c317e6c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"79712cdc4ce33c4857a93875e1bb32f9c5a27b12","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"volumeAttachments\": ["},{"line_number":3,"context_line":"        {"},{"line_number":4,"context_line":"            \"device\": \"/dev/sdb\","},{"line_number":5,"context_line":"            \"id\": \"a07f71dc-8151-4e7d-a0cc-cd24a3f11113\","},{"line_number":6,"context_line":"            \"serverId\": \"fd5bb1c4-de31-4071-8472-9410bc9155ec\","},{"line_number":7,"context_line":"            \"volumeId\": \"a07f71dc-8151-4e7d-a0cc-cd24a3f11113\""},{"line_number":8,"context_line":"        }"},{"line_number":9,"context_line":"    ]"},{"line_number":10,"context_line":"}"}],"source_content_type":"application/json","patch_set":3,"id":"5faad753_6e95f13f","line":8,"range":{"start_line":3,"start_character":0,"end_line":8,"end_character":9},"in_reply_to":"5faad753_0e09dddb","updated":"2019-09-11 21:44:09.000000000","message":"Done here: https://review.opendev.org/#/c/681618/","commit_id":"df28420760c606285da704b82ffdd1dd5c317e6c"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"87d004a5e592e6cbd02e7a21356e74894055c050","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"volumeAttachments\": ["},{"line_number":3,"context_line":"        {"},{"line_number":4,"context_line":"            \"device\": \"/dev/sdb\","},{"line_number":5,"context_line":"            \"id\": \"a07f71dc-8151-4e7d-a0cc-cd24a3f11113\","},{"line_number":6,"context_line":"            \"serverId\": \"fd5bb1c4-de31-4071-8472-9410bc9155ec\","},{"line_number":7,"context_line":"            \"volumeId\": \"a07f71dc-8151-4e7d-a0cc-cd24a3f11113\""},{"line_number":8,"context_line":"        }"},{"line_number":9,"context_line":"    ]"},{"line_number":10,"context_line":"}"}],"source_content_type":"application/json","patch_set":3,"id":"3fa7e38b_efdfd5d3","line":8,"range":{"start_line":3,"start_character":0,"end_line":8,"end_character":9},"in_reply_to":"5faad753_6e95f13f","updated":"2019-09-19 13:36:40.000000000","message":"Okay. Thanks.","commit_id":"df28420760c606285da704b82ffdd1dd5c317e6c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a34976321ca45a36a525e50fff12a734da16d3c7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"volumeAttachments\": ["},{"line_number":3,"context_line":"        {"},{"line_number":4,"context_line":"            \"device\": \"/dev/sdb\","},{"line_number":5,"context_line":"            \"id\": \"a07f71dc-8151-4e7d-a0cc-cd24a3f11113\","},{"line_number":6,"context_line":"            \"serverId\": \"fd5bb1c4-de31-4071-8472-9410bc9155ec\","},{"line_number":7,"context_line":"            \"volumeId\": \"a07f71dc-8151-4e7d-a0cc-cd24a3f11113\""},{"line_number":8,"context_line":"        }"},{"line_number":9,"context_line":"    ]"},{"line_number":10,"context_line":"}"}],"source_content_type":"application/json","patch_set":3,"id":"5faad753_0e09dddb","line":8,"range":{"start_line":3,"start_character":0,"end_line":8,"end_character":9},"in_reply_to":"5faad753_f1e79ce3","updated":"2019-09-11 21:29:39.000000000","message":"This is already a large change. Is this something that can be hacked up in a follow up change?","commit_id":"df28420760c606285da704b82ffdd1dd5c317e6c"}],"nova/tests/functional/api_sample_tests/test_volumes.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"4d2ee41ce7d69ec1b1fbe08207680abf199be83f","unresolved":false,"context_lines":[{"line_number":218,"context_line":"        return subs"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    def test_list_volume_attachments(self):"},{"line_number":221,"context_line":"        subs \u003d self.test_attach_volume_to_server()"},{"line_number":222,"context_line":"        response \u003d self._do_get(\u0027servers/%s/os-volume_attachments\u0027"},{"line_number":223,"context_line":"                                % self.server_id)"},{"line_number":224,"context_line":"        self._verify_response(\u0027list-volume-attachments-resp\u0027, subs,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5faad753_c073d1e6","line":221,"range":{"start_line":221,"start_character":8,"end_line":221,"end_character":50},"updated":"2019-09-09 18:55:58.000000000","message":"Feels weird for test case to be running other test case. Should test_attach_volume_to_server have a non-test_ name? At least that way it gets run one less time...\n\n...or better yet, move the guts of test_attach_volume_to_server into setUp() and save subs in an instance var?\n\n(tried that, wfm)","commit_id":"df28420760c606285da704b82ffdd1dd5c317e6c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f8e310c9e9999f44892dcc21bd370ee18d15df19","unresolved":false,"context_lines":[{"line_number":218,"context_line":"        return subs"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    def test_list_volume_attachments(self):"},{"line_number":221,"context_line":"        subs \u003d self.test_attach_volume_to_server()"},{"line_number":222,"context_line":"        response \u003d self._do_get(\u0027servers/%s/os-volume_attachments\u0027"},{"line_number":223,"context_line":"                                % self.server_id)"},{"line_number":224,"context_line":"        self._verify_response(\u0027list-volume-attachments-resp\u0027, subs,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5faad753_a709eb95","line":221,"range":{"start_line":221,"start_character":8,"end_line":221,"end_character":50},"in_reply_to":"5faad753_c073d1e6","updated":"2019-09-10 22:44:55.000000000","message":"Yeah IDK, I could have also just created one big test that does all of this (create a server, attach a volume, list attachments, show the attachment and then detach it) but that\u0027s not generally how these API samples tests work.","commit_id":"df28420760c606285da704b82ffdd1dd5c317e6c"}]}