)]}'
{"id":"openstack%2Fnova~680869","triplet_id":"openstack%2Fnova~stable%2Fstein~I857ad7264f1a7ef1263d8a9d4eca491d6c8dce0f","project":"openstack/nova","branch":"stable/stein","topic":"bug/1735009","hashtags":[],"change_id":"I857ad7264f1a7ef1263d8a9d4eca491d6c8dce0f","subject":"Fix rebuild of baremetal instance when vm_state is ERROR","status":"MERGED","created":"2019-09-08 14:57:46.000000000","updated":"2019-09-18 17:37:45.000000000","submitted":"2019-09-18 17:31:19.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"680869-1568827879400-4f1731f4","meta_rev_id":"c9c5b63425cf9d3e2a51dac0eb390b42c97f62a5","_number":680869,"virtual_id_number":680869,"owner":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"date":"2019-09-08 17:06:00.000000000","_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"date":"2019-09-08 17:11:05.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":2,"date":"2019-09-18 17:31:17.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"recommended":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"all":[{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":1,"date":"2019-09-10 15:24:17.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":2,"date":"2019-09-18 14:29:58.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"all":[{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":1,"date":"2019-09-18 14:29:58.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},{"value":0,"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-09-08 17:06:00.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"REVIEWER"},{"updated":"2019-09-08 17:11:05.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-09-10 15:24:17.000000000","updated_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"reviewer":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"state":"REVIEWER"},{"updated":"2019-09-18 14:29:58.000000000","updated_by":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"reviewer":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"state":"REVIEWER"},{"updated":"2019-09-18 17:31:17.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"94feee512039a1246cfa427d23f563dea7618116","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-09-08 14:57:46.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"4fd90e4b933b1b95f4149c7a0d33102e2271ebc2","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2019-09-08 14:57:55.000000000","message":"Topic changed from bug/1735009-stable/stein to bug/1735009","accounts_in_message":[],"_revision_number":1},{"id":"df54f4e50c930d68b1f991129f5debe87a25ba35","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2019-09-08 17:06:00.000000000","message":"Patch Set 1:\n\nBuild succeeded.\n\n- nova http://cloudbase-ci.com/nova/680869/1 : SUCCESS in 2h 07m 06s","accounts_in_message":[],"_revision_number":1},{"id":"76d4f30d230b4267a87dd3dc476b68cd99628ab2","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2019-09-08 17:11:05.000000000","message":"Patch Set 1:\n\nBuild succeeded. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm: recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-xenial https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/69/680869/1/check/tempest-dsvm-full-xenial/7f8ab13/ : SUCCESS in 1h 51m 07s\n- tempest-dsvm-full-xenial-py3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/69/680869/1/check/tempest-dsvm-full-xenial-py3/2cea069/ : SUCCESS in 1h 57m 52s (non-voting)\n- grenade-dsvm-xenial https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/69/680869/1/check/grenade-dsvm-xenial/c49acde/ : SUCCESS in 1h 10m 19s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"fad2585c04e11e3b4a330930d48e4cbbe6b0b96f","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-08 17:30:51.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/7b1eaf4ce6ae40dbb5097ddfd9917cc7 : SUCCESS in 1h 01m 16s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/fb4f78c6540b42b383a5522258d71751 : SUCCESS in 1h 30m 32s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/fd9cf464f7ab4a9688298460ec67859f : SUCCESS in 17m 12s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/602864d470d4487b8f905184234ef76b : SUCCESS in 11m 12s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/08353949314c4f328a17f8c7e96fd349 : SUCCESS in 8m 57s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/1a8eb0119d844ee497c751986b0d3555 : SUCCESS in 11m 40s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/75ace22ad7754a33a62c1ab277b58526 : SUCCESS in 12m 28s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/920b3bfab17940719a567d54ddf9f3ad : SUCCESS in 11m 17s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/28ddab6267a74ec6bfa7f1eec97e850c : SUCCESS in 10m 51s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/ba671025e4824f1d8287956a14deebdc : SUCCESS in 6m 31s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/087123ec10154c67bfedaf94da811228 : SUCCESS in 53m 56s (non-voting)\n- devstack-plugin-ceph-tempest https://zuul.opendev.org/t/openstack/build/6197fe94a1434b82998ed10bb6bbf1d5 : SUCCESS in 1h 08m 28s (non-voting)\n- neutron-grenade-multinode https://zuul.opendev.org/t/openstack/build/01aa2a6b74d448a08219cbd8fc61d787 : SUCCESS in 1h 13m 19s\n- nova-grenade-live-migration https://zuul.opendev.org/t/openstack/build/aea0b89a318241f6bdd26a38ed3ccb72 : SUCCESS in 1h 02m 26s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/56059066f76b4bc1af9497d994c798a4 : SUCCESS in 52m 20s\n- nova-next https://zuul.opendev.org/t/openstack/build/eac692e981634b1d8899cab246b9364c : SUCCESS in 1h 19m 42s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/34bee271644f48d0b4a3d3a5f0073d91 : SUCCESS in 18m 49s\n- nova-tox-functional-py35 https://zuul.opendev.org/t/openstack/build/04092983c64a46399cbc8733ac1d827f : SUCCESS in 29m 08s\n- tempest-multinode-full https://zuul.opendev.org/t/openstack/build/388e9d2cf01c43efaa25d929c67368dc : SUCCESS in 1h 43m 25s (non-voting)\n- tempest-slow-py3 https://zuul.opendev.org/t/openstack/build/6a626bd6b1a0422eacf82f4d82663f6e : SUCCESS in 2h 16m 13s","accounts_in_message":[],"_revision_number":1},{"id":"5313aafcc4dd20545152a21010454cbabfbdc7cb","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2019-09-10 15:24:17.000000000","message":"Patch Set 1: Code-Review+1\n\nClean backport from master.","accounts_in_message":[],"_revision_number":1},{"id":"f824a1cbb03cdbe236067f669b4c7a75db6eceb4","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2019-09-18 14:29:58.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"3f19fdb968fd0210b15ab1175aa228162f97b655","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-18 14:30:40.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"46c45711e7ca409d5e39c5c89b95138eb7229b97","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-18 17:31:17.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- grenade-py3 https://zuul.opendev.org/t/openstack/build/3dc6d14a11e44fd7977643fcb95eed53 : SUCCESS in 1h 03m 04s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/3f9d32de972a4297a102aae3022fa838 : SUCCESS in 1h 22m 13s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/3514d44efae045ada54ddc0c338015a2 : SUCCESS in 12m 54s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/880c995d58534687ac23a4f58d6b13c6 : SUCCESS in 11m 47s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/fef8f66454c94c15b7ff81d4e6b5c0d8 : SUCCESS in 14m 55s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/f18adb22473f4406ac18f2223eccbafa : SUCCESS in 17m 23s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/924ff12cc5e1485392f4af07bf571efe : SUCCESS in 12m 10s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/270600a444144e30b1211e222a6efdd7 : SUCCESS in 13m 03s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/cd50f1b2e84749f4b04b739003680ef8 : SUCCESS in 7m 02s\n- nova-grenade-live-migration https://zuul.opendev.org/t/openstack/build/fee3e79f56b2434590b85f810c0ea075 : SUCCESS in 1h 21m 17s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/978c7d95518b4d058b199fe61a1fb631 : SUCCESS in 1h 01m 11s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/a7b3d28b9c6a4798b3bec0cd1dfa2c14 : SUCCESS in 21m 59s\n- nova-tox-functional-py35 https://zuul.opendev.org/t/openstack/build/fbcae97d2c104095a067fda65d62f0a4 : SUCCESS in 21m 21s\n- nova-next https://zuul.opendev.org/t/openstack/build/11dd6e3cb5d84cc89319c4ea2a126f24 : SUCCESS in 1h 21m 23s\n- tempest-slow-py3 https://zuul.opendev.org/t/openstack/build/f5ff5492659344ff92e1b018b45ddcda : SUCCESS in 2h 29m 55s","accounts_in_message":[],"_revision_number":1},{"id":"602a50c1dff722b4570cc38d2f4e26d98f993f93","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-18 17:31:19.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"c9c5b63425cf9d3e2a51dac0eb390b42c97f62a5","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-18 17:37:45.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/878297053b124d54a3289bda168bd355 : SUCCESS in 52s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"c21cbf296495b0604cc995d5d17ed164ae8562c5","revisions":{"c21cbf296495b0604cc995d5d17ed164ae8562c5":{"kind":"REWORK","_number":1,"created":"2019-09-08 14:57:46.000000000","uploader":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"ref":"refs/changes/69/680869/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/69/680869/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/69/680869/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/69/680869/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/69/680869/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/69/680869/1"}}},"commit":{"parents":[{"commit":"7cc65270cba1012db5155aaa4342a38eae065ff9","subject":"Merge \"Add useful error log when _determine_version_cap raises DBNotAllowed\" into stable/stein","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/7cc65270cba1012db5155aaa4342a38eae065ff9"}]}],"author":{"name":"Mathieu Gagné","email":"mgagne@iweb.com","date":"2017-11-27 22:33:50.000000000","tz":-300},"committer":{"name":"Matt Riedemann","email":"mriedem.os@gmail.com","date":"2019-09-08 14:57:46.000000000","tz":0},"subject":"Fix rebuild of baremetal instance when vm_state is ERROR","message":"Fix rebuild of baremetal instance when vm_state is ERROR\n\nNova allows rebuild of instance when vm_state is ERROR. [1]\n\nThe vm_state is restored to ACTIVE only after a successful build.\nThis means rebuilding a baremetal instance using the Ironic driver\nis impossible because wait_for_active fails if vm_state\u003dERROR is found.\n\nThis is a regression introduced in a previous change which added\nthe ability to delete an instance in spawning state. [2]\n\nThis present change will skip the abort installation logic\nif task_state is REBUILD_SPAWNING while preserving the previous logic.\n\n[1] https://bugs.launchpad.net/nova/+bug/1183946\n[2] https://bugs.launchpad.net/nova/+bug/1455000\n\nChange-Id: I857ad7264f1a7ef1263d8a9d4eca491d6c8dce0f\nCloses-bug: #1735009\n(cherry picked from commit 1819718e798fb904644391badc3beb40c181ac39)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/c21cbf296495b0604cc995d5d17ed164ae8562c5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/c21cbf296495b0604cc995d5d17ed164ae8562c5"}]},"branch":"refs/heads/stable/stein"}},"requirements":[],"submit_records":[],"submit_requirements":[]}