)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1f283240edb8b29b3296f423e00c05edbff352ba","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"New confirm resize functional tests were added in"},{"line_number":10,"context_line":"Ia69dace6d3b395fa113c1382e8eb52c2cc36119d. But they could be racy [1]"},{"line_number":11,"context_line":"because the migration allocation is deleted in placement as the last"},{"line_number":12,"context_line":"thing in the confirm_resize process. So it happens after the migratin is"},{"line_number":13,"context_line":"set to confirmed and the instance state is set to ACTIVE."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This patch shrink the window by waiting for the instance state as it"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5faad753_0ff9044c","line":12,"range":{"start_line":11,"start_character":57,"end_line":12,"end_character":37},"updated":"2019-09-10 13:16:30.000000000","message":"You mean this right?\n\nhttps://github.com/openstack/nova/blob/43afc0443c7941703a63f11bcd2557c0c78e2f18/nova/compute/manager.py#L4023","commit_id":"5647b280a81fb997c4115c56225c0c3c341d1b81"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6347655a207475ff2853ec156c04f679ffca6f0d","unresolved":false,"context_lines":[{"line_number":9,"context_line":"New confirm resize functional tests were added in"},{"line_number":10,"context_line":"Ia69dace6d3b395fa113c1382e8eb52c2cc36119d. But they could be racy [1]"},{"line_number":11,"context_line":"because the migration allocation is deleted in placement as the last"},{"line_number":12,"context_line":"thing in the confirm_resize process. So it happens after the migratin is"},{"line_number":13,"context_line":"set to confirmed and the instance state is set to ACTIVE."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This patch shrink the window by waiting for the instance state as it"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5faad753_6f14384f","line":12,"range":{"start_line":12,"start_character":61,"end_line":12,"end_character":69},"updated":"2019-09-10 13:17:01.000000000","message":"migration","commit_id":"5647b280a81fb997c4115c56225c0c3c341d1b81"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"3e9db22a949b2bfd02500b1290348af0efa6dd19","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"New confirm resize functional tests were added in"},{"line_number":10,"context_line":"Ia69dace6d3b395fa113c1382e8eb52c2cc36119d. But they could be racy [1]"},{"line_number":11,"context_line":"because the migration allocation is deleted in placement as the last"},{"line_number":12,"context_line":"thing in the confirm_resize process. So it happens after the migratin is"},{"line_number":13,"context_line":"set to confirmed and the instance state is set to ACTIVE."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This patch shrink the window by waiting for the instance state as it"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5faad753_fb2eaaa3","line":12,"range":{"start_line":11,"start_character":57,"end_line":12,"end_character":37},"in_reply_to":"5faad753_0ff9044c","updated":"2019-09-10 15:01:53.000000000","message":"right","commit_id":"5647b280a81fb997c4115c56225c0c3c341d1b81"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"3e9db22a949b2bfd02500b1290348af0efa6dd19","unresolved":false,"context_lines":[{"line_number":9,"context_line":"New confirm resize functional tests were added in"},{"line_number":10,"context_line":"Ia69dace6d3b395fa113c1382e8eb52c2cc36119d. But they could be racy [1]"},{"line_number":11,"context_line":"because the migration allocation is deleted in placement as the last"},{"line_number":12,"context_line":"thing in the confirm_resize process. So it happens after the migratin is"},{"line_number":13,"context_line":"set to confirmed and the instance state is set to ACTIVE."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This patch shrink the window by waiting for the instance state as it"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5faad753_3b2522c3","line":12,"range":{"start_line":12,"start_character":61,"end_line":12,"end_character":69},"in_reply_to":"5faad753_6f14384f","updated":"2019-09-10 15:01:53.000000000","message":"Done","commit_id":"5647b280a81fb997c4115c56225c0c3c341d1b81"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1f283240edb8b29b3296f423e00c05edbff352ba","unresolved":false,"context_lines":[{"line_number":13,"context_line":"set to confirmed and the instance state is set to ACTIVE."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This patch shrink the window by waiting for the instance state as it"},{"line_number":16,"context_line":"happens later than the migration status update. However the test still"},{"line_number":17,"context_line":"can race."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"[1] https://954d3ddb67e757934983-a9cc155153d08dd30dfffbbf1d71d234.ssl.cf5.rackcdn.com/676138/16/gate/nova-tox-functional-py36/fb5d235/testr_results.html.gz"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5faad753_af63101a","line":17,"range":{"start_line":16,"start_character":48,"end_line":17,"end_character":9},"updated":"2019-09-10 13:16:30.000000000","message":"Why don\u0027t we wait for the compute_confirm_resize event to show up with it\u0027s finished status on the instance action for the operation?\n\nhttps://github.com/openstack/nova/blob/43afc0443c7941703a63f11bcd2557c0c78e2f18/nova/compute/manager.py#L3951\n\nThat would be after the allocations are deleted. We have some existing functional tests that check instance actions and their related event details, we\u0027d just need to poll until the compute_confirm_resize event is finished.","commit_id":"5647b280a81fb997c4115c56225c0c3c341d1b81"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"3e9db22a949b2bfd02500b1290348af0efa6dd19","unresolved":false,"context_lines":[{"line_number":13,"context_line":"set to confirmed and the instance state is set to ACTIVE."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This patch shrink the window by waiting for the instance state as it"},{"line_number":16,"context_line":"happens later than the migration status update. However the test still"},{"line_number":17,"context_line":"can race."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"[1] https://954d3ddb67e757934983-a9cc155153d08dd30dfffbbf1d71d234.ssl.cf5.rackcdn.com/676138/16/gate/nova-tox-functional-py36/fb5d235/testr_results.html.gz"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5faad753_bb1a727a","line":17,"range":{"start_line":16,"start_character":48,"end_line":17,"end_character":9},"in_reply_to":"5faad753_af63101a","updated":"2019-09-10 15:01:53.000000000","message":"Done","commit_id":"5647b280a81fb997c4115c56225c0c3c341d1b81"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6347655a207475ff2853ec156c04f679ffca6f0d","unresolved":false,"context_lines":[{"line_number":17,"context_line":"can race."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"[1] https://954d3ddb67e757934983-a9cc155153d08dd30dfffbbf1d71d234.ssl.cf5.rackcdn.com/676138/16/gate/nova-tox-functional-py36/fb5d235/testr_results.html.gz"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: Ibeb16ce16263c43bad9f148480bbebca413d8117"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5faad753_af1a307a","line":20,"updated":"2019-09-10 13:17:01.000000000","message":"We should probably have a bug for tracking this in elastic-recheck.","commit_id":"5647b280a81fb997c4115c56225c0c3c341d1b81"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"3e9db22a949b2bfd02500b1290348af0efa6dd19","unresolved":false,"context_lines":[{"line_number":17,"context_line":"can race."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"[1] https://954d3ddb67e757934983-a9cc155153d08dd30dfffbbf1d71d234.ssl.cf5.rackcdn.com/676138/16/gate/nova-tox-functional-py36/fb5d235/testr_results.html.gz"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: Ibeb16ce16263c43bad9f148480bbebca413d8117"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5faad753_db1dee73","line":20,"in_reply_to":"5faad753_af1a307a","updated":"2019-09-10 15:01:53.000000000","message":"Done","commit_id":"5647b280a81fb997c4115c56225c0c3c341d1b81"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"b5d228797604aaabda4ac6e9eee62f2958eef563","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This patch changes the confirm resize tests to wait for the successful"},{"line_number":16,"context_line":"instance action event as that is sent _after_ the migration allocation"},{"line_number":17,"context_line":"is deleted."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"[1] https://954d3ddb67e757934983-a9cc155153d08dd30dfffbbf1d71d234.ssl.cf5.rackcdn.com/676138/16/gate/nova-tox-functional-py36/fb5d235/testr_results.html.gz"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5faad753_1e84d30b","line":17,"updated":"2019-09-10 15:44:08.000000000","message":"++","commit_id":"b99e055e3a7ab8b43ed825d5c407121faa80bca8"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"b5d228797604aaabda4ac6e9eee62f2958eef563","unresolved":false,"context_lines":[{"line_number":16,"context_line":"instance action event as that is sent _after_ the migration allocation"},{"line_number":17,"context_line":"is deleted."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"[1] https://954d3ddb67e757934983-a9cc155153d08dd30dfffbbf1d71d234.ssl.cf5.rackcdn.com/676138/16/gate/nova-tox-functional-py36/fb5d235/testr_results.html.gz"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Closes-Bug: #1843433"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5faad753_be99ff79","line":19,"updated":"2019-09-10 15:44:08.000000000","message":"Unfortunately, the logs will disappear in one month so TBH, this link is not really needed.","commit_id":"b99e055e3a7ab8b43ed825d5c407121faa80bca8"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"b5d228797604aaabda4ac6e9eee62f2958eef563","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"[1] https://954d3ddb67e757934983-a9cc155153d08dd30dfffbbf1d71d234.ssl.cf5.rackcdn.com/676138/16/gate/nova-tox-functional-py36/fb5d235/testr_results.html.gz"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Closes-Bug: #1843433"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Change-Id: Ibeb16ce16263c43bad9f148480bbebca413d8117"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5faad753_5e8a4b1b","line":21,"updated":"2019-09-10 15:44:08.000000000","message":"... and you already explained the problem in the bug :-)","commit_id":"b99e055e3a7ab8b43ed825d5c407121faa80bca8"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c1d50dbb8b4d9782af07db19800cc393905a3122","unresolved":false,"context_lines":[{"line_number":16,"context_line":"instance action event as that is sent _after_ the migration allocation"},{"line_number":17,"context_line":"is deleted."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"[1] see the bug report"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Closes-Bug: #1843433"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5faad753_8192a44a","line":19,"updated":"2019-09-10 16:38:59.000000000","message":"heh, gee thanks! (sarcasm - I would have just removed this)","commit_id":"07171778e6eb8a296a50320326e3c540a9579539"}],"nova/tests/functional/integrated_helpers.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ef913abb559df41166405ec6fee96b5e98cb8cb2","unresolved":false,"context_lines":[{"line_number":324,"context_line":"                    for event in events:"},{"line_number":325,"context_line":"                        if (event[\u0027event\u0027] \u003d\u003d event_name and"},{"line_number":326,"context_line":"                                event[\u0027result\u0027] is not None and"},{"line_number":327,"context_line":"                                event[\u0027result\u0027].lower() \u003d\u003d \u0027error\u0027):"},{"line_number":328,"context_line":"                            completion_event \u003d event"},{"line_number":329,"context_line":"                            # Break out of the events loop."},{"line_number":330,"context_line":"                            break"}],"source_content_type":"text/x-python","patch_set":2,"id":"5faad753_fb59ca59","side":"PARENT","line":327,"range":{"start_line":327,"start_character":47,"end_line":327,"end_character":66},"updated":"2019-09-10 15:02:54.000000000","message":"I\u0027d still probably stick with this since needing to remember that the result is \"Error\" is annoying.","commit_id":"43afc0443c7941703a63f11bcd2557c0c78e2f18"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"0b345cf1a86ddedcd7b9483b92326e79195b1aa6","unresolved":false,"context_lines":[{"line_number":324,"context_line":"                    for event in events:"},{"line_number":325,"context_line":"                        if (event[\u0027event\u0027] \u003d\u003d event_name and"},{"line_number":326,"context_line":"                                event[\u0027result\u0027] is not None and"},{"line_number":327,"context_line":"                                event[\u0027result\u0027].lower() \u003d\u003d \u0027error\u0027):"},{"line_number":328,"context_line":"                            completion_event \u003d event"},{"line_number":329,"context_line":"                            # Break out of the events loop."},{"line_number":330,"context_line":"                            break"}],"source_content_type":"text/x-python","patch_set":2,"id":"5faad753_5b633d1b","side":"PARENT","line":327,"range":{"start_line":327,"start_character":47,"end_line":327,"end_character":66},"in_reply_to":"5faad753_fb59ca59","updated":"2019-09-10 15:30:24.000000000","message":"Done","commit_id":"43afc0443c7941703a63f11bcd2557c0c78e2f18"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c1d50dbb8b4d9782af07db19800cc393905a3122","unresolved":false,"context_lines":[{"line_number":921,"context_line":"        self.assertEqual(expected_vcpu_usage, hypervisor[\u0027vcpus_used\u0027])"},{"line_number":922,"context_line":""},{"line_number":923,"context_line":"    def _confirm_resize(self, server):"},{"line_number":924,"context_line":"        self.api.post_server_action(server[\u0027id\u0027], {\u0027confirmResize\u0027: None})"},{"line_number":925,"context_line":"        server \u003d self._wait_for_state_change(self.api, server, \u0027ACTIVE\u0027)"},{"line_number":926,"context_line":"        self._wait_for_instance_action_event("},{"line_number":927,"context_line":"            self.api, server, instance_actions.CONFIRM_RESIZE,"}],"source_content_type":"text/x-python","patch_set":4,"id":"5faad753_41bb4c71","line":924,"range":{"start_line":924,"start_character":7,"end_line":924,"end_character":16},"updated":"2019-09-10 16:38:59.000000000","message":"Should maybe pass the API in but in this case (L441) self.api \u003d\u003d self.admin_api.","commit_id":"07171778e6eb8a296a50320326e3c540a9579539"}],"nova/tests/functional/test_servers.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8f12ddad7ac3183add037d11200550089aa6445b","unresolved":false,"context_lines":[{"line_number":1813,"context_line":"        # Confirm the resize and check the usages"},{"line_number":1814,"context_line":"        post \u003d {\u0027confirmResize\u0027: None}"},{"line_number":1815,"context_line":"        self.api.post_server_action("},{"line_number":1816,"context_line":"            server[\u0027id\u0027], post, check_response_status\u003d[204])"},{"line_number":1817,"context_line":"        self._wait_for_state_change(self.api, server, \u0027ACTIVE\u0027)"},{"line_number":1818,"context_line":"        self._wait_for_instance_action_event("},{"line_number":1819,"context_line":"            self.api, server, instance_actions.CONFIRM_RESIZE,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5faad753_fb92299f","line":1816,"range":{"start_line":1816,"start_character":32,"end_line":1816,"end_character":59},"updated":"2019-09-10 15:07:38.000000000","message":"It occurs to me late that this is not needed.","commit_id":"49ead22cb30a8ade77bab9359216f5b34c0dbdb4"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"0b345cf1a86ddedcd7b9483b92326e79195b1aa6","unresolved":false,"context_lines":[{"line_number":1813,"context_line":"        # Confirm the resize and check the usages"},{"line_number":1814,"context_line":"        post \u003d {\u0027confirmResize\u0027: None}"},{"line_number":1815,"context_line":"        self.api.post_server_action("},{"line_number":1816,"context_line":"            server[\u0027id\u0027], post, check_response_status\u003d[204])"},{"line_number":1817,"context_line":"        self._wait_for_state_change(self.api, server, \u0027ACTIVE\u0027)"},{"line_number":1818,"context_line":"        self._wait_for_instance_action_event("},{"line_number":1819,"context_line":"            self.api, server, instance_actions.CONFIRM_RESIZE,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5faad753_1b6dc503","line":1816,"range":{"start_line":1816,"start_character":32,"end_line":1816,"end_character":59},"in_reply_to":"5faad753_fb92299f","updated":"2019-09-10 15:30:24.000000000","message":"Done","commit_id":"49ead22cb30a8ade77bab9359216f5b34c0dbdb4"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8f12ddad7ac3183add037d11200550089aa6445b","unresolved":false,"context_lines":[{"line_number":1892,"context_line":"            server, self.flavor2, self.flavor3, rp_uuid)"},{"line_number":1893,"context_line":""},{"line_number":1894,"context_line":"        # Confirm the resize and check the usages"},{"line_number":1895,"context_line":"        post \u003d {\u0027confirmResize\u0027: None}"},{"line_number":1896,"context_line":"        self.api.post_server_action("},{"line_number":1897,"context_line":"            server[\u0027id\u0027], post, check_response_status\u003d[204])"},{"line_number":1898,"context_line":"        self._wait_for_state_change(self.api, server, \u0027ACTIVE\u0027)"},{"line_number":1899,"context_line":"        self._wait_for_instance_action_event("},{"line_number":1900,"context_line":"            self.api, server, instance_actions.CONFIRM_RESIZE,"},{"line_number":1901,"context_line":"            \u0027compute_confirm_resize\u0027, \u0027Success\u0027)"},{"line_number":1902,"context_line":""},{"line_number":1903,"context_line":"        self._run_periodics()"},{"line_number":1904,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5faad753_3bf681fb","line":1901,"range":{"start_line":1895,"start_character":8,"end_line":1901,"end_character":48},"updated":"2019-09-10 15:07:38.000000000","message":"We\u0027re getting a pattern here. For a follow up we might want to throw this block into a _confirm_resize helper method. I mainly say that because I didn\u0027t expect to see all of these tests updated, just the one that was known to fail.","commit_id":"49ead22cb30a8ade77bab9359216f5b34c0dbdb4"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"0b345cf1a86ddedcd7b9483b92326e79195b1aa6","unresolved":false,"context_lines":[{"line_number":1892,"context_line":"            server, self.flavor2, self.flavor3, rp_uuid)"},{"line_number":1893,"context_line":""},{"line_number":1894,"context_line":"        # Confirm the resize and check the usages"},{"line_number":1895,"context_line":"        post \u003d {\u0027confirmResize\u0027: None}"},{"line_number":1896,"context_line":"        self.api.post_server_action("},{"line_number":1897,"context_line":"            server[\u0027id\u0027], post, check_response_status\u003d[204])"},{"line_number":1898,"context_line":"        self._wait_for_state_change(self.api, server, \u0027ACTIVE\u0027)"},{"line_number":1899,"context_line":"        self._wait_for_instance_action_event("},{"line_number":1900,"context_line":"            self.api, server, instance_actions.CONFIRM_RESIZE,"},{"line_number":1901,"context_line":"            \u0027compute_confirm_resize\u0027, \u0027Success\u0027)"},{"line_number":1902,"context_line":""},{"line_number":1903,"context_line":"        self._run_periodics()"},{"line_number":1904,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5faad753_fb71c9df","line":1901,"range":{"start_line":1895,"start_character":8,"end_line":1901,"end_character":48},"in_reply_to":"5faad753_3bf681fb","updated":"2019-09-10 15:30:24.000000000","message":"Done","commit_id":"49ead22cb30a8ade77bab9359216f5b34c0dbdb4"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8f12ddad7ac3183add037d11200550089aa6445b","unresolved":false,"context_lines":[{"line_number":2026,"context_line":"            dest_rp_uuid, self.flavor2, volume_backed\u003dFalse)"},{"line_number":2027,"context_line":""},{"line_number":2028,"context_line":"        # Now confirm the resize and check hypervisor usage again."},{"line_number":2029,"context_line":"        self.api.post_server_action(server[\u0027id\u0027], {\u0027confirmResize\u0027: None})"},{"line_number":2030,"context_line":"        self._wait_for_state_change(self.api, server, \u0027ACTIVE\u0027)"},{"line_number":2031,"context_line":"        self._wait_for_instance_action_event("},{"line_number":2032,"context_line":"            self.api, server, instance_actions.CONFIRM_RESIZE,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5faad753_9be69544","line":2029,"updated":"2019-09-10 15:07:38.000000000","message":"see how check_response_status isn\u0027t used here...","commit_id":"49ead22cb30a8ade77bab9359216f5b34c0dbdb4"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c1d50dbb8b4d9782af07db19800cc393905a3122","unresolved":false,"context_lines":[{"line_number":6553,"context_line":"            migration_uuid, source_compute_rp_uuid\u003dself.compute1_rp_uuid)"},{"line_number":6554,"context_line":""},{"line_number":6555,"context_line":"        self.api.post_server_action(server[\u0027id\u0027], {\u0027confirmResize\u0027: None})"},{"line_number":6556,"context_line":"        self._wait_for_migration_status(server, [\u0027confirmed\u0027])"},{"line_number":6557,"context_line":""},{"line_number":6558,"context_line":"        # check that allocation is still OK"},{"line_number":6559,"context_line":"        self._check_allocation("}],"source_content_type":"text/x-python","patch_set":4,"id":"5faad753_a180008d","side":"PARENT","line":6556,"updated":"2019-09-10 16:38:59.000000000","message":"OK removing this...","commit_id":"43afc0443c7941703a63f11bcd2557c0c78e2f18"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c1d50dbb8b4d9782af07db19800cc393905a3122","unresolved":false,"context_lines":[{"line_number":6586,"context_line":"            migration_uuid, source_compute_rp_uuid\u003dself.compute1_rp_uuid)"},{"line_number":6587,"context_line":""},{"line_number":6588,"context_line":"        self.api.post_server_action(server[\u0027id\u0027], {\u0027confirmResize\u0027: None})"},{"line_number":6589,"context_line":"        self._wait_for_migration_status(server, [\u0027confirmed\u0027])"},{"line_number":6590,"context_line":""},{"line_number":6591,"context_line":"        # check that allocation is still OK"},{"line_number":6592,"context_line":"        self._check_allocation("}],"source_content_type":"text/x-python","patch_set":4,"id":"5faad753_41490c89","side":"PARENT","line":6589,"updated":"2019-09-10 16:38:59.000000000","message":"...and this likely doesn\u0027t matter because the new _confirm_resize waits for the event result of \u0027Success\u0027 which comes after the migration status is changed to \u0027confirmed\u0027.","commit_id":"43afc0443c7941703a63f11bcd2557c0c78e2f18"}]}