)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6f68f497a84d603681a8b22221086b37c93b3926","unresolved":false,"context_lines":[{"line_number":4348,"context_line":"                self.host, action\u003dfields.NotificationAction.RESIZE_REVERT,"},{"line_number":4349,"context_line":"                    phase\u003dfields.NotificationPhase.END, bdms\u003dbdms)"},{"line_number":4350,"context_line":""},{"line_number":4351,"context_line":"    def _fill_provider_mapping_based_on_allocs("},{"line_number":4352,"context_line":"            self, context, allocations, request_spec):"},{"line_number":4353,"context_line":"        if request_spec:"},{"line_number":4354,"context_line":"            # NOTE(gibi): We need to re-calculate the resource provider -"}],"source_content_type":"text/x-python","patch_set":2,"id":"5faad753_93adfa32","line":4351,"updated":"2019-09-11 21:02:58.000000000","message":"If you need to respin, and I hate to ask for a FUP to a FUP, but docstrings when writing a new method is always a good thing. We don\u0027t document enough of the compute manager code (or nova in general).","commit_id":"fa428c18b108992a8f80842a47b9ec052447a596"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"c4a98216f84abd7538313a45c8bcd0af34601b62","unresolved":false,"context_lines":[{"line_number":4348,"context_line":"                self.host, action\u003dfields.NotificationAction.RESIZE_REVERT,"},{"line_number":4349,"context_line":"                    phase\u003dfields.NotificationPhase.END, bdms\u003dbdms)"},{"line_number":4350,"context_line":""},{"line_number":4351,"context_line":"    def _fill_provider_mapping_based_on_allocs("},{"line_number":4352,"context_line":"            self, context, allocations, request_spec):"},{"line_number":4353,"context_line":"        if request_spec:"},{"line_number":4354,"context_line":"            # NOTE(gibi): We need to re-calculate the resource provider -"}],"source_content_type":"text/x-python","patch_set":2,"id":"5faad753_7bb0478b","line":4351,"in_reply_to":"5faad753_93adfa32","updated":"2019-09-12 11:47:34.000000000","message":"Done","commit_id":"fa428c18b108992a8f80842a47b9ec052447a596"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6f68f497a84d603681a8b22221086b37c93b3926","unresolved":false,"context_lines":[{"line_number":4364,"context_line":"            # the provider mappings. If the instance has ports with"},{"line_number":4365,"context_line":"            # resource request then the port update will fail in"},{"line_number":4366,"context_line":"            # _update_port_binding_for_instance() called via"},{"line_number":4367,"context_line":"            # _finish_revert_resize_network_migrate_finish() below."},{"line_number":4368,"context_line":"            provider_mappings \u003d None"},{"line_number":4369,"context_line":"        return provider_mappings"},{"line_number":4370,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5faad753_73771ed6","line":4367,"range":{"start_line":4367,"start_character":61,"end_line":4367,"end_character":66},"updated":"2019-09-11 21:02:58.000000000","message":"This no longer makes much sense. Maybe just say \"in finish_revert_resize\" instead?","commit_id":"fa428c18b108992a8f80842a47b9ec052447a596"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"c4a98216f84abd7538313a45c8bcd0af34601b62","unresolved":false,"context_lines":[{"line_number":4364,"context_line":"            # the provider mappings. If the instance has ports with"},{"line_number":4365,"context_line":"            # resource request then the port update will fail in"},{"line_number":4366,"context_line":"            # _update_port_binding_for_instance() called via"},{"line_number":4367,"context_line":"            # _finish_revert_resize_network_migrate_finish() below."},{"line_number":4368,"context_line":"            provider_mappings \u003d None"},{"line_number":4369,"context_line":"        return provider_mappings"},{"line_number":4370,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5faad753_bb3d5fde","line":4367,"range":{"start_line":4367,"start_character":61,"end_line":4367,"end_character":66},"in_reply_to":"5faad753_73771ed6","updated":"2019-09-12 11:47:34.000000000","message":"Done","commit_id":"fa428c18b108992a8f80842a47b9ec052447a596"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0d952d9c653de8a0eafd30c8f8e6dfe268ff597e","unresolved":false,"context_lines":[{"line_number":4359,"context_line":"            operation"},{"line_number":4360,"context_line":"        :returns: None if the request_spec is None. Otherwise a mapping"},{"line_number":4361,"context_line":"            between RequestGroup requester_id, currently Neutron port_id,"},{"line_number":4362,"context_line":"            and resource provider UUID that provides resource for that"},{"line_number":4363,"context_line":"            RequestGroup."},{"line_number":4364,"context_line":"        \"\"\""},{"line_number":4365,"context_line":"        if request_spec:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5faad753_5e177446","line":4362,"range":{"start_line":4362,"start_character":15,"end_line":4362,"end_character":16},"updated":"2019-09-12 14:40:50.000000000","message":"list of?","commit_id":"ad3c71e65c34fe76e9ea907631d4fd638d38725d"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"fcc829dd072f1f5cdad45a687677d2a5c024df06","unresolved":false,"context_lines":[{"line_number":4359,"context_line":"            operation"},{"line_number":4360,"context_line":"        :returns: None if the request_spec is None. Otherwise a mapping"},{"line_number":4361,"context_line":"            between RequestGroup requester_id, currently Neutron port_id,"},{"line_number":4362,"context_line":"            and resource provider UUID that provides resource for that"},{"line_number":4363,"context_line":"            RequestGroup."},{"line_number":4364,"context_line":"        \"\"\""},{"line_number":4365,"context_line":"        if request_spec:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5faad753_6102d10d","line":4362,"range":{"start_line":4362,"start_character":15,"end_line":4362,"end_character":16},"in_reply_to":"5faad753_5e177446","updated":"2019-09-12 16:01:02.000000000","message":"yeah, list of.","commit_id":"ad3c71e65c34fe76e9ea907631d4fd638d38725d"}]}
