)]}'
{"nova/conf/workarounds.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9e25753540dd590198ea017625e495f01110abd6","unresolved":false,"context_lines":[{"line_number":222,"context_line":""},{"line_number":223,"context_line":"Starting in Train, compute nodes using the libvirt virt driver can report"},{"line_number":224,"context_line":"``PCPU`` inventory and will use this for pinned instances. The scheduler will"},{"line_number":225,"context_line":"automatically translate requests using the legacy CPU pinning-related flavor"},{"line_number":226,"context_line":"extra specs, ``hw:cpu_policy`` and ``hw:cpu_thread_policy``, their image"},{"line_number":227,"context_line":"metadata property equivalents, and the emulator threads pinning flavor extra"},{"line_number":228,"context_line":"spec, ``hw:emulator_threads_policy``, to new placement requests. However,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5faad753_db7a9bef","line":225,"range":{"start_line":225,"start_character":42,"end_line":225,"end_character":76},"updated":"2019-09-12 11:31:01.000000000","message":"nit: i dont really like calling these legacy since we dont currently plan to advise changing your flavor but thats a minor point you can ignore.","commit_id":"44175eb006c888db2ede54d37a184eeef74e0e2b"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"025719fe38ca5ef0d45ce2fc16c708c9db0c1163","unresolved":false,"context_lines":[{"line_number":233,"context_line":"old-style ``VCPU``-based allocations and fallback to these allocation"},{"line_number":234,"context_line":"candidates if necessary. This has a slight performance impact and is not"},{"line_number":235,"context_line":"necessary on new or upgraded deployments where the new configuration has been"},{"line_number":236,"context_line":"set on all hosts. By setting this option, the second lookup is disabled and the"},{"line_number":237,"context_line":"scheduler will only request ``PCPU``-based allocations."},{"line_number":238,"context_line":"\"\"\"),"},{"line_number":239,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":1,"id":"5faad753_fbbe77b2","line":236,"range":{"start_line":236,"start_character":21,"end_line":236,"end_character":40},"updated":"2019-09-12 11:26:44.000000000","message":"...to True","commit_id":"44175eb006c888db2ede54d37a184eeef74e0e2b"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"025719fe38ca5ef0d45ce2fc16c708c9db0c1163","unresolved":false,"context_lines":[{"line_number":234,"context_line":"candidates if necessary. This has a slight performance impact and is not"},{"line_number":235,"context_line":"necessary on new or upgraded deployments where the new configuration has been"},{"line_number":236,"context_line":"set on all hosts. By setting this option, the second lookup is disabled and the"},{"line_number":237,"context_line":"scheduler will only request ``PCPU``-based allocations."},{"line_number":238,"context_line":"\"\"\"),"},{"line_number":239,"context_line":"]"},{"line_number":240,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5faad753_bbe9dfb7","line":237,"updated":"2019-09-12 11:26:44.000000000","message":"\"This may result in spurious NVH errors in $circumstances.\" ?","commit_id":"44175eb006c888db2ede54d37a184eeef74e0e2b"}],"nova/scheduler/manager.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"025719fe38ca5ef0d45ce2fc16c708c9db0c1163","unresolved":false,"context_lines":[{"line_number":190,"context_line":""},{"line_number":191,"context_line":"                    alloc_reqs.extend(alloc_reqs_fallback)"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"                    for provider_uuid, provider_summary in ("},{"line_number":194,"context_line":"                            provider_summaries_fallback.items()):"},{"line_number":195,"context_line":"                        if provider_uuid not in provider_summaries:"},{"line_number":196,"context_line":"                            provider_summaries[provider_uuid] \u003d ("},{"line_number":197,"context_line":"                                provider_summary)"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"            if not alloc_reqs:"},{"line_number":200,"context_line":"                LOG.info(\"Got no allocation candidates from the Placement \""}],"source_content_type":"text/x-python","patch_set":1,"id":"5faad753_db2cdb03","line":197,"range":{"start_line":193,"start_character":20,"end_line":197,"end_character":49},"updated":"2019-09-12 11:26:44.000000000","message":"provider_summaries.update(provider_summaries_fallback) ?","commit_id":"44175eb006c888db2ede54d37a184eeef74e0e2b"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a05f9b9510fc03144752756c685ba7a4ff92eb0f","unresolved":false,"context_lines":[{"line_number":190,"context_line":""},{"line_number":191,"context_line":"                    alloc_reqs.extend(alloc_reqs_fallback)"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"                    for provider_uuid, provider_summary in ("},{"line_number":194,"context_line":"                            provider_summaries_fallback.items()):"},{"line_number":195,"context_line":"                        if provider_uuid not in provider_summaries:"},{"line_number":196,"context_line":"                            provider_summaries[provider_uuid] \u003d ("},{"line_number":197,"context_line":"                                provider_summary)"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"            if not alloc_reqs:"},{"line_number":200,"context_line":"                LOG.info(\"Got no allocation candidates from the Placement \""}],"source_content_type":"text/x-python","patch_set":1,"id":"5faad753_4f290199","line":197,"range":{"start_line":193,"start_character":20,"end_line":197,"end_character":49},"in_reply_to":"5faad753_bba1df48","updated":"2019-09-12 14:09:56.000000000","message":"Done","commit_id":"44175eb006c888db2ede54d37a184eeef74e0e2b"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"1c1b3cc883b8c01bad41eacfb4686d3e650203de","unresolved":false,"context_lines":[{"line_number":190,"context_line":""},{"line_number":191,"context_line":"                    alloc_reqs.extend(alloc_reqs_fallback)"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"                    for provider_uuid, provider_summary in ("},{"line_number":194,"context_line":"                            provider_summaries_fallback.items()):"},{"line_number":195,"context_line":"                        if provider_uuid not in provider_summaries:"},{"line_number":196,"context_line":"                            provider_summaries[provider_uuid] \u003d ("},{"line_number":197,"context_line":"                                provider_summary)"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"            if not alloc_reqs:"},{"line_number":200,"context_line":"                LOG.info(\"Got no allocation candidates from the Placement \""}],"source_content_type":"text/x-python","patch_set":1,"id":"5faad753_3b540f21","line":197,"range":{"start_line":193,"start_character":20,"end_line":197,"end_character":49},"in_reply_to":"5faad753_bba1df48","updated":"2019-09-12 11:38:28.000000000","message":"The result will be the same, but I\u0027m not sure whether it\u0027s more expensive to redundantly replace a dict entry, which is what .update() would do. Shrug.","commit_id":"44175eb006c888db2ede54d37a184eeef74e0e2b"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9e25753540dd590198ea017625e495f01110abd6","unresolved":false,"context_lines":[{"line_number":190,"context_line":""},{"line_number":191,"context_line":"                    alloc_reqs.extend(alloc_reqs_fallback)"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"                    for provider_uuid, provider_summary in ("},{"line_number":194,"context_line":"                            provider_summaries_fallback.items()):"},{"line_number":195,"context_line":"                        if provider_uuid not in provider_summaries:"},{"line_number":196,"context_line":"                            provider_summaries[provider_uuid] \u003d ("},{"line_number":197,"context_line":"                                provider_summary)"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"            if not alloc_reqs:"},{"line_number":200,"context_line":"                LOG.info(\"Got no allocation candidates from the Placement \""}],"source_content_type":"text/x-python","patch_set":1,"id":"5faad753_fb68b71d","line":197,"range":{"start_line":193,"start_character":20,"end_line":197,"end_character":49},"in_reply_to":"5faad753_db2cdb03","updated":"2019-09-12 11:31:01.000000000","message":"not this is better as stephen is filtering out providers that we know support PCPUs so we shoudl not add the VCPU provider summeries for them if tehy appear in the second query","commit_id":"44175eb006c888db2ede54d37a184eeef74e0e2b"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"8e3cc9c6e40c758b807c088ac96cc0014b5069a4","unresolved":false,"context_lines":[{"line_number":190,"context_line":""},{"line_number":191,"context_line":"                    alloc_reqs.extend(alloc_reqs_fallback)"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"                    for provider_uuid, provider_summary in ("},{"line_number":194,"context_line":"                            provider_summaries_fallback.items()):"},{"line_number":195,"context_line":"                        if provider_uuid not in provider_summaries:"},{"line_number":196,"context_line":"                            provider_summaries[provider_uuid] \u003d ("},{"line_number":197,"context_line":"                                provider_summary)"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"            if not alloc_reqs:"},{"line_number":200,"context_line":"                LOG.info(\"Got no allocation candidates from the Placement \""}],"source_content_type":"text/x-python","patch_set":1,"id":"5faad753_bba1df48","line":197,"range":{"start_line":193,"start_character":20,"end_line":197,"end_character":49},"in_reply_to":"5faad753_fb68b71d","updated":"2019-09-12 11:34:15.000000000","message":"A summary is going to be the same for a given provider regardless, so the effect will be the same.","commit_id":"44175eb006c888db2ede54d37a184eeef74e0e2b"}]}