)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"db588b47f4dddbf6d60e77641fe270b348600293","unresolved":false,"context_lines":[{"line_number":17,"context_line":"set of flags (no CPU has a \u0027None\u0027 or null flag)."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"The solution is easy - don\u0027t add the None values."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I1468ad4b724b8d0e3a855c329bd8c8af513d986c"},{"line_number":22,"context_line":"Signed-off-by: Stephen Finucane \u003csfinucan@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5faad753_69486f5b","line":20,"updated":"2019-09-12 21:22:38.000000000","message":"Add a bug.","commit_id":"25f20edb5bf5f1a43e58d8a91ba2c349f1349654"}],"nova/tests/unit/virt/libvirt/test_utils.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"db588b47f4dddbf6d60e77641fe270b348600293","unresolved":false,"context_lines":[{"line_number":1002,"context_line":"        os_mach_type \u003d libvirt_utils.get_machine_type(image_meta)"},{"line_number":1003,"context_line":"        self.assertEqual(\u0027q35\u0027, os_mach_type)"},{"line_number":1004,"context_line":""},{"line_number":1005,"context_line":"    def test_get_flags_by_flavor_specs(self):"},{"line_number":1006,"context_line":"        flavor \u003d objects.Flavor("},{"line_number":1007,"context_line":"            id\u003d1, flavorid\u003d\u0027fakeid-1\u0027, name\u003d\u0027fake1.small\u0027, memory_mb\u003d128,"},{"line_number":1008,"context_line":"            vcpus\u003d1, root_gb\u003d1, ephemeral_gb\u003d0, swap\u003d0, rxtx_factor\u003d0,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5faad753_0973fbb2","line":1005,"updated":"2019-09-12 21:22:38.000000000","message":"So did we not have any test coverage of that code before?\n\nWhy wouldn\u0027t any functional tests fail? We have functional tests that create servers with required traits, but I guess they don\u0027t use the libvirt driver so that\u0027s why they didn\u0027t hit them, right?\n\nBut we have functional tests that use the libvirt driver, so could they have hit this if tweaked?","commit_id":"25f20edb5bf5f1a43e58d8a91ba2c349f1349654"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8bbd123c5e39c2e7fcb29de5c721910f2d003ec1","unresolved":false,"context_lines":[{"line_number":1009,"context_line":"            deleted\u003dFalse, extra_specs\u003d{"},{"line_number":1010,"context_line":"                \u0027trait:%s\u0027 % os_traits.HW_CPU_X86_3DNOW: \u0027required\u0027,"},{"line_number":1011,"context_line":"                \u0027trait:%s\u0027 % os_traits.HW_CPU_X86_SSE2: \u0027required\u0027,"},{"line_number":1012,"context_line":"                \u0027trait:%s\u0027 % os_traits.HW_CPU_HYPERTHREADING: \u0027required\u0027,"},{"line_number":1013,"context_line":"            })"},{"line_number":1014,"context_line":"        traits \u003d libvirt_utils.get_flags_by_flavor_specs(flavor)"},{"line_number":1015,"context_line":"        # we shouldn\u0027t see the hyperthreading trait since that\u0027s a valid trait"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_d405dd7b","line":1012,"range":{"start_line":1012,"start_character":46,"end_line":1012,"end_character":60},"updated":"2019-09-18 16:33:53.000000000","message":"Just a note that I did my due diligence to make sure we require a minimum version of os-traits that contains this (which is newer than the other two here) and this was added in 0.10.0:\n\nhttps://review.opendev.org/#/c/576030/\n\nAnd we currently require at least 0.16.0.","commit_id":"6ec09de2435fd849ba8123d587cce34e1d8b5ec7"}]}