)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"94ea363053f9f9496f740991edb73b902b19fe5f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Adam Spiers \u003caspiers@suse.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-09-13 10:59:42 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add reminder to update corresponding glance docs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Some documentation regarding metadata for image properties is"},{"line_number":10,"context_line":"duplicated in glance and had previously gotten out of sync[0], so add"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5faad753_c0fa8dbb","line":7,"range":{"start_line":7,"start_character":37,"end_line":7,"end_character":43},"updated":"2019-09-13 10:09:15.000000000","message":"OCD nit: s/glance/Glance/\n\n(Same everywhere in the commit message.)\n\nBut if you intentionally used lowercase in the commit message also due to documented guideline[*], then ignore this nit.\n\n[*] https://governance.openstack.org/tc/reference/service-project-naming.html","commit_id":"fe5c67a3fc8ee91eda9dd42fd48fd0d362a38c81"},{"author":{"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},"change_message_id":"977bc54c07e4c9b81d3f8ffebaeea8b722fb44be","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Adam Spiers \u003caspiers@suse.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-09-13 10:59:42 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add reminder to update corresponding glance docs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Some documentation regarding metadata for image properties is"},{"line_number":10,"context_line":"duplicated in glance and had previously gotten out of sync[0], so add"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5faad753_40df7d0c","line":7,"range":{"start_line":7,"start_character":37,"end_line":7,"end_character":43},"in_reply_to":"5faad753_c0fa8dbb","updated":"2019-09-13 10:16:50.000000000","message":"Yes, nova developers need to start unlearning this habit:\n\nhttps://review.opendev.org/#/c/681359/5/security-guide/source/compute/hardening-the-virtualization-layers.rst@185\n\nhttps://review.opendev.org/#/c/681359/2//COMMIT_MSG@10","commit_id":"fe5c67a3fc8ee91eda9dd42fd48fd0d362a38c81"}],"nova/virt/libvirt/blockinfo.py":[{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"94ea363053f9f9496f740991edb73b902b19fe5f","unresolved":false,"context_lines":[{"line_number":202,"context_line":""},{"line_number":203,"context_line":"def is_disk_bus_valid_for_virt(virt_type, disk_bus):"},{"line_number":204,"context_line":"    # NOTE(aspiers): If you change this, don\u0027t forget to update the"},{"line_number":205,"context_line":"    # docs and metadata for hw_*_bus in glance."},{"line_number":206,"context_line":"    valid_bus \u003d {"},{"line_number":207,"context_line":"        \u0027qemu\u0027: [\u0027virtio\u0027, \u0027scsi\u0027, \u0027ide\u0027, \u0027usb\u0027, \u0027fdc\u0027, \u0027sata\u0027],"},{"line_number":208,"context_line":"        \u0027kvm\u0027: [\u0027virtio\u0027, \u0027scsi\u0027, \u0027ide\u0027, \u0027usb\u0027, \u0027fdc\u0027, \u0027sata\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"5faad753_a0999179","line":205,"range":{"start_line":205,"start_character":6,"end_line":205,"end_character":10},"updated":"2019-09-13 10:09:15.000000000","message":"Do you want to mention the document name in brackets here, and elsewhere in code?  \u0027useful-image-properties\u0027?","commit_id":"fe5c67a3fc8ee91eda9dd42fd48fd0d362a38c81"},{"author":{"_account_id":2394,"name":"Adam Spiers","email":"aspiers@suse.com","username":"adam.spiers"},"change_message_id":"977bc54c07e4c9b81d3f8ffebaeea8b722fb44be","unresolved":false,"context_lines":[{"line_number":202,"context_line":""},{"line_number":203,"context_line":"def is_disk_bus_valid_for_virt(virt_type, disk_bus):"},{"line_number":204,"context_line":"    # NOTE(aspiers): If you change this, don\u0027t forget to update the"},{"line_number":205,"context_line":"    # docs and metadata for hw_*_bus in glance."},{"line_number":206,"context_line":"    valid_bus \u003d {"},{"line_number":207,"context_line":"        \u0027qemu\u0027: [\u0027virtio\u0027, \u0027scsi\u0027, \u0027ide\u0027, \u0027usb\u0027, \u0027fdc\u0027, \u0027sata\u0027],"},{"line_number":208,"context_line":"        \u0027kvm\u0027: [\u0027virtio\u0027, \u0027scsi\u0027, \u0027ide\u0027, \u0027usb\u0027, \u0027fdc\u0027, \u0027sata\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"5faad753_20ea81ab","line":205,"range":{"start_line":205,"start_character":6,"end_line":205,"end_character":10},"in_reply_to":"5faad753_a0999179","updated":"2019-09-13 10:16:50.000000000","message":"Deliberately omitted since it\u0027s multiple files and they could change over time.","commit_id":"fe5c67a3fc8ee91eda9dd42fd48fd0d362a38c81"}]}