)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b8998c0242b5746dbb17c7c6d4cdb0e4a4d1a86f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     ya.wang \u003cwang.ya@99cloud.net\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-09-16 19:41:52 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix typor of cpu model when check CPU compatibility"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I9c7e842c4ef29cc78057a7ed9701f28ecb5e1a8b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3fa7e38b_4dd19157","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":9},"updated":"2019-09-16 16:29:29.000000000","message":"typo","commit_id":"8de82a228460e62c32c41e11e582a4b0eb3d6829"},{"author":{"_account_id":27614,"name":"ya.wang","email":"me@littleya.com","username":"ya.wang"},"change_message_id":"77f73b0e6ae4a6c8d417acc25ae3a3b6e1b3cc22","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     ya.wang \u003cwang.ya@99cloud.net\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-09-16 19:41:52 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix typor of cpu model when check CPU compatibility"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I9c7e842c4ef29cc78057a7ed9701f28ecb5e1a8b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3fa7e38b_84d75b24","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":9},"in_reply_to":"3fa7e38b_4dd19157","updated":"2019-09-17 02:45:08.000000000","message":"Done","commit_id":"8de82a228460e62c32c41e11e582a4b0eb3d6829"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b8998c0242b5746dbb17c7c6d4cdb0e4a4d1a86f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3fa7e38b_ad9a856b","line":10,"updated":"2019-09-16 16:29:29.000000000","message":"You\u0027ll need a bug link too","commit_id":"8de82a228460e62c32c41e11e582a4b0eb3d6829"},{"author":{"_account_id":27614,"name":"ya.wang","email":"me@littleya.com","username":"ya.wang"},"change_message_id":"77f73b0e6ae4a6c8d417acc25ae3a3b6e1b3cc22","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3fa7e38b_24dc6745","line":10,"in_reply_to":"3fa7e38b_ad9a856b","updated":"2019-09-17 02:45:08.000000000","message":"Done","commit_id":"8de82a228460e62c32c41e11e582a4b0eb3d6829"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"ab959002bf85b74f4732e7b9412d09491c821f80","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     ya.wang \u003cwang.ya@99cloud.net\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-09-17 10:44:17 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix typo of cpu model when check CPU compatibility"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Closes-Bug: 1844211"},{"line_number":10,"context_line":"Change-Id: I9c7e842c4ef29cc78057a7ed9701f28ecb5e1a8b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3fa7e38b_5997e891","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":50},"updated":"2019-09-18 15:42:46.000000000","message":"FWIW, I\u0027d write it as:\n\n\"libvirt: Get the CPU model, not \u0027arch\u0027 from get_capabilities()\"\n\n(Because the typo is something that matters and is important, as it breaks \u0027nova-compute\u0027 start up.)","commit_id":"34c7d909f3e757db53fe01f1bc1125a818f98365"}],"nova/tests/unit/virt/libvirt/fakelibvirt.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b8998c0242b5746dbb17c7c6d4cdb0e4a4d1a86f","unresolved":false,"context_lines":[{"line_number":1485,"context_line":"        model_node \u003d tree.find(\u0027./model\u0027)"},{"line_number":1486,"context_line":"        if model_node is not None:"},{"line_number":1487,"context_line":"            # arch_node may not present, therefore query all cpu models."},{"line_number":1488,"context_line":"            if model_node.text not in self.getCPUModelNames(\u0027x86_64\u0027) and \\"},{"line_number":1489,"context_line":"                model_node.text not in self.getCPUModelNames(\u0027ppc64\u0027):"},{"line_number":1490,"context_line":"                raise make_libvirtError("},{"line_number":1491,"context_line":"                    libvirtError,"},{"line_number":1492,"context_line":"                    \"internal error: Unknown CPU model %s\" % model_node.text,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_2df775f8","line":1489,"range":{"start_line":1488,"start_character":0,"end_line":1489,"end_character":70},"updated":"2019-09-16 16:29:29.000000000","message":"Try:\n\n  if model_node.text not in (\n          self.getCPUModelNames(\u0027x86_64\u0027),\n          self.getCPUModelNames(\u0027ppc64\u0027)):","commit_id":"8de82a228460e62c32c41e11e582a4b0eb3d6829"},{"author":{"_account_id":27614,"name":"ya.wang","email":"me@littleya.com","username":"ya.wang"},"change_message_id":"77f73b0e6ae4a6c8d417acc25ae3a3b6e1b3cc22","unresolved":false,"context_lines":[{"line_number":1485,"context_line":"        model_node \u003d tree.find(\u0027./model\u0027)"},{"line_number":1486,"context_line":"        if model_node is not None:"},{"line_number":1487,"context_line":"            # arch_node may not present, therefore query all cpu models."},{"line_number":1488,"context_line":"            if model_node.text not in self.getCPUModelNames(\u0027x86_64\u0027) and \\"},{"line_number":1489,"context_line":"                model_node.text not in self.getCPUModelNames(\u0027ppc64\u0027):"},{"line_number":1490,"context_line":"                raise make_libvirtError("},{"line_number":1491,"context_line":"                    libvirtError,"},{"line_number":1492,"context_line":"                    \"internal error: Unknown CPU model %s\" % model_node.text,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_c4c5535d","line":1489,"range":{"start_line":1488,"start_character":0,"end_line":1489,"end_character":70},"in_reply_to":"3fa7e38b_2df775f8","updated":"2019-09-17 02:45:08.000000000","message":"Em, not a good idea because \u0027self.getCPUModelNames\u0027 return a list.","commit_id":"8de82a228460e62c32c41e11e582a4b0eb3d6829"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"ab959002bf85b74f4732e7b9412d09491c821f80","unresolved":false,"context_lines":[{"line_number":784,"context_line":"        # Use guest CPU model to check the compatibility between guest CPU and"},{"line_number":785,"context_line":"        # configured extra_flags"},{"line_number":786,"context_line":"        cpu \u003d vconfig.LibvirtConfigGuestCPU()"},{"line_number":787,"context_line":"        cpu.model \u003d self._host.get_capabilities().host.cpu.model"},{"line_number":788,"context_line":"        for flag in set(x.lower() for x in CONF.libvirt.cpu_model_extra_flags):"},{"line_number":789,"context_line":"            cpu.add_feature(vconfig.LibvirtConfigCPUFeature(flag))"},{"line_number":790,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_fe355af8","line":787,"range":{"start_line":787,"start_character":59,"end_line":787,"end_character":64},"updated":"2019-09-18 15:42:46.000000000","message":"Oops; good catch.\n\n(I recall Stephen wondering about this on IRC; glad this turned into a fix.)","commit_id":"34c7d909f3e757db53fe01f1bc1125a818f98365"}]}