)]}'
{"nova/virt/block_device.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f5bf28f5237880e1ad94383284ef678674e011f5","unresolved":false,"context_lines":[{"line_number":278,"context_line":"                       \u0027device_name\u0027: \u0027mount_device\u0027,"},{"line_number":279,"context_line":"                       \u0027device_type\u0027: None,"},{"line_number":280,"context_line":"                       # needed for boot from volume for blank/image/snapshot"},{"line_number":281,"context_line":"                       \u0027attachment_id\u0027: None}"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"    def _transform(self):"},{"line_number":284,"context_line":"        if (not self._bdm_obj.source_type \u003d\u003d self._valid_source or"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_d7ea8773","side":"PARENT","line":281,"updated":"2019-09-21 13:41:23.000000000","message":"Looks like we still need this.","commit_id":"059c0132898ef71b5287950d3177c36c306bfc19"}],"nova/volume/cinder.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"ca2755dbb184bb31ade244c346632ff7fe647143","unresolved":false,"context_lines":[{"line_number":589,"context_line":"    @translate_volume_exception"},{"line_number":590,"context_line":"    def terminate_connection(self, context, volume_id, connector):"},{"line_number":591,"context_line":"        return cinderclient(context).volumes.terminate_connection(volume_id,"},{"line_number":592,"context_line":"                                                                  connector)"},{"line_number":593,"context_line":""},{"line_number":594,"context_line":"    @translate_cinder_exception"},{"line_number":595,"context_line":"    def migrate_volume_completion(self, context, old_volume_id, new_volume_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_e9aa7f83","line":592,"updated":"2019-09-18 23:36:24.000000000","message":"I was wondering, should we also test that we don\u0027t do an old-style detach with an upgraded deployment for the sake of testing the patch below? I was looking at my old comment where an old PS was doing a new-style attach but an old-style detach and was wondering how we can verify that today.","commit_id":"948ae4f09e6aa923e712ccb7dbf568e116ac7ad9"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"aa7be853a424dec00209d27870920946f3e09bd5","unresolved":false,"context_lines":[{"line_number":589,"context_line":"    @translate_volume_exception"},{"line_number":590,"context_line":"    def terminate_connection(self, context, volume_id, connector):"},{"line_number":591,"context_line":"        return cinderclient(context).volumes.terminate_connection(volume_id,"},{"line_number":592,"context_line":"                                                                  connector)"},{"line_number":593,"context_line":""},{"line_number":594,"context_line":"    @translate_cinder_exception"},{"line_number":595,"context_line":"    def migrate_volume_completion(self, context, old_volume_id, new_volume_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_c04f4690","line":592,"in_reply_to":"3fa7e38b_c9f6a390","updated":"2019-09-19 15:45:30.000000000","message":"My guess is cinder logs the same message regardless of which API method you call since the new style attachment stuff overlaps some with the old termination connection stuff in the volume manager when it comes to removing exports in the storage backend:\n\nhttps://github.com/openstack/cinder/blob/410791580ef60ddb03104bf20766859ed9d78932/cinder/volume/manager.py#L4618","commit_id":"948ae4f09e6aa923e712ccb7dbf568e116ac7ad9"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"23db3e08a4824d86abd0de4fe2649eef1aab133c","unresolved":false,"context_lines":[{"line_number":589,"context_line":"    @translate_volume_exception"},{"line_number":590,"context_line":"    def terminate_connection(self, context, volume_id, connector):"},{"line_number":591,"context_line":"        return cinderclient(context).volumes.terminate_connection(volume_id,"},{"line_number":592,"context_line":"                                                                  connector)"},{"line_number":593,"context_line":""},{"line_number":594,"context_line":"    @translate_cinder_exception"},{"line_number":595,"context_line":"    def migrate_volume_completion(self, context, old_volume_id, new_volume_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_c9f6a390","line":592,"in_reply_to":"3fa7e38b_e9aa7f83","updated":"2019-09-18 23:55:01.000000000","message":"I see a message in the cinder log indicating that the terminate_connection API was called during a boot-from-volume test [1]:\n\n\"Sep 17 00:38:54.868180 ubuntu-bionic-rax-ord-0011387592 cinder-volume[18181]: INFO cinder.volume.manager [req-1707c1e5-7ea9-4fc2-b34d-59523cc8e1e2 req-bf94b15a-8a6f-4b3d-ab53-6cfab0a9e57c tempest-ServersTestBootFromVolume-975926612 None] Terminate volume connection completed successfully.\"\n\n\nwhich shouldn\u0027t happen unless an old-style attach is being triggered, right?\n\n\nBut then right after that, I see an attachment delete API call, which is new-style detach:\n\n\"Sep 17 00:38:54.868648 ubuntu-bionic-rax-ord-0011387592 cinder-volume[18181]: DEBUG cinder.volume.manager [req-1707c1e5-7ea9-4fc2-b34d-59523cc8e1e2 req-bf94b15a-8a6f-4b3d-ab53-6cfab0a9e57c tempest-ServersTestBootFromVolume-975926612 None] Deleting attachment bfd69cdc-d559-4ff2-aa2b-7a8b734e249b. {{(pid\u003d18400) _do_attachment_delete /opt/stack/cinder/cinder/volume/manager.py:4656}}\"\n\n\nso I\u0027m confused about what is happening here.\n\n[1] https://zuul.opendev.org/t/openstack/build/bb9f9e7c6bf54b4b868457a8eb090491/log/controller/logs/screen-c-vol.txt.gz#1268","commit_id":"948ae4f09e6aa923e712ccb7dbf568e116ac7ad9"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"aa7be853a424dec00209d27870920946f3e09bd5","unresolved":false,"context_lines":[{"line_number":589,"context_line":"    @translate_volume_exception"},{"line_number":590,"context_line":"    def terminate_connection(self, context, volume_id, connector):"},{"line_number":591,"context_line":"        return cinderclient(context).volumes.terminate_connection(volume_id,"},{"line_number":592,"context_line":"                                                                  connector)"},{"line_number":593,"context_line":""},{"line_number":594,"context_line":"    @translate_cinder_exception"},{"line_number":595,"context_line":"    def migrate_volume_completion(self, context, old_volume_id, new_volume_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_e080428e","line":592,"in_reply_to":"3fa7e38b_e9aa7f83","updated":"2019-09-19 15:45:30.000000000","message":"Yeah I can do that since I\u0027m going to rev this change anyway to remove the dict/attribute silliness.","commit_id":"948ae4f09e6aa923e712ccb7dbf568e116ac7ad9"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f5bf28f5237880e1ad94383284ef678674e011f5","unresolved":false,"context_lines":[{"line_number":588,"context_line":""},{"line_number":589,"context_line":"    @translate_volume_exception"},{"line_number":590,"context_line":"    def terminate_connection(self, context, volume_id, connector):"},{"line_number":591,"context_line":"        raise Exception(\u0027We should never call os-terminate_connection on \u0027"},{"line_number":592,"context_line":"                        \u0027volume %s with an upgraded deployment.\u0027 % volume_id)"},{"line_number":593,"context_line":""},{"line_number":594,"context_line":"    @translate_cinder_exception"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_37f43b5b","line":591,"updated":"2019-09-21 13:41:23.000000000","message":"OK we hit this:\n\nhttps://zuul.opendev.org/t/openstack/build/c6810f812182466790ba51831514ff1d/log/controller/logs/screen-n-cpu.txt.gz#50003\n\nWhich means we\u0027re not saving the attachment_id.","commit_id":"06836406d76ed3568c7c82a1de3519fea2ec6c87"}]}