)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6940df2a496c117db7f3f0ea5e27fa7ab673c1ce","unresolved":false,"context_lines":[{"line_number":10,"context_line":"Remove this patch to avoid this directory"},{"line_number":11,"context_line":"left."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: 1824858"},{"line_number":14,"context_line":"This reverts commit 05b7f63a42e3512da6fe45d2e6639fb47ed8102b."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I52293b6ce3e1ce77fa31b382d0067fb3bc68b21f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_f0b11e46","line":13,"updated":"2019-11-06 21:43:28.000000000","message":"I\u0027m pretty sure we have a duplicate of this somewhere in nova bugs because I know I\u0027ve referenced this issue before and what you said, that just because images_type\u003drbd doesn\u0027t mean all files are on local storage, just that the instance root disk will be on shared storage. The other $instance_path files like console could be on local storage.\n\nThis is related:\n\nhttps://docs.openstack.org/nova/latest/configuration/config.html#workarounds.ensure_libvirt_rbd_instance_dir_cleanup","commit_id":"86aee83812ff04f4439b715ca9ac06dc1aa690ae"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"489c26676d7638926feebbd13d6a0aa90c7989df","unresolved":false,"context_lines":[{"line_number":9664,"context_line":"            images.fetch_to_raw(context, image_id, path)"},{"line_number":9665,"context_line":"            return True"},{"line_number":9666,"context_line":""},{"line_number":9667,"context_line":"    def _is_storage_shared_with(self, dest, inst_base):"},{"line_number":9668,"context_line":"        # NOTE (rmk): There are two methods of determining whether we are"},{"line_number":9669,"context_line":"        #             on the same filesystem: the source and dest IP are the"},{"line_number":9670,"context_line":"        #             same, or we create a file on the dest system via SSH"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_5618271e","side":"PARENT","line":9667,"range":{"start_line":9667,"start_character":8,"end_line":9667,"end_character":31},"updated":"2020-01-14 11:05:59.000000000","message":"you might want to add a doc string comment here with the info from the commit message to make ti very clear that this is infact checking if the instance directory is shared and not the guest disk storage","commit_id":"2f31c8d1b97c2b64581d8f824b6547f93dfd94fb"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"cb54c18224d20390bedb58c7e4a89980fb11a3b5","unresolved":false,"context_lines":[{"line_number":9664,"context_line":"            images.fetch_to_raw(context, image_id, path)"},{"line_number":9665,"context_line":"            return True"},{"line_number":9666,"context_line":""},{"line_number":9667,"context_line":"    def _is_storage_shared_with(self, dest, inst_base):"},{"line_number":9668,"context_line":"        # NOTE (rmk): There are two methods of determining whether we are"},{"line_number":9669,"context_line":"        #             on the same filesystem: the source and dest IP are the"},{"line_number":9670,"context_line":"        #             same, or we create a file on the dest system via SSH"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fa7e38b_c4217aff","side":"PARENT","line":9667,"range":{"start_line":9667,"start_character":8,"end_line":9667,"end_character":31},"in_reply_to":"3fa7e38b_5618271e","updated":"2020-02-06 01:21:53.000000000","message":"Yeah ... I do wonder if we\u0027ll see someone come around in the future and try to add the images_type check back in because it\u0027s not called out specifically why we don\u0027t do that :P","commit_id":"2f31c8d1b97c2b64581d8f824b6547f93dfd94fb"}]}