)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"18da7768ed5efc34a5ee98cd605df2fa99004adc","unresolved":false,"context_lines":[{"line_number":1298,"context_line":"                \"Virt driver is not ready. If this is the first time this \""},{"line_number":1299,"context_line":"                \"service is starting on this host, then you can ignore this \""},{"line_number":1300,"context_line":"                \"warning.\")"},{"line_number":1301,"context_line":"            return {}"},{"line_number":1302,"context_line":""},{"line_number":1303,"context_line":"        for node_name in node_names:"},{"line_number":1304,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_3421a3a0","line":1301,"range":{"start_line":1301,"start_character":12,"end_line":1301,"end_character":21},"updated":"2019-10-07 18:18:10.000000000","message":"as noted in the previous patch, I worry that we\u0027ll see this condition a nontrivial amount of the time esp. in ironic deployments, and could benefit from a retry loop","commit_id":"18d7ac91ee9aea9a0c7bf764bbf0e223c68474d7"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"650d6b647d4dcf1bfd9d5532cb54f9937658276b","unresolved":false,"context_lines":[{"line_number":1298,"context_line":"                \"Virt driver is not ready. If this is the first time this \""},{"line_number":1299,"context_line":"                \"service is starting on this host, then you can ignore this \""},{"line_number":1300,"context_line":"                \"warning.\")"},{"line_number":1301,"context_line":"            return {}"},{"line_number":1302,"context_line":""},{"line_number":1303,"context_line":"        for node_name in node_names:"},{"line_number":1304,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_50f0ddc9","line":1301,"range":{"start_line":1301,"start_character":12,"end_line":1301,"end_character":21},"in_reply_to":"3fa7e38b_3421a3a0","updated":"2019-10-08 14:22:35.000000000","message":"Matt replied to you in https://review.opendev.org/#/c/666857/13/nova/compute/manager.py@1398\n\nIf there is an agreement that retry is needed the I can add that as a separate patch. Personally I don\u0027t see this as a big problem. The next restart will do the cleanup.","commit_id":"18d7ac91ee9aea9a0c7bf764bbf0e223c68474d7"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"18da7768ed5efc34a5ee98cd605df2fa99004adc","unresolved":false,"context_lines":[{"line_number":1362,"context_line":"            # checking that instance was not already evacuated to other host"},{"line_number":1363,"context_line":"            evacuated_instances \u003d self._destroy_evacuated_instances("},{"line_number":1364,"context_line":"                context,"},{"line_number":1365,"context_line":"                {cn.hypervisor_hostname: cn.uuid"},{"line_number":1366,"context_line":"                 for cn in nodes_by_uuid.values()})"},{"line_number":1367,"context_line":""},{"line_number":1368,"context_line":"            # Initialise instances on the host that are not evacuating"},{"line_number":1369,"context_line":"            for instance in instances:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_79195686","line":1366,"range":{"start_line":1365,"start_character":16,"end_line":1366,"end_character":50},"updated":"2019-10-07 18:18:10.000000000","message":"IMO it would be better to do this dict reversal within _destroy_evacuated_instances rather than here.","commit_id":"18d7ac91ee9aea9a0c7bf764bbf0e223c68474d7"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"650d6b647d4dcf1bfd9d5532cb54f9937658276b","unresolved":false,"context_lines":[{"line_number":1362,"context_line":"            # checking that instance was not already evacuated to other host"},{"line_number":1363,"context_line":"            evacuated_instances \u003d self._destroy_evacuated_instances("},{"line_number":1364,"context_line":"                context,"},{"line_number":1365,"context_line":"                {cn.hypervisor_hostname: cn.uuid"},{"line_number":1366,"context_line":"                 for cn in nodes_by_uuid.values()})"},{"line_number":1367,"context_line":""},{"line_number":1368,"context_line":"            # Initialise instances on the host that are not evacuating"},{"line_number":1369,"context_line":"            for instance in instances:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_10f02567","line":1366,"range":{"start_line":1365,"start_character":16,"end_line":1366,"end_character":50},"in_reply_to":"3fa7e38b_79195686","updated":"2019-10-08 14:22:35.000000000","message":"yeah, make sense. Done.","commit_id":"18d7ac91ee9aea9a0c7bf764bbf0e223c68474d7"}]}