)]}'
{"nova/virt/libvirt/volume/remotefs.py":[{"author":{"_account_id":25113,"name":"Fan Zhang","email":"zh.f@outlook.com","username":"fanzhang"},"change_message_id":"e5ed3e16154227ad8e5e89c1372686f1bfee4098","unresolved":false,"context_lines":[{"line_number":155,"context_line":"        \"\"\""},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    @abc.abstractmethod"},{"line_number":158,"context_line":"    def copy_file(self, src, dst, on_execute, on_completion, compression):"},{"line_number":159,"context_line":"        \"\"\"Copy file to/from remote host."},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"        Remote address must be specified in format:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_548fa629","line":158,"range":{"start_line":158,"start_character":61,"end_line":158,"end_character":72},"updated":"2019-09-19 01:31:09.000000000","message":"What for?  Remember to add the param annotation please.","commit_id":"39a1130987c4a6b4a4ed6e9e404ec584495e37e4"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"bdcd5b2c8fb358d07d8f8464111b129d4dfbda16","unresolved":false,"context_lines":[{"line_number":155,"context_line":"        \"\"\""},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    @abc.abstractmethod"},{"line_number":158,"context_line":"    def copy_file(self, src, dst, on_execute, on_completion, compression):"},{"line_number":159,"context_line":"        \"\"\"Copy file to/from remote host."},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"        Remote address must be specified in format:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_d2771c3a","line":158,"range":{"start_line":158,"start_character":61,"end_line":158,"end_character":72},"in_reply_to":"3fa7e38b_548fa629","updated":"2019-09-19 14:01:20.000000000","message":"The methods of sub classes have the \u0027compression\u0027 argument.\n\nhttps://github.com/openstack/nova/blob/fbc0c1967763e7774d7d5b576cdba2e0a36daf91/nova/virt/libvirt/volume/remotefs.py#L191\nhttps://github.com/openstack/nova/blob/fbc0c1967763e7774d7d5b576cdba2e0a36daf91/nova/virt/libvirt/volume/remotefs.py#L308\n\nI agree with adding the param annotation as Fan Zhang mentioned.","commit_id":"39a1130987c4a6b4a4ed6e9e404ec584495e37e4"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f8873216276760378f2ff9ff6171f0bc0d2f7b43","unresolved":false,"context_lines":[{"line_number":155,"context_line":"        \"\"\""},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    @abc.abstractmethod"},{"line_number":158,"context_line":"    def copy_file(self, src, dst, on_execute, on_completion, compression):"},{"line_number":159,"context_line":"        \"\"\"Copy file to/from remote host."},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"        Remote address must be specified in format:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_ecf0f1ff","line":158,"range":{"start_line":158,"start_character":61,"end_line":158,"end_character":72},"in_reply_to":"3fa7e38b_d2771c3a","updated":"2019-09-24 16:02:34.000000000","message":"Done","commit_id":"39a1130987c4a6b4a4ed6e9e404ec584495e37e4"}]}