)]}'
{"nova/tests/fixtures.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7f2cc91f29bb72adef66ad8916e902ddb515de0c","unresolved":false,"context_lines":[{"line_number":765,"context_line":"            flavor.create()"},{"line_number":766,"context_line":""},{"line_number":767,"context_line":""},{"line_number":768,"context_line":"class RPCFixture(fixtures.Fixture):"},{"line_number":769,"context_line":"    def __init__(self, *exmods):"},{"line_number":770,"context_line":"        super(RPCFixture, self).__init__()"},{"line_number":771,"context_line":"        self.exmods \u003d []"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_50ed4823","line":768,"updated":"2019-09-20 17:58:02.000000000","message":"I would define your new fixture closer to this one.","commit_id":"e76bb92f243485a7617e6e704390ce07d9797375"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"864958bed8f7bf6374e491f09b241952f462b8f3","unresolved":false,"context_lines":[{"line_number":765,"context_line":"            flavor.create()"},{"line_number":766,"context_line":""},{"line_number":767,"context_line":""},{"line_number":768,"context_line":"class RPCFixture(fixtures.Fixture):"},{"line_number":769,"context_line":"    def __init__(self, *exmods):"},{"line_number":770,"context_line":"        super(RPCFixture, self).__init__()"},{"line_number":771,"context_line":"        self.exmods \u003d []"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_5a1c7e11","line":768,"in_reply_to":"3fa7e38b_50ed4823","updated":"2019-09-21 15:32:12.000000000","message":"Done","commit_id":"e76bb92f243485a7617e6e704390ce07d9797375"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"c642bff36aa3fe08262da92f84acb7b0651908fb","unresolved":false,"context_lines":[{"line_number":2150,"context_line":""},{"line_number":2151,"context_line":""},{"line_number":2152,"context_line":"class OsloMessagingFakeDriverJsonFixture(fixtures.Fixture):"},{"line_number":2153,"context_line":"    \"\"\"A fixture to temporary fix oslo.messaging bug #1529084 by using"},{"line_number":2154,"context_line":"    jsonutils.dumps instead of json.dumps for checking if the rpc messages are"},{"line_number":2155,"context_line":"    json serializable or not. This should be removed when the oslo bug is fixed"},{"line_number":2156,"context_line":"    and nova is bumped to use the new oslo version."}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_ca298a9b","line":2153,"updated":"2019-09-20 18:17:59.000000000","message":"nit: a TODO here would be good","commit_id":"e76bb92f243485a7617e6e704390ce07d9797375"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"864958bed8f7bf6374e491f09b241952f462b8f3","unresolved":false,"context_lines":[{"line_number":2150,"context_line":""},{"line_number":2151,"context_line":""},{"line_number":2152,"context_line":"class OsloMessagingFakeDriverJsonFixture(fixtures.Fixture):"},{"line_number":2153,"context_line":"    \"\"\"A fixture to temporary fix oslo.messaging bug #1529084 by using"},{"line_number":2154,"context_line":"    jsonutils.dumps instead of json.dumps for checking if the rpc messages are"},{"line_number":2155,"context_line":"    json serializable or not. This should be removed when the oslo bug is fixed"},{"line_number":2156,"context_line":"    and nova is bumped to use the new oslo version."}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_ba1d7210","line":2153,"in_reply_to":"3fa7e38b_ca298a9b","updated":"2019-09-21 15:32:12.000000000","message":"Done","commit_id":"e76bb92f243485a7617e6e704390ce07d9797375"}],"nova/tests/functional/integrated_helpers.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7f2cc91f29bb72adef66ad8916e902ddb515de0c","unresolved":false,"context_lines":[{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        nova.tests.unit.image.fake.stub_out_image_service(self)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        self.useFixture(nova_fixtures.OsloMessagingFakeDriverJsonFixture(self))"},{"line_number":99,"context_line":"        self.useFixture(cast_as_call.CastAsCall(self))"},{"line_number":100,"context_line":"        placement \u003d self.useFixture(func_fixtures.PlacementFixture())"},{"line_number":101,"context_line":"        self.placement_api \u003d placement.api"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_10f7d0f7","line":98,"updated":"2019-09-20 17:58:02.000000000","message":"Rather than play whack-a-mole, would wouldn\u0027t we just always use this when we also use the RPCFixture?","commit_id":"e76bb92f243485a7617e6e704390ce07d9797375"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"c642bff36aa3fe08262da92f84acb7b0651908fb","unresolved":false,"context_lines":[{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        nova.tests.unit.image.fake.stub_out_image_service(self)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        self.useFixture(nova_fixtures.OsloMessagingFakeDriverJsonFixture(self))"},{"line_number":99,"context_line":"        self.useFixture(cast_as_call.CastAsCall(self))"},{"line_number":100,"context_line":"        placement \u003d self.useFixture(func_fixtures.PlacementFixture())"},{"line_number":101,"context_line":"        self.placement_api \u003d placement.api"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_904420b9","line":98,"in_reply_to":"3fa7e38b_10f7d0f7","updated":"2019-09-20 18:17:59.000000000","message":"Well, at least FWIW we played whack-a-mole correctly - I tried adding a stub in the base nova/test.py to blow up when _check_serialize was called, and this patch indeed caught them all. But I agree with you, we shouldn\u0027t have to think about it like that.","commit_id":"e76bb92f243485a7617e6e704390ce07d9797375"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"864958bed8f7bf6374e491f09b241952f462b8f3","unresolved":false,"context_lines":[{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        nova.tests.unit.image.fake.stub_out_image_service(self)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        self.useFixture(nova_fixtures.OsloMessagingFakeDriverJsonFixture(self))"},{"line_number":99,"context_line":"        self.useFixture(cast_as_call.CastAsCall(self))"},{"line_number":100,"context_line":"        placement \u003d self.useFixture(func_fixtures.PlacementFixture())"},{"line_number":101,"context_line":"        self.placement_api \u003d placement.api"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_3ad74226","line":98,"in_reply_to":"3fa7e38b_904420b9","updated":"2019-09-21 15:32:12.000000000","message":"I\u0027ve exterminated the moles.","commit_id":"e76bb92f243485a7617e6e704390ce07d9797375"}],"requirements.txt":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"c7f8399938f66596fc0dc62f8fd66639912c8235","unresolved":false,"context_lines":[{"line_number":45,"context_line":"oslo.utils\u003e\u003d3.40.2 # Apache-2.0"},{"line_number":46,"context_line":"oslo.db\u003e\u003d4.44.0 # Apache-2.0"},{"line_number":47,"context_line":"oslo.rootwrap\u003e\u003d5.8.0 # Apache-2.0"},{"line_number":48,"context_line":"oslo.messaging\u003e\u003d7.0.0 # Apache-2.0"},{"line_number":49,"context_line":"oslo.policy\u003e\u003d1.38.0 # Apache-2.0"},{"line_number":50,"context_line":"oslo.privsep\u003e\u003d1.33.2 # Apache-2.0"},{"line_number":51,"context_line":"oslo.i18n\u003e\u003d3.15.3 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":4,"id":"3fa7e38b_a8069e84","line":48,"range":{"start_line":48,"start_character":0,"end_line":48,"end_character":34},"updated":"2019-11-13 14:07:42.000000000","message":"this needs to be updated as well (will cause requirements job to bounce)","commit_id":"bd406237b5f81643db466266123dbde18423f205"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"9bf35e25189252d7bbca4ebf2f78fd43b95397b8","unresolved":false,"context_lines":[{"line_number":45,"context_line":"oslo.utils\u003e\u003d3.40.2 # Apache-2.0"},{"line_number":46,"context_line":"oslo.db\u003e\u003d4.44.0 # Apache-2.0"},{"line_number":47,"context_line":"oslo.rootwrap\u003e\u003d5.8.0 # Apache-2.0"},{"line_number":48,"context_line":"oslo.messaging\u003e\u003d7.0.0 # Apache-2.0"},{"line_number":49,"context_line":"oslo.policy\u003e\u003d1.38.0 # Apache-2.0"},{"line_number":50,"context_line":"oslo.privsep\u003e\u003d1.33.2 # Apache-2.0"},{"line_number":51,"context_line":"oslo.i18n\u003e\u003d3.15.3 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":4,"id":"3fa7e38b_cfe8bce0","line":48,"range":{"start_line":48,"start_character":0,"end_line":48,"end_character":34},"in_reply_to":"3fa7e38b_a8069e84","updated":"2019-11-13 17:26:27.000000000","message":"Done","commit_id":"bd406237b5f81643db466266123dbde18423f205"}]}